* Fixes#1045.
* Rune Stones are now consumable by all classes.
* Adjusted the item type to 2 (usable item) from 11 (delayed item).
* Removed the IG_RUNE item group.
Thanks to @cydh and @Paoly28!
* Fixes#2069.
* Usable items that don't have a script will now execute as normal.
* Items that have a special effect with no script were not displaying their effect since the check was stopping any execution.
* Cleared up some usages of script command end.
Thanks to @LiamKarlMitchell!
* Fixed#2001
* Novice Fly Wings (12323) now cannot be used in `noteleport` map
* Novice Butterfly Wings (12324) now cannot be used in `noreturn` map
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Fixes#1898.
* Separated the SC_ARMOR_ELEMENT to each element (Water, Earth, Fire, Wind).
* Added the status icon for the respective element.
Thanks to @zackdreaver!
While refactoring those events the following other changes were made:
Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.
The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.
All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).
All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).
Renamed a few events in the script configuration to match the other names
Added constants for months and weekdays
Additionally added constants for gettime types to make it easier to read.
Replaced all existing usages I found with their proper new syntax or better fitting functions.
This commit makes those item scripts a little more readable and decreases the chance of mistakenly using an incorrect weapon type id.
Follow up to c6187fa.
* Boarding Halter will now properly be removed on expiration when a player is logged out. (fixes#1035)
* Removed hard coded checks for other official rental items.
* Rental items now call the OnUnequip Script of the item which can be used to remove player states.
* Updated various items in the database to match the new format.
* Moved all item effects to source.
* Updated HP/SP Increase Potions to use the official statuses.
* Updated Vellum Flail to use the official status instead of Critical Wound.
Thanks to @exneval.
* Fixes#586 - Resolved some compile warnings.
* Fixes#584 - Cleaned up the success rate and duration for Sling bombs.
- Banana Bomb now reduces LUK by 75.
- Throwing Cure Free now removes Poison, Orcish, Change Undead, Blind, Confusion, Deadly Poison, and heals a static 500 HP.
- Updated pre-renewal Genetic items to match renewal.
- Moved VIP_Third_Class function from other/CashShop_Functions into other/re/CashShop_Functions (only used in re folder).
- Fixed a mistake in quests/quests_nameless.txt blame me 36f337ea41a876ef471bfbb78128e35fa0d9aa56
- re/quest/quests_eclage clean-up and bug fix
Signed-off-by: Atemo <capucrath@gmail.com>
* Item bonus correction, ambiguous of 'HP/SP Gain' implementation.
* Since no implementation for 'drain HP/SP from target', the bonus was removed but makes 'HP/SP Drain' bonuses act like 'drain HP/SP from target' that was totally wrong.
* This also fixed#471, @AbuGosok
* Removed HP/SP Gain bonuses that should be use HP/SP Drain:
* `bonus bHPGainAttack,n;` is same as `bonus bHPDrainValue,n;`.
* `bonus bSPGainAttack,n;` is same as `bonus bSPDrainValue,n;`.
* `bonus2 bHPGainAttackRate,x,n;` is same as `bonus2 bHPDrainRate,x,n;`.
* `bonus2 bSPGainAttackRate,x,n;` is same as `bonus2 bSPDrainRate,x,n;`.
* `bonus2 bHPGainRaceAttack,r,n;` is same as `bonus2 bHPDrainValueRace,r,n;`.
* `bonus2 bSPGainRaceAttack,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
* `bonus2 bHPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
* `bonus2 bSPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
* `bonus bHPGainAttackRate,n;` none.
* `bonus bSPGainAttackRate,n;` none.
* Fixed#454, thank @jeanroyce
* Item update & correction script from Aegis
* Wunderkammer renamed to YinYang_Earring (18575).
* Updated scripts for 7676, 18593, 18595, 18597, 18600, 18601, 18630, 18631, 18636, 18637, 18650, 18650, 18652, 18656, 18659, 18671, 20700, 20724, 28315, 28316, 28317, 28318.
* Updated script for RCC2013 Combos 28315:28317 and 28316:28318.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Now coma triggered on every attack types (bugreport:3100)
* Added bonuses `bonus2 bComaRace,r,n;` and `bonus2 bComaClass,c,n;`, replacing the current usages of `bWeaponComaRace` and `bWeaponComaClass`.
* This bonus has no effect for GVG and BG monsters.
* Fixed Shockwave Trap (HT_SHOCKWAVE) SP reduction, should be % of MaxSP not % of 'current' SP.
* Fixed#462, failure in `setunitdata` for NPC. Thank a91323, @julia40124009
* Fixed#470, changed SO_ARRULLO target to BL_CHAR.
* Added skill flag INF2_HIT_TRAP (0x40000) to removed hardcoded 'skill that can hit traps'.
* NOTE: Client-side's factor also determines that skill can be targeted to trap-type skill or not.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Added `bonus2 bSubSkill,sk,n;` -> Reduces n% damage received from skill sk.
* Added `bonus bHPGainAttack,n;` -> Heals +n HP with a normal attack.
* Added `bonus bSPGainAttack,n;` -> Heals +n SP with a normal attack.
* Added `bonus bHPGainAttackRate,n;` -> Heals +n% HP of inflicted damage on every hit when attacking an enemy.
* Added `bonus bSPGainAttackRate,n;` -> Heals +n% SP of inflicted damage on every hit when attacking an enemy.
* Added `bonus2 bHPGainAttackRate,n,x;` -> Has chance x/10% to heals +n% HP of inflicted damage on every hit when attacking an enemy.
* Added `bonus2 bSPGainAttackRate,n,x;` -> Has chance x/10% to heals +n% SP of inflicted damage on every hit when attacking an enemy.
* Replaced `bonus2 bHPDrainValue,n,x;` for x = 0 to `bonus bHPGainAttack,n;`. Since x = 1 is same as `bonus bHPDrainValue,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Replaced `bonus2 bSPDrainValue,n,x;` for x = 0 to `bonus bSPGainAttack,n;`. Since x = 1 is same as `bonus bSPDrainValue,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Replaced `bonus3 bSPDrainRate,n,x,y;` for y = 0 to `bonus2 bSPGainAttackRate,n,x;`. Since y = 1 is same as `bonus2 bSPDrainRate,x,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Updated the documentations.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Implemented ALL_REVERSEORCISH as follow up 01ae1ae6126dc8aa91f967eea7d145e10dfb29e3.
* Clean up `rand()` script usage in Fools_Day_Box (12396) and Fools_Day_Box2 (12397).
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Max level to equip item now works for Pre-Renewal too, since the field is optional. 0 means no max level limit.
* Fixed fail message on clif_equipitemack when item cannot be equipped because level limitation
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
- Autobonus3 will now also trigger when using ground skills (bugreport:6434)
- Fixed trigger chance of the Angelic Ring auto-bonuses (5% -> 10%) and that they didn't display any effect
- Fixed warning for infinite warp where count_rewarp increased when the player was warped near a warp
Special thanks to Radian
Signed-off-by: Capuche <capucrath@gmail.com>
* Changed `mr` values to use constantan value
* Added check for IT_SHADOWGEAR's script restriction before executing it
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
-- Added itemstack check when init autotrader (bugreport:9077)
-- 'getitem' issue, gave unidentified item (bugreport:9075), follow up 62a2813
-- Invalid Def & Mdef reduction of SC_ARMORCHANGE & duration (NPC_STONESKIN & NPC_ANTIMAGIC), should be percentage (bugreport:9076)
-- Invalid Effect duration & Reflect chance of SC_MAGICMIRROR (NPC_MAGICMIRROR)
-- Wrong usage of script_isstring() for script commands: addspiritball, delspiritball, & countspiritball
* Misc:
-- Moved mail send progress to mail.c mail_send() from clif.c clif_parse_Mail_send()
-- Moved hardcoded flood protection when send a mail to 'mail_delay' in misc.conf
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Added 'bonus2 bAddItemGroupHealRate' to replace 'bonus2 bAddItemHealRate' for Item Group ID usage. Since MAX_ITEMGROUP is removed, there is no identifier which entry that Item ID or Item Group. Previous check using 'if (type2 < MAX_ITEMGROUP)' (2d53a782fa (diff-08420bab8271f3965304fee42cf4b865L3220))
* bonus2 bAddItemHealRate,iid,n;
* bonus2 bAddItemGroupHealRate,ig,n;
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Fixed Chorus songs causing the map server to crash. (bugreport:8817, bugreport:8819)
* Updated renewal Arrow Shower area to be 5x5 for levels 6-10.
* Neutral Barrier should effect all targets and only block Earth Quake splash damage.
* Only party and guild members should be affected by Stealth Field.
* Fixed Cloud Kill layout to be 7x7.
* Feint Bomb should explode after half a second.
* Fixed Fire Rain unit ID causing Fire Wall, Ice Wall, and other unit skills to display improperly. (bugreport:8775)
* Updated the effects of Banana Bomb, Concentrated White Potion Z, and Vitata 500.
* Fixed Gentle Touch - Revitalize HP regeneration calculation.
* Fixed Gentle Touch - Change making MDEF go below 0 and doing too much damage. (bugreport:8690)
* Fixed Gentle Touch - Energy Gain not adding spirit balls when doing damage.
* Fixed Gentle Touch - Cure to heal players who are wearing a shield with the Golden Thief Bug card. (bugreport:8815)
* Fixed Tear Gas /sob emoticon not stopping when the skill ended.
* Fixed Kagerou/Oboro charms not applying to specific skills. (bugreport:8823)
* Updated some other Kagerou/Oboro skills. Thanks to idAthena.
* Players will stop attacking when forced to sit through skill_sit. (bugreport:8796)
* Fixed Extremity Fist not removing natural SP regen flag and adjusted the icon to show for the 5 minute duration. (bugreport:8811)
* Implemented the official effect for Chaos Panic. (bugreport:8520)
* Fixed a small typo for the knockback of Crescent Elbow.
* Fixed Cross Slash not checking for players wearing Shields + Dagger/Sword. (bugreport:8797)
* Synced up the 3rd class pre-renewal skill database files with the renewal skill database files.
