8488 Commits

Author SHA1 Message Date
Lemongrass3110
1b634c8f42 Fixed showdigit's start values (#1807)
Fixed #1769
2016-12-20 01:37:40 +01:00
aleos
8492f6c35e Fixes Feint Bomb and bNoKnockBack (fixes #1814)
* Resolves Feint Bomb's backslide effect not working when the player is wearing an item that has the bonus NoKnockBack active.
Thanks to @Everade!
2016-12-19 19:32:35 -05:00
aleos
1a5e3a35bd Added readable constants for knockback functions
* Added enum for skill_blown.
* Added enum for unit_blown_immune.
2016-12-19 19:04:01 -05:00
Lemongrass3110
552c39acc3 Fixed #1809
Thanks to @Tokeiburu
2016-12-20 00:13:48 +01:00
Playtester
d1f8c8ca6c Fiber Lock vs. Land Protector (follow-up to 79e9afa)
* Fiber Lock now ends in all situations in which the unit group is removed (e.g. Land Protector)
2016-12-19 23:43:56 +01:00
Playtester
74d577ce52 Gospel, Tarot, Curse, Poison, Hallucination, Hell Power, NPC skills
* Official Gospel chances, effects and duration (fixes #1812)
-- Chance of Gospel to trigger increased from 10%*skill_lv to 50%+5%*skill_lv
-- Gospel's Heal effect now heals 1000-9999 HP instead of 1-9999 HP
-- Blessing and Increase Agi effects now last for 4 minutes instead of 60 seconds
-- Increase Defense now only lasts 10 seconds instead of 60 seconds
-- Gospel's damage is now twice likely to trigger with one of two different effects
-- Fixed Gospel's damage not showing the Holy Cross effect
-- Gospel's first damage effect deals 3000-7999 damage which is reduced by DEF (percentual in pre-re)
-- Gospel's second damage effect deals 1500-5499 damage which cannot be reduced by DEF
-- Curse, Blind and Poison effect now last 30 minutes instead of 60 seconds
-- Provoke lasts infinite, but is removed when changing maps or logging out
-- Fixed Provoke's icon from disappearing whenever a status changes
-- DEF, ATK, Flee and Speed super debuffs now only last 20 seconds instead of 60 seconds
* Official status change base duration for curse (fixes #1811)
-- Curse base duration is 30 seconds in pre-re and 20 seconds in renewal
-- Napalm Vulcan, Tarot Card of Fate, NPC_HELLJUDGEMENT, NPC_WIDECURSE use this duration
-- NPC_CURSEATTACK has a fixed 30 seconds duration
* Official status change base duration for poison (fixes #1811)
-- Poison base duration is 60 seconds in pre-re and 20 seconds in renewal
-- Duration is no longer halved for monsters in pre-re
-- Envenom, Venom Dust, Venom Splasher, Tarot Card of Fate, NPC_POISON, NPC_ACIDBREATH use this duration
* NPC_STOP now has a duration of 15 seconds instead of 10 seconds
* NPC_HELLPOWER and NPC_WIDEHELLDIGNITY now have a duration of 180 seconds instead of 300 seconds
* Tarot Card of Fate uses base duration for Curse, Poison, Stone, Freeze and Stun
-- For Confusion and Stop the duration remains fixed to 30 seconds
* All NPC status skills now have a 20%*skill_lv chance to trigger instead of 50%+10%*skill_lv
-- NPC_HALLUCINATION and NPC_HELLPOWER now only affect you to 20% instead of 100%/60%
* Damage shown by Hallucination is now completely random instead of being multiplied by 6
* The animation is now shown when trying to resurrect someone affected by Hell Power

Special thanks to @mrjnumber1 and Luke for providing various information on these.
2016-12-19 22:28:18 +01:00
Locien
a4a6dd896f Small fix to previous magic rod changes
Fixed a compiler error.
2016-12-17 04:10:07 +01:00
Locien
d92272eb89 Corrected behavior for magic rod showing its animation in pre-renewal
In pre-renewal the animation of magic rod only shows up when the user is
attacked with a spell that can be absorbed by it. In renewal it shows
when you cast the skill instead. This has been tested on iRO Chaos and
iRO Classic.
2016-12-17 00:55:34 +01:00
Lemongrass3110
b0bcd060c4 Added windows specific socket timeout code (#1714)
* Added windows specific socket timeout code

Added socket code for windows that respects our given timeout.
Also added some more ifndef checks to some stat reporting functions.
Updated the MSDN reference link.
Fixed the delay being milliseconds on windows, thanks to @theultramage
Fixes #794 on windows.
2016-12-17 00:36:23 +01:00
Stolao
25bcb51598 Merge pull request #1793 from rathena/Code_Consistancy_Edit
Code Consistency
2016-12-16 13:27:52 -08:00
Lemongrass3110
7df9962a72 Follow up to 9333921
Thanks to @Playtester's friend Ash for reporting this.
2016-12-13 09:10:07 +01:00
Stolao
f0059affb3 no message 2016-12-12 11:44:55 -08:00
Aleos
d095fe7a67 Merge pull request #1741 from rathena/cleanup/itemgroups
Cleaned up Item Groups
- Moved constants from const.txt to script_constants.h.
- Removes hard coded item groups into the IG_* database to easily be adjusted/created.
- Renamed IG_FingingOre -> IG_FindingOre.
2016-12-12 13:58:54 -05:00
Playtester
b4225e8436 Tarot Card of Fate Follow-Up (fixes #1789)
* The tarot card THE SUN no longer blocks other cards in pre-re (still does in renewal)
* Added a configuration for equal chance for all cards in case someone prefers eAthena behavior
2016-12-12 19:10:28 +01:00
Lemongrass3110
0e78dfca26 Fixed a compiler warning
Follow up to 79e9afa
Fixes #1787
Thanks to @srhmike
2016-12-12 08:47:58 +01:00
Playtester
f084db4f1c Monsters spreading out on hide (fixes #1786)
* When you hide and monsters are still on their original chase path, they will no longer spread out
-- This makes Grimtooth mobbing viable again on default settings
-- In all other situations, monsters will still spread out
2016-12-11 22:37:32 +01:00
Playtester
79e9afaff0 Fiber Lock / Spider Web (fixes #1782)
* Fiber Lock's duration now depends on the map and how many fiber locks have been stacked
-- PVM: 1st - 8s, 2nd - 16s (default - 8s)
-- PVP: 1st - 4s, 2nd - 8s, 3rd - 12s (default - 4s)
* Fiber Lock now always doubles fire damage, even in renewal
* When a unit affected by Fiber Lock takes fire damage, the Fiber Lock that lasts shortest is now removed
* A unit can now only move when all Fiber Locks on it were removed or have expired
* When a unit with multiple Fiber Locks on it dies, not all Fiber Locks are removed
* A unit can no longer be affected by more than 3 Fiber Locks at the same time
2016-12-11 19:25:48 +01:00
Lemongrass3110
ab38f2cd7e Fixed jobmasks for custom jobs(>32 bit)
Fixes #1784
Thanks to @Stolao
2016-12-11 16:33:41 +01:00
Lemongrass3110
93339212bc Fixed #1772 (#1773)
* Fixed #1772

Added support for char_id to readparam
Added a check and error message if get_var is used on a parameter instead of a variable
2016-12-11 16:00:44 +01:00
Lemongrass3110
d13acf3886 Fixed a bug with getarraysize
When the attached rid of the script was actually not a player, but a monster or something else the script was terminated. A good example for this was to use getarraysize on a OnTouchNPC event.

Thanks to MasterOfMuppets(@Locien) for reporting this.
2016-12-11 14:57:18 +01:00
Playtester
08406785c6 Skills that increase elemental damage (fixes #1780)
* Negative values in the attr_fix table will now longer be ignored
* Renewal: Skills that increase elemental damage stack linearly with the attr_fix value
(e.g. if the attr_fix value is -25% and a skill increases elemental damage by 50%, it becomes 25%)
* Pre-Renewal: Skills that increase elemental damage increase damage percentually
(e.g. if damage is 25 and a skill increases elemental damage by 20%, it becomes 30)
2016-12-10 18:39:03 +01:00
Playtester
fd892a0425 Monster idle/walk behavior (fixes #1778)
* Monsters will now remember which players have spotted them
* If all players that spotted the monster logged out, it will become inactive again
* Inactive monsters neither walk nor use any skills (e.g. Metamorphosis)
* Minor documentation fix
2016-12-10 17:05:09 +01:00
aleos
8399992598 Adjusted variable size
* Increased variable size for the item group check to prevent overflows.
2016-12-10 09:25:54 -05:00
Lemongrass3110
b9a8ab722e Added an additional parameter to instance_enter (#1720)
Added an additional parameter to instance_enter

This allows easier usage for instances in IM_NONE, where a player will never be attached to the instance.
All you have to do is remember the created instance id and supply this command with it. That way you do not have to use any workaround like the following anymore:
warp instance_mapname( <mapname>, <instance id> ), <hardcoded enter x coordinate>, <hardcoded enter y coordinate>;

Added usage of the new constants in the existing scripts

Fixed default checks and null pointer output
Thanks to @Atemo
2016-12-10 12:38:57 +01:00
aleos89
0162ad890e Corrected Spore Explosion on GCC builds
* Follow up to 8f4660b.
* Resolves Spore Explosion not inflicting damage on targets for some GCC builds.
Thanks to @Tokeiburu!
2016-12-08 09:23:41 -05:00
Lemongrass3110
e490befb9a Follow up to e2eadcf 2016-12-08 01:41:21 +01:00
Lemongrass3110
e2eadcfbd8 Implemented mapflag nolockon correctly
Fixed #1736
Thanks to @GrumpyLittlePanda for reporting and @Playtester for pointing me into the right direction.
2016-12-07 23:09:53 +01:00
Lemongrass3110
2bb92a114b Fixed hallucination ignoring reloadbattleconf
Fixed #1765
2016-12-07 22:28:36 +01:00
Playtester
05783ade33 Follow-up to 0dbc83d (related to #1768)
* Moved the skill_tarotcard function up so the compiler doesn't throw warnings
* Minor code optimizations and comment updates
2016-12-07 22:09:09 +01:00
Playtester
0dbc83db9d Tarot Card of Fate (fixes #1768)
* Implemented official chances for each Tarot Card to occur
-- 15%: LOVERS
-- 10%: FOOL, MAGICIAN, HIGH PRIESTESS, STRENGTH, SUN
-- 8%: TEMPERANCE
-- 7%: CHARIOT
-- 6%: THE HANGED MAN
-- 5%: DEATH, STAR
-- 2%: TOWER
-- 1%: WHEEL OF FORTUNE, DEVIL
* The SUN tarot card will give you the tarot card status change
-- The status change makes you immune to other tarot card effects
-- The affected person will see a tarot card icon and the duration of the effect
* Fixed LOVERS healing self instead of the target
* The LOVERS tarot card now displays on self instead of target

Special thanks to @mrjnumber1
2016-12-07 21:28:32 +01:00
Cydh Ramdh
342443bf61 Added new mapflag hidemobhpbar (#1537)
* Added new mapflag `hidemobhpbar` to hides monster's HP bar on a map.
* Added maps for this mapflag, credits to @Atemo and @Lemongrass3110 

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-12-04 10:52:14 +07:00
Atemo
d3f0aec324 Fix issue #1651
- The timer event wasn't updated on last tick event
2016-12-03 05:50:16 +01:00
aleos89
33fa182c48 Corrected damage immunity states (fixes #1754)
* Added unit data damage immunity to the GvG targeting function.
* Added unit data and mob mode damage immunity to the reflecting damage calculation function.
Thanks to @admkakaroto!
2016-12-02 07:38:53 -05:00
aleos89
c05808a305 Fixed item bonus bAddMaxWeight (fixes #1761)
* Stored bAddMaxWeight into it's own variable for later calculation.
* Created enum constants for status_calc_weight and status_calc_cart_weight for easier readability.
2016-12-01 13:00:38 -05:00
Lemongrass3110
ac2ba09415 Fixed areawarp cell check
The script command areawarp has been checking the wrong target map for ages. It has been checking the mapindex rather than the mapid and therefore returned a wrong result.
2016-12-01 13:06:54 +01:00
Lemongrass3110
c88ca4432d Definition cleanup
Removed a few ghost definitions
Adjusted some definitions to use the same types

Related to #1738
2016-11-26 20:34:55 +01:00
aleos89
82675d86d0 Resolved the rental timer display (fixes #1745)
* Follow up to 45d9674.
* Fixes the timer message displaying too often.
Thanks to @whupdo!
2016-11-26 14:09:44 -05:00
Lemongrass3110
9aaf18eb33 Fixed some compile warnings
Follow up to 09a0c29
Fixes #1748 - thanks to @srhmike
2016-11-26 17:19:14 +01:00
aleos89
09a0c29a39 Corrected Lux Anima behavior (fixes #1110)
* Only transfers the most recent rune buff to the party.
* The source loses the rune buff that is passed to the party.
* There is a stack limit of 20 Lux Anima Runestones.
-- Stack only applies to renewal as the item isn't implemented in pre-renewal.
2016-11-25 15:42:44 -05:00
aleos89
2c3201116c Split item stack database between renewal and pre-renewal
* Separated the database between the two modes.
2016-11-25 15:31:16 -05:00
aleos89
595d9b743d Fixed a potential map server crash
* Resolves an invalid operator check for pc_check_available_item.
* Added a new flag for pc_delitem to not calculate a player's status when unequipping an item.
Thanks to @cydh!
2016-11-24 23:41:53 -05:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00
aleos89
127c13bbdd Cleaned up Item Groups
* Moved constants from const.txt to script_constants.h.
* Removes hard coded item groups into the IG_* database to easily be adjusted/created.
* Renamed IG_FingingOre -> IG_FindingOre.

Enabled commented Item Groups
* Follow up to 50d5c14.
* Retains consistency between constant and ID values.
* Renamed duplicate item groups to avoid compile errors.
2016-11-22 09:32:14 -05:00
Cydh Ramdh
633a642e5a * Corrected combos of Elemental Clothes (19048)
* Updated Status Change documentation for `SC_SIEGFRIED` and `SC_SCRESIST`
* Fixed `bResEff` cannot be used to increase the rate (for reducing resistance)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-20 11:35:02 +07:00
aleos89
0dd3c74c2e Fixed some arrays not zeroing out on status recalculation (fixes #1722)
* Follow up to 0f1b1af, f296409, and a79d065.
* Fixes several bonuses that are not zeroed out properly since the block order didn't match.
Thanks to @whupdo!
2016-11-19 09:26:33 -05:00
aleos89
ef63cffa30 Small OPTION_INVISIBLE refactor
* Cleaned up the usage of OPTION_INVISIBLE to utilize the macro that was defined for it.
2016-11-18 14:44:49 -05:00
Playtester
db3ef52fd2 Frost Nova AoE (fixes #1619)
- Increased Frost Nova AoE from 5x5 to 7x7
- Frost Nova no longer hits enemies that are on the same cell as the caster
2016-11-17 18:25:56 +01:00
Lemongrass3110
0fa8919749 Added sura jobs to the switch 2016-11-17 17:35:35 +07:00
aleos89
9910478ce2 Resolved some compile warnings
* Resolved two unreachable code warnings.
* Resolved two potentially uninitialized local variable warnings.
2016-11-16 13:07:19 -05:00
Lemongrass3110
ecc8cf9f0b Initial release of the clan system
Thanks to @cydh, @RagnarokNova and @aleos89 for their help.
2016-11-16 15:36:08 +01:00