17339 Commits

Author SHA1 Message Date
Atemo
f8c3c67ef3
Small correction with subtype card (#6405) 2021-12-12 17:45:55 +01:00
Atemo
b143a0cf3f
Fixed an issue with bAutoSpellWhenHit (#6402)
Fixed #6383

Thanks to @imaqtdan
2021-12-09 22:53:35 +01:00
Atemo
68bfbe9209
Added new shadow Equipments (#6399)
* Added shadow eq according to the items description up to nov 2021
2021-12-09 16:14:45 +01:00
Aleos
b1c535d68f
Adds missing baby classes to the HP/SP table (#6397)
Adds Baby Ninja, Baby Kagerou, Baby Oboro, Baby Taekwon, Baby Star Gladiator, Baby Soul Linker, Baby Gunslinger, and Baby Rebellion who weren't in the old TXT database during the YAML conversion.

Fixes #6393

Thanks to @kaninhot004
2021-12-09 10:22:28 +01:00
Lemongrass3110
02f247b798
Fixed an issue with skill db conversion (#6398)
With 6bc0dff the csv2yaml tool does not use deprecated constants anymore.
In our conversion logic we still used them though and therefore conversion might crash.

Thanks to @Rytech2
2021-12-09 09:25:22 +01:00
Atemo
546df9bc2d
New card subtype (#6394)
* Implemented new card subtype to differentiate normal cards from enchanted ones
* Available Subtypes:
** Normal (default)
** Enchant
* Updated the item database with the new subtype
* Updated the npc folders using getiteminfo ITEMINFO_SUBTYPE

Thanks to @Lemongrass3110 and @aleos89 !
2021-12-08 18:27:22 +01:00
Lemongrass3110
6c6da0c6e8 Follow up to 081b5c8
Thanks to @attackjom
2021-12-08 17:38:10 +01:00
Atemo
42a1f6413b
Added an exception for quest locations for memorial. (#6392)
* Updated the docs

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2021-12-08 15:53:10 +01:00
Atemo
4a778815a3
Converted mercenary_db to YAML format (#6101)
* Converts the Mercenary Tables file into YAML.
* Includes CSV2YAML converter.
* Fixed mercenary name not properly displayed after moving

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-12-07 00:49:44 +01:00
Sandro Junior
9b05754071
Fix SC_CHANGE not using max matk (#6382)
Thanks to Hercules for the fix

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-12-06 19:43:37 +01:00
Everade
17c84e9cf3
Updated Malangdo Costume enchant services (#6373)
Added support for more than 120 missing enchants
Textual improvements

Fixes #6372

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-12-06 16:42:01 +01:00
Sandro Junior
a028a74ae5
Fix SC_WINKCHARM behavior (#6384)
Adds a check to prevent func unit_walktoxy_timer to use DIR_CENTER direction (which has -1 value) on SC_WINKCHARMed mobs. Using this direction may cause dump values when accessing dirx or diry array;

Fixed timer mismatchs reported in https://github.com/rathena/rathena/issues/6371#issuecomment-982108186

Fixes #6371 

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-12-06 14:59:09 +01:00
Lemongrass3110
081b5c86bd
Cleanup as follow up to a205287 (#6377)
Removes unused constants
Cleans up some wrong usages of e_mode
Cleans up a mistake introduced in 62a2813a
Fixed a mismatching header
2021-12-05 22:34:52 +01:00
Vincent Stumpf
a7b4e5fd03
Fix compiler error on linux (#6376) 2021-12-05 21:45:52 +01:00
Sandro Junior
4dfeff1ed3
Fix missing condition for HW_GANBANTEIN (#6385)
Adds a condition for HW_GANBANTEIN since it's one of the skills that can be cast with no gemstone when equipped with Mistress Card.
2021-12-05 20:05:15 +01:00
Atemo
1ae1468b73
Added etc item according to the items description up to nov 2021 (#6381) 2021-12-05 15:22:09 +01:00
idk-whoami
a4c9722a48
Corrected script for some item (#6375) 2021-12-05 15:20:52 +01:00
Everade
17d58f0559
Updated "F_IsCharm" function to support all latest enchants. (#6391)
Please note that there are some gaps in between these ID ranges, but since we did the same with ID 4700 - 4999, i figured it should be fine.

Fixed #6389
2021-12-05 15:15:00 +01:00
Atemo
4cd2ef747d
Walking npc now ignore official_cell_stack_limit (#6379) 2021-12-02 14:53:17 +01:00
Atemo
a205287307
Converted elemental_db to YAML (#6102)
* Converts the Elemental Summons Tables file into YAML.
* Includes CSV2YAML converter.

Thanks to @Lemongrass3110, @aleos89, @secretdataz !
2021-11-26 00:53:35 +01:00
Atemo
ae1135dd2b
Implemented news cards and enchants (#6363)
* Implemented news cards and enchants according to KRO description
2021-11-23 17:46:42 +01:00
Aleos
fe0d445500
Fixes HP/SP table issues (#6361)
* Fixes #6360.
* Adds missing HP/SP values for Rebellion, Baby Rebellion, Expanded Super Novice, Expanded Super Baby, Baby Summoner, Star Emperor, Baby Star Emperor, Soul Reaper, and Baby Soul Reaper.
* Adds official HP/SP values for Summoner, Baby Summoner, Star Emperor, Baby Star Emperor, Soul Reaper, and Baby Soul Reaper. These are missing levels 176-200 though.
* Fixes the BonusStats parser to properly check for the max job level.
* Adds several logical checks for blocking level 0 during parse.
* Adds several logical checks for skipping content over a job's max level for HP/SP and BEXP/JEXP.
* Fixes the SP values being filled against the max job level instead of base level if the HP/SP Table wasn't being used.
* The parser will now properly fill the HP/SP array with 0's so that the loadingFinished() function can properly calculate a value to insert if something is missing.
* Adds a better solution to CSV2YAML when checking for the max base level when converting HP/SP.
* Fixes the CSV2YAML generating bad job bonus stat conversions.
Thanks to @kaninhot004 and @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-11-22 15:49:28 -05:00
Atemo
9d6a78cf68
Updated the english item name of several items (#6366)
* Small optimization
2021-11-22 16:34:03 +01:00
idk-whoami
913434317c
Corrected script for some item (#6364) 2021-11-22 15:44:56 +01:00
Atemo
424e05d8f7
Implemented some NPC skills (#6343)
* Implemented NPC_CHEAL
* NPC_MILLENNIUMSHIELD
* NPC_STORMGUST2
* NPC_ARROWSTORM
* NPC_DRAGONBREATH
* NPC_WIDEWEB
* NPC_REVERBERATION
* NPC_COMET
* NPC_VENOMIMPRESS
* NPC_SR_CURSEDCIRCLE
* NPC_DARKPIERCING
* NPC_FATALMENACE
* NPC_PSYCHIC_WAVE
* NPC_DRAGONBREATH
* NPC_MAGMA_ERUPTION
* NPC_RAYOFGENESIS
* Uncommented NPC_LEX_AETERNA skills in mob_skill_db.txt
* NPC_MANDRAGORA
* NPC_DANCINGBLADE
* Uncommented NPC_DARKPIERCING
* NPC_PULSESTRIKE2

Thanks to @attackjom and @Lemongrass3110 !
2021-11-21 18:24:55 +01:00
Jittapan Pluemsumran
eef8ef434a
Remove Maximum Power-Thrust buff on weapon unequip. Fixes #6277 (#6282) 2021-11-21 21:39:12 +07:00
idk-whoami
5f92aae35f
Corrected script for some item (#6357) 2021-11-19 16:25:07 +01:00
Atemo
33be829d9e
Added removespecialeffect/removespecialeffect2 script commands (#6322)
* Added removespecialeffect/removespecialeffect2 script commands, follow-up #5272 thanks to @attackjom
Credit to @4144 for the original work in https://github.com/HerculesWS/Hercules/pull/2226/files

Thanks to @Lemongrass3110 !
2021-11-18 23:37:44 +01:00
Atemo
acac89eeca
Updated Classes field in item_db.yml (#6362)
* Updated Classes field in item_db.yml to include ITEMJ_FOURTH
2021-11-18 18:30:13 +01:00
Atemo
da82fea633
Added missing docs about the trait stats (#6359) 2021-11-18 10:24:46 +01:00
Everade
7e815cbe6e
Corrects costume exchanges for enchant box 4-21 (#6208)
* Exchange costumes is now fully based on KRO, to get rid of TWRO customizations.
* Fixes wrong enchant stone box rewards.
* Removes custom costumes from possible enchant lists. (this list is most likely still inaccurate)

Fixes #6206
2021-11-17 23:09:04 +01:00
Aleos
6bc0dff20d
Converts Job databases to YAML (#4759)
* Converts the job_db, job_db2, job_basehpsp_db, job_exp, and job_param_db to YAML.
* Optimizes several places utilizing C++ features.
* Removes 3rd class job data from pre-renewal.
* Adds minimal support for 4th jobs.
* Job level bonus stats now supports multiple bonuses per level as well as an integer for the specific stat instead of only being limited to 1.
* Includes CSV2YAML converter.
Thanks to @Lemongrass3110, @Atemo, @Balferian, @attackjom, @dimasshotta!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-11-17 16:13:07 -05:00
Aleos
ff0cbfe4e8
Minor fixes and cleanups to the mob database (#6356)
* Made some minor fixes and cleanups to the mob database documentation and parser.
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-11-16 19:29:11 -05:00
Aleos
ae666be1e3
Fixes AutoSpellOnSkill targetting (#6355)
* Flips the self and target masks around once more.
Thanks to @Anjuts!
2021-11-13 18:05:09 -05:00
idk-whoami
2910148b85
Corrected script for some item (#6345) 2021-11-11 22:59:54 +01:00
Atemo
7dcc75d82e
Fixed a mistake on NPC_COMET (#6351)
Fixed https://github.com/rathena/rathena/issues/6350

Thanks to @attackjom !
2021-11-11 14:23:37 +01:00
Aleos
238af67994
Fixes AutoSpell target checks (#6352)
* Fixes #6346.
* Resolves an issue with bonus3 bAutoSpell, bonus3 bAutoSpellWhenHit, and bonus4 bAutoSpellOnSkill having their self and target flags flipped.
Thanks to @Anjuts and @mazvi!
2021-11-10 19:37:27 -05:00
Lemongrass3110
22c7f3988d
Yet another autospell fix (#6341)
Fixes #6337

Hopefully this was all now.

Thanks to @renniw
2021-11-02 23:41:19 +01:00
Lemongrass3110
7277d47ab6
Fixed a mail weight check (#6342)
Thanks to @limitro
2021-11-02 22:31:31 +01:00
Lemongrass3110
a53a65650f Fixed mob_db_re.sql
Something seem to have gone wrong with merging.

Fixes #6338

Thanks to @RagnaWay
2021-10-28 15:47:25 +02:00
Lemongrass3110
4b9c3e37f3
Fixed walking NPCs with monster sprites (#6325)
Sending all NPCs with new type now

Fixes #6312

Thanks to @Everade and @attackjom
2021-10-27 17:42:44 +02:00
Atemo
bca8287473
Random option support for addmonsterdrop (#6308)
* Added more parameters to the script command addmonsterdrop to support the random option system.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Thanks to @aleos89
2021-10-27 13:09:06 +02:00
HAO YAN
edfb95f39d
Added script command mercenary_delete (#6334)
Enable to remove mercenary from player.
2021-10-27 11:25:57 +02:00
Lemongrass3110
46586599fb
Restored previous logic for autospells (#6332)
Fixes #6330
The logic was inverted accidentally in 31327ade

Thanks to @mazvi and @Anjuts
2021-10-27 10:49:18 +02:00
Atemo
5933ab8304
Temple of the demon god instance (#5611)
* Implemented Temple of the Demong God instance
Implemented the skills NPC_WIDEWEB, NPC_WIDESUCK and NPC_FIRESTORM from https://github.com/idathena/trunk
Credit to @exneval

Thanks to @Badarosk0 @idk-whoami @Everade @aleos89
2021-10-26 18:21:12 +00:00
Atemo
3abc86e02d
Wave mode instances - walkthrough conversions (#3884)
* Wave mode instances - walkthrough conversions

* NPC_EMOTION and NPC_EMOTION_ON disrupted the walking system and have been restricted on the maps.
* Implemented AI_SPECIALs. AI and normal monsters can naturally fight each others. However monsters with AI_SPECIAL can't be hit by normal monsters.

* Implemented mob_setidleevent command.
`mob_setidleevent <GID>,<event>;`
This command will attach an event label to the monster with the given <GID> which will execute when the <GID> is idle.

* Added parameters to unitskilluseid and unitskillusepos
-- `<cancel>`: define if the skill can be interrupted when hit (by default the cancel value was 'castcancel' from skill_db.txt)
-- `<Line_ID>` : the monster will say the message from 'Line_ID' in mob_chat_db.yml when casting the skill

* Added `UMOB_IGNORE_CELL_STACK_LIMIT` for setunitdata/getunitdata script command.
When true, the monster will ignore the stack limit (max number of characters that can stack within a single cell) defined by 'official_cell_stack_limit' in misc.conf

* The script is disabled by default like on KRO

Thanks to @Lemongrass3110 @aleos89 @Badarosk0 @sigtus @Questune09 !
2021-10-26 14:56:47 +02:00
Lemongrass3110
eda43a6295
Fixed a stack corruption from WS_WEAPONREFINE (#6333)
Fixes #6331

Thanks to @24msz6eo
2021-10-24 19:28:57 +02:00
Lemongrass3110
cc6c1c3eff Follow up to 487c278
Fixed sample entries
2021-10-24 15:58:45 +02:00
Jittapan Pluemsumran
e50a91c59c
Added null pointer checks for autobonus (#6327)
Fixes #6324

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-10-24 14:52:10 +02:00
Lemongrass3110
487c27833b
Fixed reading armor level from sql (#6328)
Fixes #6323

Thanks to @bgamez23 and @aleos89
2021-10-21 20:09:05 +02:00