1248 Commits

Author SHA1 Message Date
ai4rei
0f1c66191c * Fixed buyers, that are currently in a vending shop could be fooled into buying an item at different price than they see by reopening the vending shop (bugreport:4728).
- This implements the official vending shop unique id handling (previously mistaken for char id), made compatible with packets before it's introduction (follow up to r14234).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14682 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-26 11:52:44 +00:00
ai4rei
a4b7cce2c5 * Various accumulated insignificant fixes to documentation, examples and comments.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14674 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-15 20:12:51 +00:00
ai4rei
ad4e9bbee1 * Replaced remaining occurences of '-1' with 'INVALID_TIMER', where appropriate (follow up to r12998).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 21:00:38 +00:00
ai4rei
ab332bd663 * Fixed packet_len entry for packet 0x289 (ZC_PC_CASH_POINT_UPDATE) not matching the actual size used in clif_cashshop_ack (bugreport:4701, since r14639, follow up to r12264).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14660 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-09 16:37:43 +00:00
ai4rei
5f93676dea * Fixed script command 'progressbar' resuming fails on second invocation, when there was no script pause between the first and second call (bugreport:4698, since r14024).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14659 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:28:41 +00:00
ai4rei
bc191110f2 * Applied fix provided by Valaris to make /pvpinfo actually work. (bugreport:1785, since r1602).
- Filled-in missing packet fields and documented the packet. Note, that this command does not show anything outside of PvP maps (client-side limitation).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14657 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:19:07 +00:00
ai4rei
75ca2f146a * Fixed improper use of itemdb_search. It does not return NULL but a dummy item, if the item id is invalid.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14642 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-30 17:23:54 +00:00
ai4rei
33d2446b11 * Collection of random insignificant changes.
- Added progress indication on map-server shutdown when objects are removed from maps, as it takes significant amount of time to complete.
- Moved ers_free in db_obj_vclear, so that the node pointer is not used for comparison after it has been freed.
- Some documentation of shop packets.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14639 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-29 21:31:36 +00:00
ai4rei
5984718d86 * Fixed opening other player's vending terminating currently running NPC conversation. Vending is now unavailable when talking to an NPC (bugreport:2208).
* Fixed vending not accepting 0 Zeny as sell price. The client asks for confirmation when you attempt to sell items at 0 Zeny (bugreport:2595, since r918 and r11344).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14628 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-26 15:02:31 +00:00
ai4rei
9aa76bdd13 * Added support for new /remove and /recall packets for 2010-08-03aRagexeRE and newer.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14620 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-25 01:40:35 +00:00
ai4rei
1e81541e66 * Resolved random compiler warnings.
- Silenced pointer size mismatch gcc warning for variables passed to script_setarray_pc (bugreport:4661, since r14613).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14615 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22 14:06:37 +00:00
ai4rei
98c85e0d33 * Fixed missing check in cooking, causing cooking kit requirement could be bypassed by sending 0x25b (CZ_REQ_MAKINGITEM) directly (bugreport:4642, since r13628).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14592 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-15 19:33:27 +00:00
ai4rei
adc89d50f4 * Updates to the playBGM functionality (since r14335).
- Removed impossible condition in playBGM script command (from soundeffect).
- Removed unused code (retrieving of a bl) in playBGMall (from soundeffectall).
- Made playBGMall default to 'entire server' when both map name and coordinates are omitted instead of printing an error.
- Updated documentation for playBGM and playBGMall to match actual behavior.
- Removed unused parameter 'bl' in clif_playBGM.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 13:10:08 +00:00
ai4rei
522a51bb10 * Removed some of the duplicate, storage-related packet code.
- Removed clif_guildstoragelist and adjusted clif_storagelist to be able to handle any kind of storage.
- Removed clif_guildstorageitemadded in favor of clif_storageitemadded.
- This also fixes clif_guildstorageitemadded sending old update packet for clients prior 20090603, although packet 0x1c4 (ZC_ADD_ITEM_TO_STORE2) was added before PACKETVER 5 (before 2003-11-03aSakexe, exact addition date unknown) (since r14286).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14571 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-09 23:18:03 +00:00
ai4rei
e26ea94a2f * Reverted r14563, due to multiple issues which render the source malfunctioning or uncompilable. To be redone later (bugreport:4627).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14567 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:45:24 +00:00
Paradox924X
ca53ef6f4a Changed almost all instances of sprintf() to snprintf().
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14563 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 18:38:03 +00:00
ai4rei
5cfc017080 * Removed leftovers of the item_value_db.txt feature (bugreport:2031, since athena-dev-2.1.1-mod377, followup to pre-svn 2004/05/29).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14553 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:15:29 +00:00
ai4rei
fc662a0020 * Random clif.c fixes and cleanups.
- Fixed clif_homskillup using sd before nullpo check (since r9297 and r9307).
- Merged code responsible for disabling pets in GvG and spawning them as per TODO (related r12002).
- Fixed base and job exp not being sent to the client for new connections (follow to r14505).
- Fixed Magnifier (item) and Identify (skill) attempting to identify an item, even when cancel is pressed, causing skill failed message.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:58:34 +00:00
ai4rei
f9bdaf5426 * Added defines for guild notice sizes (MAX_GUILDMES1 and MAX_GUILDMES2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14544 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:17:07 +00:00
ai4rei
ce93557473 * Added clif_starskill (packet 0x20e, ZC_STARSKILL) to host the packet previously implemented by clif_feel_info, clif_hate_info, clif_mission_info and clif_feel_hate_reset (related r4352, r4375 and r9162).
- This also fixes sd->bl.id being sometimes supplied for monster_id in this packet.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14543 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:56:19 +00:00
ai4rei
10638473e4 * Various additions and updates to the comments and documentation of packets in clif.
- Renamed clif_01ac to clif_skillunit_update to make it look less 'mysterious'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14542 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:06:00 +00:00
ai4rei
c8cae9e659 * Removed clif_weather_sub and clif_misceffect2 in favor of clif_specialeffect_single and clif_specialeffect (all of them are ZC_NOTIFY_EFFECT2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14541 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 12:08:44 +00:00
ai4rei
a313575e51 * Added packet 0x1b1 (ZC_SHOWDIGIT).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14539 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 00:02:55 +00:00
ai4rei
ca36918486 * Confirmed packet 0x291 (ZC_MSG) to be general-purpose msgstringtable.txt packet and updated all functions using it (related r12245 and r13126).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14538 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 23:59:10 +00:00
ai4rei
6cb2c681c9 * Added a define for star gladiator feel/hate info array length (follow up to r8721 and r11840).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14523 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 08:25:03 +00:00
ai4rei
c82e8e36f1 * Added an option to re-roll the /dice emotion server-side, to prevent cheats during events (bugreport:4194).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14519 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 23:08:42 +00:00
ai4rei
93e376eac5 * Added emotion_type enumeration for clif_emotion constants.
- Made clif_parse_Emotion use clif_emotion, rather than having it's code inlined.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14518 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 22:43:10 +00:00
ai4rei
5d1bbf6c2a * Added clr_type enumeration for vanish effect constants.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14517 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 21:41:38 +00:00
ai4rei
8b5c0c742b * Resolved multiple issues with the party booking system (bugreport:4573, since r14412).
- Fixed recruitments were limited to party leaders.
- Fixed recruitment index was party id instead of an auto-increment value, causing sorting by age not working.
- Fixed search result packet being sent on recruitment creation (probably to work-around next problem).
- Fixed packet 0x0805 not getting sent, because of commented entries in packet_db.txt (packet ver. restriction of clif_send).
- Fixed recruitment creation notice being sent to the recruiter only.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14516 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 21:06:17 +00:00
ai4rei
4d73f8ab86 * Made the party booking search pass results as array of pointers, rather than array of indexes, which require further lookup.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14514 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 13:44:23 +00:00
ai4rei
c13027baf7 * Replaced literal constants related to the party booking system with defines.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14513 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 12:41:26 +00:00
ai4rei
d503330ed8 * Fixed pets with player sprites causing the client to crash while looking for non-existing resources (topic:260895, follow up to r14488).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14496 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-24 23:15:11 +00:00
ai4rei
29f9e79242 * Fixed disguising as player clone causing the client to crash while looking for non-existing NPC sprites (bugreport:4428, since r14387, related r14383).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14488 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-22 19:43:19 +00:00
ai4rei
53fd4cef96 * Fixed guild and guild member exp truncation issue (bugreport:4130, since r14242).
- Fixed guild member position, hair, hair color, gender, class and level could potentially become corrupted due to shorts being read as ints (partially since r2986).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14487 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-22 16:52:46 +00:00
Paradox924X
9c672be638 Use packet 0xe7 instead of 0x1f5 within clif_tradestart() when there is no trade_partner (or an invalid one) specified even for PACKETVER >= 6. (bugreport:4544)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14454 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-10 03:55:52 +00:00
Paradox924X
527041fb58 Send the actual level of the person you're trading with rather than limiting it by the max_lv/aura_lv settings.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14451 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-08 22:21:03 +00:00
Gepard
5c72ec7b7e Applied clif_equiplist fix by Ai4rei to prevent client crash when equipment is broken/repaired and PACKETVER >= 20100629. Follow-up to r14368. (bugreport:4459)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14449 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-07 10:44:16 +00:00
Paradox924X
53e81e1369 Applied patch by xazax to clean up various bits of code across mapserver code. (bugreport:4512)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14438 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-02 04:24:46 +00:00
Paradox924X
120bf1dfec Added a missing const qualifier to a variable. (bugreport:4472)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14419 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-11 03:10:11 +00:00
Paradox924X
2f9e3dbf81 Replaced all nullpo_retr() calls which returned 0 with nullpo_ret() calls.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14414 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-09 01:57:04 +00:00
L0ne_W0lf
b0ba85081c * Touched up the party booking patch, seems I forgot some lines in clif.c...and managed to duplicate a line in map.c.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14413 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-06 15:36:41 +00:00
L0ne_W0lf
ba7f770b45 * Added Spira's Party Booking System implementation
- Added two additional mercenaries and updated data.
- Added place holder values to the item database.
- Added packets for the party booking system.
- Updated the 13.2 monster skills to official.
- Updated stats and drop rates on several monsters.
- Fixed Lullaby working on allies/party members.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14412 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-05 17:17:58 +00:00
L0ne_W0lf
6e837a5214 * Added bard/dancer songs and duets to the nodispell list. (bugreport:4411)
* Applied Ai4rei's patch for the skill WE_CALLPARTNER (bugreport:4437)
* Lots of updates to monster stats/drops, all fairly minor.
* Updated the price and weight of a handful of etc items.
* Removed drops for quest-spawned Satan Morroc. (bugreport:4425)
* Changed weight on novice consumable items to 0 (bugreport:4442)
* Updated Sage quest skill quest with the file curtosy of 5511.
* Fixed the Pink Crystal being named Blue Crystal in Flavius.
* Touched up the archer tutorial, and phantasmic arrow quests.
* Fixed Turbo Track records for 8 and 16 normal saving as expert. (bugreport:4433)
* Corrected the positions for the arug castle 04 exterior flags. (bugreport:4436)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14409 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-09-18 17:15:37 +00:00
Paradox924X
c29c148adc All mobs whose display sprites are those of a job id will now appropriately be identified to the client as players, not mobs.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14405 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-09-09 03:52:21 +00:00
brianluau
239a74fc2c - Fixed duration of Box_Of_Sunlight. (bugreport:4408)
- Fixed some small typos in KVM scripts. (bugreport:4403)
- Fixed @refresh leaving you stuck if you had a chat window open.
- Changed @refresh to also send your facing direction.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14394 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-26 14:27:19 +00:00
Skotlex
1ffca62da2 - Added a few missing updates to the last packet update to properly support player clones and disguising.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14387 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-20 18:14:40 +00:00
Inkfish
3a10ff3524 Fixed a typo in clif_storagelist
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14386 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-20 16:15:01 +00:00
Skotlex
e19451d423 - Implemented usage of packets 0x7fa and 0x7f7, 0x7f8, 0x7f9. These are used for proper deletion of items as well as movement/spawn packets for Renewal clients.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14383 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-19 15:46:55 +00:00
Inkfish
6f58038c69 Fixed an exploit where unauthorized GMs can give zeny through auction.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14379 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-17 02:09:47 +00:00
L0ne_W0lf
dc0977ed37 * Quest log kill count now updated properly. (Added from topic 253813)
* More battleground editing, and some bug fixes.
- * ALL BATTLEGROUNDS ARE NOW ACTIVE BY DEFAULT. PLEASE CONTINUE TESTING *
- Rewrote the Badge Exchange NPC in bg_common.txt, is official now.
- Other changes to the bg_common folder, including disabled GM NPC.
- Completely rewrote Flavius for the most part, from ground up.
- Moved old Flavius battlegrounds to /custom/battleground folder.
- Restored original bg_common, and KVM to /custom/battleground
- Fixed wall bugs in Tierra Gorge, and added an oninit to the timers.
- Other minor tweaks to both Tierra Gorge and KVM scripts.
- Fixed the pseudo-cooldown on KVM not working properly, I hope.
- Added global time2str function which will be used later in Endless tower.
* Applied Epoque's mapflag clean up, which removes flags from scripts.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14374 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-14 16:06:23 +00:00