1248 Commits

Author SHA1 Message Date
ultramage
34def63ece Cleaning/fixing the previous commits a bit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13775 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 11:41:40 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
Inkfish
e4ed05e3f0 PNEUMA, BASILICA and SAFETYWALL no longer protect you from such negative status changes as COMA, STUN, FREEZE and etc. (bugreport:1346)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13767 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 11:07:09 +00:00
zephyrus
15a8174e29 - Rental items now can be stackable items too.
- Added @font command to test kRO fonts. (Client side requires : Langtype 0 / Hex + Fonts Files on the data folder).
- Rental now announces with a maximum time to fix a problem with 1 month or more rentals.
- Reduced amount of calculations of Flee on map change (only if required).
- More security on Rental items.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13761 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 16:47:12 +00:00
Inkfish
ed83c8817d * Added check on stackable items to 'checkweight' (bugreport:1569, bugreport:2756, bugreport 2994) [Inkfish]
* Fixed flee penalty wasn't applied for battleground and wouldn't be restored on map change [Inkfish]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13735 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 10:38:00 +00:00
brianluau
a11e789e0a - Fixed some typos in the script command documentation. (bugreport:2547)
- Fixed a misleading message in the custom Job Changer. (bugreport:682)
- Updated some NPC's facing directions. (bugreport:3030)
- Added missing newline in some ShowWarning(). (bugreport:2940)
- Fixed SC_BOSSMAPINFO time being off by 1 minutes (bugreport:3035)
Now, the seconds are rounded up to the next whole minute.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13713 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:23:30 +00:00
ultramage
22b2671e0f Added length check to functions clif_parse_CreateChatRoom and clif_parse_ChatRoomStatusChange (bugreport:2999).
This prevents a signed/unsigned integer overflow when calling the safestrncpy function.
Also added a note regarding a potential out-of-bounds access issue in these functions.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13690 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 15:09:17 +00:00
ultramage
d6ca23f16f Made some adjustments to the land skill code, based on official information:
- Expanded and corrected the land skill view id enum in skill.h
- Renamed UNT_ATTACK_SKILLS to UNT_DUMMYSKILL and UNT_KAENSIN to UNT_KAEN (official terminology)
- changed GS_DESPERADO to use the UNT_DUMMYSKILL view id instead of UNT_KAENSIN (and is it supposed to be a land skill at all?)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 13:57:22 +00:00
ultramage
c7515f00d8 Adjusted the exploit crashfix from r13678 to abort when invalid input is detected.
Script text input packets of length 8 are now also invalid since there must be at least a zero byte (end of string) present.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13680 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-20 16:28:53 +00:00
zephyrus
27e8e70acb - Critical crash fix. Please update your servers.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13678 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-17 22:59:41 +00:00
Playtester
6eccfdfff4 * Cooking success chance is now affected by DEX and LUK
- "cooking exp" still needs to be implemented
- also fixed a small issue when whispering to someone in autotrade

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13671 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-14 16:09:19 +00:00
ultramage
0149dbeb97 Quick-fixed a bug that let anyone kick any online character from the mapserver (bugreport:2939).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13656 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-03 17:04:49 +00:00
ultramage
d8104e4df7 Defined new server-side PACKETVER 20081126 to add support for the modified pet information packet (topic:197874).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13641 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-30 10:02:41 +00:00
ultramage
500f9893a1 Added packet 0x43f's length to the packet len table and adjusted related code (followup to r13622).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13640 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-30 08:55:12 +00:00
ultramage
86c1cf7721 Extended the hardcoded packet length table values up to MAX_PACKET_DB (0x500).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13639 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-30 08:51:01 +00:00
zephyrus
5ddd4d08fe - Implementing official battleground "emblem" crossed swords icon.
- Removing the custom guild packets from Battleground as they are not needed anymore.
- Scripts updated.
- In this way, you get "battle cursor" over your same team, but that's how official does.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13635 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-29 16:49:52 +00:00
ultramage
6578f10ffa Enhanced the 'hack on npc menu' message in clif_parse_NpcSelectMenu.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13633 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-29 09:30:59 +00:00
ultramage
71fbf3e1a4 Added correct packets for the food item creation window.
Added script command 'cooking' to activate this window and applied it to the 5 cooking kit items.
Renamed the cooking quest variable to cooking_q to avoid a naming collision with the new script command.
(You need to manually rename all occurences of this variable in your txt-savefile/sql-database if you want to preserve player progress.)
The code still relies on the messy skill_produce_mix logic and still uses completely custom equations. To be fixed in a separate commit.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13628 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-25 21:59:55 +00:00
Sara
be0d3c68fb Ghetto-fixed the status timer packet for now.
For some reason, packet lengths as high as 0x43f are not reading properly, despite being fine in the packet database.
It works fine right now, but it should be changed when the packet database reading is fixed.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13622 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 11:01:34 +00:00
Sara
0073a977c0 Some more fixes to my buggy commit -.-;
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13621 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 10:07:56 +00:00
akrus
db152551e5 :)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13619 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 09:14:58 +00:00
Sara
9189eb2c15 Some fixes to my previous commit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13618 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 09:10:30 +00:00
akrus
70ab4f2888 Quick fix for Sara's commit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13614 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 08:24:57 +00:00
Sara
b3860fdc01 * Added support for new status change packet, uses new setting display_status_timers in client.conf.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13613 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 01:56:16 +00:00
zephyrus
7fd0aa832a - Implemented official battlechat packets (thanks to Pakpil).
- Implemented the scoreboard packets (thanks to Pakpil).
- Updates to Tierra Valley according to official info.
* There are no barricades around each base, barricades are in the middle left path.
* There is another graveyard used for the owners of the middle base, with faster spawn (each 20 seconds).
* I added a flag respawn in the middle, currently I don't know if this if official or not, but it allows each team recapture the middle base.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13593 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-17 22:32:49 +00:00
FlavioJS
bce9eb25bd * Results of client behavior investigation when mes/next/close/menu/input is used.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13575 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-10 16:41:06 +00:00
ultramage
541f74494e Added several mail id checks to prevent a map server crash (bugreport:2837).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13571 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-08 00:10:39 +00:00
ultramage
9c6c292775 Small edits to battleground code (bugreport:2816)
- removed bg_idle_announce setting (could be considered later)
- moved crystal protection code to battle_calc_bg_damage
- removed mob state 'inmunity' in favor of a script-based solution
- removed unneeded 'setmobdata' (fixes collision with mob controller)
- added svn:eol-style native for battleground code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13565 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-04 17:26:07 +00:00
ultramage
5af84c659d Just some generic cleanups.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13556 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-02 17:54:13 +00:00
zephyrus
e9153a3c17 - Fixed item Nemesis.
- Fixed Tarot Card being used on Emperium.
- First Part of BattleGround Implementation (please wait).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13550 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-02-26 21:27:12 +00:00
sketchyphoenix
35dbe82eea * Consolidated is_atcommand() and is_atcommand_sub()
- replaced gmlvl arg with a flag arg for internal/player generated checks. (dummy sds that used this arg are given gm levels)
	- each command check runs through is_atcommand() and is checked for its origin (internal or player generated)
	- charcommands are also parsed in this function.
	- script atcommand/charcommand function calls to is_atcommand() have been updated
	- also updated some clif/map functions calls to is_atcommand()
	* charcommands should now log properly with the target of the command included.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-02-23 18:32:43 +00:00
ultramage
47fad03c47 Added a missing break; in pc_setstat, messing up LUK increasing (see r13460) (bugreport:2697).
Corrected clif_bladestop(), void function returning a value (see r13471) (bugreport:2698).
Fixed npcs with touch area not stopping walk timers (see r6516) (bugreport:2700).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13480 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-23 11:53:52 +00:00
FlavioJS
e3d5e89496 * Changed val4 of SC_BLADESTOP from a block_list pointer to an id. (64bit portability issue and potential dangling pointer crash)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13471 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-22 09:37:47 +00:00
ultramage
9c255d04a4 Fixed a null pointer crash in r13463 (thanks to Ramsey for reporting it).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13467 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-21 07:58:50 +00:00
ultramage
dfe2b1edaa Efficiency improvement for clif_send (use pc_db iterator instead of sockets array).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13463 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-20 21:55:07 +00:00
ultramage
578532f577 Moved the 'changed' mailbox flag from shared mmo.h to mapserver-only.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13433 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-05 15:34:09 +00:00
ultramage
ac66afa042 Cleaned up code for inserting cards into items.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13418 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-12-28 23:04:50 +00:00
zephyrus
d33dce2ac2 - Book reading script command.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13417 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-12-28 17:08:51 +00:00
sketchyphoenix
76ff905e03 Removed charcommand code while allowing atcommand code to support its functionality.
Charcommands still retain their '#' symbol but now looks for a character name as the first parameter instead of last.
Atcommand configs now support charcommand level configurations by comma seperation (e.g. 60,99)
As a result of this, all atcommands that don't affect multiple users already (@kickall, @doom, @mapexit) are capable of remote usage.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13403 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-12-18 02:36:01 +00:00
FlavioJS
7ae74b588b * Hunted down improper uses of va_list variables.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13383 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-11-22 23:54:34 +00:00
FlavioJS
72542d65cc * Hunted down the simpler 64bit pointer truncations.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13380 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-11-22 15:44:17 +00:00
zephyrus
c830a56da3 - Item Rental System.
Script Usage:
- rentitem <itemid>,<seconds>;
- rentitem <itemname>,<seconds>;

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13370 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-11-16 16:14:30 +00:00
Sara
f772c39910 * Fixed the maximum level of Create Elemental Converter. (bugreport:2326) [Sara]
* Fixed issue preventing you from changing to the original cart when using Change Cart. (bugreport:2383) [Sara]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13353 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-11-06 04:30:35 +00:00
Paradox924X
7659437737 Commented out unused function clif_marriage_process.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13320 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-24 18:38:59 +00:00
ultramage
287402e21b Swapped around packets 0x2b6 and 0x2b7, ought to fix some issues with the quest system.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13278 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-11 07:47:43 +00:00
ultramage
90ad9f3a8c Fixed chat_createnpcchat() not checking if a chatroom already exists, producing memleaks in certain situations (bugreport:2325).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13269 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-08 13:15:35 +00:00
L0ne_W0lf
f17bc9ba3e voided out clif_blown as per Valaris' instruction.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13263 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-06 11:54:45 +00:00
ultramage
ef5a49688d Fixed knockback not updating the client position of disguised players (bugreport:2308).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13261 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-06 08:11:49 +00:00
ultramage
b9929bd369 Fixed friends list ack packet using truncated values (bugreport:2310).
Blame goes to r2574.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13260 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-10-06 08:03:37 +00:00
ultramage
dc8edb6416 Adding null pointer check (followup to r13240).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13243 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-09-28 06:47:19 +00:00