8516 Commits

Author SHA1 Message Date
Lemongrass3110
d6daffe737 Fixed aftercast animation of Coluceo Heal
Fixes #1884
Thanks to @Tokeiburu
2017-01-15 23:32:04 +01:00
vstumpf
11f0a1f9d1 Clan Chat logging is now available 2017-01-14 17:47:36 +01:00
Lemongrass3110
f5c43329b2 Follow up to 9f4587a
Fixes #1877
Thanks to @Tokeiburu and @Everade for their help.
2017-01-13 23:34:06 +01:00
aleos89
6de7aa88e8 Resolved party bound item check (fixes #1874)
* Resolved a potential map-server crash.
* If a party bound item is attempted to be removed because the player was offline during party destruction, delete the item without recalculating the status.
Thanks to @Tokeiburu!
2017-01-13 12:29:18 -05:00
Lemongrass3110
a73814eeee Fixed some compile warnings
Fixes #1861
Thanks to @rubie123
2017-01-11 10:21:47 +01:00
Lemongrass3110
2043c95e66 Refactored hardcoded npc event names (#1767)
While refactoring those events the following other changes were made:

Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.

The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.

All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).

All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).

Renamed a few events in the script configuration to match the other names

Added constants for months and weekdays

Additionally added constants for gettime types to make it easier to read.

Replaced all existing usages I found with their proper new syntax or better fitting functions.
2017-01-10 22:58:04 +01:00
Playtester
870273e48f Fixed Taekwon Mission not working (fixes #1862)
* Taekwon Mission will now work regardless of setting "taekwon_mission_mobname"

Special thanks to @vstumpf for the fix.
2017-01-09 20:36:30 +01:00
lighta
c93b9cec6e Small finalisation for ARM va_list issue 2017-01-08 15:43:54 -05:00
Johnathan Fercher
755329fe11 raspberry simple adaptation
added a new version of itemdb_group_free at map/itemdb.c.
2017-01-08 15:35:19 -05:00
Lemongrass3110
14b79eafcb Follow up to 88aaa9b
Fixes #1857
Thanks to @srhmike
2017-01-07 22:32:07 +01:00
Aleos
f14b5b34ec Adjusted the parameter size for NPC commands (#1856)
* Adjusted the parameter size for NPC commands
* Fixes #1805
* Changed NAME_LENGTH parameter size to NPC_NAME_LENGTH.
Thanks to @Tokeiburu!
2017-01-06 19:11:50 -05:00
Lemongrass3110
88aaa9be98 Added a parameter to map_nick2sd for partial name (#1852)
With this parameter the caller can decide if he wants to enable or disable partial name scan support.
Generally it was disabled in a lot of functions(clif,channel,script commands).
It is still available for some "non-critical" atcommands as well as for all charcommands.
2017-01-07 00:19:04 +01:00
Lemongrass3110
55459f30f2 Added a script command for instance information (#1815)
With this script command you can look up information about a specific instance. This way you do not have to hardcode values specified in the database in the script if you need it.

Thanks to @aleos89 for the script documentation.
2017-01-07 00:08:11 +01:00
Lemongrass3110
12457d342f Fixed sleep2 and awake functions for non-players (#1849)
Fixes #1837
2017-01-06 23:41:18 +01:00
Lemongrass3110
eb47d74f08 Added a config for maprespawnguildid's behaviour (#1836) 2017-01-06 23:29:49 +01:00
naffej
da526d1982 Update battle.c (#1850)
* Fixed Neutral Barrier not checking the target, instead of source, if attacks should hit.
2017-01-06 12:53:07 -05:00
Lemongrass3110
03a54402bc Fixed ZC_PROPERTY_HOMUN_2 packet
Homunculus also have their HP stored as int from 2014-10-16 onward.
Please note that the information windows is to small to show the numbers correctly, because Gravity certainly does not intend that the HP can become that high.
2017-01-04 13:21:47 +01:00
Lemongrass3110
8b6b9c19ac Follow up to b0bcd06
Added a special error message for timeout, since it does not set an error code when a timeout occurs.
Also added a message when the socket is not writeable after successful connection.
2017-01-03 15:44:08 +01:00
Playtester
396b5c3215 Renewal Stealth / Chase Walk (fixes #1826)
* Stopping Stealth aka Chase Walk in renewal now has a cast time
2016-12-30 20:53:52 +01:00
Locien
be1c0ee1e6 Geffen Magic Tournament instance - Semi-official implementation
Big thanks to @RagnarokNova for creating this script with the help of
@tokeiburu, Diablo and others. I simply converted it to be compliant
with rAthena master standard. Hope you guys enjoy it and report any bugs
:)

To clarify on the semi-official part: This script was made from scratch
by playing on iRO and may have inconsistencies with the official
version. If you want to use this on your server you must enable it
yourself by uncommenting the entry in scripts_athena.conf.
2016-12-30 18:45:49 +01:00
Lemongrass3110
575583d0a6 Added some new NPC constants and mob placeholders 2016-12-28 13:03:44 +01:00
Playtester
260655a3c4 Songs and Dances vs. Dispell and Vanishing Buster (fixes #1824)
* Songs and Dances can no longer be dispelled by Dispell and Vanishing Buster
* Added a configuration to simulate the old behavior: Dispelling works if target not inside song area
2016-12-25 20:02:07 +01:00
Jittapan Pluemsumran
9f4587a652 Made prevent_logout effect on log-in optional (#1827)
* Made prevent_logout effect on log-in optional
kRO does not prevent players from logging out after connecting to its zone servers.
2016-12-25 22:16:30 +07:00
Playtester
182557311b Official song and dance formulas (fixes #1808)
* Fixed musical lessons not having any effect on Song of Lutie's MaxHP bonus (lesson/2)
* Song of Lutie now heals 1 HP more every 2 vit instead of 5 HP more every 10 vit
* Perfect Tablature's flee bonus in renewal is now 3*skill_lv + agi/15 + lesson/2
* Perfect Tablature's perfect dodge bonus is now (skill_lv+1)/2 + luk/30 + lesson/5
* Focus Ballet's hit bonus in renewal is now 20 + 2*skill_lv + dex/15 + lesson
* Focus Ballet's hit bonus in pre-re is now 1 + 2*skill_lv + dex/10 + lesson
* Slow Grace's ASPD decrease in renewal is now 3*skill_lv + dex/15 + lesson
* Slow Grace's ASPD decrease in pre-re is now 5 + 3*skill_lv + dex/10 + lesson
* Slow Grace's speed decrease in renewal is now 2*skill_lv + agi/20 + lesson/2
* Slow Grace's speed decrease in pre-re is now 5 + 3*skill_lv + agi/10 + lesson
* Impressive Riff's ASPD increase in pre-re is now 5 + skill_lv + agi/20 + lesson/2
* Lady Luck's critical bonus is now 10 + skill_lv + luk/10 + 0.5*lesson (not rounded down)
2016-12-20 22:17:52 +01:00
Playtester
d5357c3e9f Hell Power, Hallucination, Gospel (follow-up to 74d577c, fixes #1816)
* NPC_HELLPOWER is now a "no damage" skill and works similar to NPC_HALLUCINATION
* NPC_HALLUCINATION now has a fixed duration
* Both skills have a max level of 5 (for activation chance)
* Fixed Gospel's activation chance being 1% higher than it should be
* Fixed a compiler warning (see #1816)
2016-12-20 15:49:49 +01:00
Cydh Ramdh
2896d894d1 Official Random Coordinates for Savepoint (#1756)
* Added parameters for `savepoint are range for `x` and `y` for random savepoint coordinates.
* Added documentation for new savepoint params. Credits to @aleos89
* Updated savepoint on script to follow official behaviour (random save in 3x3). All credits to @Atemo
2016-12-20 17:16:42 +07:00
Cydh Ramdh
388e699e15 Added party config change_party_leader_samemap (#1803)
* Added party config `change_party_leader_samemap`
* Prevent changing the party leader if the specified player is not on the same map (Note 1)
* Default is `yes` as official does
* This config will be ignored by `party_changeleader` script command
* Thanks to @aleos89 and @Lemongrass3110

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-12-20 17:06:14 +07:00
Locien
fb29b18b52 Consistency changes for script unit commands (#1801)
* Consistency changes for script unit commands

Made it so that all unit commands(except for unitexists) take 0 as the
unit ID argument which will reference the activator of the script.
Unitwarp has since previously had this functionality and it's very
useful. Example use: When a monster walks over an npc script with the
OnTouchNPC label unitkill 0; will kill the monster.

* Clean up and fixes to unit script commands self referencing with ID 0

Added a script_rid2bl function that will return the block list beloning
to an RID specified or the activator of the script if 0 is specified as
RID.
2016-12-20 02:08:35 +01:00
Lemongrass3110
1b634c8f42 Fixed showdigit's start values (#1807)
Fixed #1769
2016-12-20 01:37:40 +01:00
aleos
8492f6c35e Fixes Feint Bomb and bNoKnockBack (fixes #1814)
* Resolves Feint Bomb's backslide effect not working when the player is wearing an item that has the bonus NoKnockBack active.
Thanks to @Everade!
2016-12-19 19:32:35 -05:00
aleos
1a5e3a35bd Added readable constants for knockback functions
* Added enum for skill_blown.
* Added enum for unit_blown_immune.
2016-12-19 19:04:01 -05:00
Lemongrass3110
552c39acc3 Fixed #1809
Thanks to @Tokeiburu
2016-12-20 00:13:48 +01:00
Playtester
d1f8c8ca6c Fiber Lock vs. Land Protector (follow-up to 79e9afa)
* Fiber Lock now ends in all situations in which the unit group is removed (e.g. Land Protector)
2016-12-19 23:43:56 +01:00
Playtester
74d577ce52 Gospel, Tarot, Curse, Poison, Hallucination, Hell Power, NPC skills
* Official Gospel chances, effects and duration (fixes #1812)
-- Chance of Gospel to trigger increased from 10%*skill_lv to 50%+5%*skill_lv
-- Gospel's Heal effect now heals 1000-9999 HP instead of 1-9999 HP
-- Blessing and Increase Agi effects now last for 4 minutes instead of 60 seconds
-- Increase Defense now only lasts 10 seconds instead of 60 seconds
-- Gospel's damage is now twice likely to trigger with one of two different effects
-- Fixed Gospel's damage not showing the Holy Cross effect
-- Gospel's first damage effect deals 3000-7999 damage which is reduced by DEF (percentual in pre-re)
-- Gospel's second damage effect deals 1500-5499 damage which cannot be reduced by DEF
-- Curse, Blind and Poison effect now last 30 minutes instead of 60 seconds
-- Provoke lasts infinite, but is removed when changing maps or logging out
-- Fixed Provoke's icon from disappearing whenever a status changes
-- DEF, ATK, Flee and Speed super debuffs now only last 20 seconds instead of 60 seconds
* Official status change base duration for curse (fixes #1811)
-- Curse base duration is 30 seconds in pre-re and 20 seconds in renewal
-- Napalm Vulcan, Tarot Card of Fate, NPC_HELLJUDGEMENT, NPC_WIDECURSE use this duration
-- NPC_CURSEATTACK has a fixed 30 seconds duration
* Official status change base duration for poison (fixes #1811)
-- Poison base duration is 60 seconds in pre-re and 20 seconds in renewal
-- Duration is no longer halved for monsters in pre-re
-- Envenom, Venom Dust, Venom Splasher, Tarot Card of Fate, NPC_POISON, NPC_ACIDBREATH use this duration
* NPC_STOP now has a duration of 15 seconds instead of 10 seconds
* NPC_HELLPOWER and NPC_WIDEHELLDIGNITY now have a duration of 180 seconds instead of 300 seconds
* Tarot Card of Fate uses base duration for Curse, Poison, Stone, Freeze and Stun
-- For Confusion and Stop the duration remains fixed to 30 seconds
* All NPC status skills now have a 20%*skill_lv chance to trigger instead of 50%+10%*skill_lv
-- NPC_HALLUCINATION and NPC_HELLPOWER now only affect you to 20% instead of 100%/60%
* Damage shown by Hallucination is now completely random instead of being multiplied by 6
* The animation is now shown when trying to resurrect someone affected by Hell Power

Special thanks to @mrjnumber1 and Luke for providing various information on these.
2016-12-19 22:28:18 +01:00
Locien
a4a6dd896f Small fix to previous magic rod changes
Fixed a compiler error.
2016-12-17 04:10:07 +01:00
Locien
d92272eb89 Corrected behavior for magic rod showing its animation in pre-renewal
In pre-renewal the animation of magic rod only shows up when the user is
attacked with a spell that can be absorbed by it. In renewal it shows
when you cast the skill instead. This has been tested on iRO Chaos and
iRO Classic.
2016-12-17 00:55:34 +01:00
Lemongrass3110
b0bcd060c4 Added windows specific socket timeout code (#1714)
* Added windows specific socket timeout code

Added socket code for windows that respects our given timeout.
Also added some more ifndef checks to some stat reporting functions.
Updated the MSDN reference link.
Fixed the delay being milliseconds on windows, thanks to @theultramage
Fixes #794 on windows.
2016-12-17 00:36:23 +01:00
Stolao
25bcb51598 Merge pull request #1793 from rathena/Code_Consistancy_Edit
Code Consistency
2016-12-16 13:27:52 -08:00
Lemongrass3110
7df9962a72 Follow up to 9333921
Thanks to @Playtester's friend Ash for reporting this.
2016-12-13 09:10:07 +01:00
Stolao
f0059affb3 no message 2016-12-12 11:44:55 -08:00
Aleos
d095fe7a67 Merge pull request #1741 from rathena/cleanup/itemgroups
Cleaned up Item Groups
- Moved constants from const.txt to script_constants.h.
- Removes hard coded item groups into the IG_* database to easily be adjusted/created.
- Renamed IG_FingingOre -> IG_FindingOre.
2016-12-12 13:58:54 -05:00
Playtester
b4225e8436 Tarot Card of Fate Follow-Up (fixes #1789)
* The tarot card THE SUN no longer blocks other cards in pre-re (still does in renewal)
* Added a configuration for equal chance for all cards in case someone prefers eAthena behavior
2016-12-12 19:10:28 +01:00
Lemongrass3110
0e78dfca26 Fixed a compiler warning
Follow up to 79e9afa
Fixes #1787
Thanks to @srhmike
2016-12-12 08:47:58 +01:00
Playtester
f084db4f1c Monsters spreading out on hide (fixes #1786)
* When you hide and monsters are still on their original chase path, they will no longer spread out
-- This makes Grimtooth mobbing viable again on default settings
-- In all other situations, monsters will still spread out
2016-12-11 22:37:32 +01:00
Playtester
79e9afaff0 Fiber Lock / Spider Web (fixes #1782)
* Fiber Lock's duration now depends on the map and how many fiber locks have been stacked
-- PVM: 1st - 8s, 2nd - 16s (default - 8s)
-- PVP: 1st - 4s, 2nd - 8s, 3rd - 12s (default - 4s)
* Fiber Lock now always doubles fire damage, even in renewal
* When a unit affected by Fiber Lock takes fire damage, the Fiber Lock that lasts shortest is now removed
* A unit can now only move when all Fiber Locks on it were removed or have expired
* When a unit with multiple Fiber Locks on it dies, not all Fiber Locks are removed
* A unit can no longer be affected by more than 3 Fiber Locks at the same time
2016-12-11 19:25:48 +01:00
Lemongrass3110
ab38f2cd7e Fixed jobmasks for custom jobs(>32 bit)
Fixes #1784
Thanks to @Stolao
2016-12-11 16:33:41 +01:00
Lemongrass3110
93339212bc Fixed #1772 (#1773)
* Fixed #1772

Added support for char_id to readparam
Added a check and error message if get_var is used on a parameter instead of a variable
2016-12-11 16:00:44 +01:00
Lemongrass3110
d13acf3886 Fixed a bug with getarraysize
When the attached rid of the script was actually not a player, but a monster or something else the script was terminated. A good example for this was to use getarraysize on a OnTouchNPC event.

Thanks to MasterOfMuppets(@Locien) for reporting this.
2016-12-11 14:57:18 +01:00
Playtester
08406785c6 Skills that increase elemental damage (fixes #1780)
* Negative values in the attr_fix table will now longer be ignored
* Renewal: Skills that increase elemental damage stack linearly with the attr_fix value
(e.g. if the attr_fix value is -25% and a skill increases elemental damage by 50%, it becomes 25%)
* Pre-Renewal: Skills that increase elemental damage increase damage percentually
(e.g. if damage is 25 and a skill increases elemental damage by 20%, it becomes 30)
2016-12-10 18:39:03 +01:00
Playtester
fd892a0425 Monster idle/walk behavior (fixes #1778)
* Monsters will now remember which players have spotted them
* If all players that spotted the monster logged out, it will become inactive again
* Inactive monsters neither walk nor use any skills (e.g. Metamorphosis)
* Minor documentation fix
2016-12-10 17:05:09 +01:00