8516 Commits

Author SHA1 Message Date
aleos
8399992598 Adjusted variable size
* Increased variable size for the item group check to prevent overflows.
2016-12-10 09:25:54 -05:00
Lemongrass3110
b9a8ab722e Added an additional parameter to instance_enter (#1720)
Added an additional parameter to instance_enter

This allows easier usage for instances in IM_NONE, where a player will never be attached to the instance.
All you have to do is remember the created instance id and supply this command with it. That way you do not have to use any workaround like the following anymore:
warp instance_mapname( <mapname>, <instance id> ), <hardcoded enter x coordinate>, <hardcoded enter y coordinate>;

Added usage of the new constants in the existing scripts

Fixed default checks and null pointer output
Thanks to @Atemo
2016-12-10 12:38:57 +01:00
aleos89
0162ad890e Corrected Spore Explosion on GCC builds
* Follow up to 8f4660b.
* Resolves Spore Explosion not inflicting damage on targets for some GCC builds.
Thanks to @Tokeiburu!
2016-12-08 09:23:41 -05:00
Lemongrass3110
e490befb9a Follow up to e2eadcf 2016-12-08 01:41:21 +01:00
Lemongrass3110
e2eadcfbd8 Implemented mapflag nolockon correctly
Fixed #1736
Thanks to @GrumpyLittlePanda for reporting and @Playtester for pointing me into the right direction.
2016-12-07 23:09:53 +01:00
Lemongrass3110
2bb92a114b Fixed hallucination ignoring reloadbattleconf
Fixed #1765
2016-12-07 22:28:36 +01:00
Playtester
05783ade33 Follow-up to 0dbc83d (related to #1768)
* Moved the skill_tarotcard function up so the compiler doesn't throw warnings
* Minor code optimizations and comment updates
2016-12-07 22:09:09 +01:00
Playtester
0dbc83db9d Tarot Card of Fate (fixes #1768)
* Implemented official chances for each Tarot Card to occur
-- 15%: LOVERS
-- 10%: FOOL, MAGICIAN, HIGH PRIESTESS, STRENGTH, SUN
-- 8%: TEMPERANCE
-- 7%: CHARIOT
-- 6%: THE HANGED MAN
-- 5%: DEATH, STAR
-- 2%: TOWER
-- 1%: WHEEL OF FORTUNE, DEVIL
* The SUN tarot card will give you the tarot card status change
-- The status change makes you immune to other tarot card effects
-- The affected person will see a tarot card icon and the duration of the effect
* Fixed LOVERS healing self instead of the target
* The LOVERS tarot card now displays on self instead of target

Special thanks to @mrjnumber1
2016-12-07 21:28:32 +01:00
Cydh Ramdh
342443bf61 Added new mapflag hidemobhpbar (#1537)
* Added new mapflag `hidemobhpbar` to hides monster's HP bar on a map.
* Added maps for this mapflag, credits to @Atemo and @Lemongrass3110 

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-12-04 10:52:14 +07:00
Atemo
d3f0aec324 Fix issue #1651
- The timer event wasn't updated on last tick event
2016-12-03 05:50:16 +01:00
aleos89
33fa182c48 Corrected damage immunity states (fixes #1754)
* Added unit data damage immunity to the GvG targeting function.
* Added unit data and mob mode damage immunity to the reflecting damage calculation function.
Thanks to @admkakaroto!
2016-12-02 07:38:53 -05:00
aleos89
c05808a305 Fixed item bonus bAddMaxWeight (fixes #1761)
* Stored bAddMaxWeight into it's own variable for later calculation.
* Created enum constants for status_calc_weight and status_calc_cart_weight for easier readability.
2016-12-01 13:00:38 -05:00
Lemongrass3110
ac2ba09415 Fixed areawarp cell check
The script command areawarp has been checking the wrong target map for ages. It has been checking the mapindex rather than the mapid and therefore returned a wrong result.
2016-12-01 13:06:54 +01:00
Lemongrass3110
c88ca4432d Definition cleanup
Removed a few ghost definitions
Adjusted some definitions to use the same types

Related to #1738
2016-11-26 20:34:55 +01:00
aleos89
82675d86d0 Resolved the rental timer display (fixes #1745)
* Follow up to 45d9674.
* Fixes the timer message displaying too often.
Thanks to @whupdo!
2016-11-26 14:09:44 -05:00
Lemongrass3110
9aaf18eb33 Fixed some compile warnings
Follow up to 09a0c29
Fixes #1748 - thanks to @srhmike
2016-11-26 17:19:14 +01:00
aleos89
09a0c29a39 Corrected Lux Anima behavior (fixes #1110)
* Only transfers the most recent rune buff to the party.
* The source loses the rune buff that is passed to the party.
* There is a stack limit of 20 Lux Anima Runestones.
-- Stack only applies to renewal as the item isn't implemented in pre-renewal.
2016-11-25 15:42:44 -05:00
aleos89
2c3201116c Split item stack database between renewal and pre-renewal
* Separated the database between the two modes.
2016-11-25 15:31:16 -05:00
aleos89
595d9b743d Fixed a potential map server crash
* Resolves an invalid operator check for pc_check_available_item.
* Added a new flag for pc_delitem to not calculate a player's status when unequipping an item.
Thanks to @cydh!
2016-11-24 23:41:53 -05:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00
aleos89
127c13bbdd Cleaned up Item Groups
* Moved constants from const.txt to script_constants.h.
* Removes hard coded item groups into the IG_* database to easily be adjusted/created.
* Renamed IG_FingingOre -> IG_FindingOre.

Enabled commented Item Groups
* Follow up to 50d5c14.
* Retains consistency between constant and ID values.
* Renamed duplicate item groups to avoid compile errors.
2016-11-22 09:32:14 -05:00
Cydh Ramdh
633a642e5a * Corrected combos of Elemental Clothes (19048)
* Updated Status Change documentation for `SC_SIEGFRIED` and `SC_SCRESIST`
* Fixed `bResEff` cannot be used to increase the rate (for reducing resistance)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-20 11:35:02 +07:00
aleos89
0dd3c74c2e Fixed some arrays not zeroing out on status recalculation (fixes #1722)
* Follow up to 0f1b1af, f296409, and a79d065.
* Fixes several bonuses that are not zeroed out properly since the block order didn't match.
Thanks to @whupdo!
2016-11-19 09:26:33 -05:00
aleos89
ef63cffa30 Small OPTION_INVISIBLE refactor
* Cleaned up the usage of OPTION_INVISIBLE to utilize the macro that was defined for it.
2016-11-18 14:44:49 -05:00
Playtester
db3ef52fd2 Frost Nova AoE (fixes #1619)
- Increased Frost Nova AoE from 5x5 to 7x7
- Frost Nova no longer hits enemies that are on the same cell as the caster
2016-11-17 18:25:56 +01:00
Lemongrass3110
0fa8919749 Added sura jobs to the switch 2016-11-17 17:35:35 +07:00
aleos89
9910478ce2 Resolved some compile warnings
* Resolved two unreachable code warnings.
* Resolved two potentially uninitialized local variable warnings.
2016-11-16 13:07:19 -05:00
Lemongrass3110
ecc8cf9f0b Initial release of the clan system
Thanks to @cydh, @RagnarokNova and @aleos89 for their help.
2016-11-16 15:36:08 +01:00
aleos89
dfccb88785 Removed double saving attempts
* Follow up to 3dfdb38.
* Removed an extra save attempt if a player changes jobs and has fame.
2016-11-16 08:50:36 -05:00
aleos89
3dfdb38d32 Fixed atcommand changecharsex sync issue (fixes #1684)
* Resolves the map-server holding a different job value than what the char-server could be holding.
Thanks to @Grantea!
2016-11-16 08:41:16 -05:00
Lemongrass3110
9bf5d4a291 Fixed a shadowed variable
Fixes #1718
2016-11-16 08:18:18 +01:00
aleos89
cb279a7243 Resolved an uninitialized variable (fixes #1717)
* Follow up to ade1b17.
* Corrects the countitem script command having an uninitialized variable warning during compile.
Thanks to @hnomkeng!
2016-11-15 21:54:44 -05:00
aleos89
5332d7f0e7 Resolved a map crash with pet items (fixes #1716)
* Follow up to ade1b17.
* Added a pet data check that was removed.
Thanks to @Keniski!
2016-11-15 21:52:05 -05:00
aleos89
d1cc320769 Corrected Storage dirty flag check
* Follow up to ade1b17.
2016-11-15 16:17:11 -05:00
aleos89
00fd5e7078 Removed rAthena Stat Reporter
* Follow up to 0ffeec0.
* No longer being used so it will now be completely removed.
2016-11-15 10:19:58 -05:00
Lemongrass3110
28cee2caa9 Cleaned storage saving output 2016-11-14 20:05:19 +01:00
Aleos
ade1b171eb Optimized Inventory, Cart Inventory, and Storage usage (#1115)
* These storage types now mimic Guild Storage and can be loaded/saved whenever needed.
* Relieves mmo_charstatus from having to send storage types and lets the char-server handle it.
* All storage types now have an increased max amount.
* Implemented Premium Storage System. Thanks to @cydh!
* Fixes #441 - Players will no longer be required to log out to resync cart item data before opening a Vending Store.
* Refactored player weight and cart weight calculations into their own functions.
* Added script commands openstorage2, guildstoragecountitem[2] and guildstoragedelitem[2].
* Refactored several function return types as well as documentation.
Thanks to @lighta and @cydh for their help with it!
2016-11-14 13:11:43 -05:00
aleos89
8028789dee Removed unused functions
* Removed inter_storage_delete and inter_guild_storage_delete functions as they are not used.
2016-11-14 09:38:59 -05:00
Lemongrass3110
b5de7df013 Implemented correct windows socket cleanup
Resolves HerculesWS/Hercules#1513
Thanks to @mkbu95 for bringing this up
2016-11-14 10:44:43 +01:00
Lemongrass3110
4ed035b036 Cleaned up fame lists (#1660)
Added 0x97e into the packet length table
2016-11-14 09:04:42 +01:00
aleos89
eae1161d53 Corrected Sling Item behavior
* Partial revert of 89a33a7.
* Moved bonuses back to the item_db so items can easily be customized.
* Sling Item is no longer usable on self.
2016-11-13 15:07:14 -05:00
aleos89
c00c7346d2 Resolved some compile errors
* Follow up to 9c552ca and 5aa53e4.
2016-11-11 15:35:38 -05:00
aleos89
5aa53e4738 Merge branch 'master' into cleanup/storages_optimization 2016-11-11 14:54:43 -05:00
aleos89
56512ce116 Corrected vending order of similar item IDs
* Resolves an issue where if a similar item ID is vended more than once (non-stackable) the order of the vended items becomes incorrect when one is purchased.
Thanks to @Tokeiburu!
2016-11-11 14:26:32 -05:00
Lemongrass3110
a03105b49d Fixed a potential map-server crash
Fixes #1398
2016-11-10 00:18:16 +01:00
Lemongrass3110
4687247769 Fixed a possible null pointer
Follow up to e93c888
See https://rathena.org/board/topic/108045-map-server-crash-after-using-skill-manhole/
2016-11-10 00:12:26 +01:00
aleos89
74a703d649 Corrected Anodyne usage on no teleport maps (fixes #1704)
* Added a missing break.
2016-11-09 09:36:10 -05:00
aleos89
550cfcad54 Merge branch 'master' of https://github.com/rathena/rathena 2016-11-08 11:10:33 -05:00
aleos89
623d845717 Fixed IgnoreDefClassRate check (fixes #1702)
* The item bonus will now properly check for a valid Class rather than a valid Race.
* Added IgnoreDefRaceRate and IgnoreDefClassRate to the item_bonus documentation.
Thanks to @Tokeiburu!
2016-11-08 11:07:08 -05:00
aleos89
9a009bf316 Corrected Spiritual Sphere Absorption and Cursed Circle interaction (fixes #1514)
* Spiritual Sphere Absorption will fail to go through if the caster is captured in Cursed Circle.
2016-11-07 16:46:21 -05:00