10057 Commits

Author SHA1 Message Date
lordttseven
a58fc65984 Status change packet cleanup
* fixed a couple typos
 * replaced duplicate function clif_status_load with a macro
 * normalized and documented status change table related getter abstraction
 * put some checks that were previously in multiple places into clif_status_change
 * packets are now used as they are on official servers:
  - ZC_MSG_STATE_CHANGE for ending statuses and starting them on non-pcs
  - ZC_MSG_STATE_CHANGE2 for starting *all* statuses on players
  - tick = 9999 for statuses of indeterminate duration
  - for non-pc units, a packet is only sent if it has a visual impact on the client; if you notice any missing visual effects, please report them!
 * fixed hidden GM characters leaking certain status packets
 * fixed hidden GM characters not displaying timers for newly gained statuses
 * fixed status end packet never being sent for non-pc, non-mercenary units
 * fixed SC_CLOAKING displaying a time bar on the client
 * fixed tick being an unsigned int, yet used as a signed int
 * removed hard-coded status length exceptions in clif_status_change

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-15 10:30:42 +00:00
gepard1984
2a9d39e36f Fixed Nick DB code using uninitialized data (bugreport:5439).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15687 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-14 11:46:24 +00:00
gepard1984
38b210138c Fixed char-server notifying map-servers only about first 30 maps (on other map-servers) (bugreport:5410).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15686 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-13 20:46:13 +00:00
eathenabot
949eead817 * Merged changes up to eAthena 15077.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15685 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-13 20:42:55 +00:00
gepard1984
ca21876adf Fixed mail system not notifying about new messages that were received from another map-server (bugreport:1651).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15684 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-13 19:00:49 +00:00
gepard1984
6aabd3d1b7 - Added missing parameter to db_iput and db_uiput macros (follow-up to r15682).
- Numeric global variables (mapreg) now utilize `DBMap`'s ability to store integer-type data (follow-up to r15682).
 - Minor code cleanup: replaced some `DBMap` function calls with macros.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15683 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-13 15:20:58 +00:00
gepard1984
691872fdc7 Enhanced DBMap implementation to allow storing integer type data in addition to void pointers.
- Added enum for data: `int`, `unsigned int` and `void*`
 - Replaced generic `void*` data with `DBData` struct to hold `int`, `unsigned int` or `void*` (member of `DBNode`)
 - Added `db_i2data`, `db_ui2data` and `db_ptr2data` functions to cast from `int`/`uint`/`void*` to `DBData` (used in `DBMap::put()`)
 - Added `db_data2i`, `db_data2ui` and `db_data2ptr` functions to get `int`/`uint`/`void*` from `DBData`
 - Enabled statistics for new functions in `db_stats` struct
 - `DBCreateData` functions (used in `DBMap::ensure()`) now return `DBData` instead of `void*`
 - `DBApply` functions (used in `DBMap::foreach()` and `DBMap::destroy()`) now take `DBData*` as a parameter instead of `void*`
 - `DBMatcher` functions (used in `DBMap::getall()`) now take `DBData` as a parameter instead of `void*`
 - `DBReleaser` functions now take `DBData` as parameter instead of `void*`
 - Default releasers release data if it is `void*` (`DB_DATA_PTR`) type
 - `DBIterator` functions: `first()`, `last()`, `next()` and `prev()` now return `DBData*` instead of `void*`
 - `DBIterator::remove()` now returns `int` (1 if node was found and removed, 0 otherwise) instead of `void*` and takes an extra `DBData*` parameter for the data of removed entry
 - `DBMap::get()` and `DBMap::ensure()` now return `DBData*` instead of `void*`
 - `DBMap::remove()` and `DBMap::put()` now return `int` (1 if node already existed, 0 otherwise) instead of `void*` and take an extra `DBData*` parameter for the data of removed entry
 - `DBMap::put()` now takes `DBData` as parameter instead of `void*`
 - `DBMap::getall()` now puts data into `DBData**` buffer instead of `void**` buffer
 - Updated macros:
   - (`i`/`ui`/`str`)`db_get` and (`i`/`ui`/`str`)`db_ensure` were wrapped with `db_data2ptr` to extract data from `DBData*` that is now returned by `DBMap::get()`
   - added (`i`/`ui`/`str`)`db_iget` and (`i`/`ui`/`str`)`db_uiget` that get `DBData` from `DBMap` and extract `int`/`unsigned int` from it (with `db_data2i`/`db_data2ui`)
   - `db_put`, `idb_put`, `uidb_put` and `strdb_put` data params were wrapped with `db_ptr2data` to match new signature of `DBMap::put()` (`DBData` instead of `void*`)
   - added (`i`/`ui`/`str`)`db_iput` and (`i`/`ui`/`str`)`db_uiput` that put `int`/`unsigned int` into `DBMap` (first wrapping it with `DBData`)
   - added `NULL` in place of extra parameter for removed data in `db_remove` macros
   - `dbi_first`, `dbi_last`, `dbi_next` and `dbi_prev` were wrapped with `db_data2ptr` to extract data from `DBData*` that is now returned by these `DBIterator` functions
 - Updated `DBMap` documentation, and fixed a dozen of typos in it.
 - Updated rest of rA code to reflect `DBMap` changes (mostly required signature changes of `DBCreateData` and `DBApply` functions).
 - Fixed a bug where `DBMap::put()` would return data of a deleted entry.
 - Removed some unnecessary pointer casts.
 - Increased `showmsg.c` static buffer size to fit entire DBMap stats report.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15682 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-13 14:46:28 +00:00
og2
1d01830661 Fixed char being stuck with breaks (bugreport:5374)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15681 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-12 23:59:16 +00:00
kenpachi2k11
7d6b0d7cd0 Follow up r15679. Changed Hatii Baby to Baby Hatii.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15680 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-12 20:19:39 +00:00
kenpachi2k11
8deaf7a050 Fixed Garms iRO name. (bugreport:5421)
Fixed some create_arrow_db.txt comments. (Follow up r15672.)
Fixed Sura job change quest. (bugreport:5431)
Corrected a NPC location in quests_veins.txt.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15679 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-12 19:50:51 +00:00
kenpachi2k11
1e2b445e0a Fixed Banish Winter Quest (two while loops could not be left). (bugreport:3142)
Fixed Siblings Quest exploits and made it more official. (bugreport:4088)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15678 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-11 22:02:48 +00:00
protimus
9d0455ffea - Follow up r15676.
Some monsters reported are of pre-renewal.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15677 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-11 07:10:19 +00:00
protimus
872df13c60 Fixed some wrong monster drops. (bugreport:5422)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15676 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-11 06:20:43 +00:00
Protimus
50a6aed796 * Added packets for clients 2012-03-07+
Not is recommended use this version yet, there are small packets structures to do changes.
* Added support for packet 0x970.
New schema of character creation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15675 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-11 05:28:50 +00:00
masao87
724fe6b1dc - Updated the whole Script to match with official file.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15674 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-11 00:54:40 +00:00
masao87
4b1e9d1d55 - Added Bossnia Event.
- Added new Town cleaners.
- Added mobs to sec_pri02 .

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15673 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-10 19:22:27 +00:00
kenpachi2k11
441a0e24c7 Fixed some arrow recipes. (bugreport:5413)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15672 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-10 19:19:06 +00:00
kenpachi2k11
60d3667d47 Fixed pre-RE EXP tables. (bugreport:5280)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15671 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-10 17:45:06 +00:00
kenpachi2k11
2510d450b6 Fixed Royal Guards job bonuses. (bugreport:5402)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-10 17:03:00 +00:00
kenpachi2k11
7ed46f7eb9 Fixed Poison Bottles (ID:678) script. (bugreport:5246)
Added Bradium Golem to mob_race2_db.txt (bugreport:5257)
Fixed Pile Bunkers (ID:1549) job requirements. (bugreport:5394)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15669 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-10 13:25:28 +00:00
gepard1984
8817eaa885 Code cleanup: replaced DBIterator function calls with macros where possible.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15668 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-09 14:31:15 +00:00
epoque11
3c6cf65bdf - Fixed skillratio bonus only ever being multiplied by a factor of 1 (follow-up to r15666)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15667 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-08 13:23:50 +00:00
xantara
e13ceef503 - Correctly fixed Aimed Bolt and Arrow Storm skill ratios (related to bugreport:5272 and r15663) - thanks to Lighta
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15666 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-08 03:37:24 +00:00
masao87
3f33f566f0 - Fixed a little leftover in socket_enchant2.txt .
- Added warp to iz_dun05 bugreport:5395 .
- Fixed a little typo in clif.c .
- Moved "int clif_status_load_single" from clif.c to clif.h .

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15665 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-07 23:50:38 +00:00
kenpachi2k11
f712811c13 Enabled some headgears. (Follow up r15662.)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15664 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-07 22:01:23 +00:00
xantara
7a6949a30f Fixed a few Ranger-related skills (bugreport:5272)
- Added check to not allow attacks when mounted on a Warg
- Added check to only allow a certain amount of skills when mounted on a Warg
- Updated Warg Bite's chance rate of immobilization and duration
- Updated Arrowstorm and Aimed Bolt's skill ratio damage

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15663 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-07 05:40:31 +00:00
kenpachi2k11
7fad147092 Enabled some headgears. (Inspired by bugreport:1849)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15662 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-06 23:02:27 +00:00
lordttseven
914c046ee4 * fixed a missing break; in status_change_start resulting in broken combo targets (bugreport:5389 and bugreport:5396, since r15009)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15661 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-06 16:38:13 +00:00
jmanfffreak
000d0e777c Added King Dramoh to mal_dun01 (bugreport:5381)
Corrected NPC sprite in minstrel job quest (bugreport:5387)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15660 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-06 02:02:26 +00:00
eathenabot
76f6cffc57 * Merged changes up to eAthena 15076.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15659 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-05 13:57:01 +00:00
gepard1984
47fc6d2fe2 - Guild Castle code cleanup:
- all changes to guild castle data are now handled first by map-server and only sent to char-server for saving
  - ensured that changes made to guild castle during char-server disconnection time will be resent on reconnect
  - actually removed definition of `MAX_GUILDCASTLE` (r15657)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15658 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-05 00:08:28 +00:00
gepard1984
f810293de3 - Guild Castle code cleanup:
- removed `MAX_GUILDCASTLE` limit
  - char-server now caches guild castles in `DBMap`
  - improved guild castle SQL queries to support non-default values of `MAX_GUARDIANS`
  - disallowed declaring guild castles on maps that are on other map-servers 
  - map-server now requests data for all guild castles from char-server on initial connect (bugreport:287)
  - removed ''guildcastleinfo events'' as they were esentially duplicated ''OnAgitInit''
  - optimized castle data load packets (bugreport:287)
  - updated WoE scripts to reflect source changes (scripts no longer need or should request castle or guild data)
  - updated related docs
- Added `db_size` macro.
- Replaced manual counting of castles occupied by a guild with `guild_checkcastles()` calls.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15657 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-04 18:37:29 +00:00
lordttseven
d78313665c Assorted skill-related tidbits
* reduced network load for PC_PERM_ALL_SKILL
 * fixed @allskill setting skill ids too late
 * fixed skill reset giving free level 9 NV_BASIC

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15655 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-04 11:00:25 +00:00
lordttseven
272d3792c5 * fixed job change level not being recorded for 2nd -> 3rd class (bugreport:5383). the fix should be self-regenerating on existing 3rd job characters
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15653 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-03 23:39:20 +00:00
lordttseven
9f938e0c70 * fixed getiteminfo offset being off by one in REMODE (bugreport:5378)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15652 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-03 13:15:01 +00:00
gepard1984
e314187787 Updated CMakeLists (follow-up to r15572, r15586) (patch provided by Saithis, pid:82588).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15651 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-02 19:57:29 +00:00
gepard1984
654676b73e Replaced some magic numbers related to castle guardians with MAX_GUARDIANS.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15650 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-02 17:00:17 +00:00
lordttseven
ce45ab511f - reverted r15523 (broken workaround for an underlying issue, see bugreport:5237 again)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15649 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-02 16:24:29 +00:00
gepard1984
412c51b4bd Minor NPC code cleanup: timer labels.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15648 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-02 00:43:28 +00:00
gepard1984
14d2a44ea5 - Fixed dangling pointer caused by r15644 (partially reverted).
- Fixed possible memory leaks with guild castle script events.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15647 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-02 00:22:18 +00:00
gepard1984
7da6590aad Proper fix for r15641 (reference to non-existant NPC).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15646 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 23:35:13 +00:00
shennetsind
c971087af3 Follow up r15638: the 'sd' party is unnecessary -- when there is no player (e.g. killed by command/npc) the modifier is always 100%. also, the primary 'sd' in mob_dead is 'mvp_sd' and not 'sd'.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15645 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 23:22:19 +00:00
gepard1984
17bb9ae684 Enabled DB_OPT_RELEASE_DATA for several DBMaps to simplify data freeing.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15644 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 23:21:45 +00:00
gepard1984
57de7584e8 Fixed skillname->ID DBMap storing skill integer value in void pointer.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15643 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 21:27:57 +00:00
gepard1984
b4d04d7117 Enabled DB_OPT_RELEASE_DATA for atcommands DBMaps so they are able to free data automatically (as pointed out by Wildcard).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15642 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 17:50:26 +00:00
masao87
4defbd1e6f - Follow up r15636, removed an warning where the Script trys to hide an Non-Existant NPC named "Staff#airplane_01".
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15641 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-01 14:13:19 +00:00
gepard1984
1e31877e30 Some NPC code cleanup (event labels).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15640 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-02-29 23:53:22 +00:00
protimus
2b62d9c05d Fixed Bradium Brooch ASPD bonus.
Added town mapflag to brasilis.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15639 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-02-29 06:12:12 +00:00
protimus
d70e5562da Removed drop and exp penalties of bosses monsters in renewal. (bugreport:5377)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15638 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-02-29 05:52:53 +00:00
gepard1984
9e913e885f Updated Apple Gambling script to official.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15637 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-02-28 22:28:19 +00:00