14120 Commits

Author SHA1 Message Date
Lemongrass3110
b213864542 Merge pull request #1283 from secretdataz/master
Kitsune Ear Bell Ribbon (18934) should give 10% ASPD bonus.
2016-05-19 10:05:14 +02:00
Jittapan Pluemsumran
8e0dff7acb
Kitsune Ear Bell Ribbon (18934) should give 10% ASPD bonus.
thanks to @spinzaku
2016-05-19 14:53:14 +07:00
aleos89
24ef79b12e Corrected Dispell, Clearance and Banishing Buster usage on hidden targets (fixes #1266)
* When the target hides after having one of these skills casted upon them, the skill will no longer fail.
2016-05-18 09:20:24 -04:00
Cydh Ramdh
c6917e36cd Follow up 1e584cb0f402f599bddf855b6bb07d28b0a43c76
* `active_transform` for Fox_Ears_Bell_Ribbon (18934) was reverted. Thanks to @spinzaku

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-05-18 12:46:57 +07:00
Cydh Ramdh
1e584cb0f4 Item DB Fixes
* Fixed #1276.
  * Cursed_Lyre (1741) now cannot be equipped by Archers
  * Falken_Blitz (Falken_Blitz) now only for Sniper & Ranger
  * (Rhe rest are correct) Thanks to @darknessfmy
* Fixed #1275.
  * Fox_Ears_Bell_Ribbon (18934) now has 1 slot and require level 50 to equipped.
  * Thanks to @spinzaku

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-05-18 08:32:55 +07:00
Lemongrass3110
0a79b4bc6d Cleaned and merged the chat functions
This adresses the issue that clients from late 2015 will not zero terminate most of their messages anymore.
It should also fix the problem with the unknown packets that were most likely caused by adding the zero termination directly into the packet buffer.
2016-05-17 23:38:53 +02:00
aleos89
b3c1866cf5 Updated Defender and Neutral Barrier reductions (fixes #1065)
* Defender now reduces Acid Demonstration damage (renewal mode).
* Defender no longer reduces Throw Zeny and Rapid Throw damage.
* Acid Demonstration now misses on targets in Neutral Barrier.
2016-05-17 10:38:03 -04:00
Lemongrass3110
0b126bae37 Merge pull request #1273 from Jeybla/AddFeedingLog
Thanks to @Jeybla for pointing out that I forgot to add the update script.
2016-05-17 07:57:49 +02:00
nanakiwurtz
01a324478a Item DB SQL Sync
* Updated item_db_re.sql

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-05-17 12:35:01 +07:00
nanakiwurtz
c4ded914e6 Updated Item DB
* Added missing costumes
* Thanks to @zackdreaver

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-05-17 12:33:06 +07:00
nanakiwurtz
44e27bd6bc Merge pull request #1257 from zackdreaver/master
* Added new costumes and fix item name translation
* Thanks to @zackdreaver
2016-05-17 12:22:30 +07:00
Jey
9bd10dacf4 Follow up to 879ddcc1af2600b90420d1c876e28866f68489ef:
Upgrade Script for feeding log.
2016-05-17 02:27:55 +02:00
aleos89
fe4eefb787 Implemented script command active_transform (fixes #1006)
* Works the same as script command transform and can be stacked with it as well.
* active_transform has display priority if transform is active.
Thanks to Ziu and @Darkelfen!
2016-05-16 14:15:22 -04:00
aleos89
717eb225ba Corrected weapon attack versus infinite defense (fixes #1169)
* Resolves Exceed Break, Spell Fist, and Giant Growth doing extra damage to infinite defense targets.
2016-05-15 09:10:02 -04:00
aleos89
cb703c5bfa Expanded instance_db to include idle time
* Follow up to c97be60.
* Adjusted the instance_db to allow instance idle time to be adjustable.
2016-05-14 12:06:04 -04:00
aleos89
8f7d2208a9 Adjusted instance scripts to new format
* Follow up to c97be60.
* Adjusted script command instance_create to include owner ID.
2016-05-14 12:01:22 -04:00
aleos89
c97be60bbf Expanded the instance system to support new modes
* New modes include: No player attached, single player, and guild.
* Expanded script command instance_create to take in an owner ID and an optional mode.
* Added a new script command instance_check_guild (works the same as instance_check_party).
* Refactored all instance_id to unsigned short.
2016-05-14 11:57:54 -04:00
aleos89
4c617bcd59 Corrected Graffiti removing all units (fixes #1263)
* Graffiti will no longer remove all units of the Rogue class.
* Graffiti will now fail to cast again if a Graffiti already exists on the map.
* Graffiti should only be removed on map changes, but Remover/Cleaner still removes it (custom) since the skill was never officially implemented.
2016-05-14 09:39:40 -04:00
aleos89
ca049a66f4 Resolved a compile error for CentOS (fixes #1190)
* Send a 0 instead of NULL to the va_list when freeing item groups.
2016-05-13 13:59:27 -04:00
zackdreaver
ebf0ad345b sort item based id
Signed-off-by: zackdreaver <zackdreaver@gmail.com>
2016-05-13 14:29:00 +07:00
aleos89
9cd7e595cf Updated 16th Night effect (fixes #1164)
* No longer drains 1 SP every second.
- Description states it does but tests show it does not.
2016-05-12 14:18:51 -04:00
Cydh Ramdh
b8b2593c9c Corrected weapon's MATK, not as item bonus
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-05-12 18:00:02 +07:00
zackdreaver
0b59a45005 Follow up 9c994e098676e441a17fa772319d809298973146
Signed-off-by: zackdreaver <zackdreaver@gmail.com>
2016-05-12 01:34:20 +07:00
aleos89
952b072468 Implemented item bonuses bWeaponAtkRate and bWeaponMatkRate (fixes #1161)
* Increases an equipped weapon's ATK/MATK by given rate.
* bWeaponMatkRate does not work in pre-renewal as there is no MATK for weapons in pre-renewal.
* Renamed 'bonus2 bWeaponAtkRate' to 'bonus2 bWeaponDamageRate'.
- Seems to be unused in the current item database.
- Damage fits the bonus name better as it increased the final damage, not the weapon's attack specifically.
2016-05-11 13:36:59 -04:00
zackdreaver
9c994e0986 Added new costumes and fix item name translation
Signed-off-by: zackdreaver <zackdreaver@gmail.com>
2016-05-11 19:45:30 +07:00
aleos89
af8524aa7d Follow up to 10bac96
* Adjusted the directional check for script command pushpc.
2016-05-11 08:42:11 -04:00
Aleos
cdb626c628 Merge pull request #1252 from wilkemeyer/fix/clif-emblem-validate
Refactored part of guild emblem validation
* Corrected clif_validate_emblem returning incorrect value types.
* Created readable constants.
Thanks to @wilkemeyer!
2016-05-10 08:15:56 -04:00
Lemongrass3110
3132b6060d Added bonus for Purple Cowboy Hat(5816)
Thanks to @zackdreaver
2016-05-10 13:26:24 +02:00
Lemongrass3110
1c8eb5cafd Merge pull request #1255 from Daegaladh/patch-1
The names of Classic_Hat_J and Cowboy_Hat_J were swapped.
2016-05-10 13:20:21 +02:00
Lemongrass3110
2e770337ea Removed a disturbing whitespace
Fixes #1256
2016-05-10 13:04:18 +02:00
Aleos
440c6ef5bb Corrected some packet structure issues* Resolves
Corrected some packet structure issues
* Resolves a chatting issue while using fake names.
* Resolves an incorrect packet header size for requesting player registries.
Thanks to @wilkemeyer!
2016-05-09 09:24:48 -04:00
Daegaladh
b76dea774e Fixed Classic_Hat_J and Cowboy_Hat_J names swapped 2016-05-08 23:12:05 +02:00
Daegaladh
5c64185abe Fixed Classic_Hat_J and Cowboy_Hat_J names swapped 2016-05-08 23:10:51 +02:00
Lemongrass3110
c4390e58d5 Fixed compilation with visual studio
Follow up to 0da7136.
Fixes # 1254.
2016-05-08 17:18:30 +02:00
rAthenaAPI
b556d20ff6 SQL synchronization
[ci skip]
2016-05-08 17:03:12 +02:00
Aleos
62d9a9b040 Add Requiem weapon set
Added Requiem weapons
* Implemented two item bonuses bMagicAddRace2 and bIgnoreMdefRace2Rate.
Thanks to @secretdataz!
2016-05-08 08:53:03 -04:00
Florian Wilkemeyer
d2ded889cb map-server: return-type-fix clif_validate_emblem was declared to return bool but actually returned int-value 2016-05-07 22:17:25 +02:00
aleos89
c6ba347a54 Increased MAX_RACE2_MOBS for future use 2016-05-07 13:44:49 -04:00
Aleos
0da7136ae7 Merge pull request #1241 from wilkemeyer/optimize/pathsearch-memallocations
Optimized path_search() by reducing amount of allocations per call.
Thanks to @wilkemeyer!
2016-05-07 13:00:36 -04:00
Florian Wilkemeyer
6104db8d1e map-server: clif: fixed missing wfifo allocation in global-message-parser 2016-05-07 16:46:19 +02:00
Florian Wilkemeyer
b414faef45 map-server: intif fixed too small wfifo allocation 2016-05-07 16:46:13 +02:00
Jittapan Pluemsumran
7ec06ca1a8
Follow up to dc74119 2016-05-07 10:29:24 +07:00
aleos89
0c09928dd3 Fixed the Monster Transform status icon (fixes #1215)
* Resolved the timer getting removed from the icon on map changes.
* The status is not infinite so it should not be sent to the client as infinite.
2016-05-06 08:59:23 -04:00
Lemongrass3110
2b61f45a94 Fixed readparam behaviour for variables
Readparam now works correctly with variables.
This is a follow up to e112fc1 which addressed #647.

Fixes #1213, thanks to @Everade.
2016-05-06 01:14:12 +02:00
aleos89
55165ac0bf Fixed a map crash from the mob mode update (fixes #1235 and fixes #1238)
* Follow up to 55e4df1.
* Added an extra check to make sure block list is not null on skill use.
Thanks to @Vomaito, @keitenai, @spinzaku, @Playtester, and @Tokeiburu!
2016-05-05 12:36:33 -04:00
Lemongrass3110
09974e8ded Merge pull request #1243 from wilkemeyer/fix/skillidx-can-become-out-of-bounds
map-server: increased size of skilldb_id2idx[] array, to fix crash caused by array oob access.
2016-05-05 00:06:00 +02:00
Florian Wilkemeyer
f7bc696335 map-server: increased size of skilldb_id2idx[] array, to prevent out-of-bounds access.
Bug:
It was Initially declared as size of UINT16_MAX (0xffff) but as the skill-id itself which will be used
as offset can reach this value, it's too small.
2016-05-04 21:57:10 +02:00
aleos89
d83559cb7f Added missing Summoner constants
* Added JOB_SUMMONER and EAJ_SUMMONER constants.
* Updated eA Job System documentation.
2016-05-04 12:58:09 -04:00
Florian Wilkemeyer
ce97b9ae0f corrected some typos in descriptive comments 2016-05-04 14:46:29 +02:00
Florian Wilkemeyer
99cb385f34 map-server: optimized path_search(), by removing dynamic memory allocation for each call.
Pathfinding uses BHEAP_* (vector) operations from db.h, before this optimization each pathsearch resulted in an call to aMalloc() / aFree()  which is quite costly as it fragments memory over time & may cause software stalls when the application's heap must be resized.

Now it allocates the Heap once (& may grow it accordingly) and re-uses the allocated memory every time/call.

This makes also tons of monsters less cpu-time intensive.
2016-05-04 14:00:37 +02:00