2372 Commits

Author SHA1 Message Date
skotlex
7d317be8dd - 'Forget me Not' no longer blocks ASPD bonuses from working or prevents their re-casting, they are simply dispelled when the effect takes place.
- Fixed a possible crash when a player logs out before their create-party request is accepted.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12193 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-11 13:11:15 +00:00
FlavioJS
549684872d * Expanded the script command 'input': (bugreport:811)
- two new optional arguments 'min' and 'max'
- return value indicating if it's in the correct range
- config variables for the default value of the arguments: 'input_min_value' and 'input_max_value' in script_athena.conf

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12192 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-11 10:40:52 +00:00
ultramage
7aee90fe03 Added two missing opt2 values, for Angelus and Bleeding status.
Cleaned up pc_statusup and pc_statusup2.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12190 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-10 22:43:22 +00:00
ultramage
c12125ed84 Fixed Warp Portal code sometimes producing errors/crashes in the case where a priest enters his/her own warp (bugreport:270)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12189 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-10 22:40:50 +00:00
ultramage
c2a02f48bd Fixed wrong message in item group loading code (bugreport:936)
Fixed 'charisalpha' not working for the first char (bugreport:940)
Disabled signed/unsigned warnings for visual studio 2005

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12186 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-08 10:23:24 +00:00
skotlex
96684da892 - Fixed Freezing Trap doing no damage (changed type from misc to weapon)
- Changed suiton's element to water (apparently fixes not being able to use water-based skills on it)
- Fixed Landmine doing no damage (decreased trigger range to 0 to match its splash range)
- Fixed the disguise commands using the wrong variable when attempting to disguise as an npc.
- Fixed a compilation warning on CELL_CHKNODAMAGE (which is a totally bad-ripoff of basilica cells anyway)
- Corrected and optimized npc_remove_map's npc array cleanup (@reloadscripts no longer report 'too many npcs per map and related dangling pointer crashes are fixed)
- Removed suspicious, yet totally unused npc_data variable 'n'
- HP loss item scripts can no longer kill you.
- Corrected the item-drop-rate check to avoid duplicate entries in @whodrops after a @reloadmobdb
- Cleaned up and optimized map_addnpc (there are never any gaps in the npc array so npc_num always points to the last valid entry)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12180 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-07 00:07:47 +00:00
zephyrus
c4fb4f4361 - Some code cleanups.
- Added new Cell types (NoChat and NoDamage)
- Added JobChangeLevel and FreeSKPoints to #stats
- Added a Crash protection in clif_send with invalid fd values.
- Merged a missing update in TK Mission.
- Added script command 'getmapflag'
- Merged some new Status Change to Stable.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12175 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-04 18:23:57 +00:00
ultramage
2ef6778696 Fixes to Devotion (see topic:153345)
- removed totally fake Devotion packet from Marionette Control code (see r3934)
- fixed one devoted chars array management code bug which caused chars to be included in the array multiple times, producing various problems (also see r3934)
- the link will now re-display when coming into view range
- the link will no longer break if the devotee walks away, but instead, if he receives damage while being out of range of Devotion

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12171 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-03 23:26:00 +00:00
FlavioJS
0594a1a350 * Added an iterator to map.h/c.
Will be used instead of map_getallusers, which has problems with dangling pointers (returned array isn't updated).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12170 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-03 19:20:42 +00:00
ultramage
fb85ff7006 Fixed sql charserver crashing when mapserver is disconnected and someone does a double login (bugreport:870)
- it was a typo in r11410

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12159 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-02-01 07:22:17 +00:00
skotlex
52b3140f90 - Plagiarize can no longer copy skill levels beyond their max skill_db value.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12151 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-29 19:26:18 +00:00
skotlex
220fb381a2 - Modified pc_dead so that the src is passed on to the master when it is a pet or homunculus.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12150 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-29 13:17:15 +00:00
FlavioJS
b605b6d722 * Small update to the dgbhelpplug plugin:
- fixed only half of wide character strings being printed
- fixed the memory validity check in Dhp__PrintDataValue being optimized out in release mode

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12143 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-27 00:34:24 +00:00
toms
ac123d2304 Updated conversion tools for mob_db & item_db
Updated SQL Files (item & mobs)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12138 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-25 16:11:39 +00:00
ultramage
6c10763883 Fixed battle config loading not applying the side-effects of battle_adjust_conf() side-effect if an import: operation fails.
This is what caused the odd slowdown reported in bugreport:260.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12118 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-21 10:24:33 +00:00
skotlex
b4a3bad556 - Fixed a comparison whn doing item searches
- Fixed hom_setting&0x2 conflicting with the 'view-range' limit check.
- Stone curse now uses status_percent_damage instead of a precalculated value.
- Merged the SA_MONOCELL and SA_CLASSCHANGE code. After changing class all the status changes that cannot be triggered on bosses are dispelled. 
- SA_CLASSCHANGE now uses the bloody branch list to pick a target MVP class.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12098 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-20 14:32:10 +00:00
FlavioJS
19df0af514 * Added plugin dbghelpplug to generate more extensive crash reports in windows.
- see header of src/plugins/dbghelpplug.c to know it's capabilities
- VS8 project file supplied at vcproj-8/dbghelpplug.vcproj
- a dll compiled in release mode is supplied at plugins/dbghelpplug.dll

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12089 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-19 09:20:47 +00:00
skotlex
4550514f4d - Made battle_check_range fail whenever the distance between src/target is greater than the viewing range.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12084 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-17 09:46:31 +00:00
ultramage
9ead7d0a99 Icewalls can no longer be knocked back (see bugreport:38)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12083 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-17 07:38:11 +00:00
ultramage
f855102c48 * Manner system fixing
- better-than-aegis 'red bubble' packet updates; now it shows correctly
- added support for /rc, which is basically mute for 60 minutes
- fixed typo in r12076 making gm-mute start on the gm instead of target
- fixed @mute not ending the status properly when using negative values
- adde missing clif_manner_message(), sends info about manner updates

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12079 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-15 15:05:11 +00:00
skotlex
4988d419aa - Fixed missing mob_spawn call, which was making CR_CULTIVATION not actually spawn the plant.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12077 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-14 22:13:43 +00:00
ultramage
fc719995cb * Client packet corrections
- 0x01df is not 'gmreqnochatcount', but for requesting a player's account name via right-click menu (which currently can't be done)
- added /remove and /recall, aliases to /shift and /summon
- added /changemaptype, which alters a single cell's gat type
- gm kick will no longer exit the client (now it goes to the login screen)
- removed the quicksort invocation in /ignore code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12076 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-14 19:13:16 +00:00
ultramage
88cfb8ff5a Fixed card removal script functions' 'extra card' bug (bugreport:786)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12075 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-14 13:25:41 +00:00
ultramage
f96f0d27a9 Removed the hardcoded limit for numeric npc input boxes (bugreport:811)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12074 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-14 12:01:58 +00:00
ultramage
1859b5e45a Applied a temp patch to make some npc-executed atcommands work again (bugreport:790).
Added support for right-click-gm-menu kicking NPC objects.
Removed redundant function npc_checknear2().

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12073 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-14 11:34:59 +00:00
skotlex
fb100b2f09 - Fixed dangling pointer crashes when bleeding or Deadly poison kills a spawn-once monster.
- Fixed a possible ERS entry corruption when Deadly Poison kills a target that has kaziel active.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12069 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-13 23:06:06 +00:00
skotlex
0f7c4f24f3 - Fixed a possible ers_entry corruption if you die from bleeding while under the effects of kaizel.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12063 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-13 03:08:36 +00:00
skotlex
418f5b1059 - Updated Safety wall so it does not blocks melee magic.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12062 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-13 02:52:06 +00:00
FlavioJS
04d47e8c6d * Another possible fix to ers/status_change crashing.
- same logic as r12058 but in status_change_timer.
- look out for this error: "[Error]: status_change_timer: Unexpected NULL status change id: ### data: ###"
  getting it means that a crash was avoided and the culprit found.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12061 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-13 02:40:39 +00:00
FlavioJS
4b4a7ef2a0 * Modified npc_parsesrcfile to read the file as binary and let sv_parse handle LF/CRLF line endings.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12059 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-12 17:21:41 +00:00
FlavioJS
a85a22d75a * Possible fix to ers/status_change crashing. [FlavioJS]
- this patch is untested. Didn't find anyone willing to test it and I can't reproduce the crash so can't test the patch.
  symptom:
   status_change_entry.timer is being modified after the entry is freed.
   ers uses that memory location as a pointer when the entry is freed, it crashes when accessing the contents when it points to an invalid location.
  assumption:
   status_change_start starts an already existing status.
   as a consequence of something called inside status_change_start the status is ended.
   when the sce is finally being modified, it's modifying a freed entry.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12058 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-12 17:12:23 +00:00
skotlex
da34bd4811 - Implemented the extra damage bonus to TK_JUMPKICK when it is used while running (however what the bonus's equation is has been lost to time, so someone else correct it).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12053 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-11 13:00:27 +00:00
skotlex
114f7e13e3 - Corrected CR_CULTIVATION to cause summoned plants to expire after 5 minutes.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12052 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-11 10:36:56 +00:00
skotlex
ced9aada8c - Fixed getmonsterinfo to return "null" when returning the name of a non-existing mob instead of -1.
- Extended the status_percent_damage define to include a bolean to specify whether or not the target can be killed from it.
- Corrected CR_CULTIVATION to fail when the target cell has some BL_CHAR on it already.
- Changed the meaning of 'flag' in status_percent_change, to enable differentiation between damage that can kill the object and damage that cannot.
- Script command percentheal will no longer kill the player if the specified amount is negative (and not -100).


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12051 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-10 22:02:33 +00:00
ultramage
787512d6db Fixed Abracadabra unable to cast non-targeted skills (bugreport:186)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12044 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-10 18:14:59 +00:00
ultramage
fafb4b8476 Another round of login server cleaning
* fixed passwordencrypt on SQL not behaving correctly (since r10753)
 * corrected some column lengths in the login db (username, password,...)
 * fixed some places which used wfifo without first reallocating it
 * removed interserver packet 0x7532 (Request to end connection), as there was no code that actually sent this packet
 * moved RFIFOSKIP actions to execute as soon as possible

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12043 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-10 15:35:23 +00:00
skotlex
614c28dbf9 - Removed 'skill_steal_type' from skill.conf as said config no longer exists.
- Corrected @slaveclone/@clone behaving as @evilclone when you change the @ symbol.
- Modified SC_ARMOR_ELEMENT so it grants elemental resist as if it they were card granted bonuses.
- fixed a SA_DISPELL crash when casted on an object with no status changes.
- Adjusted the autospell code so that it does not relies on card_id == 0 for subtracting rates.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12041 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-10 13:10:13 +00:00
skotlex
5c4212300a - corrected duration of sphere mines to be 30 secs regardless of skill level
- Corrected duel_count/duel_list (you DON'T place variables in a .h file! That is what 'extern' is for)
- Script command warpportal now places a warp in its initial state (as if a real warp portal was casted)
- Updated dispell to also not remove the following effects: Hindsight, Inc Hit/Atk Rate (NPC_POWERUP), Nen, TK stances and tumble, warm and speedup1 (the other speed potion)
- Chase-walking characters can now loot.
- Hiding characters can't drop items now. 


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12036 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-09 16:08:57 +00:00
ultramage
b3696e2e03 Added missing session auth checks to charserver.
Packets from non-authed clients will now be discarded.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12034 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-08 14:30:28 +00:00
skotlex
9a2033c364 - Made the pc reg variables receive a const char* as the argument, since they duplicate the value anyway (and they were receiving const char* values from the setd function)
- Fixed Wand of Hermod not starting the SC_HERMOD status change (which blocks spells)
- Fixed a missing break in the cast cancel code.
- Fixed additional def/mdef from vit/int bonuses being lost when a status change that affects def/mdef triggers (for homunculus)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12033 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-08 13:30:43 +00:00
reddozen
25aebd3e08 git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12031 54d463be-8e91-2dee-dedb-b68131a5f0ec 2008-01-08 00:29:33 +00:00
ultramage
d3ff689c2b Added missing code to log main chat messages sent by whispering to main_chat_nick (bugreport:424)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12030 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-08 00:24:35 +00:00
skotlex
38dd2f2fde - Fixed Overthrust's timer not being able to be refreshed when recasting it (conflict on what val2 should mean)
- Changed the code in status_change_timer so that a null pointer no longer causes a crash but prints an error instead.
- Corrected clones not copying over a player's skills properly.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12027 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-06 23:48:13 +00:00
ultramage
0848355f90 Extended the id range for npcs, now [400,700) will also be treated as NPC objects (see topic:170845 and bugreport:727).
Silenced a compilation warning.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12025 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-06 22:08:23 +00:00
zephyrus
825d214242 - Fixed a visual itemdupple bug on mail system.
- Fixed Overthrusth status cannot being recalled at same skill lvl.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12023 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-06 16:43:02 +00:00
ultramage
c29f4e1823 Fixed a mistake in r11991 that let knockback work through walls
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12010 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-04 13:00:49 +00:00
ultramage
e7bb626a80 Modified the map_setcell() code to to use a boolean flag instead of needing SET_ / CLR_ pairs of defines (topic:174323).
Also removed script object 'setcell', added script function 'setcell'.
- Now you can manipulate cell information without needing @loadnpc
- You can also manipulate the terrain ('gat') type itself, using the new cell_walkable, cell_shootable and cell_water constants
  (currently the implementation uses bit flags too, so to get the type you want, you need to adjust the flags one by one)
- This breaks current scripts, so please adjust places that use setcell
  (also be sure to _only_ use predefined constants, not direct numbers)
- Details can be found in the script reference.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12009 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-04 12:41:49 +00:00
skotlex
de7ce05609 - Fixed Music Lesson's effect on Assassin Cross of Sunset.
- Fixed a possible crash in status_change_timer when debug mode is disabled.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12006 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-04 09:33:24 +00:00
ultramage
6bf267e60e Changes to reduce the number of map cell types
- Pneuma now again works via status change (see r3969)
- removed unused CELL_SAFETYWALL
- removed custom CELL_REGEN, it just increased regen rate (r1192, r1518)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12005 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-03 23:27:22 +00:00
ultramage
c2dfc595b1 Fixed npc unloading not clearing NPC touch cells (bugreport:595).
Added a comment to npc_unsetcells(), pointing out that it's most likely not scanning for cells correctly.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12004 54d463be-8e91-2dee-dedb-b68131a5f0ec
2008-01-03 22:00:59 +00:00