8070 Commits

Author SHA1 Message Date
Euphy
314ee3918b Added UTF-8 BOM detection for NPC scripts. (Hercules 694d32a)
Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-04-07 20:20:47 -04:00
Cydh Ramdh
e54a1d47df * Follow up e2d2494
- Removed hardcodes SI_ for SC_ITEMSCRIPT
- Changed some item scripts that use SC_ITEMSCRIPT to sc_start2, added val2 as SI_
- Revert some hardcodes ITEMID_
* Changed spiritball limit to MAX_SPIRITBALL (Hercules partial merge)
* Updated .sql item_db files

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-04-05 17:19:44 +07:00
aleos89
3269d0f9af Follow up to 26afd76 to fix Elemental Shield. (bugreport:8872) 2014-04-04 19:13:43 -04:00
aleos89
e2d2494e13 Bug Fixes
* Fixed Main Frame Restructure not giving DEF bonus when wearing Madogear. (bugreport:8863)
* Updated some more damage formulas for Kagerou skills.
* Fixed critical damage bonus from Monster Transformation system.
* Fixed Fire Trap and Ice Trap Burning/Freezing chance.
* Cleaned up the visual effects for Ranger traps.
* Odins Power now decreases DEF/MDEF by 40 at level 2. (bugreport:8869)
* Added skill define for Overbrand's Plus Attack.
* Fixed an issue with Overbrand's pierce damage placement. (bugreport:8856)
* Fixed Unlimit not updating DEF/MDEF on players and increased the cooldown to 5 minutes. (bugreport:8870)
* Few status icon updates.
* Fixed two compile warnings when the VIP system is enabled.
2014-04-04 15:37:29 -04:00
Cydh Ramdh
c8c40a1377 Follow up 0081e25, 8a723ee (msg_conf stuffs)
- Revert MAP_MAX_MSG to 1500
- Moved some messages to empty spaces
- Added warning message if msg_number is invalid when msg_conf files are being read
- And minor stuffs

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-04-04 22:28:11 +07:00
Akkarinage
8a723ee496 Modified map server msg limit to accommodate new @costume messages.
Added additional removal checks when taking off costumes. Fixes bugreport:8862.
p.s. special thanks to aleos for pointing me in the right direction!
2014-04-04 14:48:40 +01:00
aleos89
d876272283 Bug Fixes
* Cleaned up the card fix calculations once more. (bugreport:8848)
* Fixed Kaite pre-renewal effect. (bugreport:6415)
* Fixed a possible crash from Elemental Action.
* Cleaned up the costume atcommand messages.
* Fixed a few issues from the CppCheck report.
2014-04-03 14:38:58 -04:00
aleos89
0081e25922 Costume System cleanup.
- Cleaned up overall system to work like officials.
- Added costume atcommand to easily enable/disable costumes.
2014-04-03 11:26:38 -04:00
aleos89
2fe8140f96 Quest Log system improvement. (Hercules 6f55c00)
- Improved memory usage of the quest log system. (saves up to 75kB per online character).
- Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data.
- Added some code documentation.
- Thanks to @shennetsind and @MishimaHaruna.
2014-04-03 09:39:34 -04:00
aleos89
cc59315323 Fixed some 3rd class skill effects not displaying properly. (bugreport:8144, 8804) (Hercules 8cc9012) 2014-04-03 08:48:49 -04:00
aleos89
44ddd96365 Bug Fixes
* Updated Poem of Braggi cast time reduction bonus from Musical Lessons to only be 1% per level.
* Updated Don't Forget Me ASPD decrease and movement speed formulas.
* Updated many renewal and some pre-renewal status changes that effect ASPD to official.
* Cleaned up some various status change formulas.
2014-04-02 15:23:35 -04:00
aleos89
e86471bb0b Fixed npcshopattach not working on all Shop types. (bugreport:8850) 2014-04-02 13:19:39 -04:00
aleos89
c4a41c4049 Fixed a compile error for pre-renewal. (bugreport:8855) 2014-04-02 08:27:42 -04:00
aleos89
744eb0e532 Follow up to 0fed97c to include a warning when skill_unit_layout/skill_nounit_layout has overflowed to prevent future issues. 2014-04-01 15:08:25 -04:00
aleos89
9b098e109e Merge pull request #62 from cydh/master
Added a few new script commands thanks to @cydh!
- *countitem:
-- Added cartcountitem
-- Added storagecountitem
-- Added cartcountitem2
-- Added storagecountitem2
-- Added a new param 'AccountID'
- *delitem:
-- Added cartdelitem
-- Added storagedelitem
-- Added cartdelitem2
-- Added storagedelitem2
2014-04-01 14:49:45 -04:00
aleos89
0fed97c1d9 Bug Fixes
* Follow up to 6e795af expiration timer passing wrong time value. Thanks to @MrKeiKun.
* Follow up to 26afd76 to force players to use skill_sit before pc_setsit to invoke pc_stop_walking and pc_stop_attack first.
* Follow up to 26afd76 to revert change on Extremity Fist status icon.
* Fixed some Gentle Touch - Revitalize typos.
* Fixed some Gentle Touch - Energy Gain typos. (bugreport:8846)
* Corrected Explosion Spirits effect for renewal. (bugreport:8842)
* Rebound status from Full Throttle will now disable HP and SP regeneration.
* Fixed Mainframe Restructure not giving DEF bonus. (bugreport:8840)
* Added Hiding and Sight to the list of skills not usable while riding Mado using _INF3 and removed hardcoded checks.
* Increased the max skill unit layout to accommodate the addition of Fire Rain. (bugreport:8775)
* Fixed Unlimit to not work with Warg skills and sets DEF/MDEF to 1 per Ziu's tests.
* Fixed damage and life (hits) for Wall of Thorn.
* Added an extra check for Crescent Elbow to check for short range and to handle knockback with the autospell skill.
2014-04-01 14:26:37 -04:00
aleos89
5e02af25af Fixed quest information icons not displaying properly on NPC. (bugreport:8156, bugreport:8157) (Hercules 1ab0017) 2014-03-31 08:17:45 -04:00
aleos89
26afd769ce Bug Fixes
* Fixed Chorus songs causing the map server to crash. (bugreport:8817, bugreport:8819)
* Updated renewal Arrow Shower area to be 5x5 for levels 6-10.
* Neutral Barrier should effect all targets and only block Earth Quake splash damage.
* Only party and guild members should be affected by Stealth Field.
* Fixed Cloud Kill layout to be 7x7.
* Feint Bomb should explode after half a second.
* Fixed Fire Rain unit ID causing Fire Wall, Ice Wall, and other unit skills to display improperly. (bugreport:8775)
* Updated the effects of Banana Bomb, Concentrated White Potion Z, and Vitata 500.
* Fixed Gentle Touch - Revitalize HP regeneration calculation.
* Fixed Gentle Touch - Change making MDEF go below 0 and doing too much damage. (bugreport:8690)
* Fixed Gentle Touch - Energy Gain not adding spirit balls when doing damage.
* Fixed Gentle Touch - Cure to heal players who are wearing a shield with the Golden Thief Bug card. (bugreport:8815)
* Fixed Tear Gas /sob emoticon not stopping when the skill ended.
* Fixed Kagerou/Oboro charms not applying to specific skills. (bugreport:8823)
* Updated some other Kagerou/Oboro skills. Thanks to idAthena.
* Players will stop attacking when forced to sit through skill_sit. (bugreport:8796)
* Fixed Extremity Fist not removing natural SP regen flag and adjusted the icon to show for the 5 minute duration. (bugreport:8811)
* Implemented the official effect for Chaos Panic. (bugreport:8520)
* Fixed a small typo for the knockback of Crescent Elbow.
* Fixed Cross Slash not checking for players wearing Shields + Dagger/Sword. (bugreport:8797)
* Synced up the 3rd class pre-renewal skill database files with the renewal skill database files.
2014-03-28 15:12:23 -04:00
Cydh Ramdh
f756d7e249 Merge branch 'rathena/master' 2014-03-27 13:48:41 +07:00
aleos89
6e795af5c1 Added the remaining part to the official expiration timer. (Hercules 7120b55) 2014-03-26 09:27:03 -04:00
Cydh Ramdh
01c30bf505 Script Command Updates:
- *countitem:
-- Added cartcountitem
-- Added storagecountitem
-- Added cartcountitem2
-- Added storagecountitem2
-- Added a new param 'AccountID'
- *delitem:
-- Added cartdelitem
-- Added storagedelitem
-- Added cartdelitem2
-- Added storagedelitem2

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-22 14:44:20 +07:00
aleos89
cfa4d3c6b1 Bug Fixes
* Cleaned up some remaining Concentration leftovers from 1f26499. (bugreport:8756)
* Added a missing break for the damage calculation of Cross Strike.
* Adjusted the area of effect for Feint Bomb.
* Miscellaneous cleanups.
2014-03-21 14:22:29 -04:00
aleos89
1f26499994 Bug Fixes
* Fixed Group A Songs not showing their respective skill animation. (bugreport:7379)
* Fixed Cart Revolution pushing targets East rather than West. (bugreport:8806)
* Chemical Protection should not remove Strip status. (bugreport:8807)
* Concentration now casts Endure. (bugreport:4262, bugreport:8756)
* Fixed the Riding Mount icon not showing up after relogging for Dragons and Mado Gear. (bugreport:8805)
* Crescent Elbow will now knock the target back 8 cells.
* Other miscellaneous cleanups.
2014-03-20 12:59:18 -04:00
lighta
51f26d43d2 Follow up e0c8e01
Move skill_get_cooldown_ into pc_get_skillcooldown
and add a short src_doc description to promote his usage
(and avoid duplicate code)
Fix few cppcheck issues (variable scope optimisation mostly)
2014-03-18 17:36:23 -04:00
aleos89
26aad11908 Fixed the Item Shop and Point Shop not displaying their shop message when "callshop" is used. (bugreport:8710) 2014-03-18 15:30:22 -04:00
aleos89
e0c8e01e08 Fixed Release not storing the cooldown of the skill that is released. (bugreport:8800) 2014-03-18 15:13:19 -04:00
aleos89
c7c5f7e89e Bug Fixes
* Fixed Venom Splasher consuming a second Red Gemstone. (bugreport:8506)
* Corrected Final Strike's damage formula. (bugreport:8648)
* Shield Boomerang should always be a neutral attack.
* Shield Chain should always take the element of the weapon.
* Updated Occult Impact damage and force element to neutral on final attack. (bugreport:7462)
* Added a list of skills that get forced to neutral for the final attack in renewal mode. Merge from idAthena.
2014-03-17 14:37:28 -04:00
aleos89
8198715203 Follow up to 165609d. Fixed a remaining typo by removing constant field. (bugreport: 8789) 2014-03-17 12:09:32 -04:00
aleos89
79fbd3bc69 Bug Fixes
* Updated Pointpoint Attack to also have a chance to break Helm equips. (bugreport:8735)
* Fixed Feint Bomb stacking with Hiding and Stealth. (bugreport:8346)
* Updated the trigger area of Feint Bomb to be 3x3 and AoE is 5x5. (bugreport:8346)
* Fixed Chemical Protection not removing Strip effects. (bugreport:8746)
* Fixed Warg Strike's Warg requirement, reverted to misc attack, and ignores target's Flee. (bugreport:8732)
* Warg Bite and Warg Dash now ignore target's Flee.
* Corrected Epiclesis HP/SP recovery timer. (bugreport:8751)
* Fixed Crimson Moon not working with Epiclesis.
* Updated Spirit Sphere requirement for Gentle Touch - Cure to 1.
* Fixed Shield Boomerang not taking weapon element into account. (bugreport:8757)
* Homunculus skill re-use delay is no longer reset when vaporized.
* Lauda Agnus and Lauda Ramus can now be casted when the caster is not in a party.
* Cart Revolution will now always knock targets to the West (added config to disable). (bugreport:8753)
* Updated all non-3rd class skills cast times. (Hercules e2fdc3b)
* Corrected Prestige magic evasion formula. (bugreport:8737)
* Poem of Netherworld will now only effect enemies except in WoE. (bugreport:8771)
* Poem of Netherworld can be removed by Status Recovery and Lion Howling.
* Updated Deep Sleep, Crystalize, and Vacuum Extreme to use base status. (bugreport:8749)
* Self Destruction now ignores target's DEF cards.
* Fixed Raising Dragon not recovering SP. (bugreport:8769)
* Fixed Charm bonuses for Kagerou/Oboro. (bugreport:8319)
* Moved calculation for Chorus bonus.
* Fixed Over Brand damaging targets on the entire map. (bugreport:8736)
* Fixed Cast Ninja Spell not randomly picking a status ailment to cast on target. (bugreport:8774)
2014-03-17 11:37:36 -04:00
Euphy
0602234e4d Follow-up 165609d: fixed damage issue. (bugreport:8768, credits: Jey)
http://rathena.org/board/tracker/issue-8768-about-the-damage-i-think-the-race-or-resist/

Player-looking NPCs will now display properly. (Hercules 1007d60)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-14 16:19:08 -04:00
scriptor
184ba55dfc added status ids 2014-03-14 10:08:46 +01:00
Euphy
8c133f139b Hercules merges.
- If a player has both a Cart and Magic Gear, removing them will now first remove the Magic Gear first (instead of both simultaneously).  (2f9a514)
- Added overflow check to 'itemheal'; documentation updated. (1849d35)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-13 16:20:56 -04:00
Cydh Ramdh
dd67f9de96 Bug Fixes:
- 'hp_rate' and 'sp_rate' config aren't working. http://rathena.org/board/tracker/issue-8742-max-hpsp-battleconf-not-working/
- Mercenary DB that aren't being read properly whic also happens for Homunculus DB. http://rathena.org/board/tracker/issue-8761-mercenary-db-import-folder-issue/
- Fixed Elemental DBs that aren't being imported yet. (also changed to sv_readdb)

Rebellion Skill Updates:
- Some updates according to kRO updates on http://forums.irowiki.org/showpost.php?p=1364894&postcount=579, http://forums.irowiki.org/showpost.php?p=1388802&postcount=981, and http://forums.irowiki.org/showpost.php?p=1389627&postcount=1008
- Partial merge from idAthena.
- Using 0x107 as temporary marker on mini-map for Crimson Marker target.
- Some stuffs maybe still wrong, feel free to report/fix it.
- Thank people on those links, Ziu, and idAthena.

Misc changes:
- Changed some function names for homunculus.c/h with prefix hom_* and mercenary.c/h with prefix mercenary_*
- Change unnecessary 'int' return value tos 'void'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-13 23:59:29 +07:00
aleos89
bebfb06159 Follow up to f916504. Forgot to increase packet length. (bugreport:8745) 2014-03-13 11:23:03 -04:00
aleos89
165609d487 Fixed elemental reductions stacking to eventually cause 100% immunity. Thanks to Jey. (bugreport:8695) 2014-03-13 10:47:47 -04:00
Cydh Ramdh
0766c73229 Bug fixes
* Fixed wrong bonus for Max HP (bugreport:8679)
* HP/SP respawn (restart_hp_rate and restart_sp_rate) should be work now (bugreport:8642)
* Fixed MVP drop that failed to make random order (bugreport:8665)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-08 04:27:36 +07:00
aleos89
2dece5586d Bug Fixes
* Follow up to 2cd1e8c compile error. (bugreport:8733)
* Implemented official hiding effect for Feint Bomb. (bugreport:8346)
2014-03-07 15:51:16 -05:00
aleos89
2cd1e8c393 Bug Fixes
* Reverted a change made to Raising Dragon for HP/SP Regen.
* Fixed Rage Burst not consuming Rage Counters on use. (bugreport:7975)
2014-03-07 14:19:09 -05:00
aleos89
5aa2f17fc1 Bug Fixes
* Fixed Guild Auras applying to other guilds. (bugreport:7073) (Hercules 81caf70, 7fc0697, eb53067)
* Fixed wrong packet being used for storages on 20071002 and older clients.
2014-03-07 11:53:14 -05:00
aleos89
df1b99212b Bug Fixes
* Updated /stats+ to support 2013-12 and newer clients. (bugreport:8726) (Hercules 42b5c04)
* Guild auras will no longer be removed on Land Protector. (Hercules 186fbc5)
* Fixed the animation for logout. (Hercules 3f473c2)
2014-03-06 15:14:26 -05:00
aleos89
499010d34c Bug Fixes
* Fixed Gates of Hell range check. (bugreport:8680) (Hercules d554d61)
* Updated All Odin Power to official effects. (Hercules d554d61)
* Removed the range check from Hell Gate.
* Sorcerer Insignias are now disabled on Land Protector.
* Fixed Rush Windmill adding BATK rather than WATK.
2014-03-06 13:18:37 -05:00
aleos89
d010f67ac2 Bug Fixes
* Updated Sightrasher area to be 15x15. (bugreport:8701)
* Added missing accuracy decrease and Base Level damage modifier for Fatal Menace. (bugreport:8723)
* Warg Strike issues: (bugreport:8724)
-- Fixed Warg Strike not working while using Warg Ride.
-- Warg Strike is now a neutral element.
-- Warg Strike attack type is now a weapon.
-- Warg Strike will no longer ignore target's Flee.
* Warg Bite is now a neutral element.
2014-03-06 10:23:12 -05:00
aleos89
c547d24652 Follow up to f916504.
* Fixed a compile error.
2014-03-06 07:48:04 -05:00
aleos89
931f26065c Teleport and Map Warp Portals
- Added a battle_config to allow avoidance of Teleporting on top of Map Warp Portals. (bugreport:8584)
- Officially no one has been able to Teleport on top of a Map Warp Portal.
2014-03-05 15:31:31 -05:00
aleos89
f9165044ca VIP System Additions
* GM's (or group IDs > VIP group ID) will not be able to become VIP.
* Adjusted @whodrops and @mobinfo to account for VIP rates.
2014-03-05 10:45:53 -05:00
aleos89
f6cc486ab7 Bug Fixes
* Taekwon stances will now be removed on logout to prevent them being permanently on when a Taekwon is no longer ranked. (bugreport:8614)
* Added a battle config (taekwon_mission_mobname) for Taekwon Mission to check for kills based on monster names, off by default. (bugreport:8614) -- Credits to clydelion for the base.
* Removed a case that ignores damaging a target when they are on the same cell as the caster for Frost Nova. (bugreport:8705)
* Removed a skill unit check for Overbrand. (bugreport:8711)
2014-03-04 13:53:58 -05:00
Euphy
4a84de748c Merge pull request #49 from CairoLee/master
- Add instance_enter2 script command
2014-03-03 16:41:29 -05:00
aleos89
4534bd4b1d Follow up to 96c768f.
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Fixed Circling Nature HP regeneration formula. (bugreport:8670)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8715)
* Fixed Overbrand skill attack. (bugreport:8627)
2014-03-03 09:11:25 -05:00
Matej Pristak
d98cf33cbb oops, forgot one thing 2014-03-02 23:32:53 +01:00
Matej Pristak
a5b2b4ed49 temporary fix for vending items not saving correct cart ID > prompt player to relog if we have a new item in cart 2014-03-02 23:21:33 +01:00