8070 Commits

Author SHA1 Message Date
Lemongrass3110
b1b3aae1e9 Fixed a bug where experience might go above the defined maximum
Might be related to #1010
2016-03-04 18:22:57 +01:00
aleos89
4eb3a9eeda Updated callshop script command for Item and Point Shop (fixes #1008)
* Follow up to a16fb7c.
* Resolves the callshop script command not using the new Cash Shop interface for Item and Point Shop.
2016-03-04 09:19:56 -05:00
Lemongrass3110
98fedbdf09 Fixed null termination on party chat for 2015-10 onwards
Fixed #1003
Fixed #992
2016-03-03 23:12:09 +01:00
Playtester
61a48b9b0b Jack Frost, Status Traps, Stone Fling, Leap, Cannon Spear
* Fixed status base chances of Jack Frost and Status Traps (fixes #997)
-- Jack Frost: 200% freeze chance instead of 100%
-- Land Mine: 10% stun chance instead of 35%-55%
-- Flasher: 100% blind chance instead of 40%-80%
-- Freezing Trap: 100% freeze chance of instead 38%-50%
* Sandman Sleep and Throw Stone Blind base duration is now 30s in pre-re and 20s in renewal
* Leap now has a shorter distance when used diagonally (fixes #1007)
* Cannon Spear now shows the skill animation even if it doesn't hit anything (fixes #1004)
2016-03-03 22:11:41 +01:00
aleos89
3a5f3a3f98 Fixed a possible crash with NPC currencies (fixes #1002 and fixes #1005)
* Resolved the nullpo return message.
* If the Cash Shop opened through the client button is used it will now properly return the cash value.
2016-03-03 14:47:25 -05:00
aleos89
101b07130c Corrected a typo in Body Style command (fixes #999)
* Adjusted parenthesis.
2016-03-03 13:20:30 -05:00
Jittapan Pluemsumran
e9c9fd65d4 Don't add null if the message is already null-terminated. Fixes #1000 2016-03-03 11:33:39 +07:00
aleos89
2fd0517351 Updated some Cash Shop related comments
* Small follow up to a16fb7c.
* Updated/corrected miscellaneous comments for NPC shops.
* Added enum values for Cash Shop failure client messages.
* Re-ordered some functions be with other related functions.
2016-03-02 09:34:19 -05:00
aleos89
a16fb7c176 Updated Item and Point Shop (fixes #843)
* Item and Point Shop now works like the NPC Cash Shop.
* No longer has issues with player Zeny checks.
2016-02-29 20:54:23 -05:00
Playtester
f5b6e9f7c4 Merge branch 'master' of https://github.com/rathena/rathena 2016-02-29 22:18:38 +01:00
Playtester
1bf8537140 Berserk HP recovery (fixes #993)
* Fixed a problem that HP/SP didn't recover properly when casting Berserk, MERC_HPUP or MERC_SPUP while attacking
2016-02-29 22:17:49 +01:00
Cydh Ramdh
4ff4fe42ee Follwo up 20588abcd83fab53f9e52deafc08bfcddfe1658a
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-29 22:07:36 +07:00
Cydh Ramdh
20588abcd8 Merge pull request #987 from rathena/feature/exp_max_level
EXP on Max Level
* Fixed #942
* 'Last' EXP for max base level is 99,999,999 and 999,999,999 for Job EXP on max job level.
* Player still obtains EXP on max level (of course until both base & job reach 100%).
* This behavior is used for Base EXP check for:
  * Super Novice's Explosion Spirit.
  * Royal Guard's Inspiration.
  * High Priest's Redemptio.
* Added config `death_penalty_maxlv`, default is set to 0. Player on max level, never loss EXP by death penalty.
* On EXP lost by death penalty. EXP will be shown as negative value.
* Fixed check for EXP value on packet `0x07f6`. EXP is limited to INT_MIN until INT_MAX by client (so don't expect client to displays value more than this!)
* Added EXP gained/lost message by `@showexp` on death penalty too.	
* Fixed PR_REDEMPTIO and LG_INSPIRATION requirement  …
  * Only charge the Base EXP.
  * Lost EXP will be displayed
2016-02-29 21:05:45 +07:00
Cydh Ramdh
dc679b8c06 Follow up d9a35c8c6a7c08d5397647cb0ae470bd5692898d
* A little check to avoid unnecessary process.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-29 19:50:24 +07:00
aleos89
811723f3aa Corrected random Start Point issues (fixes #955)
* Follow up to 994b406.
* Fixes new characters initial spawn locations getting set to maps that aren't defined in the config.
* Fixes issues with reading maps from import not resetting the array of maps read from the char_config.
* Cleaned up the Start Item parser to follow the Start Point parser.
Thanks to @LiamKarlMitchell!
2016-02-28 12:12:21 -05:00
Playtester
b3b3e9cc71 Official status change base durations for Silence and Stone (fixes #990)
* The renewal default duration for Silence is now 20s (30s in pre-re)
* Items, NPC_SILENCEATTACK and NPC_WIDESILENCE and monster Lex Divina use the default silence duration
* Incubation time for Stone is now subtracted from the Stone duration
* Incubation time is now 100ms for all Stone skills except Stone Curse (5 seconds)
* The Stone timer is now more exact and now deal 1% HP damage exactly every 5 seconds, even if it's on the last tick
* Fixed Sienna Execrate missing its skill animation
2016-02-28 17:37:41 +01:00
Cydh Ramdh
ccf52095a3 Follow up 26dcf345fe753dc43568bb118b6a22e2c93bc7bc
* Added necessary mapflags.
* Corrected documentation.
* Fixed some typos.
* Thanks to @Atemo

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-28 18:17:49 +07:00
Playtester
ec59446043 Official status change base durations for Freeze and Blind (fixes #988)
* Snowflake Draft now has a skill-specific duration of 5s*level
* All freeze durations (default and skill-specific) are increased by 2.5s in renewal
* The renewal default duration is now 27.5s (+2.5s)
* Items, Storm Gust, Frost Joke, NPC_ICEBREATH and NPC_WIDEFREEZE use the default freeze duration
* All items and skills that cause blind now have a base duration of 30s in pre-re and 20s in renewal
* Fixed NPC_DARKCROSS and NPC_GRANDDARKNESS not giving the blind status change
2016-02-28 01:03:14 +01:00
Lemongrass3110
fa561fbfe2 Added NPC IDs 10175-10203
Merged from HerculesWS/Hercules@f95290c
Thanks to @Jedzkie
2016-02-27 15:20:51 +01:00
aleos89
1b9a0b5af5 Updated Kyomu effect and Magic Reflection effect
* All skills have a chance of failing at 25%, not just Shield Reflect and Reflect Damage.
* Kaite, Magic Mirror, and Shield Spell - Defense are not nullified by Kyomu.
* Item-based and Magic Mirror reflection damage Boss monsters, Kaite does not.
2016-02-26 18:33:07 -05:00
Playtester
6f74f67da0 Fixed range exploit (fixes #984)
* Players will no longer get +2 range server-sided when using a target spell
* This will prevent players from modifying the client to get extra range
2016-02-25 22:40:44 +01:00
Playtester
7cfdd9ddef Pre-renewal Impressive Riff (fixes #111)
* Fixed the pre-renewal ASPD bonus being almost double as high as officially
* Follow-up to 13d1c2d
2016-02-25 19:06:58 +01:00
aleos89
11699dff87 Updated Body Style command
* Now allows for Royal Guard class.
2016-02-25 09:05:49 -05:00
Playtester
7273b4d6ba Fixed Taekwon Ranker HP/SP bonus (fixes #982)
* The HP/SP bonus will now be applied to the base HP/SP similar to the 25% HP/SP bonus for Trans classes
* HP/SP rate increase items it will now give the full HP/SP percent bonus rather than just a third
* Fixed HP/SP increase items will no longer give triple the amount they should
2016-02-24 21:36:49 +01:00
aleos89
473e7f8fa5 Fixed compile warnings
* Follow up to 03fab34.
2016-02-24 13:48:33 -05:00
aleos89
03fab34fa3 Updated wall checks for some 3rd class skills
* Wind Cutter, Cold Slower, Arms Cannon, Dragon Breath, Dragon Breath - Water, and Arrow Storm will no longer damage targets around walls.
2016-02-24 13:31:36 -05:00
Cydh Ramdh
9944c1dd46 Fixed PR_REDEMPTIO and LG_INSPIRATION requirement
* Only charge the Base EXP.
* Lost EXP will be displayed.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-24 12:26:04 +07:00
Atemo
321b1d22e8 Removed the displayed name in from of the message displayed by npctalk and unittalk scripts commands (so we can append whatever we want to).
Signed-off-by: Atemo <capucrath@gmail.com>
2016-02-23 22:12:18 +01:00
Playtester
c144febc30 Elemental Resist Potions vs Dispell (fixes #977)
* The status effect from Elemental Resist Potions can no longer be removed by "Dispell"
2016-02-23 18:07:27 +01:00
aleos89
d512f1588c Refactored Monster Mode
* Refactored all monster mode checks to use the enum e_mode.
* Created elemental_skillmode enum to separate usage from monster mode enum.
* Renamed EL_SKILLMODE_PASIVE -> EL_SKILLMODE_PASSIVE.
* elemental_change_mode() will now return the proper value from elemental_change_mode_ack().
2016-02-23 11:21:45 -05:00
aleos89
5c3d4e3e90 Updated Cursed Circle effect
* Should not stack/refresh itself.
2016-02-23 10:02:18 -05:00
Cydh Ramdh
d9a35c8c6a Follow up 51c422cf7cc9e6046886ec89cb9cec07c9cb0d3e.
* Added some skills and effects that can reveal hidden traps.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-22 23:33:27 +07:00
Cydh Ramdh
51c422cf7c Corrected trap invisibilty behavior.
* Changed `traps_setting` config values.
  * 0 = Always visible (default)
  * 1 = Enable invisibility in versus maps (GVG/PVP/BG)
  * 2 = Enable invisibility in all maps
* Added skill unit flag `UF_HIDDEN_TRAP 0x20000` for trap invisibilty.

NOTES:
* Invisible traps are always visible for the trapper and trapper's partymates.
* If the trap is invisible, it always be hid immediately (except the people above).
* Revealed hidden traps, are always visible by everyone.
* Currently, only `HT_DETECTING` that can reveal the hidden traps (hardcoded). TODO: Sight, Ruwach, and Improve Concentration also able to reveal hidden traps.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-22 22:34:08 +07:00
aleos89
2ad4972be8 Corrected Moon Slasher effect
* Now able to stop Boss monsters.
* Has a random duration of 1~3 seconds.
Thanks to @Playtester!
2016-02-22 09:14:54 -05:00
Cydh Ramdh
f2f135708b Follow up 70a67d6c5790f9fa61edcf7f2eda339b5e8df9e0
* On EXP lost by death penalty. EXP will be shown as negative value.
* Fixed check for EXP value on packet `0x07f6`. EXP is limited to INT_MIN until INT_MAX by client (so don't expect client to displays value more than this!)
* Added EXP gained/lost message by `@showexp` on death penalty too.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-22 12:33:39 +07:00
Playtester
3449b67abc Follow-up to 8d20393 and a63b031
* Thunder Storm, Exploding Dragon, Lightning Jolt and Snowflake Draft can now damage more than just once every 500ms
* Fixed a problem with negative aftercast delay
2016-02-21 19:34:34 +01:00
Playtester
a63b031958 aMotion delay is now set at cast begin (fixes #944)
* When casting a spell with cast time shorter than aMotion, the delay will now be set to aMotion or min_skill_delay_limit
* aMotion and min_skill_delay_limit are no longer applied at cast end nor by auto spells
* Aftercast delay can only increase the delay and never decrease it
* When there is no aftercast delay, the client will no longer show a non-existent 10 second delay
* Removed "double cast" code of Jupitel and Waterball, it's no longer needed as it fits into the official delay system
* Added a constant SECURITY_CASTTIME, which is added at cast begin and subtracted at cast end to prevent hackers to send in skill packets before the timer triggers cast end
* Set skill_amotion_leniency to 0 by default as it applies delay at cast end and would consequently block the official system from working; you can set it back to 90 or even 140 for increased security
2016-02-21 17:06:39 +01:00
aleos89
f264885411 Follow up to 7c5bda2
* Corrected the Flash Combo bonus ATK not being applied to the caster and not displaying in the status window.
* Corrected Sky Net Blow not casting at the end of Flash Combo if the target is dead.
2016-02-21 09:53:05 -05:00
Cydh Ramdh
70a67d6c57 Official EXP on Max Level
* Fixed #942
* 'Last' EXP for max base level is 99,999,999 and 999,999,999 for Job EXP on max job level.
* Player still obtains EXP on max level (of course until both base & job reach 100%).
* This behavior is used for Base EXP check for:
  * Super Novice's Explosion Spirit.
  * Royal Guard's Inspiration.
  * High Priest's Redemptio.
* Added config `death_penalty_maxlv`, default is set to 0. Player on max level, never loss EXP by death penalty.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-21 18:43:24 +07:00
Playtester
4c1c6e6d2f Merge branch 'master' of https://github.com/rathena/rathena 2016-02-20 21:42:01 +01:00
Playtester
8d20393b10 Ninja Skills vs Land Protector (fixes #971)
* Exploding Dragon, Lightning Jolt and Snowflake Draft are now unit skills
-- They no longer can deal damage on Land Protector
-- They will deal damage instantly, regardless of your ASPD
* Exploding Dragon now deals 150%+150%*level damage divided by number of hits, it can no longer damage plants
* Snowflake Draft's freeze base duration is now 2500ms+5000ms*level
* Renewal: Lightning Jolt's AoE is now 3x3 on level 1-2, 5x5 on level 3-4 and 7x7 on level 5
* Pre-Renewal: Cast time of Wind Blade level 8-10 is now 500ms shorter
* Watery Evasion now makes non-Ninja enemies stop when they walk on it and are not knock-back immune
2016-02-20 21:41:01 +01:00
aleos89
10b57568ee Corrected Sniper Trap behavior
* Cluster Bomb and Ice Bound Trap now have a 1 second delay after activation.
* Firing Trap is now activated immediately.
Thanks to @Tokeiburu!
2016-02-20 08:16:31 -05:00
Cydh Ramdh
26dcf345fe Added WOE:TE Restrictions
* Added mapflag `gvg_te`, `gvg_te_castle`, this is will be activated during WOE:TE sessions. These changes are needed because of:
  * If `gvgon` is used, TE castles become `gvg`, it makes the restriction failure. Items that are supposed to only can be used/equipped in TE Castles, also affected in 'normal' GVG/WOE maps.
  * These flags used form `item_noequip`, `skill_nocast`, and `status_disabled` flag 16. (If just assume TE Castles are Restricted Zone 8, the failure will occurs as point 1 above).
* Added Restricted Zone 8 for TE Guild Dungeons, to prevent marriage skills can be casted there.
* Added command `gvgon3` to set GVG for WOE:TE Castles.
* Added command `canParticipateSiegeTE` is 'hardcoded' function to check player's job that can participate in WOE:TE.
  * Current usages in `GD_EMERGENCYCALL` and replace the in-script function.
* Changed default config `allow_consume_restricted_item` to 'no'. All restricted usable/consumable/healing items are always failed to be used.
* Changed the GVG items/skills restriction check. "Item cannot be equipped in GVG maps" are supposed to ignore the agit flag statuses, as long as the map is GVG flagged, items/skills are always restricted and otherwise.
* Moved previous entries of `skill_nocast` flag 16 as hardcode (for now).

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-20 09:33:07 +07:00
Playtester
cac5b3cb1d Monster level 10 skills (Part 3), Fire Pillar, Storm Gust (fixes #973)
* Monster level 10 Frost Diver now deals 500% damage and has a 100% freeze base chance
* Added the remaining explanations and corresponding rAthena level to mob_skill_db_powerskill.txt, now all powered-up skills are listed
* Damage of Fire Pillar is now multiplied by number of hits when used by monsters
* Storm Gust's freeze duration is now 30 seconds in renewal
2016-02-19 23:25:05 +01:00
Aleos
9b87f47b57 Merge pull request #952 from CairoLee/master
CashShop Database cleanup
* Fixes #970.
* Now uses sv_readdb.
Thanks to @CairoLee!
2016-02-19 10:12:09 -05:00
aleos89
e51b7f1d86 Follow up to 8828312
* Compile error. Sorry!
2016-02-19 10:06:04 -05:00
aleos89
88283126e8 Updated Autospell effect
* Skill delay is now applied when autocasting spells during attacks.
2016-02-19 09:42:59 -05:00
Playtester
2c3cb602dc Blaze Shield slowdown, Sanctuary knock-back (fixes #963)
* Blaze Shield now properly slows down enemies while still making sure they take all the hits while moving over a fire cell
* Fixed some skills still having damage delay, even though their source is a unit (BL_SKILL)
* Sanctuary knock-back is now 2 cells instead of 1 and pushes "away from cell center of each cell", similar to Storm Gust
2016-02-18 18:42:13 +01:00
aleos89
d53ed80226 Updated Prestige effect
* Prestige's status is now refreshed when casted again.
* Prestige is now removed by Banding.
2016-02-18 09:41:58 -05:00
aleos89
9f0ae12824 Fixes #863
* Striking now takes the target's weapon level into account.
* Now displays the proper skill fail message when used on wrong targets.
2016-02-17 10:49:18 -05:00