8070 Commits

Author SHA1 Message Date
aleos89
6dc437fd08 Implemented the official effect of Vellum Vanish (fixes #900 and fixes #1021)
* The Vellum Vanish bonus only refers to bHPVanishRaceRate and bSPVanishRaceRate.
* Requires client 2013-03-20 and newer to display blue damage.
* Properly displays blue damage being done for SP Vellum Vanish.
* Vellum Vanish items no longer deal physical damage except on skill usage.
* Skill usage with Vellum Vanish does not cause vanish.
* HP and SP Vellum Vanish items do not stack (SP will override HP).
2016-03-23 14:25:58 -04:00
Matej Pristak
df1108923a Fixing venders being stuck when map->char connection gets reset. 2016-03-22 20:55:34 +01:00
aleos89
242b3c1ab4 Corrected item requires for Repair (fixes #1076)
* No longer requires Magic Gear Fuel.
* Repair Kit will now be properly checked.
2016-03-22 12:35:25 -04:00
Playtester
0bd337d9ad Monster logging/EXP, Knuckle Arrow damage
* Removed the self-logging aspect of monsters for non-damage skills (follow-up to a6f73a6)
-- Officially, these skills don't log and don't increase exp
* Fixed a wrong reference that caused Knuckle Arrow damage to depend on own weight rather than enemy weight (see #1071)
2016-03-21 22:40:20 +01:00
Lemongrass3110
33f397c025 Fixed the WFIFO issue in char select
Fixed #1082
"Reverted" aea025e
2016-03-21 16:27:12 +01:00
aleos89
41ed114493 Follow up to Doram release (fixes #1080)
* Resolves an issue with skill normalizations.
* Resolves an issue with becoming a High Novice automatically giving players the Basic Skill fully leveled.
* Updated the Job EXP table for Doram to match official. Still missing Base EXP table.
2016-03-21 10:56:37 -04:00
Playtester
989a2525ec Skills vs Icewalls/Traps, Talkie Box, Feint Bomb
* Implemented official behavior when attacking icewalls and traps with skills (fixes #1056)
-- Skills hitting icewalls and traps: Arrow Shower, Cold Slower, Tornado Kick, Sightless Mind, Meteor Assault, Spread Attack, Throw Huuma, Sightrasher, Sight Blaster, Earth Shaker, Rampage Blaster, Feint Bomb, Magnum Break, Fire Trap, Ice Trap, Cart Revolution, Napalm Vulcan, Triple Attack, Occult Impaction, Throw Spirit Sphere, Asura Strike, Spear Stab, Spiral Pierce, Holy Cross
-- Can target icewalls and traps but have strange behavior: Bowling Bash, Focused Arrow Strike, First Wind
-- Can hit icewalls and traps, but not target traps: Grimtooth, Raging Thrust, Blitz Beat, Napalm Beat, Fireball, Vulcan Arm, Tiger Cannon
-- Can hit icewalls and traps ONLY in PVP: Dragon Breath, Suicidal Destruction, Axe Tornado, Sky Blow
-- Can hit icewalls only: All other single target skills, Counter Slash
-- Can target icewalls but have strange behavior: Brandish Spear, Wind Cutter, Cannon Spear, Flame Launcher
-- Can not hit icewalls and traps: All unit skills, Frost Nova, Comet, Arms Cannon, Fatal Menace, Lion Howling
-- Can destroy traps but not hit icewalls: Claymore Trap
* When monsters use skills, they hit icewalls and traps and the damage displays, but they will no longer deal actual damage to the icewall or trap
-- Added an option to skill.conf with which you can define which types can damage icewalls and traps, by default it's 1 (player only), if you want to revert to previous behavior, set it to 31 (all)
* Fixed an issue where traps could not hit icewalls and other traps in PVP
* Taekwon combos can now trigger on traps
* Fixed an issue that caused damage to be displayed twice when attacking a trap with certain skills
* Fixed Feint Bomb causing knock-back to the target (see #1070)
* Fixed Talkie Box being triggered by monsters (fixes #1074)
2016-03-20 17:44:47 +01:00
Cydh Ramdh
09b2ea06ee * Refactor pc_setparam for SP_BASEEXP and SP_JOBEXP.
* Added script command `getexp2` for safety usage of `set BaseExp,n;` and `set JobExp,n` usages.
* Cleanup exp lost functionto `pc_lostexp`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-20 12:31:44 +07:00
aleos89
daa9e018f4 Release of Doram Race!
* Requires client 2015-10-01 and newer.
* All skills are usable from from the base list to all 3 branch types.
-- Some skills still need their official activation chance and durations.
* Adjusted the char-server start point and start item split functions to be more dynamic.
Thanks to Rytech and @NovaRagnarok for their information!
2016-03-19 14:09:30 -04:00
Playtester
1ca9fb58f2 Decrease Agi, Adoramus (fixes #1067)
* The chance of Decrease Agi and Adoramus is now reduced by a fixed 1% per MDEF
* Decrease Agi can now overwrite itself with a lower level
* The base chance to cause blind when Adoramus activates is now 1000%
* Adoramus now has a blind duration of 7s+1s*level and an Adoramus duration of 10s+5s*level for both players and monsters
* Adoramus and Decrease Agi cancel each other out
* Adoramus no longer reduces speed (only AGI reduction and blind)
* Adoramus no longer cancels ASPD/Speed increasing buffs
* Adoramus can no longer be blocked/canceled by ASPD/Speed increasing buffs
* When Adoramus ends, it will no longer automatically end blind at the same time
2016-03-18 23:06:29 +01:00
Playtester
207c67d72c Cleanup (follow-up to 718e478)
* Visual Studio likes to add spaces, sometimes I don't agree
2016-03-18 20:17:01 +01:00
aleos89
a021829cda Fixed Epiclesis interval checks (fixes #1066)
* Epiclesis will now properly check for hidden players every 5 seconds.
* Adjusted the skill unit interval to check every second rather than every 3 seconds.
2016-03-18 13:38:12 -04:00
Playtester
718e4785ae Follow-up to 78419ba (monster random walk)
* Fixed a problem with monsters always ending up in the south-western corner eventually
* Fixed a problem that monsters had a high chance to stick to walls
* Fixed a problem that monsters didn't actually check all cells before giving up
* Code even more optimized as a free cell will now be found faster than before on average
2016-03-17 23:12:52 +01:00
Playtester
aa6a1110bd Arrow Shower and Arms Cannon (follow-up to 7906f0a)
* Fixed Arrow Shower not hitting Traps and Icewall in pre-renewal
* Arms Cannon can no longer hit Traps and Icewall (see #1056)
2016-03-17 21:24:37 +01:00
aleos89
0664fac298 Fixed Garment/Robe disappearing on player movement (fixes #1036)
* Garment/Robe will no longer be removed from display of other players in sight when the wearer player walks.
2016-03-17 09:38:50 -04:00
Cydh Ramdh
f31475d5e3 Merge pull request #986 from rathena/feature/pk_traps_setting
Trap Invisibility, Fixes #892
* Changed `traps_setting` config values.
  * 0 = Always visible (default)
  * 1 = Enable invisibility in versus maps (GVG/PVP/BG)
  * 2 = Enable invisibility in all maps
* Added skill unit flag `UF_HIDDEN_TRAP = 0x20000` for trap invisibility. By default, there are (renewal) Hunter traps with this flag:
  * HT_SKIDTRAP
  * HT_LANDMINE
  * HT_ANKLESNARE
  * HT_SHOCKWAVE
  * HT_SANDMAN
  * HT_FLASHER
  * HT_FREEZINGTRAP
  * HT_TALKIEBOX
* Added some skills and effects that can reveal hidden traps. By default, Detect, Sight, Ruwach, and Improve Concentration can reveal hidden traps.
2016-03-17 05:45:27 +01:00
Lemongrass3110
aea025eca2 Fixed an error popup at the char select
for clients from 2015-10-01 and onwards
2016-03-16 23:53:23 +01:00
aleos89
2a4fc75baa Fixed script command unitkill crashing the server (fixes #1027)
* Resolves an issue with Mercenary causing the server to crash when killed through the script command unitkill.
* Blame dd67f9d.
2016-03-16 10:13:03 -04:00
Playtester
c6ed8a4f92 Fixed critical duel exploit (fixes #1055)
* Entering or leaving duel will now remove all the skill units you've placed
* Entering or leaving duel will now behave like warping / moving on a different tile
2016-03-15 21:17:09 +01:00
Napster (icxbb-xx)
ae10da3a61 Follow up 85749e84b9
thank you @cydh
2016-03-15 21:31:29 +07:00
Napster (icxbb-xx)
e155db9272 Merge branch 'master' of https://github.com/rathena/rathena 2016-03-15 09:52:20 +07:00
Napster (icxbb-xx)
85749e84b9 Fixed #850 MVP exp message issue clients 2013-12-23cRagexe and newer.
* gravity remove packet MVP exp message, if you want re-enables the message
  check you battle config mvp_exp_reward_message
2016-03-15 09:51:55 +07:00
aleos89
074bdded09 Cleaned up rental item expiration
* Boarding Halter will now properly be removed on expiration when a player is logged out. (fixes #1035)
* Removed hard coded checks for other official rental items.
* Rental items now call the OnUnequip Script of the item which can be used to remove player states.
* Updated various items in the database to match the new format.
2016-03-14 18:50:29 -04:00
Playtester
b5de854b90 Snap, Ganbantein, Gravitational Field, Flying Kick (fixes #1052)
* Snap now has a server-sided range of 14
* Snap, Ganbantein and Gravitational Field will no longer cause you to move if you target a cell out of range
* Snap and Flying Kick will now check for obstacles on a linear path rather than on the normal walkpath
* Range specified in skill_db is now equal to the client-sided range
* Some range code cleanup
2016-03-13 16:42:46 +01:00
Playtester
fbb8edba39 Fear status change (#1048)
* Fear now causes the SC_ANKLE status change for 2 seconds rather than having a weird custom implementation
* Fear now removes blind and makes you immune to it
* Fixed SC_ANKLE not properly blocking teleportation
* Some code optimizations
2016-03-12 23:07:13 +01:00
Playtester
a6f73a6227 Status changes that cause damage reworked (fixes #1033, fixes #448)
* Created a better structure for status changes with intervals and integrated the status changes Stone, Poison, Deadly Poison, Bleeding, Magic Mushroom, Burning, Pyrexia, Leech's End and Toxin into the new structure
-- The exact remaining duration of these status changes will now be stored
-- The correct duration is reloaded when logging back in, you can't avoid a single tick be re-logging
-- It will now show the correct duration on the icon of the status change after re-logging, no longer negative values
-- The durations are now accurately transferred when using Deadly Infect
-- These status changes now use unified code, which makes it much easier to integrate more status changes into this structure with low risk of breaking something
* Removed all the status change specific logging of damage and integrated it into the normal logging behavior
-- The following skills deal "No source" damage: Stone, Poison, Deadly Poison, Bleeding, Coma, Magic Mushroom
-- The following skills deal "Self" damage: Burning, Pyrexia, Leech's End, Toxin
-- "No source" will neither be logged nor contribute to the total damage, your exp share doesn't increase from the damage, but it also won't cause the monster to give less EXP, it won't break freeze or similar status changes, it won't make you stand up, it won't make you stop moving, it won't prevent you from logging out
-- "Self" damage will now be logged and contribute to the total damage, it makes monster give the exp tap bonus, but also makes monsters give less exp the more "self damage" they've taken, it will break freeze and similar status changes, it will make you stand up properly now, it will make you flinch and stop moving, it will prevent you from logging out, but angry type monsters will not lose their aggressive bit from it and it will not cause monsters to use their rude-attack skill
-- Monsters will now use their rude-attack skill on the first rude-attack as long as the damage does not come from self
-- When a monster takes damage from a status change, its HP meter will now be updated
* Burning now has an interval of 3s and a minimum duration of 10s
* Pyrexia now causes blind for Pyrexia's duration instead of just 30s
* Ground Drift's poison base duration is now 60s in pre-re (follow-up to e7150ee)
* Fixed a bug where the minimum duration failed to apply when the received duration was below 1ms
* map_foreachindir and map_foreachinshootarea will now properly print their function names in case of an error
* Updated documentation (transferring source ID is no longer required, remaining tick should now always be in val4)

If this breaks anything, please report asap.
2016-03-12 16:50:50 +01:00
Atemo
6f34c14c0e Fix a mistake in npctalk 2016-03-12 16:03:16 +01:00
Cydh Ramdh
292098d911 Documentation update for
* `canParticipateSiegeTE` script

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-12 06:29:30 +07:00
aleos89
0f5b6db813 Implemented new adoption methods
* Implemented atcommand adopt.
* Implemented script command adopt.
* Circumvents adoption issues with 2013-08+ clients (Related to #768).
* Suggested from https://rathena.org/board/topic/104014-suggestion-add-adopt-or-etc/
2016-03-11 13:45:17 -05:00
aleos89
ed7157c80b Refactored Party Booking defines (fixes #1018)
* Adjusted the name of the defines to better suit their purpose.
Thanks to @Artuvazro!
2016-03-10 13:47:01 -05:00
aleos89
0fb78d45b7 Corrected Tiger Cannon splash damage (fixes #1020)
* The splash damage now factors in resistances from the splash targets.
2016-03-09 13:32:49 -05:00
aleos89
b98ba7a274 Expanded script command addrid
* Added another option to attach players based on a specified map.
* As suggested in https://rathena.org/board/topic/88331-addrid-addition/ and  https://rathena.org/board/topic/103478-addrid-map-support/
2016-03-08 12:43:09 -05:00
Cydh Ramdh
9ebf59c37b * Official EXP-Giving Script
* Fixed #980.
  * Job Quest EXP always be shown in yellow color.
  * Miracle Tonic (12259) and Leap of Fantasy (12261) give fixed EXP through `pc_setparam` that ignore EXP item bonuses and exp rates. Not as Quest EXP from `getexp` script.
  * If given EXP is 0 by `getexp`, it won't be notified in client EXP log.
  * If given EXP for base/job that reach max level, client will be notified as 0 EXP gained.
* Follow up 20588abcd83fab53f9e52deafc08bfcddfe1658a
  * Some clean up on `pc_gainexp`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-08 18:03:59 +07:00
Cydh Ramdh
71cdcb3a0a Follow up b70b25945e697b3b5e6e637ac096430490ee17c5
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-08 17:47:24 +07:00
aleos89
709424a75f Resolved a compile error
* Small follow up to 0d5e491.
2016-03-07 10:32:25 -05:00
aleos89
0d5e491b4e Fixed a potential crash with script command setunitdata (fixes #1024)
* Corrected the mercenary client refresh function using monster data rather than mercenary data.
Thanks to @Racaae and @julia40124009!
2016-03-07 09:33:00 -05:00
aleos89
809f220b9f Added to script command navigateto documentation
* Small follow up to 179f734.
* Also corrected an invalid constant.
2016-03-06 16:15:54 -05:00
aleos89
179f734249 Added documentation for script command navigateto
* Follow up to 4f13007.
* Corrected a few constants from PLANE -> AIRSHIP.
2016-03-06 16:10:15 -05:00
Lemongrass3110
4f13007fec Implemented serverside navigation system start
This feature was hidden in the client since 2011 and just came to our attention recently.
2016-03-06 21:48:47 +01:00
Playtester
80e026433f Official status change base durations for Stun (fixes #1019)
* NPC_LICK now has a base chance of 20%*level and a base duration of 5s
* Excruciating Palm now has a base duration 5s
* Shield Press now has a base duration of 5s+0.5s*level
* Earth Shaker now has a base duration of 2s (level 2-3) and 3s (level 4-5)
* Blind follow-up: Sightless Mind now has a base duration of 30s in pre-re and 20s in renewal
2016-03-06 19:46:45 +01:00
Playtester
e7150ee936 Gunslinger Mine / Ground Drift (fixes #998)
* Fixed knock back being 6 tiles instead of 3
* Stun duration is now 5 seconds
* Blind / Silence durations are now 30 seconds (pre-re) or 20 seconds (re)
* The damage is now delayed by aMotion; as the status effect kicks in immediately, damage will break Freeze
* The base chance for a status change is now 50% instead of 5%
* It is now a weapon skill, damage% increase/reductions are now considered, in renewal the skill can completely miss
* Damage in pre-renewal is 100% + fixed damage of 50*level
* Damage in renewal is 200%+20%*level
* Fixed sphere attack not being considered in the damage formula
* The ground effect disappears immediately after activation now
2016-03-06 12:09:46 +01:00
Lemongrass3110
b70b25945e Fixed experience overflow on high rates
Fixes #1014
2016-03-06 05:16:58 +01:00
Lemongrass3110
551bf2ef5d Fixed experience not counting for the next level
This was broken on 20588ab because the function pc_thisbaseexp was misinterpreted.

Now you get the required exp for the level you just mastered -1 again. Fixes #1013

Thanks to @Sweet520 for reporting.
2016-03-06 05:04:36 +01:00
Playtester
7906f0a3ff Line of Sight System updated (fixes #937, fixes #994)
* You can now target walls with ground skills
* Updated path check to not check the last cell
* Unit skills will now place units depending on line of sight to the caster rather than the cast center
* Implemented a new algorithm that retrieves all units in an area that are in line of sight with the area center
* Arrow Shower, Dragon Breath, Cold Slower, Wind Cutter and Arms Cannon now use the new algorithm (Arrow Shower is no longer a unit skill)
* Nodamage skills will no longer fail when the target walked around a corner
* The following damage skills will no longer damage through walls: Raging Thrust, Tornado Kick, Splash Attack, Venom Splasher, Fireball, Meteor Assault, Desperado, Spread Attack, Pulse Strike, Hell's Judgment, Vampire Gift, Magnum Break, Sightrasher, Frost Nova, Explosion, Self Destruction, Firing Trap, Icebound Trap, Cluster Bomb, Claymore, Fire Pillar
2016-03-05 18:02:22 +01:00
Lemongrass3110
fb4cf3e5e3 Merge pull request #1001 from secretdataz/fix/message
Fixed chat message that already have zero termination being misinterpreted as corrupted packets.
This issue was reported on #1000 by @secretdataz and was on clients from 2015-10-01 onwards and was mainly caused by Frost Joke.

Thanks to @secretdataz for additionally providing a fix for it in this pull request too.
2016-03-05 16:28:36 +01:00
Lemongrass3110
fef0d3d175 Fixed SG_DEVIL not giving blind anymore
Additionally fixed setting BaseExp and JobExp variables by script to not go over the new maximum.
2016-03-05 16:10:06 +01:00
aleos89
0677347527 Updated Madogear effect
* Partial revert of 744aed5.
* Blocked Canto Candidus giving Increase Agility to Madogear-ed players.
* Was fixed in a kRO patch on Feb. 24, 2016.
2016-03-05 09:54:09 -05:00
Lemongrass3110
ae8ba78449 Fixed multi level up exploit, which allowed going over the defined maximum levels
Fixed #1010
2016-03-05 13:35:51 +01:00
Playtester
2b7eb9f523 Follow-up to ecb01c4 (Angry mode)
* When monsters switch modes from or to angry mode, the aggressive bit will now be set properly
2016-03-04 21:40:38 +01:00
Playtester
ecb01c44f4 Monster angry mode and provoke (fixes #1011)
* When provoked, monsters will now only switch targets when they would also change targets on damage
* Added a new option to the mob_ai setting to restore the old behavior (monsters always go after the one casting provoke)
* When casting provoke on an angry mode monster before it was attacked, it will now go for the one casting provoke and not switch back to the closest target
* Angry mode will now always be reset when the monster switches to idle
2016-03-04 21:22:16 +01:00