9891 Commits

Author SHA1 Message Date
Lemongrass3110
c924b90b2b Follow up to be9babe
Exporting the random option ids back into the script engine, since they might be useful to some custom scripts.
2020-11-09 14:12:51 +01:00
Aleos
be9babee32
Converts the random option databases to YAML (#5494)
* Fixes #3084.
* Creating random option groups now further reflects official behavior.
* Group bonuses can now be created without having to create multiple permutations of the same group.
* Specific slot options can now be defined which guarantee a bonus.
* Non-guaranteed options can now be defined along with a maximum amount.
* Random option value can now be defined as a range instead of a static value.
* Adds conversion of official random option groups.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-08 12:21:52 -05:00
Lemongrass3110
9e68985f61
Fixed invisible items after VIP expiration (#5521)
Fixes #5083

Thanks to @Everade and @mazvi
2020-11-06 23:19:41 +01:00
Aleos
008a2f9585
Fixes Venom Pressure combo with Poisoning Weapon (#5343)
* Resolves the poison from Poisoning Weapon not passing onto the target when using Venom Pressure.
Thanks to @teededung!
2020-11-06 14:32:10 -05:00
Lemongrass3110
d01b718cc0
Initial support for enchantgrade (#5445)
Thanks to @LunarSHINING, @idk-whoami and @attackjom
2020-11-05 22:18:12 +01:00
Patotron
12cfe31bf1
Fixed max Doram ASPD (#5522)
Co-authored-by: Toni Pozo <porutoni@gmail.com>
2020-11-04 12:02:29 +01:00
Lemongrass3110
aa80345839
Fixed item restrictions for "All" (#5518)
Since Doram's are 16 and MAPID_ALL was defined with only the first 16 bits were covered by 0xFFFF, the job restriction failed if Summoner was not explicitly allowed.

Fixes #5516

Thanks to @kaninhot004
2020-11-03 23:56:56 +01:00
Aleos
e8fcf01ffe
Resolves null YAML node checks (#5520)
Fixes #5510.

Resolves an issue with nodeExists not checking for null nodes resulting in parsing false-positives.
Further cleanup to the item DB SQL node parsing to allow some extra options to be toggle-able.
Default stacking options to false if not defined.

Thanks to @mplaten and @Lemongrass3110!
2020-11-03 22:42:02 +01:00
Lemongrass3110
765b6a8ed2
Fixed a useless warning for PACKETVER < 20141016 (#5519)
Fixes #5515

Thanks to @joven15 and @Patotron
2020-11-03 20:30:34 +01:00
Vincent Stumpf
d158603424
Fix other character disguises on @refresh (#5366) 2020-11-01 12:58:16 -08:00
Atemo
0964881a81
Small correction of getiteminfo script command (subtype shifted the values) (#5508)
Fixed #5505 

Thanks to @Triedge !
2020-10-30 18:32:09 +01:00
inhyositsu
b61089093f
Corrects BuyingStore parsing (#5502)
* Fixes a label parse check when loading BuyingStore values for items.
Thanks to @inhyositsu!
2020-10-29 08:47:42 -04:00
Aleos
93eaf3207e
Resolves SQL header output on suffix files (#5497)
* Resolves an issue where the wrong header was being printed to the SQL files that contain a suffix to them.
Thanks to @Atemo!
2020-10-28 12:45:52 -04:00
Daegaladh
8682a9e02e
Small walkpath optimizations (#5322)
* Thanks to @mattthewaz
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-27 11:58:35 +01:00
Eric Liu
7a4bef2ab7
Fix several honor token items and add Prontera Recall skill (#5431)
Co-authored-by: Eric <eric@nomoss.co>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-26 20:44:13 +01:00
Aleos
ad3f48f9de
Cleans up the item SQL parsing (#5478)
Fixes a couple issues with the column checking.
Adds verification to table columns to make sure table format is correct.
Cleans up the node processing.
Adds a loading progress status.
Adjusts the SQL import files to not destroy previously imported data.
Updated README.md to reflect the changes for SQL importing.

Fixes #5485
Fixes #5477

Thanks to @Lemongrass3110!

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-26 00:16:15 +01:00
Vincent Stumpf
de621fee16
Fix erroneous freeing of global combo script (#5483)
Fixes #5476
When removing a combo, we free the bonus script in the global map
Thanks to @saya9200
2020-10-25 22:53:43 +01:00
Lemongrass3110
7a4009601d Fixed newline escaping in YAML2SQL converter 2020-10-25 00:12:00 +02:00
Lemongrass3110
579dc7b3a1 Added an initial loading message to YAML parsing 2020-10-24 22:49:19 +02:00
Atemo
4786d76ef7
Fixed a typo in the item parsing (#5480)
The 'Locations' node doesn't exist in the block
2020-10-24 22:31:30 +02:00
Daegaladh
f28019a798
Fixed Acid Terror armor break rate on renewal (#5475)
*Follow up to ea8da71cdda5cddbc05cdc736683487e5c14bf08
2020-10-23 16:21:48 +02:00
Vincent Stumpf
2c199f1aad
Fix items not being refineable (#5474) 2020-10-23 13:18:04 +02:00
Lemongrass3110
ed473d066d
Cleaned up hat effect code (#5462)
Converted from self written container to std::vector.
Converted clif code to struct usage.
2020-10-23 01:07:12 +02:00
Lemongrass3110
7336058485
Cleaned up and fixed some subtype checks (#5472)
Fixes #5471

Thanks to @LuciferGmes

Co-authored-by: aleos <aleos89@users.noreply.github.com>
2020-10-22 23:56:54 +02:00
Lemongrass3110
20f39922dc
Fixes compilation on 2010-07-30 and older (#5470)
Fixes #5464

Thanks to @KrokusPokus
2020-10-22 12:54:22 +02:00
Lemongrass3110
52dbea2fba Follow up to 323db7e
Fixes 2 compilation warnings

Thanks to @zEro-trap and Mael
2020-10-22 11:07:07 +02:00
Lemongrass3110
63e42dbd4b First small follow up to 04cfe17
Only report duplicate Aegisname, if it is not the same item.
When buy and sell price caused a possible zeny exploit the whole YAML node will be reported, since it could be from import and either Buy or Sell might not exist.
2020-10-22 10:37:55 +02:00
Aleos
04cfe17b2b
Converted item database to YAML (#4335)
* Combines item_avail, item_buyingstore, item_delay, item_flag, item_nouse, item_stack, and item_trade databases into one.
* General cleanups and optimizations.
* Includes CSV2YAML conversion tool.
* Includes YAML2SQL conversion tool.
* Adjusts dummy_item from being created by malloc and now creates it by make_shared.
* Item combos are now stored as a STL.
Thanks to @Lemongrass3110, @Atemo, and @cydh!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-21 19:02:11 -04:00
Aleos
323db7e661
Fixes Overheat behavior (#5455)
* Fixes #5395.
* Fixes Overheat not properly accounting for the Mechanic during battle calculations.
* Minor cleanups and improvements.
Thanks to @LotusRO!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-19 16:03:48 -04:00
Aleos
ef33ba1fca
Fixes Stellar Mark causing a map crash (#5438)
* Fixes #5429.
* Follow up to 6ba869e.
* Fixes a potential crash from Stellar Mark.
Thanks to @ecdarreola!
2020-10-19 15:24:47 -04:00
Aleos
3f36c0d60a
Fixes damage reduction statuses/skills (#5453)
* Resolves an issue with damage not being passed back to the parent function after it has been reduced by various statuses or skills.
Thanks to @teededung!
2020-10-19 14:04:36 -04:00
Aleos
7367714d40
Moves AUTOLOOT_DISTANCE macro define location (#5421)
* Fixes #5375.
* Moves the macro define for AUTOLOOT_DISTANCE to mob.hpp as mob.cpp requires this, not atcommand.cpp.
Thanks to @vstumpf!
2020-10-19 08:49:57 -04:00
Lemongrass3110
6328383578 Follow up to 8e84f0e
Fixed pre-renewal compilation
2020-10-19 14:10:55 +02:00
Jittapan Pluemsumran
8e84f0e9ef
Grouped bonus arrays into a single struct (#5454) 2020-10-19 11:08:11 +07:00
Lemongrass3110
be3aee7f74
Update and cleanup of packet definitions (#5443)
Moved changes from the Hercules file to rAthena's intermediate layer where possible.
Updated to the latest Hercules definitions.
Added missing packed attributes.
2020-10-13 20:02:29 +02:00
Lemongrass3110
f4f2f886d1
Hat Effect Update (#5442) 2020-10-11 17:21:40 +02:00
Lemongrass3110
0d2154b0fb
Effect State Update (#5440) 2020-10-10 10:02:30 +02:00
Aleos
8385162fdc
Fixes Sonic Blow damage in renewal (#5439)
* Fixes #5432.
* Corrects the damage formula for Sonic Blow in renewal mode.
Thanks to @kyurejl!
2020-10-09 09:10:17 -04:00
Lemongrass3110
d4c018cd90
Mob and NPC Identity Update (#5441) 2020-10-09 14:44:59 +02:00
Aleos
00c02479db
Fixes Magnetic field behavior (#5423)
* Fixes #5401.
* Minor optimizations to core skill behavior.
* Adjusts the status timer to be stored in val4.
* Impose a unit lock before doing status damage.
* Check for status state before attempting to reapply the status timer.
Thanks to @LotusRO!
2020-10-07 09:45:58 -04:00
Aleos
62312d2e84
Fixes achievements and multi level up events (#5425)
* Fixes #5413.
* Fixes an issue where achievements that check for specific base/job level events don't get triggered if battle_config.multi_level_up is enabled.
Thanks to @saya9200!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-02 10:05:05 -04:00
Lemongrass3110
b1b7d06559
Follow up to 3ab1ada (#5411)
Fixes calls to the function without the character session

Thanks to @KrokusPokus
2020-09-28 14:29:15 +02:00
Aleos
6ba869e398
Fixes Flash Kick and Stellar Mark interaction (#5400)
* Fixes #5399.
* Fixes targets getting stored into Stellar Mark if they are killed by Flash Kick.
Thanks to @SeravySensei!
2020-09-28 08:15:51 -04:00
Aleos
35702c62c2
Corrects item group announce flag item ID cap (#5371)
* Fixes #5370.
* Corrects the item group announce flag option being limited to uint16 for the item to display in the broadcast.
Thanks to @OriginRO!
2020-09-15 11:08:07 -04:00
Aleos
0da05e29c3
Corrected some statuses and Mado Gear interaction (#3782)
* Follow up to 0d81697.
* Added a separate check for Mado Gear and blocking Merchant/Blacksmith/Whitesmith specific statuses.
* Harmonized the statuses with the new allowed skill list.
Thanks to @slyx88!
2020-09-10 10:27:04 -04:00
Atemo
e1761aff6c
Addtionnal check in npc_touch_areanpc for npc_click (#5386)
Added a check in npc_touch_areanpc (only) to avoid a warning from npc_click
2020-09-09 15:12:27 +02:00
Atemo
08adc45ba9
bg_join - battleground doc update (#5385)
* Added more information in the doc about waitingroom2bg_single and bg_join commands
* Added MF_BATTLEGROUND mapflag check in waitingroom2bg_single and bg_join to prevent the player to join a bg when the battle map is not a battleground map
2020-09-09 15:09:55 +02:00
Daegaladh
bd90763ffe
Fixed a potential crash in the char-server (#5381) 2020-09-07 20:25:27 +02:00
Atemo
7264180a6f
Small correction in bg_team_leave (#5372)
Corrected bg_team_leave to also remove the player from the bg when entry_point (bg enqueue) is not defined
2020-09-03 22:51:24 +02:00
Atemo
07cac123a9
Terra Gloria (episode 16.2) - walkthrough conversion (#3990)
* Updated monsters DB (data from aegis and DP)
* Updated item_db (data from aegis and DP)
* Updated quest_db, thanks to @zackdreaver for the quests names !
* Implemented SC_EP16_2_BUFF_SS, SC_EP16_2_BUFF_SC, SC_EP16_2_BUFF_AC buff, thanks to @aleos89 !
** Not removed on change map
** Not removed on log out
** Not removed by dispell/clearance/Vanishing Buster
** Removed on death
* SQL synchronisation

Thanks to @Badarosk0, @attackjom, @admkakaroto, @JohnnyPlayy, @Angelic234, @teededung for the reviews/contributions !
2020-08-29 00:33:28 +02:00