-- bonus_script "<script code>",<duration>{,<flag>{,<type>{,<char_id>}}};
-- see 'doc/script_commands.txt' for more details.
-- Thank everyone who discussed it
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
Standardizes all (or almost) of the documentation for this file
Now has documentation for functions which will support Doxygen
Also standardized conditional bracketing
Removed some scopes in status_calc_speed (please double test)
Removed an unused function
'///' Is a Doxygen comment for one line
'///<' Used for variable declaration commenting
'/** **/' Standard function documentation
'//!' For TODO and FIXME
'//' Regular comment not shown in Doxygen
I apologize for conflicts
More to come, so please keep an eye out when updating that there may be updates causing many conflicts
-Note we now rely on the clientinfo version for 1st connection
-Upd date2version up to version 45
-Fix some typo banking merge (RFIFOREST and money capping was too late)
-> Applied follow-up for using monster IDs with the commands (ead2a83)
Merged revert of r15787 where character must face north (5188b69)
Merged bug fix for visual effects on relog (f304c36)
-> This fixes the Warlock Sphere issue on relog as well as many other visual effects
Applied a possible map crash fix - Credits ivanyan
http://rathena.org/board/tracker/issue-8212-server-crash-guild-retrieveitembound/
Started working on some source code documentation
Renamed bank update SQL file to upgrade_20131105.sql
-- warning: suggest parentheses around assignment used as truth value
-- warning: variable 'skill_id' set but not used
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
** Some attempts to support this job with its skills (as usable as good as I can, some of them are custom from limited info, maybe I miss some behaviors)
** Maybe some formulas, entries on skill_db, skill_require_db, skill_unit_db, and skill_cast_db are still custom
** Thank posters are on: (1) http://rathena.org/board/topic/85195-rebellion-class-released-on-kro-sakray/ (2) http://forums.irowiki.org/showthread.php?t=100131
** Some notes:
--> RL_RICHS_COIN, Rich's Coin
--> RL_MASS_SPIRAL, Mass Spiral: Bleeding chance and additional damage still custom formula
--> RL_BANISHING_BUSTER,Banishing Buster: Custom chance formula to remove buff/debuff
--> RL_B_TRAP,Bind Trap: Even I updated my client and use original lua, I stil can't see the trap
--> RL_FLICKER,Flicker
--> RL_S_STORM,Shatter Storm: Custom formula for success rate
--> RL_E_CHAIN,Eternal Chain
--> RL_QD_SHOT,Quick Draw Shot
--> RL_C_MARKER,Crimson Marker: Still doesn't show the icon of marked target on minimap (I don't know the packet for it)
--> RL_FIREDANCE,Fire Dance: Not sure it's only 1 hit damage or works like Desperado (I saw someone's screenshot, it seem only deals 1 hit)
--> RL_H_MINE,Howling Mine
--> RL_P_ALTER,Platinum Alter
--> RL_FALLEN_ANGEL,Fallen Angel
--> RL_R_TRIP,Round Trip
--> RL_FIRE_RAIN,Fire Rain: (1) This should able to remove ground target aroung its area, (2) And the splash area like a 'cone' (I imagined like someone uses gun then fire brutally to his/her front way)
--> RL_HEAT_BARREL,Heat Barrel: Still custom formula, but I saw the damage is increased highly.
--> RL_AM_BLAST,Anti-Material Blast: Custom formula for success chance
--> RL_SLUGSHOT,Slug Shot: Custom formula for damage (I saw someone's screenshot, bullet with 120 weight can deals 100k damage)
--> RL_HAMMER_OF_GOD,Hammer of God: If there is no enemy with SC_C_MARKER around the area, the skill Hammer of God animation won't displayed (maybe I missed something? I guess so)
(I guess some lines and algorithm should be cleaner, cooler, and sexier. :P)
IMPORTANT for client side:
- You should have up-to-date grf files
- I used original lua files, I didn't use translated lua files that exist nowadays because I think they need to update their supports for Rebellion
- Some items for Rebellion Skill's requirement(s) aren't added yet
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
-- Updated item_db.txt, makes Rebellion can use Gunslinger weapons and ammos
-- Updated item_db.sql and item_db_re.sql
-- 3CeAM 2.0 merger: r13
-- idAthena merger: r1057, r1077
* Follow up 3f6d4b6
-- Update the const.txt for SC_MOONSTAR and SC_SUPER_STAR. SC_EXTREMITYFIST2 should be always on the end of SC number
* Hercules merger: 1375af7d00
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
-Add some missing case for RK_DRAGONBREATH_WATER
-Fix watk not being calculated properly with bonus in Re
-Rm leftover of previous skillcooldown system (skill_cooldown_load)
-Add skill_get_itemeq (accessor)
-Add requiered equiped item to cast in skill_require_db.
-Fix SC_ASH not always giving 50% chance failing, wrong emplacement
-Fix SC_STYLE_CHANGE not being relaunch when eleanor resurected.
-Fix cardfix for target not being reseted and therefor using same value
as caster.
-Move ADJUST_SKILL_DAMAGE in battle_calc_weapon_final_atk_modifiers
(since it shuold alter the final dammage just like it do for magic and
misc)
-Add battle_do_reflect and skill_do_copy small function to encapsulate
code.
-Upd channel_clean and channel_delete to simplify autodelete case for
public chans
-Fix SC_FEINTBOMB that had a fixed blewcount and not 3*skilllv
-Fix SC_VACUUM_EXTREME where some scenario was setting scs_nomove to -1
and therefor blocking char forever.
-Fix SC_STRIKING where val1 was overwritten for sp cast but also used as
skilllv for critical bonus...
-Upd SC_GN_CARTBOOST, should be ending be DECREASE_AGI
-Upd SC_MAGNETICFIELD should be endend when getting earth dmg or
quagmire
-Mv SC_WARMER, SC_WHITEIMPRISON, SC_FREEZING ending other status section
in proper area.
