8844 Commits

Author SHA1 Message Date
L0ne_W0lf
28e4aaf123 * Added item type IT_CASH (item type 18) Requires user confirmation before using/generating item(s).
* Updated the item types for several of the cash item boxes to 18.
* Fixed the Exorcism_Bible bonus, missing {}'s for who knows how long. (bugreport:4342)
* Updated Brasilis monsters stats again, care of Playtester.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14549 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 19:23:32 +00:00
ai4rei
4ac5525eb8 * Fixed mapflags not getting initialized upon @reloadscript (bugreport:2247, since r1275).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14548 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 18:50:34 +00:00
ai4rei
081db1deb2 * Removed redundant check in food vs. cash food status change overriding code, partially suggested by xazax (related r14437 and r14510).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14547 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 17:20:47 +00:00
ai4rei
ff135c1ee5 * Added an error message when a client connection exceeds the socket write buffer, so that it does not appear to be closed for no apparent reason (follow up to r13469).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14546 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 16:40:44 +00:00
ai4rei
fc662a0020 * Random clif.c fixes and cleanups.
- Fixed clif_homskillup using sd before nullpo check (since r9297 and r9307).
- Merged code responsible for disabling pets in GvG and spawning them as per TODO (related r12002).
- Fixed base and job exp not being sent to the client for new connections (follow to r14505).
- Fixed Magnifier (item) and Identify (skill) attempting to identify an item, even when cancel is pressed, causing skill failed message.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:58:34 +00:00
ai4rei
f9bdaf5426 * Added defines for guild notice sizes (MAX_GUILDMES1 and MAX_GUILDMES2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14544 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:17:07 +00:00
ai4rei
ce93557473 * Added clif_starskill (packet 0x20e, ZC_STARSKILL) to host the packet previously implemented by clif_feel_info, clif_hate_info, clif_mission_info and clif_feel_hate_reset (related r4352, r4375 and r9162).
- This also fixes sd->bl.id being sometimes supplied for monster_id in this packet.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14543 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:56:19 +00:00
ai4rei
10638473e4 * Various additions and updates to the comments and documentation of packets in clif.
- Renamed clif_01ac to clif_skillunit_update to make it look less 'mysterious'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14542 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:06:00 +00:00
ai4rei
c8cae9e659 * Removed clif_weather_sub and clif_misceffect2 in favor of clif_specialeffect_single and clif_specialeffect (all of them are ZC_NOTIFY_EFFECT2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14541 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 12:08:44 +00:00
L0ne_W0lf
521a0280af Monsters spawned with mob-generating items now have MD_ANGRY applied to them.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14540 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 05:09:45 +00:00
ai4rei
a313575e51 * Added packet 0x1b1 (ZC_SHOWDIGIT).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14539 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 00:02:55 +00:00
ai4rei
ca36918486 * Confirmed packet 0x291 (ZC_MSG) to be general-purpose msgstringtable.txt packet and updated all functions using it (related r12245 and r13126).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14538 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 23:59:10 +00:00
ai4rei
5c84df6a15 * Fixed using main chat nick longer than 15 characters would cause a buffer overflow (bugreport:2671, since r5013).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14537 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 20:57:47 +00:00
ai4rei
0b5563ac28 * Fixed bAutoSpellOnSkill bonuses could not be chained (bugreport:4421, since r13596).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14536 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 18:36:27 +00:00
ai4rei
9808dfb86b * Fixed NPC_TALK message being displayed with EOL character attached (bugreport:4596, since r14270).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14535 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 17:07:14 +00:00
ai4rei
459d8fd961 * Reverted change from r14533 and restored the 3rd field of mob_avail.txt being optional (bugreport:4599, since r14532).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14534 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 15:48:59 +00:00
ai4rei
fe818bf27a * Updated example in mob_avail.txt to match the format description and actual implementation (bugreport:4599, follow up to r14532).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14533 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 15:09:47 +00:00
ai4rei
0781024807 * Monster database reading now utilizes sv_readdb.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14532 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 10:18:57 +00:00
ai4rei
279ea12459 * Fixed out-of-bound access to percentrefinery array causing refine bonuses stop working (bugreport:4598, since r14526).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14531 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 22:18:30 +00:00
ai4rei
cc4608e666 * Fixed class being used instead of idx in status_readdb_job2 (bugreport:4597, since r14526).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14530 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 21:57:42 +00:00
ai4rei
947d2c8ae4 * Fixed a mistake (excess dummy name) in dead branch list fallback value (since r32).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14529 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 20:19:39 +00:00
ai4rei
c792e189e4 * Moved function 'exists' (file presense check) to utils.c, so that it is available to code outside of lock.c
- Fixed associated F_OK and R_OK defines causing 'already defined' warnings on MinGW (since r1361).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14528 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 18:02:54 +00:00
ai4rei
df022f175d * Resolved missing script documentation (bugreport:4578).
- Added documentation for bonus bAutoSpellOnSkill (follow up to r13596).
- Added documentation for script command progressbar (follow up to r14024).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14527 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 15:42:39 +00:00
ai4rei
91aee9b80c * Made job_db1.txt, job_db2.txt, size_fix.txt and refine_db.txt reading use sv_readdb.
- NOTE: Any MAX_LEVEL (map.h) increase requires at least same increase of SV_READDB_MAX_FIELDS as well.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14526 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 12:40:36 +00:00
ai4rei
739d77f80f * Added SV_READDB_MAX_FIELDS define for configuration of the sv_readdb limit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14525 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 12:08:39 +00:00
ai4rei
cbc43338bf * Made skill_tree.txt reading use sv_readdb. [Ai4rei]
- Added define for skill entry requirements.
- Reports duplicate skills within same job class.
- Updated comments for skill Berserk in skill_tree.txt, among others because they would cause errors the way they are read now.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14524 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 08:55:22 +00:00
ai4rei
6cb2c681c9 * Added a define for star gladiator feel/hate info array length (follow up to r8721 and r11840).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14523 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 08:25:03 +00:00
ai4rei
72c5290837 * Fixed script command getusers causing 'player not attached' errors when asking for character count in entire server (bugreport:4591, since r14495).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14522 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-30 06:49:51 +00:00
ai4rei
c634198301 * Resolved issues with item delay system.
- Fixed random crashes caused by map_session_data corruption due to out-of-bounds access to item_delay array (bugreport:4568, since r14455).
- Fixed item delay database not being compatible with @reloaditemdb. Item delays are now reset upon reloading, much like a restart would do (bugreport:4589).
- Fixed trailing commented lines in db/item_delay.txt could cause 'too many entries' error to be displayed.
- Fixed last entity of a cash food item not being recognized as cash food, thus not receiving use delay, due to access to deleted inventory slot (since r14426).
- These changes also fix a warning regarding variable 'i' in pc_useitem being potentionally uninitialized (bugreport:4559).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14521 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-29 19:55:47 +00:00
ai4rei
b870941ee0 * Insignificant code tweaks: removal of excess function declarations and self assignments.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14520 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-29 11:28:13 +00:00
ai4rei
c82e8e36f1 * Added an option to re-roll the /dice emotion server-side, to prevent cheats during events (bugreport:4194).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14519 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 23:08:42 +00:00
ai4rei
93e376eac5 * Added emotion_type enumeration for clif_emotion constants.
- Made clif_parse_Emotion use clif_emotion, rather than having it's code inlined.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14518 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 22:43:10 +00:00
ai4rei
5d1bbf6c2a * Added clr_type enumeration for vanish effect constants.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14517 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 21:41:38 +00:00
ai4rei
8b5c0c742b * Resolved multiple issues with the party booking system (bugreport:4573, since r14412).
- Fixed recruitments were limited to party leaders.
- Fixed recruitment index was party id instead of an auto-increment value, causing sorting by age not working.
- Fixed search result packet being sent on recruitment creation (probably to work-around next problem).
- Fixed packet 0x0805 not getting sent, because of commented entries in packet_db.txt (packet ver. restriction of clif_send).
- Fixed recruitment creation notice being sent to the recruiter only.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14516 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 21:06:17 +00:00
ai4rei
7a092c2aca * Removed 'negative clrtype is used for skipping unauthed objects from saving' introduced in r9975, as it is no longer required/used (follow up to r12223).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14515 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 17:12:22 +00:00
ai4rei
4d73f8ab86 * Made the party booking search pass results as array of pointers, rather than array of indexes, which require further lookup.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14514 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 13:44:23 +00:00
ai4rei
c13027baf7 * Replaced literal constants related to the party booking system with defines.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14513 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 12:41:26 +00:00
ai4rei
97f148678c * Fixed pets derived from immobile monsters not being able to walk (bugreport:3377, since r13789).
- This also fixes pets using original monster walk speed, instead of the one defined in pet db.
- Fixed pets not being able to attack (pet_attack_support and pet_damage_support) when derived from a monster, which is not able to attack.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14512 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 12:09:29 +00:00
ai4rei
a5326bd2b6 * Fixed a crash uncovered with r14501, caused by outdated local variables when a script is about to suspend or terminate (bugreport:4577).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14511 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 02:02:30 +00:00
ai4rei
2c88023b3d * Fixed a crash when using food status bonuses with cash food status bonuses (bugreport:4582, since r14437).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14510 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 01:32:28 +00:00
ai4rei
81a1e993cc * Fixed description of bCriticalAddRace having 'race' and 'crit' parameters interchanged (bugreport:4383, since r1116 and r1382, related r12804).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14509 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 16:16:30 +00:00
ultramage
81420ce9cd Reverted r14504, the old value is correct due to how the equation works.
Fixed an ancient off-by-one mistake in the statpoint calc equation, details are in bugreport:4575.
This will affect players with levels above 99, now giving them one stat point a level later.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14508 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 16:08:09 +00:00
ultramage
74872445ff Changed 'killerrid' and 'killedrid' from player vars to player params (bugreport:3249).
Now stored in player session data, so they don't get saved on logout anymore.
Added sql upgrade script 'upgrade_svn14507.sql' to remove the now unused player variables.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14507 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 14:03:41 +00:00
ai4rei
6354bf0a0c * Some updates and fixes to script command documentation. [Ai4rei]
- Fixed small inaccuracy in description for homevolution (bugreport:125).
- Added ~AnnieRuru~'s fixes to item scripts, variables, and commands addtimer and addnpctimer (bugreport:373).
- Fixed documentation for function command in regard of passed arguments and return value. (bugreport:373).
- Simplified description for getusers, by hiding internal mechanics of the command, which are irrelevant to a scripter (bugreport:2545).
- Added description for setfont and mercenary-related commands (bugreport:3034).
- Added documentation for ?: operator and "global" labels provided by Gepard (bugreport:3650).
- Added documentation for operators -, ~ and ! (bugreport:3650).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14506 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 11:37:45 +00:00
ai4rei
5042f8262c * Fixed base and job exp not getting reset on (de)leveling through commands (bugreport:85).
- Fixed level up related functions not updating client-side exp information, causing the exp percent value display random values.
- Fixed party system not getting notified of level-ups through parameter changes.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14505 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 07:44:35 +00:00
ai4rei
f483bfedc3 * Fixed auto-generated statpoint table missing 3 status points (since r1107).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14504 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-26 07:10:38 +00:00
ai4rei
10396bbbbf * Too large client packets, which would otherwise cause the client to crash, are now dropped and reported (bugreport:4391).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14503 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-25 23:06:06 +00:00
ai4rei
3541b61e5e * Fixed a crash when an unknown map is encountered during parsing a 'script' npc and the script has mismatched curly braces (bugreport:4423, since r11502).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14502 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-25 20:59:50 +00:00
ai4rei
db5357a6e0 * Fixed script commands attachrid and detachrid not updating the attached character's information about currently running script, causing errors with dialog-based scripts or preventing characters from walking (bugreport:4571).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14501 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-25 15:44:44 +00:00
ai4rei
68168bbf6d * Fixed party booking search not interpreting level 0 as 'all levels' and using level as upper rather than lower bound (bugreport:4537, since r14412).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14500 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-25 00:49:50 +00:00