8844 Commits

Author SHA1 Message Date
ai4rei
d59156d971 * Fixed label definitions silently overwriting built-in script functions (bugreport:2806, follow up to r8027).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14600 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17 22:54:13 +00:00
ai4rei
ddbbf5e603 * Added temporary check to skill_delunitgroup to prevent crashes when 'group' is NULL and added some debug messages to track down the source of the crash (bugreport:3504).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14599 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17 20:04:26 +00:00
ai4rei
59e20f2496 * Spellchecked script_commands.txt.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14598 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17 13:55:04 +00:00
ai4rei
f964fb6ec2 * Random script engine clean-ups that have accumulated over time.
- Resolved unnecessary script_getnum re-evaluation in a loop in script command 'npcshopdelitem' (since r7120).
- Script commands 'menu', 'select' and 'prompt' now warn, when there are more menu options, than the client can handle correctly (TODO from r10316).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14597 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17 12:40:38 +00:00
ai4rei
6269cfe730 * Added missing pet db documentation for fields 'attack_rate', 'defence_attack_rate', 'change_target_rate', 'pet_script' and 'loyal_script' based on the one provided by frenzmu06 (bugreport:4636, follow up to r13752).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14596 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17 00:51:00 +00:00
ai4rei
7502f6c185 * Reverted r14525 (introduction of SV_READDB_MAX_FIELDS) because it causes confusion to certain group of users and depends on MAX_LEVEL since r14526.
- Made sv_readdb be able to process any amount of columns instead.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14595 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-16 22:53:42 +00:00
ai4rei
9eeaa7dc47 * Fixed a mistake in sv_split, causing CR being recognized as EOL character, even when only LF was specified (since r12459).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14594 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-16 20:55:41 +00:00
ai4rei
ddca23e35d * Corrected type of second argument of script command 'setbattleflag' from string to number (bugreport:4640, topic:261833, since r5407, related r14577).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14593 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-15 23:50:42 +00:00
ai4rei
98c85e0d33 * Fixed missing check in cooking, causing cooking kit requirement could be bypassed by sending 0x25b (CZ_REQ_MAKINGITEM) directly (bugreport:4642, since r13628).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14592 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-15 19:33:27 +00:00
ai4rei
af9699058d * Fixed plugin 'sig' not being compilable on Mac OS X, due to different return value type of 'strsignal' (bugreport:4637).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14591 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-13 20:57:21 +00:00
ai4rei
7e97934f53 * Added pet_db2.txt to make it apparent, that pet db has support for customs as well.
- Fixed typo 'HungeyDelay' into 'HungryDelay' in pet database description (bugreport:4636, since r13752).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14590 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-13 10:58:56 +00:00
ai4rei
63d3ed791c * Fixed homunculus_autoloot not working with skill/item granted drops and loot (bugreport:4452, since r12203).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14589 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 21:14:16 +00:00
ai4rei
23ac179cf0 * Fixed killed monsters were assumed to be killed by homunculus only, if no damage log entries were elligible for exp distribution, even when no homunculus took part in damage dealing (bugreport:4452, since r12203).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14588 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 21:09:55 +00:00
ai4rei
c457a39996 * Added enumeration for monster damage log field 'flag'.
* Corrected wording of the setting homunculus_autoloot (since r12203).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14587 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 20:22:25 +00:00
ai4rei
e7fec551b1 * Removed disabled backup of script command 'isequipped' (since r1605).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14586 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 18:06:14 +00:00
ai4rei
edfc3293e5 * Made script engine's DEBUG_DISASM block use script_op2name, rather than hardcoding operator names as per TODO from r13083 (related r9569, follow up to r10667).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14585 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 16:09:18 +00:00
ai4rei
b19741a68a * Cleaned up MOTD reading (related r292 and r4552).
- Added a warning for common client crash caused by the sequence ' :' in MOTD.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14584 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 14:53:57 +00:00
ai4rei
6a0558d0c2 * Fixed impossible condition in soundeffect script command (since athena-dev-2.1.1-mod1046, related r5841).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14583 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 13:48:14 +00:00
ai4rei
adc89d50f4 * Updates to the playBGM functionality (since r14335).
- Removed impossible condition in playBGM script command (from soundeffect).
- Removed unused code (retrieving of a bl) in playBGMall (from soundeffectall).
- Made playBGMall default to 'entire server' when both map name and coordinates are omitted instead of printing an error.
- Updated documentation for playBGM and playBGMall to match actual behavior.
- Removed unused parameter 'bl' in clif_playBGM.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 13:10:08 +00:00
ai4rei
6aabf7c260 * Fixed script command setd always assuming value parameter to be a string, which causes hexadecimal and octal numbers not being handled properly (topic:261833, followup to r14577 and r14578).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 01:38:41 +00:00
ai4rei
c961604f0b * Removed motd from ragsrvinfo table in main.sql, missed in previous commit (follow up to r14579).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14580 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:58:24 +00:00
ai4rei
d173283814 * Updates to dynamic server information ragsrvinfo on SQL.
- Fixed exp and drop rates (int) getting truncated (short) when sent to char-server.
- Removed `motd` from `ragsrvinfo` as it is not dynamically changed by the server and as such can be read by 3rd party applications directly from conf/motd.txt if required.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14579 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:44:38 +00:00
brianluau
8c9202976a - Fixed argument declaration of 'setd' (topic:261833, related r14573).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14578 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:12:10 +00:00
ai4rei
6a684a566b * Added support for checking argument data type of built-in script functions (bugreport:1701, topic:261833, related r14573).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14577 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 21:52:27 +00:00
ai4rei
72e7dce800 * Fixed error message in intif_parse_mercenary_received printing wrong struct size (bugreport:4633, since r13116).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14576 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 12:13:20 +00:00
ai4rei
806daea231 * Replaced buildin_getpartyname_sub, buildin_getguildname_sub and buildin_getguildmaster_sub, which create only unnecessary overhead, with equivalent inlined code.
- Fixed a memory leak in getguildmasterid, when the guild leader was not online (bugreport:2743).
- Command getguildmasterid no longer requires the guild leader to be online.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14575 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 01:23:38 +00:00
ai4rei
f27307a8cf * Fixed bAutoSpellOnSkill bonuses not working independently of each other (bugreport:4617, since r13596, related r14536).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14574 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 00:07:25 +00:00
ai4rei
e560ba458b * Revised argument declaration of all script commands according to the actual functions' argument usage.
- Fixed many script commands with fixed amount of optional parameters to no longer accept any amount of arguments (faulty declaration).
- Corrected use of dummy parameter for guildopenstorage in scripts.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14573 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10 22:29:12 +00:00
ai4rei
a322c9e9f1 * Applied update to charhelp.txt provided by EvilPuncker to match current charcommand behavior (bugreport:4632, follow up to r13403).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14572 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10 16:59:20 +00:00
ai4rei
522a51bb10 * Removed some of the duplicate, storage-related packet code.
- Removed clif_guildstoragelist and adjusted clif_storagelist to be able to handle any kind of storage.
- Removed clif_guildstorageitemadded in favor of clif_storageitemadded.
- This also fixes clif_guildstorageitemadded sending old update packet for clients prior 20090603, although packet 0x1c4 (ZC_ADD_ITEM_TO_STORE2) was added before PACKETVER 5 (before 2003-11-03aSakexe, exact addition date unknown) (since r14286).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14571 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-09 23:18:03 +00:00
ai4rei
6cfbe77910 * Applied some script command documentation updates and fixes as already done inside the wiki.
- Updated description for 'next', 'return', 'attachrid', 'detachrid', 'itemskill', 'openstorage', 'skilleffect', 'donpcevent', 'day', 'night', 'atoi' and 'axtoi' to resolve inaccuracies, missing information or unverified behavior.
- Clarified the purpose of the 'jump_zero' and 'getelementofarray' script commands.
- Fixed 'changebase' stating, that it only works in item scripts (since r2402).
- Fixed 'kickwaitingroomall' stating, that it is not properly linked into the script engine, thus not working (since r13732).
- Updated the description for 'cutin' so that it does not give the impression, that the client is able to display multiple illustrations at once, and being less confusing about the maximum size of illustrations.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14570 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08 23:41:55 +00:00
ai4rei
00a72ed8b9 * Fixed txt-converter-login was no longer compilable with supplied project/make files, due to missing reference to function exists in utils.c (bugreport:4626, since r14528).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14569 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08 00:15:48 +00:00
ai4rei
437a082a1a * Applied svn:eol-style to VS2010 project files (follow up to r14562).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14568 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 20:10:53 +00:00
ai4rei
e26ea94a2f * Reverted r14563, due to multiple issues which render the source malfunctioning or uncompilable. To be redone later (bugreport:4627).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14567 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:45:24 +00:00
Paradox924X
45c05e45b7 Removed unnecessary reference operator from scanf calls passing character strings as arguments in adduser tool.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14566 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:24:03 +00:00
Paradox924X
f95546e131 Revert of r14564. The value wasn't an arbitrary account id but rather the file format version. Added comment specifying this.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14565 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:18:03 +00:00
Paradox924X
bece9eef66 Removed arbitrary account id from atop account.txt (Since r13000).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14564 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:06:48 +00:00
Paradox924X
ca53ef6f4a Changed almost all instances of sprintf() to snprintf().
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14563 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 18:38:03 +00:00
Paradox924X
f6d95be1f9 Added Visual Studio 10 project files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14562 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 12:14:52 +00:00
ai4rei
eaa7afe00c * Further corrections to doc/item_bonus.txt (bugreport:4624).
- Added documentation for bUnbreakableGarment, bUnbreakableWeapon, bUnbreakableArmor, bUnbreakableHelm, bUnbreakableShield, bUnbreakableShoes, bBreakWeaponRate and bBreakArmorRate (follow up to r485, r915, r1116, r13819).
- Fixed bIgnoreDefEle having race constants listed instead of element constants (since r12804).
- Fixed bUnstripable* not mentioning, that the bonus parameter is meaningless (follow up to r1382).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14561 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 10:02:35 +00:00
ai4rei
a6c1101658 * Corrected description for bonuses bHealPower and bHealPower2 stating skill names being supported, although the bonus does not accept 'skill' as parameter (bugreport:4619, since r13821).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14560 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-06 16:17:46 +00:00
L0ne_W0lf
013acf50b1 Added support for bonus bAddItemHealRate, which works for all healing items care of Epoque.
Updated some items to use bonus bAddItemHealRate, and healpower2.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14559 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-06 00:15:16 +00:00
ai4rei
c1151a7ee3 * Fixed party booking search increasing result counter, even when no results were found, causing crashes from r14516 onwards (bugreport:4615, since r14412).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14558 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-05 00:00:37 +00:00
ai4rei
2e82e68ce9 * Fixed soul linkers not receiving taekwon angel buffs upon level up (bugreport:3585, since r3657 and r3660, related r6294).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14556 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 17:27:07 +00:00
L0ne_W0lf
d68eeba638 Corrected incorrect bonuses relating to bAddMonsterDropItem/Group. (burgerport:4569)
Updated the IG_Ore, IG_Food, IG_Recovery and IG_Jewel item groups to official items/rates.
As a result bAddMonsterDropItemGroup now uses the highest rate in group as it's base rate.
Updated instances with more proper English, care of Resplendent.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14555 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 16:14:07 +00:00
ai4rei
d3773c0b51 * Corrected 'chance' in description for bonuses bAddMonsterDropItem and bAddMonsterDropItemGroup (bugreport:4063, partially since r1572).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14554 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:59:34 +00:00
ai4rei
5cfc017080 * Removed leftovers of the item_value_db.txt feature (bugreport:2031, since athena-dev-2.1.1-mod377, followup to pre-svn 2004/05/29).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14553 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:15:29 +00:00
L0ne_W0lf
e4ae836f44 Updated some more cash shop boxes to use rentitem instead of getitem.
Added mercenary skills for Mimic, Disguise, Alice, Doppelganger, and Egnigem.
Removed duplicate NPCs in Lighthalzen and Morroc. (bugreport:4555)
Corrected typo (Sit -> Suit) in enhcant_arm NPC. (bugreport:4586)
Corrected a typo in the christmas_2008 event. (bugreport:4600)
Changed which White Lady spawns in endless tower. (bugreport:4601)
Also added Quest Log Entries to Endless Tower, please test.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14552 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 02:24:34 +00:00
ai4rei
cd78795961 * Various code tweaks and updates related to item types.
- Replaced item type literals with their appropriate constants.
- Added itemdb_typename to replace the ugly "BUG!" filled array in @iteminfo (since r1741, follow up to r14550).
- Made the item database parser verify item type for validity.
- Added item type constants to const.txt for use in scripts (getiteminfo).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14551 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 22:33:32 +00:00
ai4rei
df41665d39 * Added support for IT_CASH to @iteminfo, logging filters and item drop rate adjustment. Added 'show_picker.item_type'-specific IT_CASH value to it's description (follow up to r14549).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14550 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 20:44:38 +00:00