16526 Commits

Author SHA1 Message Date
Lemongrass3110
afaee2f01d Fixed some compiler warnings
Follow up to 45cd580

Thanks to @aleos89
2020-06-03 23:28:50 +02:00
Lemongrass3110
e2185b8c7d Fixed an issue with storages
Thanks to @Daegaladh
2020-06-03 23:10:59 +02:00
Daegaladh
b758a60bee Fixed death counter not being properly reseted with Super Novice link
*Follow up to 929c30c4143dc78cb85bc70d022113e75f62d0cc
2020-06-03 17:12:05 +02:00
Lemongrass3110
45cd5808b7
Initial support for newer packet versions (#4944)
Basic support for packets up to April 2020
Changing the default packet version to 2020-04-01

Thanks to everyone involved!
2020-06-03 16:35:10 +02:00
Daegaladh
929c30c414 Fixed death counter not updating properly
Also fixes Super Novice bonus not being removed on death and a possible crash
*Thanks to @aleos89
2020-06-03 04:46:33 +02:00
Lemongrass3110
47ebf332ab Follow up to b10caa0 2020-06-02 23:58:57 +02:00
Lemongrass3110
5784231946 Removed a sample entry in item_avail.txt
This should have never been enabled by default...
2020-06-02 20:15:32 +02:00
Lemongrass3110
b394b93100 Fixed instance YAML conversion handling 2020-06-02 20:12:02 +02:00
Lemongrass3110
b10caa039b Fixed slave recalculation on reloadmobdb
Slaves sometimes ended up with weird status calculations or insane speed, because their status got recalculated before their master and this way their speed could not be copied from the master.

Thanks to @Daegaladh
2020-06-02 19:37:33 +02:00
Lemongrass3110
6c5ed52572
Added a missing percentheal (#5033)
Fixes #5031

Thanks to @Masao87
2020-06-02 15:49:11 +02:00
rAthenaAPI
a956d40747 SQL synchronization 2020-06-02 04:00:41 +02:00
rAthenaAPI
3691a21e3d Mob and NPC Identity Update 2020-06-02 04:00:28 +02:00
SeravySensei
cd0937c468
Fix missing pet egg checks (#5029)
Fixes #5024
2020-05-31 16:11:01 +02:00
rAthenaAPI
2c1477d4ce SQL synchronization 2020-05-29 21:08:43 +02:00
qwerty7vp
bb5fd45d09
Corrects Valkyrie Knife item script (#4948)
* Adds missing Super Novice class bonuses.
Thanks to @Questune09 and @qwerty7vp!
2020-05-29 15:08:35 -04:00
rAthenaAPI
0de5244c56 SQL synchronization 2020-05-29 20:20:20 +02:00
qwerty7vp
ec05f56ecb
Whikebain Ears should Ignore 100% MDEF (#5025)
* Fixes MDEF ignore to 100% for Normal and Boss class monsters only.
* Fixes bonus for slotted version.
Thanks to @qwerty7vp!
2020-05-29 14:20:10 -04:00
LordWhiplash
d386d515a2
Fix Racing Cap combo with Racing 3Lv (#5020)
* Fixes #4998.
* Adjusts Cart Boost bonus to level 3.
* Adjusts duration to 120 seconds.
Thanks to @Angelic234 and @LordWhiplash!
2020-05-29 13:40:20 -04:00
Aleos
4f68d0c144
Fixes Mercenary kill counter (#5010)
* Fixes #4329.
* The master or the Mercenary are able to increase the kill count.
Thanks to @Indigo000!
2020-05-28 13:22:31 -04:00
Aleos
023dcac49f
Adjusts Reverberation behavior (#5013)
* Reverberation no longer uses any sub-attack skill.
* Adjusts hit count to be split on each hit.
Thanks to @attackjom!
2020-05-28 11:37:31 -04:00
rAthenaAPI
7e38cc6fa8 SQL synchronization 2020-05-27 22:54:02 +02:00
LordWhiplash
55e3d45fa1
Fix Whikebain's Black Tail (#5016)
* Fixes #5005.
* Whikebain's Black Tail should not apply curse.
Thanks to @reunite-ro and @LordWhiplash!
Co-authored-by: LordWhiplash <LordWhiplash@users.noreply.github.com>
2020-05-27 16:53:55 -04:00
Atemo
7efd696af7
Added several check for OnTouch and OnTouch_ before running the event (#5009)
* Check if the player is still in npc range
* Check if the player is still able to interact with the npc
* Check if the npc is cloaked
2020-05-27 15:52:37 +02:00
Aleos
0e42b738c5
Fixes looter mobs getting stuck (#5000)
* Follow up to b6b6b13.
* Fixes #4941.
* Fixes cases of monsters getting stuck when they lose sight of their target item that is looted by another monster.
Thanks to @iraciz and @SeravySensei!
2020-05-26 10:30:59 -04:00
Aleos
c81e6ffc09
Fixes Decorate Cart requirement (#5012)
* Fixes #4980.
* Decorate Cart requires a Cart be active.
Thanks to @LordWhiplash!
2020-05-26 09:41:08 -04:00
Aleos
7cc59c6708
Adjusts a few checks for item tradability (#4995)
* Follow up to bfb6972.
* Adds a new return array for script command inventorylist: `@inventorylist_tradable`
* Adjusts script command countitem to not count rental items.
2020-05-25 20:28:11 -04:00
Aleos
14c388b401
Resolves some Battleground issues (#4725)
* Queue data will now be kept available until a Battleground event is over.
* Players can now join an active Battleground.
* Adds a more detailed queue state tracking feature.
* When a battleground is being prepared and not enough players click accept, stop the battleground from beginning.
* When a player logs off or leaves a queue they will now properly be removed from the queue.
* Cleans up MinPlayers and MaxPlayers parsing to not accept values less than 1.
* Resolves players not being able to join an active battleground (up to MaxPlayers) unless someone quit early.
* Adds a team size priority check to avoid adding more players to a larger team.
* Fixes battlechat messages.
* Adds a battle_config to disable the ability for players on maps with MF_NOWARP to join Battlegrounds.
* Adds a new optional ActiveEvent label to the database.
* Fixes a typo in Flavius 2 during unbooking process.
* Cleans up the behavior of the Battle Therapists to use areapercentheal and areawarp.
* Fixes KVM score not properly set on the first Battleground.
* Fixes the global timer checks not ending the main timers on Flavius and Tierra Gorge.
* Added an extra bg_reserve on global timer checks in case someone tries to join the battleground just before it's ended.
* Fixed OnReadyCheck being called on global timer checks, causing the battlegrounds to start when there were no players on the map.
* Fixed a bug on Tierra Gorge where multiple barricade walls could be stacked.
* Fixes Croix also receiving 9 badges when Guillaume wins.
* Adjusts StartDelay default to 0.
* Add a database setting to give the ability to enable or disable joining as an individual, party, or guild.
* Add a database setting to restrict jobs from entering Battlegrounds.
* Better documents script commands bg_reserve and bg_unbook.
* Other fixes and cleanups.
Thanks to @roSBK and @Daegaladh, @admkakaroto, @Artuvazro, and @Atemo!
Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2020-05-25 12:39:36 -04:00
rAthenaAPI
e6bffc11fe Effect State Update 2020-05-24 14:05:26 +02:00
aleos
81a2b8c995 Fixes NPC_DARKBREATH attack type
* Follow up to 70d6876.
* Fixes #4997.
* The attack type for NPC_DARKBREATH will now properly read the database value.
Thanks to @qwerty7vp!
2020-05-22 09:19:41 -04:00
Atemo
e1aed76410
Added enchant npc for temporal shoes slotted and ogh card exchange (#4985) 2020-05-22 15:10:26 +02:00
LordWhiplash
46aa15a182
Summoner corrections (#4993)
* Fixes SU_POWEROFSEA max HP and max SP bonus when investing more than 20 skill points.
* Fixes SU_SPIRITOFLAND and SU_CN_POWDERING combo's perfect dodge bonus.
Thanks to @LordWhiplash, @qwerty7vp, and @Balferian!
2020-05-21 22:24:29 -04:00
Atemo
b8ee97b6a1
Added rental_item_novalue config (#3749)
* Added a config to always sell the rental items to NPC for 0

Thanks to @Lemongrass3110, @cydh, @aleos89, @Daegaladh for the review !
2020-05-21 21:13:45 +02:00
LordWhiplash
43caf7cc0a
SU_HISS Perfect dodge fix (#4991)
* Fixes #4990.
* Adds missing x10 rate for perfect dodge calculations.
Thanks to @Balferian and @LordWhiplash!
2020-05-21 09:02:23 -04:00
Aleos
0fba10c324
Fixes a potential crash with atcommand time (#4989)
* Fixes #4960.
* Adds a timer data validation check for atcommand time.
Thanks to @marky291!
2020-05-20 21:21:31 -04:00
Aleos
70d6876494
Corrects NPC_DARKBREATH behavior (#4982)
* Fixes #4864.
* Adjusts damage formula to official.
* Adjusts damage type from Misc to Magic.
* Skill now has a 50% success chance to damage the target.
* Removes Flee and Defense Card ignore flags.
Thanks to @Masao87 and @mrjnumber1!
2020-05-20 18:50:04 -04:00
Aleos
20945d71db
Removes nullpo checks from CSV2YAML (#4979)
* Fixes #4791.
* Removes two nullpo checks from CSV2YAML.
* Fixes undefined reference compile errors.
Thanks to @ecdarreola!
2020-05-20 18:09:44 -04:00
Aleos
a34a2f6de0
Fixes Blood Sucker not being able to be recast (#4968)
* Fixes #4964.
* Fixes Blood Sucker not being able to be recast on another map if caster dies while active.
* Minor cleanups and added safety checks.
Thanks to @Everade!
2020-05-20 17:20:37 -04:00
Aleos
ab628b2369
Remove Summoner Hide when changing maps (#4958)
* Fixes #4953.
* Remove Summoner Hide when changing maps to avoid equipment from being stripped due to the inability to change equipment while the status is active.
Thanks to @Everade!
2020-05-20 16:54:42 -04:00
LordWhiplash
746c1bdfa9
Fixes MO_EXTREMITYFIST (#4886) 2020-05-20 22:18:31 +02:00
CairoLee
bf4b41bd66
Fixes a crash caused by invalid skill ID (#4935)
* Fixes #4934.
* Fixes a potential crash when using atcommand useskill.
Thanks to @Stingor and @CairoLee!
2020-05-20 09:22:53 -04:00
rAthenaAPI
c3dda07180 SQL synchronization 2020-05-20 06:00:42 +02:00
rAthenaAPI
92a466c758 Mob and NPC Identity Update 2020-05-20 06:00:28 +02:00
Aleos
5d4fd1d3b7
Resolves Autospell displaying errors to console (#4921)
* Fixes #4883
* Fixes Autospell displaying invalid skill errors when clicking Ok or Cancel.
Thanks to @admkakaroto!
2020-05-19 17:19:34 -04:00
Aleos
18b642c174
Skill Database cleanups (#4902)
* When reloading the skill_db clear out Abra, Magic Mushroom, and Reading Spell Book databases as well.
* Fixes NC_SHAPESHIFT and NC_REPAIR checking an invalid ItemCost slot based on the old implementation.
* Updated a lot of references to the old skill databases.
2020-05-19 15:32:57 -04:00
Aleos
d9f533165e
Fixes Adoramus' interaction with Land Protector (#4920)
* Fixes #4876.
* Adoramus should not do damage to anyone inside the range of Adoramus.
Thanks to @teededung and @Tokeiburu!
2020-05-18 16:51:46 -04:00
rAthenaAPI
936d5617b2 SQL synchronization 2020-05-18 21:13:33 +02:00
qwerty7vp
4411ee4c4e
Corrects Happy Balloon item script (#4976)
* Fixes #4963.
* Corrects Happy Balloon drop rate bonus and Aegis name.
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2020-05-18 15:13:24 -04:00
rAthenaAPI
1fe4e4f17f SQL synchronization 2020-05-18 19:35:16 +02:00
Aleos
44e5c5bcc7
Job Improvement Project - Rune Knight (Part 2) (#4709)
* Fixes #4708.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=243&curpage=1
Thanks to @ecdarreola, @Litro, @Haydrich, and @LordWhiplash!
2020-05-18 13:35:07 -04:00
Daegaladh
d1e5127728
Fixed getcharid error in Continental Guard quest (#4970) 2020-05-18 18:52:08 +02:00