4970 Commits

Author SHA1 Message Date
Paradox924X
6cc9f191f1 Prevented SC_EXPBOOST, SC_JEXPBOOST and SC_ITEMBOOST (used by Battle Manuals and Bubble Gum) from being dispelled by Gospel. (bugreport:4836)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14763 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-28 04:39:51 +00:00
ai4rei
bba102a818 * Added separate character state for vending (like for buyingstore), instead of vender_id != 0 (follow up to r14682, related r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14762 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-27 18:43:31 +00:00
ai4rei
2971fb3e9a * Added support for tracking state of client command /effect through packet 0x21d (CZ_LESSEFFECT).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14761 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-27 18:17:05 +00:00
ai4rei
13d8ac9537 * Fixed battlegrounds chat packet 0x2dc (ZC_BATTLEFIELD_CHAT) being sent with the battleground id rather than the account id of the talking player (since r13593).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14760 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-25 17:31:28 +00:00
Gepard
4698c6c569 * Fixed possible client crash when monster is class-changing to mob_avail'd one.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14754 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-22 02:42:12 +00:00
ai4rei
6aa18784a3 * Random accumulated tweaks and fixes.
- Added a error message to npc_enable, to spot disablenpc/enablenpc/hideoffnpc/hideonnpc on non-existing NPCs (related r14750).
- Replaced inlined npc_name2id code with calls to npc_name2id.
- Open Buying Store skill is now exempted from noskill mapflag like Vending as well (bugreport:4815, follow up to r14713).
- Fixed signed constant being returned as unsigned value in get_percentage (bugreport:4765, since r12679).
- Replaced strlen checks, which checked whether or not a string is empty, with first-byte checks.
- Fixed enabling 'fakename' not clearing party and guild name and cleaned up atcommand 'fakename' code.
- Cleaned up party/guild name code in clif_charnameack (follow up to r14737).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14751 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-20 20:19:23 +00:00
Gepard
f0fb5249a1 Removed leftovers of old charcommand config (follow-up to r13403).
Added check to ensure character `rename` status will be saved if changed.
Fixed Beast Strafing (HT_POWER) damage formula and SP requirement provided by Playtester (bugreport:4675, since r4392).


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14748 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-19 21:40:15 +00:00
ai4rei
dd28b6b2b1 * Fixed pet database reading displaying wrong amount of read entries per file (bugreport:4797).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14746 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:48:05 +00:00
ai4rei
9f7d93be5a * Fixed canceling item appraisal window (Magnifier and Identify) would prevent players from using any follow up skills (bugreport:4809, since r14545).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14745 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:36:22 +00:00
ai4rei
0f68f25c54 * Fixed monsters getting warped when stepping on an NPC warp when at least one of the bits of setting 'mob_warp' was set (bugreport:4766, since r12757).
- Fixed option 'monster_ai' referring to setting 'mob_npc_warp' rather than 'mob_warp' (follow up to r8135).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14744 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:10:13 +00:00
ai4rei
44294eb3b1 * Fixed a typo in npc_touchnext_areanpc (NPC's map being used as it's x-coordinate), which caused ::OnTouch_ invokation to affect different area than intended (bugreport:4814, since r14097).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14743 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-14 15:08:54 +00:00
ai4rei
015d2ae95c * Fixed @item2 and script command 'getitem2' not taking MAX_REFINE define into consideration (bugreport:4804).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14739 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 18:55:27 +00:00
ai4rei
ed0711d6a1 * Fixed @str/@agi/@vit/@int/@dex/@luk commands setting a stat to 0 (rather than 1), when exact amount is subtracted (bugreport:4803, since r14493).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14738 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 14:11:35 +00:00
Kisuka
91250a364c - Added official behavior of displaying party names.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 12:44:53 +00:00
ai4rei
c9a3277785 * Cleaned up packet dumping code.
- Replaced utils function 'dump' with 'WriteDump' (files) and 'ShowDump' (console), and used those to replace inlined code in clif (related r10947).
- Fixed clif_parse_debug not printing anything, when it is used with a variable length packet.
- Added ability to dump invalid packets through define DUMP_INVALID_PACKET (clif.c).
- Removed code to dump all incoming packets, as that can be achieved with the DUMP_UNKNOWN_PACKET code as well when needed (from r1009, related r10947).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14734 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-07 09:51:33 +00:00
ai4rei
a54e55ae82 * Minor clean-ups to buyingstore and searchstore code (follow up to r14732).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14733 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-06 22:57:58 +00:00
ai4rei
6b74ef9b50 * Implemented search store info system (aka. vending and buying store search) together with related items.
- Requires 2010-08-03aRagexeRE or later and can be disabled in 'conf/battle/feature.conf'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14732 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-06 19:16:09 +00:00
ai4rei
ffe2f08b20 * Fixed possible crash in script_reportdata, when a script string becomes NULL.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14731 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-05 08:53:26 +00:00
ai4rei
a8b582fbf8 * Fixed recursive map_quit invocation when a buying store is auto-closed (login when @autotrade/logout) (bugreport:4796, since r14724).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14730 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-04 10:17:22 +00:00
ai4rei
9a7c05e962 * Updates to the super novice's guardian angel prayer effect and related handling code.
- Removed the server-side chat tracking code (since r492) responsible for invoking the effect, since this functionality is handled by the client (invocation also processed by the server). This also fixes the missing 7 lines requirement on the server-side handling (bugreport:4786).
- Updated the checks in the client-invoked code part and documented the packet.
- Now only the prayer in client-side data\msgstringtable.txt (lines 791~794) applies.
- The prayer is no longer blocked by noskill-restrictions.
- Exp at 0% and 100% no longer causes the effect to trigger.
- Fixed the exp percent check to also check one digit after the decimal point (requirement is 10.0% not 10%).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14729 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-02 11:55:27 +00:00
ai4rei
57dc2cdfcf * Fixed packet 0x839 (new guild member expel notification) was expected on clients 2010-06-08aRagexeRE~2010-07-30aRagexeRE, although those do not implement it (bugreport:4789, since r14718, related r14368).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14728 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-01 22:24:18 +00:00
ai4rei
6875f52a54 * Reduced MAX_GUILD_STORAGE from 1000 to 600 (like MAX_STORAGE), since storage with 1000 items causes too large packets that are dropped then, which in turn gives the impression that the items are lost (follow up to r14503).
- Note: When updating an existing server, keep in mind that excess items in guild storage get lost, when MAX_GUILD_STORAGE is reduced.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14725 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-26 12:16:06 +00:00
ai4rei
c9d4af2383 * Updates to various custom stuff that buying stores might/are expected to support (follow up to r14713).
- Buying store no longer works on novending maps/cells (bugreport:4778).
- MANNER_NOROOM mute flag now affects buying stores as well (like vending).
- Enabled @autotrade for buying stores.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14724 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-23 21:00:48 +00:00
ai4rei
824b3f8a47 * Fixed whispering to NPCs (::OnWhisperGlobal) not working for NPCs whose unique name is different from the display name (bugreport:4776, since r2624).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14723 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-23 20:14:45 +00:00
ai4rei
b70116a541 * Fixed SP regen not stopping when Maximize Power (BS_MAXIMIZE) is in effect.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14720 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-21 01:27:49 +00:00
ai4rei
7aedde90e8 * Updated guild expel notification packet 0x15c (ZC_ACK_BAN_GUILD) for clients 2010-06-08aRagexeRE and newer to 0x839.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14718 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-20 01:21:12 +00:00
ai4rei
bc951500fd * Removed '.txt' from log config info messages, as the values already have an extension (since r197, related r196).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14717 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 21:40:16 +00:00
ai4rei
48746d078e * Fixed gcc compile warnings in char-server and console plug-in (bugreport:4771, topic:208746, since r9631 and r14700).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14716 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 21:07:43 +00:00
ai4rei
3f4cacac0b * Fixed buying stores could be opened and sold to regardless of distance between seller and buyer (since r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14715 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 18:47:45 +00:00
ai4rei
50eab8f576 * Fixed 'feature.conf' not getting loaded and a typo buying store feature setting name (follow up to r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14714 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 13:23:42 +00:00
ai4rei
ce3f78556c * Implemented buying store system (aka. reverse vending, purchase shop) together with related skill and items, without NPCs.
- For SQL apply upgrade_svn14713_log.sql to upgrade tables `picklog` and `zenylog`; for TXT no action is necessary.
- Requires 2010-04-20aRagexeRE or later and can be disabled in 'conf/battle/feature.conf'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14713 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 12:59:36 +00:00
ai4rei
5ed2bd8367 * Merged enumeration update from renewal [14699/branches/renewal] for a future commit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-17 20:16:42 +00:00
ai4rei
ba8bd70b0c * Updated configure/make scripts to resolve various issues.
- Added detection whether or not -fPIC switch is required when compiling shared objects (plug-ins) to resolve compile issues on 64-bit platforms (topic:208746).
- Native 'strnlen' implementations are now detected and disable the one in strlib (bugreport:1261).
- Define 'DB_MANUAL_CAST_TO_UNION' is now set when necessary (bugreport:1261).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14708 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-16 19:36:51 +00:00
ai4rei
86091a86f7 * Added support for client GM command /check (related r12076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14707 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-15 11:47:31 +00:00
ai4rei
2fb2b1444f * Fixed drop list of map flag 'pvp_nightmaredrop' not getting cleared upon @reloadscript (bugreport:4282, follow up to r14668).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14706 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 23:34:40 +00:00
ai4rei
0cd89ec86f * Fixed GMs with GM level equal to 'lowest_gm_level' being treated as normal players in 'gm_can_party' check (bugreport:4162, since r13143).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14705 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 21:13:19 +00:00
ai4rei
531584b648 * Fixed a crash when script 'npctalk' is given too long string (bugreport:4759, related r2145).
- Fixed related buffer overflows in message related clif functions (since r1182, r14270).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14704 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 12:49:08 +00:00
ai4rei
9f2620f2fa * Fixed script command 'bpet' (Pet Incubator) displaying an empty egg list when attempting to hatch a pet while already having one out (bugreport:3313).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14702 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-09 11:27:27 +00:00
ai4rei
63321f205e * Moved script constant manipulation code into separate functions script_get_constant / script_set_constant. [Ai4rei]
- Added protection against overwriting existing names in script constant creation code.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 10:43:51 +00:00
ai4rei
da989bb356 * Added support for new delayed character deletion.
- Asks for birth date associated with the account and has a waiting time of 24 hours by default (setting).
- For SQL apply upgrade_svn14700.sql to upgrade table `char`; for TXT no action is necessary, as it upgrades itself.
- This completes support for clients 2010-08-03aRagexeRE and later.
* Updated login sql engine version, missed during `birthdate` addition (follow up to r14672).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14700 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 02:36:43 +00:00
ai4rei
4592b9832d * Updates to various client packets.
- Renamed clif_set0199 and clif_send0199 to clif_map_property and clif_map_property_mapall respectively and added an enumeration for currently known map properties.
- Renamed clif_set01D6 to clif_map_type and added an enumeration for currently known map types.
- Resolved undocumented field of packet 0x22e (ZC_PROPERTY_HOMUN) to attack range.
- Fixed aspd field of packet 0xbd (ZC_STATUS) getting filled with karma value.
- Removed commented clif_skillinfo (duplicate of clif_item_skill).
- Other minor comment updates and 'FIXME' assignments.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14698 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 00:37:33 +00:00
ai4rei
bc2ec92a4a * Replaced 'nameid < 500' checks in script commands 'countitem', 'countitem2' and 'autoequip' with stricter ones.
- This should stop meaningless itemdb_search warnings from said commands when an invalid item id is used.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14696 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 12:18:46 +00:00
ai4rei
1bb6a3d506 * Fixed NPCs with closing parenthesis in their name could not be duplicated (bugreport:3235).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:45:10 +00:00
ai4rei
0045508031 * Fixed closing 'switch' curly not causing script EOL processing to trigger, leading to the script line after the switch being handled as belonging to the curly-less statement block (bugreport:3273, since r3422).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14694 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:02:57 +00:00
ai4rei
8dc5d7029c * Fixed non-windows 'findfile' utils function missing a 'closedir' call (bugreport:4739, since r1629).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14692 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-02 20:00:12 +00:00
ai4rei
2bc3dafd59 * Inventory and Cart item arrays are no longer getting compacted on each log-in/teleport/warp.
- This also resolves yet another issue caused by r14685 (bugreport:2604).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14691 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 20:40:16 +00:00
ai4rei
7557d37013 * Various accumulated cleanups and fixes.
- Improved the compile speed for files which include common/socket.h on windows builds (related r10471).
- Moved FIFOSIZE_SERVERLINK define from common/mmo.h to common/socket.h (since it is a server connection FIFO size setting).
- Fixed script command 'areamobuseskill' canceling monster's skill cast before it determined it's new target, which could be 'none' (bugreport:3272, since r13897).
- Added a protection against attempts to read an empty backup / write to a full backup in skill_dance_switch as per TODO from r11347.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14690 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 12:39:54 +00:00
ai4rei
8fb6c1f646 * Fixed faulty WFIFO reallocation causing memory exhaustion (bugreport:4737, since r1816, related r11503, r11571, r11886 and r12232).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14689 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 11:30:57 +00:00
ai4rei
9492535e65 * Fixed equipped items' bonus no longer working after log-in until next status recalc, due to missing pc_setequipindex which was previously called by pc_checkitem (bugreport:2604, since r14685).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-30 21:36:11 +00:00
ai4rei
884cb80892 * Removed @aw/@away which duplicates and collides with client's /am (away message) (bugreport:1235, topic:163083, since r4351).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14686 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-29 11:30:24 +00:00