85 Commits

Author SHA1 Message Date
aleos89
ab576e9bf8 Corrected Warmer's effect (fixes #1097)
* Moved the healing effect to status change timer.
* Warmer's effect will now last the entire life of the unit.
* Warmer's effect will now be removed when a player leaves the unit.
* Corrected Cloud Kill unit flag not being applied.
2016-06-06 09:47:03 -04:00
Playtester
89f86b2533 Lunatic Carrot Beat, Catnip Meteor, Grand Cross (fixes #1219)
- Lunatic Carrot Beat and Catnip Meteor now deal 300% to 700% damage which is calculated once and split between multiple hits rather than calculating damage per hit; despite this, they can still hit plants
- Reduced cast time of Lunatic Carrot Beat from 3000ms to 1500ms and cooldown from 8000ms to 6000ms according to latest tests on kRO
- Fixed Catnip Meteor still having a fixed cast time
- Increased stun chance of Lunatic Carrot Beat from 10% to 20%
- Increased curse chance of Catnip Meteor from 10% to 20%
- Increased cast time of Grand Cross in pre-re to 3000ms (see #1140)
- Fixed Grand Cross sometimes having 4 intervals instead of 3 (see #1140)
2016-05-02 23:27:08 +02:00
Playtester
1365d9418e Meteor Storm, Catnip Meteor (fixes #983)
* Official implementation of Meteor Storm behavior
-- It deploys all units directly at castend
-- Each unit has a different expiration time
-- On the last interval of a unit the meteor will appear
-- When the unit expires, it will deal damage
-- If the unit gets removed at any time, no meteor will appear and no damage will be dealt
* It is now easily possible to configure Meteor Storm behavior via database files, no more extra coding required
* Fixed Meteor Storm sometimes dealing damage even though no meteor appeared
* Fixed Meteor Storm being able to hit through walls when the caster has moved in the meantime
* Catnip Meteor will now create 3-7 meteors depending on level
* Catnip Meteor now has an interval of 500ms instead of 1000ms
* Catnip Meteor now has a curse duration of 20s instead of 5s
2016-03-28 16:37:46 +02:00
Playtester
1ca9fb58f2 Decrease Agi, Adoramus (fixes #1067)
* The chance of Decrease Agi and Adoramus is now reduced by a fixed 1% per MDEF
* Decrease Agi can now overwrite itself with a lower level
* The base chance to cause blind when Adoramus activates is now 1000%
* Adoramus now has a blind duration of 7s+1s*level and an Adoramus duration of 10s+5s*level for both players and monsters
* Adoramus and Decrease Agi cancel each other out
* Adoramus no longer reduces speed (only AGI reduction and blind)
* Adoramus no longer cancels ASPD/Speed increasing buffs
* Adoramus can no longer be blocked/canceled by ASPD/Speed increasing buffs
* When Adoramus ends, it will no longer automatically end blind at the same time
2016-03-18 23:06:29 +01:00
Playtester
a6f73a6227 Status changes that cause damage reworked (fixes #1033, fixes #448)
* Created a better structure for status changes with intervals and integrated the status changes Stone, Poison, Deadly Poison, Bleeding, Magic Mushroom, Burning, Pyrexia, Leech's End and Toxin into the new structure
-- The exact remaining duration of these status changes will now be stored
-- The correct duration is reloaded when logging back in, you can't avoid a single tick be re-logging
-- It will now show the correct duration on the icon of the status change after re-logging, no longer negative values
-- The durations are now accurately transferred when using Deadly Infect
-- These status changes now use unified code, which makes it much easier to integrate more status changes into this structure with low risk of breaking something
* Removed all the status change specific logging of damage and integrated it into the normal logging behavior
-- The following skills deal "No source" damage: Stone, Poison, Deadly Poison, Bleeding, Coma, Magic Mushroom
-- The following skills deal "Self" damage: Burning, Pyrexia, Leech's End, Toxin
-- "No source" will neither be logged nor contribute to the total damage, your exp share doesn't increase from the damage, but it also won't cause the monster to give less EXP, it won't break freeze or similar status changes, it won't make you stand up, it won't make you stop moving, it won't prevent you from logging out
-- "Self" damage will now be logged and contribute to the total damage, it makes monster give the exp tap bonus, but also makes monsters give less exp the more "self damage" they've taken, it will break freeze and similar status changes, it will make you stand up properly now, it will make you flinch and stop moving, it will prevent you from logging out, but angry type monsters will not lose their aggressive bit from it and it will not cause monsters to use their rude-attack skill
-- Monsters will now use their rude-attack skill on the first rude-attack as long as the damage does not come from self
-- When a monster takes damage from a status change, its HP meter will now be updated
* Burning now has an interval of 3s and a minimum duration of 10s
* Pyrexia now causes blind for Pyrexia's duration instead of just 30s
* Ground Drift's poison base duration is now 60s in pre-re (follow-up to e7150ee)
* Fixed a bug where the minimum duration failed to apply when the received duration was below 1ms
* map_foreachindir and map_foreachinshootarea will now properly print their function names in case of an error
* Updated documentation (transferring source ID is no longer required, remaining tick should now always be in val4)

If this breaks anything, please report asap.
2016-03-12 16:50:50 +01:00
Playtester
80e026433f Official status change base durations for Stun (fixes #1019)
* NPC_LICK now has a base chance of 20%*level and a base duration of 5s
* Excruciating Palm now has a base duration 5s
* Shield Press now has a base duration of 5s+0.5s*level
* Earth Shaker now has a base duration of 2s (level 2-3) and 3s (level 4-5)
* Blind follow-up: Sightless Mind now has a base duration of 30s in pre-re and 20s in renewal
2016-03-06 19:46:45 +01:00
Playtester
e7150ee936 Gunslinger Mine / Ground Drift (fixes #998)
* Fixed knock back being 6 tiles instead of 3
* Stun duration is now 5 seconds
* Blind / Silence durations are now 30 seconds (pre-re) or 20 seconds (re)
* The damage is now delayed by aMotion; as the status effect kicks in immediately, damage will break Freeze
* The base chance for a status change is now 50% instead of 5%
* It is now a weapon skill, damage% increase/reductions are now considered, in renewal the skill can completely miss
* Damage in pre-renewal is 100% + fixed damage of 50*level
* Damage in renewal is 200%+20%*level
* Fixed sphere attack not being considered in the damage formula
* The ground effect disappears immediately after activation now
2016-03-06 12:09:46 +01:00
Playtester
61a48b9b0b Jack Frost, Status Traps, Stone Fling, Leap, Cannon Spear
* Fixed status base chances of Jack Frost and Status Traps (fixes #997)
-- Jack Frost: 200% freeze chance instead of 100%
-- Land Mine: 10% stun chance instead of 35%-55%
-- Flasher: 100% blind chance instead of 40%-80%
-- Freezing Trap: 100% freeze chance of instead 38%-50%
* Sandman Sleep and Throw Stone Blind base duration is now 30s in pre-re and 20s in renewal
* Leap now has a shorter distance when used diagonally (fixes #1007)
* Cannon Spear now shows the skill animation even if it doesn't hit anything (fixes #1004)
2016-03-03 22:11:41 +01:00
aleos89
1616e06b9e Corrected Chain Lightning skill delay (fixes #995)
* Should have a global cast delay of 3 seconds.
2016-03-01 12:55:46 -05:00
Playtester
ec59446043 Official status change base durations for Freeze and Blind (fixes #988)
* Snowflake Draft now has a skill-specific duration of 5s*level
* All freeze durations (default and skill-specific) are increased by 2.5s in renewal
* The renewal default duration is now 27.5s (+2.5s)
* Items, Storm Gust, Frost Joke, NPC_ICEBREATH and NPC_WIDEFREEZE use the default freeze duration
* All items and skills that cause blind now have a base duration of 30s in pre-re and 20s in renewal
* Fixed NPC_DARKCROSS and NPC_GRANDDARKNESS not giving the blind status change
2016-02-28 01:03:14 +01:00
Playtester
6aad510818 Frost Joke pre-renewal freeze duration (follow-up to f5ea1dc)
* The freeze duration of Frost Joke is now 12s in pre-renewal

Note: Each status change has a default duration on official servers and most skills use it. The standard duration for Freeze in pre-renewal is 12s, but it was increased to 30s in renewal. Both Storm Gust and Frost Joke could be proven to use the standard duration, whereas Frost Diver and Snowflake Draft have a custom duration per level set.
2016-02-24 17:32:12 +01:00
aleos89
2ad4972be8 Corrected Moon Slasher effect
* Now able to stop Boss monsters.
* Has a random duration of 1~3 seconds.
Thanks to @Playtester!
2016-02-22 09:14:54 -05:00
Playtester
de08a3677e Follow up to 9721dc9
* NPC_EVILLAND and Sanctuary effects will now be slightly longer visible (just a cosmetic improvement)
2016-02-21 19:52:22 +01:00
Playtester
3449b67abc Follow-up to 8d20393 and a63b031
* Thunder Storm, Exploding Dragon, Lightning Jolt and Snowflake Draft can now damage more than just once every 500ms
* Fixed a problem with negative aftercast delay
2016-02-21 19:34:34 +01:00
Playtester
8d20393b10 Ninja Skills vs Land Protector (fixes #971)
* Exploding Dragon, Lightning Jolt and Snowflake Draft are now unit skills
-- They no longer can deal damage on Land Protector
-- They will deal damage instantly, regardless of your ASPD
* Exploding Dragon now deals 150%+150%*level damage divided by number of hits, it can no longer damage plants
* Snowflake Draft's freeze base duration is now 2500ms+5000ms*level
* Renewal: Lightning Jolt's AoE is now 3x3 on level 1-2, 5x5 on level 3-4 and 7x7 on level 5
* Pre-Renewal: Cast time of Wind Blade level 8-10 is now 500ms shorter
* Watery Evasion now makes non-Ninja enemies stop when they walk on it and are not knock-back immune
2016-02-20 21:41:01 +01:00
Playtester
7a62ab49dc Monster level 10 skills (Part 1), LoV (fixes #957)
* The following monster level 10 skills now have their official effect
-- Two-Hand Quicken: Increases ASPD by 70%. Duration 300s.
-- Lord of Vermilion: Deploys units in a 15x15 area that splash 1 cell into LP each. 520% damage per wave.
-- Thunderstorm: 20 Hits, 7x7 AoE. Splashes 3 cells into LP.
-- Decrease Agility: Reduces Agi by 50. Duration 130s.
-- Hammer Fall: 25x25 AoE. 100% base stun chance.
* Added a document that will contain all information on these special level 10 monsters skills
* Implemented official damage formula for renewal Lord of Vermilion; it only applies to LoV cast by players
2016-02-13 11:50:12 +01:00
Playtester
f5ea1dcb3e Several no-damage status change skills updated
* Scream and Frost Joke (fixes #945)
-- The delay until the status change kicks in was increased from 2s to 3s
-- Aftercast delay in pre-renewal was increased from 3s to 4s (already 4s in renewal)
-- Duration of Freeze from Frost Joke increased from 10-14s to 30s
* Hammer Fall, Lex Divina and offensive Status Recovery (fixes #945)
-- A delay of 1 second until the status change kicks in was added
-- Hammer Fall will hit the targets that are in the AoE before the delay (so you can't dodge)
-- Offensive Status Recovery's base duration reduced from 30s to 20s and base chance increased to 100%
-- Increased the maximum number of skill timers from 15 to 40 as they are needed for delayed status changes
* Stone and Freeze now remove Lex Aeterna (fixes #947)
-- For stone this refers to the second phase
* Scream, Frost Joke and Hammer Fall no longer make a target stop (fixes #948)
-- Similar behavior to e.g. Ankle Snare against bosses or in WoE
-- If the target was singing/dancing, it will still stop and the song/dance will be canceled
-- Fixed a bug that caused position lag when targets that are still moving but can't move anymore are hit
2016-02-07 18:58:53 +01:00
aleos89
31c5914bb2 Updated Stasis effect
* Fixes #830 and fixes #918.
* All players within the skills range (depending on level) are effected by Stasis.
-- Resolves issue with players behind walls not being effected.
* Duration is now 10 + (10 * skill_lv) seconds with a minimum of 10 seconds after being reduced by VIT + DEX.
* Status Recovery now removes Stasis and White Imprison.
* All players effected by Stasis are unable to cast any skill except Status Recovery, Dispell, Clearance, and Banishing Buster.
2016-02-03 15:16:23 -05:00
Playtester
4fd4c1d5bf Pneuma / ArrowShower / Ranges, Charge Attack, Waterball / Jupitel fixes
* Pneuma / Arrow Shower / Ranges (fixes #915)
-- Pneuma now also protects against knockback from ranged skills
-- Arrow Shower cast by monsters is now always a melee skill and cannot be blocked by Pneuma, but can always be blocked by Safety Wall
-- When monsters cast a skill that has no specific rule, it will be considered melee when the target is within a 7x7 area around the monster, rather than a 11x11 area
* Charge Attack (fixes #417)
-- Damage: 0-3 cells 100%, 4-6 cells 200%, 7-9 cells 300%, 10-12 cells 400%, 13 cells 500%
-- Cast time pre-Renewal: 0-3 cells 500ms, 4-6 cells 1000ms, 7+ cells 1500ms
-- Cast time renewal: 500ms (250ms fixed)
-- The caster will now move to the cell next to the target rather than right on it
-- When the attack misses, there won't be knockback (but the caster will still move)
* Waterball/Jupitel (follow up to 6ebcb67, fixes #907)
-- Waterball/Jupitel now can hit through shootable walls
-- Waterball cells now can overlap
2016-01-24 17:54:02 +01:00
Playtester
9721dc94a5 NPC_EVILLAND and Sanctuary updates (fixes #927)
* NPC_EVILLAND now has 3+level intervals, a target range of 7 and ignores flee,
* NPC_EVILLAND's area of effect per unit is now 11x11 on level 1-9 and 27x27 on level 10
* NPC_EVILLAND now ignores Devotion
* Sanctuary now has exactly 1+3*level heal intervals, regardless of number of players healed
* Sanctuary will end early when 3+level targets have been hit, targets currently on Sanctuary might still be hit when it expires
2016-01-24 01:06:00 +01:00
Playtester
6ebcb67601 Waterball, Jupitel Thunder and Mystical Amplification behavior improved
- Implemented Waterball and Jupitel Thunder double cast (fixes #907)
* Waterball and Jupitel now won't apply a delay after they have been cast and won't notify the client about the spell until 150ms later, if another skill request is received, it will actually be cast as well
* To prevent exploits this behavior can only be used every 2 seconds
* This allows you to cast a spell after Jupitel that would not have enough range to be cast after knockback
- Finally implemented the official waterball unit behavior
* When casting Waterball, water, deluge and suiton units will be turned into waterball units
* These waterball units are then turned into waterballs one-by-one
* All unit behavior now also applies to waterball, special handling is now solved via db files
* If there are multiple waterball timers active at the same time, they will actually compete for the waterball units
* When waterball does not deal damage (100% resist), it will now cancel, allowing you to act and move again
* If this breaks anything, please notify me
- Mystical Amplification improved (fixes #908)
* Mystical Amplification will now toggle at cast begin rather than cast end
* When Mystical Amplification ends, spell damage will be immediately lower even for ongoing spells
2016-01-17 18:00:18 +01:00
aleos89
bda5b80ae6 Skill Cast Time Updates
* Follow up to df35f33.
* Updated times for 3rd class extended skills.
* Merged 3rd class and on changes to pre-renewal.
2015-11-05 09:22:46 -05:00
aleos89
d95f5d2db7 Bug Fixes
* Fixes #447 - Added script command 'unitblockmove' to be used with OnTouch and Unit Commands.
* Fixes #448 - Leech End will no longer get a player stuck in stand/sit modes.
* Fixes #503 - Added script command 'ignoretimeout' which disables the SECURE_NPCTIMEOUT of a specific script.
* Fixes #521 - Pre-renewal Shield Chain should always be Neutral damage.
* Fixes #532 - Fixed an issue with the 'item_check' config not saving the unique ID when enabled.
* Fixes #537 - Arms Cannon is now a single unit target skill.
* Fixes #541 - Cleaned up Ignition Break damage formula.
* Fixes #543 and Fixes #552 - Cleaned up Reverberation to match official. Now splits damage among targets.
* Fixes #546 - Updated Randomize Spell to the latest official skill list and rates.
* Fixes #547 - Escape is now a self skill and can use normal Traps if no Alloy Traps are available.
* Fixes #551 - Great Echo and Sound of Destruction can now blocked by Pneuma.
* Fixes #556 - Adjusted Arrullo, Deep Sleep Lullaby, Netherworld, and Voice of Siren duration formulas to properly account base/job levels.
* Fixes #561 - Pre-renewal Tiger Cannon now properly removes HP when casting skill.
* Fixes #576 - Shield Spell, Exceed Break, Overbrand, Moon Slasher, Piety, Earth Drive, and Hesperuslit no longer have fixed cast time.
* Cleaned up Shadow Formation SP Drain formula to be 11-skill_lv per second.
* Sound of Destruction is now a placement skill type.
* Updated variable cast time for Windmill Rush from 2 seconds to 1 second.
2015-08-17 14:13:22 -04:00
aleos89
2a04748bf4 Fixes #261
* Corrected the skill behavior of Elemental Shield to match official.
- Thanks to @exneval and @Barigas.
2015-06-08 10:53:41 -04:00
aleos89
ba1a1aec48 Bug Fixes
* Translated the Kagerou/Oboro skill names in the skill_db.
* Added Critical Food type for newer items.
* Water Barrier should only reduce Weapon ATK and Flee.
* Illusion - Bewitch should not be able to move MVPs.
* Spider Web will no longer be deleted when the target escapes from it. (bugreport:1358)
* Adjusted Absorb Spirits to work in duels. (bugreport:4085)
* Clementia, Canto Candidus, and Praefatio will now cast on the party even if someone is wearing a Holy-type armor. (bugreport:6835)
* Masquerade - Gloomy will now remove a Homunculus who have less than 80% HP. (bugreport:8886)
* Players under the effect of Illusion - Shock will now be able to move and attack. (bugreport:8903)
* Deadly Infection should only pass Guillotine Cross poisons through the Shadow Chaser's attacks only. (bugreport:8968)
* Unlimit now gives the proper statuses when reducing DEF and MDEF. (bugreport:9181)
* Water Screen will now heal 1,000 HP every 10 seconds. (bugreport:9184)
* Tinder Breaker will now properly lock targets. (bugreport:9202)
* Corrected Weapon Blocking SP drain timer from every 3 seconds to 5 seconds. Moved Combo timer to skill_cast_db. (bugreport:9203)
* Players under the influence of Kaite will receive a flat 400% more damage from melee attacks (renewal only). (bugreport:9231)
* Release will now check the preserved skill's SP requirement before releasing. (bugreport:9333)
* Fixes #417 - Charge Attack has a range of 14 cells and can do up to 500% damage.
* Fixes #419 - Magnum Break should not hit hidden targets.
* Fixes #421 - Tension Relax should only increase healing at 1x rate when overweight and 3x when not overweight. Also corrected icon getting removed after a few seconds while sitting.
* Fixes #427 - Auto Guard will force a player to stand when being targeted to avoid client desync.
* Fixes #436 - Corrected Super Novice Spirit not allowing any headgear to be equipped.
* Fixes #438 - Soul Linker's Rebirth Spirit should have a fixed cast of 1 second.
2015-05-22 10:08:16 -04:00
aleos89
231710c0fa Bug Fixes
* Fixed #119 - Corrected Flash Combo weapon ATK and to cancel skill cast when target is more than 2 cells away.
* Fixed #148 - Corrected Kings Grace to only cast on guild members in versus type maps and added missing effects. Updated cooldown from 60 to 90 seconds.
* Fixed #341 - Offertorium and Magnificat now cancel each other out (Mimics Kyrie Eleison and Assumptio).
* Follow up to 5a0f8dc. Added missing monster transformation bonuses.
* Updated the Status Icon list with newer icons.
2015-03-18 15:12:02 -04:00
aleos89
9f6f55c07c Bug Fixes
* Fixed #167 - Dragon Breath burning chance is now 15% for all levels. Also corrected damage calculation. Thanks to @exneval.
* Fixed #270 - Cleaned up Reverberation and how it's triggered.
* Fixed #321 - Follow up to 1b6be4e. Fixed MATK calculation for for all player, monster, homunculus, mercenary, etc.
* Fixed #332 - Camouflage now hides player from targeting skills. Added missing DEF/DEF2 bonus.
* Fixed #335 - Check to make sure script has data before trying to free null values.
* Fixed Full Throttle SP drain amount and movement speed increase value. Updated cooldown value to 30 minutes.
* Fixed Bloody Lust skill type from magic to none.
* Fixed Mix Cooking, Make Bomb, Special Pharmacy, Change Material, and Rune Mastery success and fail animations.
* Cleaned up some more compile warnings.
2015-03-13 17:49:38 -04:00
Playtester
ad8e22139f Kaahi and Arrow Shower RE fixes
- Removed Kaahi timer system (fixes #320)
* Kaahi will now heal BEFORE the damage is dealt
* Heals will no longer get lost due to timer system
* Decreased Kaahi duration 1800->350 seconds
- Implemented recent Arrow Shower Renewal updates (fixes #310)
* Arrow Shower now has 3x3 AoE on level 1~5 and 5x5 AoE on level 6~10
* Arrow Shower now has a fixed after cast delay of 500ms
* Note: The bug that causes the skill to hit twice is still present (couldn't fix it)
2015-03-07 19:27:49 +01:00
aleos89
083cf5d962 Bug Fixes
* Fixed Severe Rainstorm not being able to be copied by Reproduce. (bugreport:9361)
* Fixed #137 - Updated Homunculus S Race and Element values to official.
* Fixed #163 - Proper renewal calculations for Homunculus. Merge from HerculesWS/Hercules@8faef4f
* Fixed #254 - Corrected King's Grace cooldown to be 60 seconds.
* +20 Foods cannot be dispelled or removed by death.
2015-02-10 12:13:08 -05:00
Playtester
04a1173f7d Plant damage, Land Mine, minor fixes and improvements
- Fixed up the damage code in regards of damage against plants (bugreport:9380)
  * Rewrote DAMAGE_DIV_FIX so that it rounds damage down when number of hits is negative (damage split on hits)
  * Created a function battle_apply_div_fix that does not only call DAMAGE_DIV_FIX but also makes sure that damage can only become 0 when the custom config setting skill_min_damage is not set for the current skill type
  * skill_min_damage is now 0 by default (official: all types can fail against plants as long as skills have negative number of hits), if set, all skills will deal as much damage as hits
  * Restructured and renamed function now known as "is_infinite_defense" that will work for all 3 damage types and returns if damage is infinite for the current situation, it will now also properly consider all "MD_IGNORE" modes
  * Fixed the order of processing of all 3 skill types in regards of plant damage: first all calculations are done, then plant damage is applied and then DAMAGE_DIV_FIX is applied
  * Sonic Blow and Rapid Shower are now skills with negative number of hits (i.e. they can't hit plants officially)
  * Traps can no longer ignore plant mode (only way to damage plant more is via status changes)
  * Final Strike is now able to hit plants (deals 1 HP damage)
  * When left-hand-wielding, you will now always deal 2 damage to plants per attack, regardless of whether double attack triggers or you don't even have a weapon in the right hand
  * There will no longer be backhand damage to plants (Katar)
- Land Mine is now a single target skill, the trap still triggers in a 3x3 area, but will only hit the first target that touches it (issue:99)
- Changed the "Don't return reflect damage" flag from 0x1000 to 0x1000000 as apparently the other flag was already used; updated function description so it's easier to see
- Improved SC_SIGHTBLASTER structure slightly
- Typo fixes and description improvements
2014-11-07 23:28:54 +01:00
Playtester
902c920b73 Knockback, stop effects and Skid Trap reworked, monster chase and direction updates, code optimizations
- Created a new function unit_blown_immune that will now serve as the central function to determine if an object can be knocked back or stopped (bugreport:7637)
  * Moved the check code from skill_blown to unit_blown_immune
  * Several stopping effects and traps will now use unit_blown_immune to check if the object can be stopped, if not, the object will always move to its target cell before stopping
  * Bosses and monsters immune to knockback will now no longer be stopped by such traps
  * Expanded the configuration skill_trap_type and moved its checks into unit_blown_immune, so it's possible to switch the "no stop" behavior off for GVG/BG and monsters individually
  * Long-term we should make all skills use this function to check for knockback immunity, it will make the checks a lot cleaner and more centralized
- Monster chase range updates (bugreport:7637)
  * Updated monster_chase_range in monster.conf from 1 to 3; I originally thought official value is 1, but doing some in-depth tests myself I realized it's 3 for the most important situations
  * When a monster cannot issue new "move" commands because it was affected by a status change, but is still moving due to knockback immunity, it will no longer unlock its target and stop
  * Fixed a bug that always caused the chase path monsters calculated to be 1 cell too short causing them to recalculate their path one cell before their goal every single time
- Fixed the direction calculation once again and optimized it at the same time (bugreport:9373)
  * Now the calculated direction is 100% official, really truly, checked it myself with every single cell and various skills
  * Added a new function map_calc_dir_xy that allows to check for a direction between two cells without the need of a block_list
  * map_calc_dir will now just use map_calc_dir_xy to avoid duplicate code
- Implemented Skid Trap properly (bugreport:9373)
  * The direction of the knockback will now be "away from position of the caster during cast" rather than "away from trap"
  * Skid Trap will now stop the target for 3 seconds; this works even in GVG/BG and on bosses, even though the actual knockback doesn't happen
2014-10-30 20:12:18 +01:00
Playtester
b89b669325 Combo skill updates
- Cleaned up skill_combo so it's easier to understand and update
- Monk updates (bugreport:9364, bugreport:4534)
  * Default combo delay is now (1000 - 4*AGI - 2*DEX) milliseconds, it will be used when none is specified in the skill_cast_db.txt
  * Fixed DEX increasing combo delay rather than decreasing it
  * Fixed "Triple Attack" not giving any "can act" delay so you were able to use a skill right when it triggered
  * Fixed combo delays of all combo skills (turns out they all use the default in both pre-re and re!)
  * Fixed "Palm Strike" in renewal having cast time rather than cast delay
  * Monk Spirit now reduces the SP cost of all Monk/Champion combo skills to 2 SP
- Taekwon updates (bugreport:9364)
  * Stances will no longer give you walk delay when they trigger
  * You can still use the Kick after moving as long as it's still within the combo delay
- Hunter updates (bugreport:9082)
  * Beast Strafing is now a target skill, you can target any brute or insect monster with it regardless of your previous target
  * You no longer need to target a brute or insect monster with Double Strafe for the combo to trigger
  * If the combo triggers you no longer get walk and attack delay (that means you can still use DS continuously)
  * You can still use Beast Strafe after moving as long as it's still within the combo delay
2014-10-27 20:02:43 +01:00
Playtester
b88e95381d Sight Blaster and other skill fixes, magic reflect, crash, trap display and monster behavior fixes
- Fixed cast time of Sightrasher in pre-renewal (700ms -> 500ms)
- Official Sight Blaster behavior (bugreport:6945, partially bugreport:144)
  * Sight Blaster's AoE is now 3x3 even in pre-renewal (it was originally larger so it hits traps before they trigger)
  * Sight Blaster will now prevent traps from triggering as long as they are knocked back
  * Fixed a bug that caused Sight Blaster to not work on traps and ice walls at all
  * Sight Blaster will no longer expire when the attack was reflected
  * Sight Blaster will now expire when hitting an ice wall
  * Sight Blaster will now properly protect you from being attacked from its AoE range
- Sight, Ruwach and Sight Blaster will now check for a target every 20ms (previously every 250ms)
- Step action will now be canceled when being knocked back (skills won't be executed anymore when knocked out of range)
- When knock back magic is reflected it will no longer lead to the caster being knocked back (related to bugreport:6945)
- Activated traps can no longer be hit
- Fixed a problem that left "trap ghosts" forever on the screen when a trap was knocked out of the screen
- Fixed three more potential map server crashes
- Monster behavior fixes
  * Monsters will no longer be able to do normal attacks when hiding
  * If out of any reason a monster on "attack" state can't move and can't do normal attacks, it will now use "attack" state skills
  * The order of monster thought processing is now equal to official servers
2014-10-25 13:13:06 +02:00
Cydh Ramdh
462b2bebdb * Bug Fixes:
-- Added itemstack check when init autotrader (bugreport:9077)
-- 'getitem' issue, gave unidentified item (bugreport:9075), follow up 62a2813
-- Invalid Def & Mdef reduction of SC_ARMORCHANGE & duration (NPC_STONESKIN & NPC_ANTIMAGIC), should be percentage (bugreport:9076)
-- Invalid Effect duration & Reflect chance of SC_MAGICMIRROR (NPC_MAGICMIRROR)
-- Wrong usage of script_isstring() for script commands: addspiritball, delspiritball, & countspiritball
* Misc:
-- Moved mail send progress to mail.c mail_send() from clif.c clif_parse_Mail_send()
-- Moved hardcoded flood protection when send a mail to 'mail_delay' in misc.conf

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-07-01 16:29:19 +07:00
aleos89
62a2813adc Bug Fixes
* Fixed Concentration ending when Frenzy is used. (bugreport:8942)
* Fixed Hells Plant hitting Ghost element enemies. (bugreport:8799)
* Forced guild notice changes to save immediately. (bugreport:8961)
* Fixed Cart Tornado damage formula. (bugreport:9065)
* Adjust Amistr's Castling to now switch to any target type. Still needs skill switching support. (bugreport:1784)
* Removed hard coded 1 second skill duration reduction for Spore Explosion.
* Fixed the party window not displaying the correct map name when in an instance. (bugreport:7949)
* Fixed hatching a pet causing client disconnections. (bugreport:9059) (Hercules 533ff4f)
* Updated Kagerou/Oboro skill cast times. (bugreport:9035)
* Removed deprecated negative nameid value for getitem/getitem2.
* Renamed incuvate to incubate throughout source and SQL.
* Added skill ID to the error display for battle_calc_attack to help resolve issues. (bugreport:8876)
* Cleaned and corrected some Sorcerer Elemental skills. (bugreport:9058)
* Cleaned up some more compile warnings.
2014-06-27 15:45:35 -04:00
aleos89
ce8b98b1f4 Bug Fixes
* Fixed Shield Spell not casting correctly. (bugreport:8948, bugreport:8999)
* Fixed Exceed Break attack increase not being applied. (bugreport:8993)
* Fixed Gentle Touch - Energy Gain not adding spirit spheres. (bugreport:9004)
* Updated Magnetic Field SP drain value.
2014-06-02 09:36:27 -04:00
aleos89
89ef868650 Bug Fixes
* Fixed Extremity Fist sliding issue getting players stuck in un-walkable cells. (bugreport:8949)
* Updated Cursed Circle against the target behavior.
* Updated Tinder Breaker snap behavior.
* Fixed Crush Strike to work with Auto Counter. (bugreport:6919)
* Fixed Fire Expansion - Acid skill animation.
* Fixed Spider Web not trapping targets. (bugreport:8958)
* Feint Bomb cannot be used on top of Land Protector.
* Fixed Slow Grace movement speed penalty. (bugreport:8946)
* Updated Camouflage to official effects.
* Fixed Beyond of Warcry decreasing critical rather than increasing.
* Fixed Zephyr flee bonus to be a solid 25 increase.
* Decrease Agi, Quagmire, Slow Grace, and Adoramus are no longer affected by SC_SPEEDUP1.
* Fixed Warg Strike to be a weapon attack type. (bugreport:8917)
* Fixed Explosion Spirits to double SP regen tick rather than halve SP regen rate. (bugreport:8936)
* Fixed Millennium Shield, Crush Strike, and Refresh having their cooldown values in the wrong field. (bugreport:8957)
* Cleaned up the status change table for 3rd class skills applying/removing SCB's that should/shouldn't be calculated.
* Updated Saturday Night Fever to official effects.
* Updated Berserk damage formula for renewal versus pre-renewal.
* Fixed Masquerade - Laziness not reducing movement speed.
* Updated the behavior of Frigg's Song.
* Updated Light of Regen, Xeno Slasher, and Silent Breeze skills.
* Updated several Homunculus S skill cast values.
* Deadly Infect will now only spread for short ranged attacks.
* Abundance and Guillotine Cross Poisons no longer overlap.
* Fixed Upheaval and Cursed Soil not giving their respective Max HP bonuses. (bugreport:8951)
* Fixed Solid Skin not giving DEF bonus.
* Fixed Stealth Field to properly hide players.
* Burning now reduces MDEF and has an icon.
* Updated the way skills that give equipment attack are calculated. Thanks to exneval.
* Updated the official item delay message.
* Cleaned up some other issues/left overs.
2014-05-14 14:35:24 -04:00
aleos89
1d1a58cdcb Bug Fixes
* Removed unused guild aura leftovers and fixed some other issues with setting the guild aura. (bugreport:8892)
* Fixed Fire Expansion Acid to be a magic type attack. Thanks to exneval.
* Cleaned up some remaining issues with Issen. (bugreport:8905)
* 16th Night (Izayoi) should remove fixed cast time from all skills.
* Circle of Nature is now part of Group B songs.
* Updated Reading Spell Book spell memorization to official.
* Updated homunculus skill cooldowns.
* Added missing Holy element bonus for Hesperus Lit.
* Fixed Coluseo Heal and Praefatio not giving a party bonus. (bugreport:8904)
* Fixed the status icon for ALL_RIDING not being displayed at login.
* Adjusted the notice display order when players login. (Hercules df1952d)
* Self skills can now be used while storage is open. (Hercules 6f6a6b3)
* Cleaned up SC_NOCHAT/Manner system. (Hercules 94ef1ee)
2014-04-16 11:06:09 -04:00
aleos89
06986d6540 Bug Fixes
* Updated Fire Expansion to official effects. (bugreport:8893)
* Updated Illusion Doping area of effect and hit reduction. (bugreport:8560)
* Cleaned up Full Throttle.
-- Thanks to exneval.
2014-04-13 15:46:49 -04:00
aleos89
0bbfdfbd85 Bug Fixes
* Fixed Gentle Touch - Energy Gain not gaining spheres. (bugreport:8882)
* Adjusted Full Throttle's cooldown to be 30 minutes. (bugreport:8887)
* Warmth of the Sun/Moon/Stars are now placeable on Land Protector. (bugreport:175)
* Fixed Mechanic's Axe Mastery to give (4 * skill level) ATK bonus for Mace weapons.
* Cleaned up Cart Boost and Camouflage bonus damage.
* Fixed Envenom pre-renewal bonus damage missing. (bugreport:7953)
* Fixed Eska not reducing movement speed. (bugreport:2792)
* Fixed Marsh of Abyss reducing movement speed below 50%. (bugreport:7424)
2014-04-10 11:15:30 -04:00
aleos89
81ca299d91 Bug Fixes
* Fixed Overbrand swing damage ground placement. (bugreport:8856)
* Fixed Wug Dash not getting ATK bonus from Tooth of Wug.
* Cleaned up Gates of Hell damage formula.
* Corrected Hell Gate skill define to be passive.
* Added missing immobilization duration reduction for Poem of Netherworld and blocked it from working on MVP. (bugreport:8877)
* Cleaned up NPC_RUN to show e_hlp and not get stuck in a follow state. (bugreport:8875)
* Fixed item bonus DefRatioAtkEle/DefRatioAtkRaceDefRatioAtkClass not working for left handed weapons. (bugreport:8495, bugreport:8808, bugreport:8847)
* Fixed SubSize/SubRace/SubClass stacking to create 100+% immunity. Thanks to @cydh. (bugreport:8827, bugreport:8879)
* Small cleanup to clif_parse_StatusUp.
* Fixed Sling Item to copy the source skill ID and not the dummy ID.
* Fixed spirit spheres not giving ATK bonus. (bugreport:8130, bugreport:8285, bugreport:8686)
* Acid Demonstration is now forced to neutral in renewal.
* Follow up to e2d2494 to fix cooldown for Unlimit.
* Follow up to e2d2494 to clean up some compile warnings.
* Follow up to da0da73 to fix SC_ITEMSCRIPT to only use an icon if val2 is not empty.
2014-04-09 10:10:32 -04:00
aleos89
e2d2494e13 Bug Fixes
* Fixed Main Frame Restructure not giving DEF bonus when wearing Madogear. (bugreport:8863)
* Updated some more damage formulas for Kagerou skills.
* Fixed critical damage bonus from Monster Transformation system.
* Fixed Fire Trap and Ice Trap Burning/Freezing chance.
* Cleaned up the visual effects for Ranger traps.
* Odins Power now decreases DEF/MDEF by 40 at level 2. (bugreport:8869)
* Added skill define for Overbrand's Plus Attack.
* Fixed an issue with Overbrand's pierce damage placement. (bugreport:8856)
* Fixed Unlimit not updating DEF/MDEF on players and increased the cooldown to 5 minutes. (bugreport:8870)
* Few status icon updates.
* Fixed two compile warnings when the VIP system is enabled.
2014-04-04 15:37:29 -04:00
aleos89
26afd769ce Bug Fixes
* Fixed Chorus songs causing the map server to crash. (bugreport:8817, bugreport:8819)
* Updated renewal Arrow Shower area to be 5x5 for levels 6-10.
* Neutral Barrier should effect all targets and only block Earth Quake splash damage.
* Only party and guild members should be affected by Stealth Field.
* Fixed Cloud Kill layout to be 7x7.
* Feint Bomb should explode after half a second.
* Fixed Fire Rain unit ID causing Fire Wall, Ice Wall, and other unit skills to display improperly. (bugreport:8775)
* Updated the effects of Banana Bomb, Concentrated White Potion Z, and Vitata 500.
* Fixed Gentle Touch - Revitalize HP regeneration calculation.
* Fixed Gentle Touch - Change making MDEF go below 0 and doing too much damage. (bugreport:8690)
* Fixed Gentle Touch - Energy Gain not adding spirit balls when doing damage.
* Fixed Gentle Touch - Cure to heal players who are wearing a shield with the Golden Thief Bug card. (bugreport:8815)
* Fixed Tear Gas /sob emoticon not stopping when the skill ended.
* Fixed Kagerou/Oboro charms not applying to specific skills. (bugreport:8823)
* Updated some other Kagerou/Oboro skills. Thanks to idAthena.
* Players will stop attacking when forced to sit through skill_sit. (bugreport:8796)
* Fixed Extremity Fist not removing natural SP regen flag and adjusted the icon to show for the 5 minute duration. (bugreport:8811)
* Implemented the official effect for Chaos Panic. (bugreport:8520)
* Fixed a small typo for the knockback of Crescent Elbow.
* Fixed Cross Slash not checking for players wearing Shields + Dagger/Sword. (bugreport:8797)
* Synced up the 3rd class pre-renewal skill database files with the renewal skill database files.
2014-03-28 15:12:23 -04:00
aleos89
1f26499994 Bug Fixes
* Fixed Group A Songs not showing their respective skill animation. (bugreport:7379)
* Fixed Cart Revolution pushing targets East rather than West. (bugreport:8806)
* Chemical Protection should not remove Strip status. (bugreport:8807)
* Concentration now casts Endure. (bugreport:4262, bugreport:8756)
* Fixed the Riding Mount icon not showing up after relogging for Dragons and Mado Gear. (bugreport:8805)
* Crescent Elbow will now knock the target back 8 cells.
* Other miscellaneous cleanups.
2014-03-20 12:59:18 -04:00
aleos89
2dece5586d Bug Fixes
* Follow up to 2cd1e8c compile error. (bugreport:8733)
* Implemented official hiding effect for Feint Bomb. (bugreport:8346)
2014-03-07 15:51:16 -05:00
aleos89
499010d34c Bug Fixes
* Fixed Gates of Hell range check. (bugreport:8680) (Hercules d554d61)
* Updated All Odin Power to official effects. (Hercules d554d61)
* Removed the range check from Hell Gate.
* Sorcerer Insignias are now disabled on Land Protector.
* Fixed Rush Windmill adding BATK rather than WATK.
2014-03-06 13:18:37 -05:00
aleos89
96c768f9b7 Bug Fixes
* Fixed Severe Rainstorm damage formula. (bugreport:8581)
* Caster can no longer switch equips for the duration of Severe Rainstorm. (bugreport:8581)
* Cleaned up Demonic Fire and Fire Expansion combos. (bugreport:8620)
* Fixed Dragon Breath - Fire/Water damage formula and not being reduced by DEF or Flee. (bugreport:8620)
* Fixed the movement speed formula for Camouflage. (bugreport:8619)
* Fixed Overbrand Brandish area damage. (bugreport:8627)
* Fixed cast time for Magical Amplification.
* Fixed Moonlit Serenade MATK increase. (bugreport:8697)
* Fixed Phantom Thrust not casting. (bugreport:8652)
* Fixed Gentle Touch - Cure healing formula. (bugreport:8699)
* Fixed Wall of Thorns not dealing damage to players who touch it. (bugreport:8673)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8286)
* Fixed Feint Bomb damage formula. (bugreport:8593)
* Fixed Circling Nature HP recovery and SP consumption being reversed. (bugreport:8670)
* Fixed Judex area of effect to be 3x3. (bugreport:8672)
* Fixed Abracadabra skill "Summon Monster" not displaying the monster's name. (bugreport:8671)
* Fixed Sight Blaster duration. (bugreport:8656)
* Fixed Ignition Break area of effect damage. (bugreport:8653)
* Fixed Poem of Netherworld not immobilizing enemies. (bugreport:8607)
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Adjusted Tiger Cannon damage formula and allow to bypass target's flee. (bugreport:8625)
* Fixed Self Destruction not working on self. (bugreport:8633)
* Fixed Repair not healing or consuming item requirements. (bugreport:8633)
* Fixed Silver Sniper and Magic Decoy AI types not being counted towards the land skill limit. (bugreport:8407)
* Fixed Silver Sniper bonus ATK formula.
* Fixed Magic Decoy maximum HP formula.
* Fixed Lion Howling damage formula. (bugreport:8654)
* Fixed Rapid Throw (Muchanage) damage formula. (bugreport:7861)
* Stasis no longer allows casting of Chorus skills.
* Fixed Chorus skills not checking for additional partners. (bugreport:6052)
* Body Paint no longer removes Chase Walk or Invisibility. (bugreport:6801)
* Recognized Spell is no longer cleared by Dispell or Abundance. (bugreport:6718)
* Epiclesis now removes Cloaking Exceed and will heal while in the Frenzy state. (bugreport:6679)
* Renovatio now heals while in the Frenzy state. (bugreport:6679)
* Fixed Firing Trap not having the fire element. (bugreport:8707)
* Fixed Icebound Trap not having the water element. (bugreport:8707)
* Fixed Axe Tornado not doing less damage for targets outside of the 5x5 area of effect.
* Updated the list of effects that Inspiration makes the caster immune to. (bugreport:5735)
* Cleaned up the effects of Vacuum Extreme to work as it should in GvG maps. (bugreport:6031)
* Corrected durations for Millennium Shield, Crush Strike, Refresh, and Weapon Crush.
2014-02-28 15:18:45 -05:00
Cydh Ramdh
b9c64659f7 Some fixes for bugreport:8633 http://rathena.org/board/tracker/issue-8633-about-this-commit-skills/
- Added some dummy Skill IDs tp skill_copyable_db.txt
- Demonic fire doens't have duration for lv 2 and 5
- Typo on skill_require_db.txt for Siena Execrate

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-12 19:13:57 +07:00
aleos89
4019fb4531 Bug Fixes
* Dragon Breath (Fire and Water) are no longer reduced by DEF or Flee. (bugreport:8378)
* Crush Strike no longer ignores caster's % damage cards.
* Phantom Thrust is now single enemy targetable.
* Fixed Gates of Hell SP cost, range, and sphere cost. (bugreport:7898)
* Cleaned up Tiger Cannon splash damage and remaining HP/SP consumption. (bugreport:8538)
* Fixed Rising Dragon HP/SP regen to work with Spiritual Cadence.
* Corrected Magic Decoy item requirement define not checking for PTS.
* Poem of Netherworld now targets everyone except party members. (bugreport:7741)
* Adjusted a couple skills that have infinite timers to not displays negative time to the client. (bugreport:8549)
* Fixed Sorcerer's Spirit max HP formula. (bugreport:8315)
* Fixed Banding not giving the Overawe effect. (bugreport:7641)
* Fixed Weapon Crush not casting at all. (bugreport:8583)
* Fixed Demonic Fire damage formulas from Fire Expansion.
* Fixed Fire Expansion - Smoke Powder not giving ranged and melee damage reduction. (bugreport:7841)
* Fixed Fire Expansion - Tear Gas not draining HP and not displaying the /cry emoticon. (bugreport:7841)
* Fixed Issen (Killing Stroke) damage formula for pre-renewal. (bugreport:4071)
* Adjusted Warg Strike to be a misc type attack and ignore target's Flee. (bugreport:7599)
* Updated Throw Kunai damage formulas for renewal and pre-renewal. (bugreport:7119)
* Severe Rainstorm is no longer castable on Land Protector. (bugreport:7097)
* Fixed Tropic, Chilly Air, Wild Storm, and Upheaval options not casting their specific autocast skills.
* Updated Fire Cloak, Water Drop, Wind Curtain, and Stone Shield to 100% property resistance and damage.
* Updated Heater, Cooler, Blast, and Cursed Soil damage formulas.
* Increased SP cost of Psychic Wave when Heater, Cooler, Blast, or Cursed Soil are active.
* Updated Zephyr Flee increase bonus.
* Fixed Elemental HP and ATK2 formulas.
* Fixed Sienna Execrate not consuming 2 Red Gemstones. (bugreport:7494)
* Fixed Shadow Chaser's Masquerade skills success rate formula. (bugreport:7436)
* Fixed Exceed Break to restore walk speed when cast is cancelled. (bugreport:7681)
* Vacuum Extreme no longer affects users who are in Hallucination Walk.
* Fixed Hallucination Walk missing magic avoidance.
* Adjusted Lif's Mental Change skill duration to 1 minute, 3 minutes, and 5 minutes respectively per level.
* Hovering will now specifically ignore Skid Trap, Land Mine, Ankle Snare, Flasher, Shockwave Trap, Sandman, Freezing Trap, Blast Mine, Claymore Trap , Quagmire, Gravitation Field, Volcano, Deluge, Whirlwind, Watery Evasion, Electric Walk, Fire Walk, Vacuum Extreme, Windmill, and Moon Slasher. (bugreport:7179)
* Raging Trifecta will now display an animation on usage. (bugreport:1307)
* Cleaned up Auto Shadow Spell check for the specific skills it can cast. (bugreport:8582)
2014-02-06 13:34:39 -05:00
aleos89
0f7ecd0c4d 3rd Class 2011 Post Balance Update
* Contains remaining formula updates for 3rd class skills.
* There are a few bug fixes and corrections to broken skills.
2014-01-10 10:36:53 -05:00