This prevents a signed/unsigned integer overflow when calling the safestrncpy function.
Also added a note regarding a potential out-of-bounds access issue in these functions.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13690 54d463be-8e91-2dee-dedb-b68131a5f0ec
This would cause object ids (chatrooms / ground items) to never be removed when DEBUG_MEMMGR was turned on, ultimately causing a 'no free object id' fatal error.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13689 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Expanded and corrected the land skill view id enum in skill.h
- Renamed UNT_ATTACK_SKILLS to UNT_DUMMYSKILL and UNT_KAENSIN to UNT_KAEN (official terminology)
- changed GS_DESPERADO to use the UNT_DUMMYSKILL view id instead of UNT_KAENSIN (and is it supposed to be a land skill at all?)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13688 54d463be-8e91-2dee-dedb-b68131a5f0ec
Script text input packets of length 8 are now also invalid since there must be at least a zero byte (end of string) present.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13680 54d463be-8e91-2dee-dedb-b68131a5f0ec
- it always gets blocked by Pneuma, but never by Safety Wall
- Defender doesn't reduce its damage
- Range-Def item bonuses reduce its damage
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13672 54d463be-8e91-2dee-dedb-b68131a5f0ec
- "cooking exp" still needs to be implemented
- also fixed a small issue when whispering to someone in autotrade
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13671 54d463be-8e91-2dee-dedb-b68131a5f0ec
- mobs will no longer get scattered across the whole map as soon as the last player leaves
- mobs will now random-walk indefinitely even if there are no players on the map (might have a performance impact)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13664 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Clarified char_maintenance config option.
* Changed packet 0x2712. (added request_id)
* Changed packet 0x2713. (added sex, request_id, version, clienttype; removed email, expiration time, gmlevel)
* Delayed user count check and mmo_char_send006b to when the account data arrives.
* Created auxiliary function MD5_Salt.
(split from a future commit that was getting to big for my taste)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13652 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Removing the custom guild packets from Battleground as they are not needed anymore.
- Scripts updated.
- In this way, you get "battle cursor" over your same team, but that's how official does.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13635 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed the last commit about Assumptio, it's only player to monsters, but it can be used on mercenaries.
- Added new JapanRO pets.
- Fixed Valorous Assaulter's Katzbalger missing str bonus.
- Medal of Mage (battleground reward) can also be used by Soul linkers.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13631 54d463be-8e91-2dee-dedb-b68131a5f0ec
Added script command 'cooking' to activate this window and applied it to the 5 cooking kit items.
Renamed the cooking quest variable to cooking_q to avoid a naming collision with the new script command.
(You need to manually rename all occurences of this variable in your txt-savefile/sql-database if you want to preserve player progress.)
The code still relies on the messy skill_produce_mix logic and still uses completely custom equations. To be fixed in a separate commit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13628 54d463be-8e91-2dee-dedb-b68131a5f0ec
For some reason, packet lengths as high as 0x43f are not reading properly, despite being fine in the packet database.
It works fine right now, but it should be changed when the packet database reading is fixed.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13622 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Execute script on skill (bonusautoscript3)
* Add effect on skill (bAddEffOnSkill)
* Execute skill on skill (bAutoSpellOnSkill)
- Fixed some boxes Rental time according to item descriptions.
- Implemented SC_ITEMSCRIPT, a status that gives you temporally the effect of an item. Check items 14597 to 14605 if you want to get the idea.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13596 54d463be-8e91-2dee-dedb-b68131a5f0ec
* 1 = no scoreboard (as Tierra Valley is).
* 2 = scoreboard enable (as Flavius and KvM requires).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13594 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Implemented the scoreboard packets (thanks to Pakpil).
- Updates to Tierra Valley according to official info.
* There are no barricades around each base, barricades are in the middle left path.
* There is another graveyard used for the owners of the middle base, with faster spawn (each 20 seconds).
* I added a flag respawn in the middle, currently I don't know if this if official or not, but it allows each team recapture the middle base.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13593 54d463be-8e91-2dee-dedb-b68131a5f0ec
