4608 Commits

Author SHA1 Message Date
Inkfish
ea6005e4bf Oops, I messed up the condition on my last commit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13845 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-05 08:40:26 +00:00
Inkfish
dc7f470790 * Fixed turning off a skill needed to meet the requirements. (bugreport:3175)
* Skills used through items not having aftercast delay or cast time now don't overwrite the former canact_tick. (topic:220921)
* Multiple autoscripts now can trigger at once.
* Applied a temp fix for autoscripts crashing server.(bugreport:3154)
* Implemented SC_JEXPBOOST (thanks to GMJobbie for the diff). (bugreport:3177)
* Implemented SC_IGNOREDEF. (topic:217330)
* SC_DEFRATIOATK won't affect boss monsters. (topic:217330)
* Fixed skip_teleport_lv1_menu made lv2 skip menu as well. (bugreport:3183)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13844 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-05 00:22:12 +00:00
L0ne_W0lf
7807036efd * Updates to ST_PRESERVE and a few other minor details!
- Recasting Preserve no longer toggles the skill off while active.
- Preserve is no longer saved on log-out or mapserver changes.
* Added SC_CRITICALWOUND and SC_SLOWCAST to negative statuses not saved with battle_config.debuff_on_logout&1
* Implemented the skills NPC_HELLPOWER and NPC_WIDEHELLDIGNITY, as per my personal experiences with the skill on iRO.
* Increased MAX_MOBSKILLS to 50, as Satan Morroc has over 40 active skills now.
* Added skill information for NPC_HELLPOWER and NPC_WIDEHELLDIGNITY, and enabled skills in mob_skill_db.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13843 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-04 22:46:14 +00:00
Inkfish
e7faa7e498 * Some clean ups on autocast and itemskill code. (see topic:220921 for some info)
- Autocasted Teleport now skips the menu.
- Fixed nullpo info when defensive autocasts are triggered. (follow up to r13815)
- Fixed Warp portal used in item script never worked.
- Item skills now bypass skill delay check.
- Implemented SM_SELFPROVOKE. 
- Updated item db using 'itemskill' for some items.
* Basic skills will never be reset. 

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13841 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 15:30:11 +00:00
L0ne_W0lf
c778107ca8 * Implemented the Party Buff cash skills.
* Misc updates, and updates for party buff items.
- Added CASH_BLESSING, CASH_INCAGI and CASH_ASSUMPTIO skills.
- Added itemskill commands for the party buff scrolls.
- Corrected Equipment repair book's itemtype to 11.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13840 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 03:28:20 +00:00
Inkfish
e06e7945aa Fixed normal casted Teleport always skip menu.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13839 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 00:07:38 +00:00
Playtester
cd381ab1a3 * Fixed Mystical Amplification having unlimited duration
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13838 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-02 19:35:32 +00:00
Inkfish
cf43afb4c9 Fixed skills used through items and Hocus-pocus consume requirements if you have them. (bugreport:3164)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13836 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-02 11:48:33 +00:00
Inkfish
efb13f2571 Fixed Fiberlock sometimes fails due to the long interval of skill_unit_timer. It may never fail now, though this may not be official. (bugreport:3136)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13834 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-01 14:01:42 +00:00
brianluau
e21b25987b - Fixed an off-by-one array index in r13815 that caused skills to use SP for (SkillLV+1). (bugreport:3152)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13830 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 21:23:03 +00:00
Inkfish
47c650a49a * Fixed gemstones are still required when players equipped Mistress Card. (bugreport:3147, follow up to: r13815)
* Fiberlock only catches targets the moment its casted. (bugreport:3136)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13829 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 13:54:49 +00:00
Inkfish
dcb4f2b931 Fixed 'n_ele' not initialized and a typo in the Changelog.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13828 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 11:55:59 +00:00
Inkfish
98cfff889a * Multiple autocasts can go off at a time now. [Inkfish]
* Splash damage doesn't get modified by percentual modifier now. [Inkfish]
* Monster's Spiral Pierce is again...non-elemental. [Inkfish]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13827 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 10:01:08 +00:00
Inkfish
8bd4ae799e * Fixed Hocus-pocus always fails. (bugreport:3143, follow up to: r13815)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13826 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 02:43:44 +00:00
Inkfish
f090bdbdbc * Added a new battle flag for telling which skills can have bHealPower effect.
* Added documentation for bHealPower.
* Fixed some behaviors for healing skills, (thanks to L0ne_W0lf)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13821 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 14:25:14 +00:00
Inkfish
ac5aa55ae7 * Added new bonuses bHealPower and bHealPower2.
* Heal skills code clean up. 
- bSkillHeal can affect offensive heal now. 
- bSkillHeal2 can affect AppleIdun and SlimPitcher now.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13820 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 12:21:59 +00:00
Inkfish
766143d109 Added new bonuses bUnbreakableGarment and bUnbreakableShoes.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13819 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 06:45:58 +00:00
Inkfish
586fdbcfdf * Some more fixes to skill condition issues.
- Fixed skills fail when MAX_INVENTORY reached. (bugreport:3139)
- Fixed spiritballs not being removed correctly in some situation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13818 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 02:25:38 +00:00
Inkfish
a4c36c7af8 Hmm...fixed my last commit making Tarotcard ignore sp requirement.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13817 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-28 11:11:38 +00:00
Inkfish
61c0d7b744 * Fixed some issues of skill condition check.
- HP is now checked at the end of cast.
- Lv 6-10 StoneCurse doesn't consume gems.
- Tarotcard's after-cast delay will still be applied if it fails.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13816 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-28 11:00:22 +00:00
Inkfish
b14a11ff5e * skill_check_condition clean up (bugreport:2770, bugreport:2957, bugreport:3010)
- Weapon, SP, HP and state are checked at the beginning of cast.
- Required items and ammos are checked at the end of cast.
- SP and status change required are removed at the end of cast without checking again.
- Required items are removed only if the skill is successfully used.
- Autocasts won't check for requirements but will remove them if you have them(except for SP/HP).

Hope won't cause any problems...

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13815 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-27 14:11:08 +00:00
Inkfish
d7d626e578 Now we can use 'boss_monster' to summon whatever monsters that need to be radared by Convex Mirror. (bugreport:2653)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13813 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-25 13:05:59 +00:00
Inkfish
c61942c8cd Fixed losing skill list after base change. (bugreport:3106)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13812 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-25 10:32:06 +00:00
ultramage
e8e8e35eed Fixed crash when attacking while having a bBreakArmorRate item equipped (typo in r13800) (bugreport:3121).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13810 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-24 20:41:39 +00:00
Inkfish
36ae721899 Taro Card can now break shoes and garment and won't affect dead target. (bugreport:2513)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13808 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-24 04:58:40 +00:00
Inkfish
579f0a250d Splash attacks do cause additional effects except for autocasts. (bugreport:2661)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13804 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-23 03:25:33 +00:00
Inkfish
45addf32f8 NPC_STOP now stops both sides and will be canceled if either side teleports or dies.(bugreport:3099)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13803 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 15:36:41 +00:00
Inkfish
5815851acf * The delay icon doesn't appear during casting now. (bugreport:3101)
* Status icon of ASPD potions doesn't overriding each other now.(bugreport:3095)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13802 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 13:24:16 +00:00
Inkfish
e19735da51 Splash attack doesn't cause any status effects or autocasts any more.(bugreport:2661)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13801 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 12:14:54 +00:00
Inkfish
d8a02e92eb * Fixed some behaviors of additional effects (bugreport:3100,bugreport:2661)
- Coma can now be blocked by such skills as SafetyWall, Pneuma and Basilica.
- Equipment breaking behaves exactly like coma.
- Skill's self damage may now causes coma, equipment breaking and autospell/autoscript.
- GrandCross now allows you to drain hp/sp.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13800 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 08:37:13 +00:00
Inkfish
f3572b9e6d * Now fiberlocking a fiberlocked target doesn't renew the timer but instead increases its fireweakness [Inkfish]
- This makes doublecasting firebolts on a double fiberlocked target having double damage from both 2 bolts possible = =(bugreport:3061)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13799 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-20 12:42:06 +00:00
skotlex
64972e4b5a - Updated NPC_DRAGONFEAR to supposedly behave as it should
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13797 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 19:14:12 +00:00
ultramage
13114498f0 Rigged the r13676 modification of battle_calc_weapon_attack to make neutral element reductions work again (bugreport:3097).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13795 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 14:37:10 +00:00
Inkfish
6e54839512 Fixed the three hits of EarthQuake not being calculated seperately.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13794 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 10:34:43 +00:00
Inkfish
2b1109483f * Miracle should only be dispelled on map change.
* The "party invite" and "view equip" state messages are ought to be sent on every map change instead of login.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13793 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 10:06:05 +00:00
Inkfish
dbb4774882 Fiberlock now can trap multiple enemies on the same cell and its triggering area was reduced to 1x1.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13792 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 09:13:23 +00:00
Inkfish
47f91b6387 Added missing packet 0x2c9 and fixed 0x2da's length error
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13791 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 08:58:08 +00:00
Playtester
0affe1454c * Item-bonuses and NPC skills now use the official default durations for status changes
- you gain Curse immunity if you have 0 Luk (seems buggy but is official)
- our status defense stats are already fully correct :-)
- thanks to ultramage for testing this

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13790 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 20:45:44 +00:00
ultramage
7f18f11403 status calc code cleanup
* Inverted the status calc code order, so that status_calc_bl optionally invokes status_calc_pc/mob/whatever instead of every status_calc_* calling status_calc_bl.
 * Inlined functions status_calc_bl_sub_pc, status_calc_bl_sub_hom and status_calc_bl_sub_mer into status_calc_bl.
 * Restructured status_calc_bl to require as little bl type-specific branching as possible.
 * Split status_calc_bl into two layers - the inner does the battle status calculations, while the outer deals with running appropriate base status calculations, remembering old values and handling client updates.
 * The status_calc_bl function is now the single entry-point for all status calculations.
 * status_calc_bl will now trigger a client update only on attributes that actually changed.
 * If hp or sp changes during status_calc_bl, it will now properly refresh on the client.
 * Removed SCB_PC, now SCB_ALL should be used instead.
 * Revived the unused status calc flag SCB_BASE to indicate that a base status recalculation should be done first (that's what the status_calc_* functions are for).
 * Defined a new symbolic bitmask SCB_BATTLE (SCB_ALL - SCB_BASE) in case someone needs to only calculate the battle status (currently unused).
Please report any issues with this update.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13789 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 07:24:58 +00:00
ultramage
046c8f501f Removed the optional target parameter from atcommand_homshuffle, since the standard #-charcommand mechanism exists for this very purpose (code from r9671).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13788 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 20:36:05 +00:00
skotlex
0fa2e82da2 - Fixed a couple of crashes that could ensue from the last memory corruption fix to free'ing clones.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13787 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 20:24:45 +00:00
Inkfish
a8fda75bb0 * Eske and Eska now affect friendly guardians and slaves. (bugreport:2131)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13786 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 16:11:05 +00:00
Playtester
4e49aad859 * Some fixes to the previous commit (apparently it didn't compile with VS 2008)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13785 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:43:59 +00:00
Playtester
6bf346a172 * Monocell, Instant Death and Class Change will now fail on bosses (bugreport:2907)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13783 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:04:20 +00:00
Playtester
3c7f50114c * AutoSpellWhenHit now triggers on normal+skill by default (bugreport:1652)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13777 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 16:41:27 +00:00
ultramage
34def63ece Cleaning/fixing the previous commits a bit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13775 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 11:41:40 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
ultramage
3e1d1414ae Changed the type of the 'first' parameter of status_calc_pc/mob/pet/homunculus/mercenary functions' from integer flag to a simple boolean.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13773 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:49:54 +00:00
ultramage
4acc0932f2 Removed the undocumented custom level feature from monster spawn lines (bugreport:3076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13772 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:33:39 +00:00
Inkfish
1a70b702c8 * More logical modifications on skill_additional_effect thing. Thanks to ultramage.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13771 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-14 16:15:17 +00:00