8752 Commits

Author SHA1 Message Date
Aleos
b19325b842 Corrected mob chat display checks (#2390)
* Fixes #2388.
* Added a validation check when monsters try to talk and attempt to lookup and invalid chat message on skill usage.
* Clones of players will now have no mob chat ID associated to their skills.
Thanks to @M4karov!
2017-08-31 10:15:00 -04:00
aleos
3e51f68570 Adjusted the Achievement Chat Counter
* Fixes #2334.
* Moved the achievement objective update function before the NPC waiting room event trigger.
Thanks to @ClayJensen and @Atemo!
2017-08-29 19:09:41 -04:00
Aleos
e4072e1361 Updated Silvervine Root Twist behavior (#2377)
* Fixes #1139.
* Should be removable by Earth Shaker.
* Removed maxcount limit as it's not a ground skill anymore.
2017-08-29 09:39:52 -04:00
Aleos
515fa6a163 Corrected the Chorus skills damage bonus (#2379)
* Added the missing range value when searching the map.
* Resolves an incorrect calculation in the bonus when less than 8 of the members are a Minstrel or Wanderer.
* Moved the Chorus check to the respective skills to avoid unnecessary calls to the function.
* Added documentation.
* Removed redundancy.
Thanks to @Tokeiburu and @Lemongrass3110!
2017-08-28 19:43:57 -04:00
Aleos
7a1b2e0f0a Cleaned up Item Shop checks (#2373)
* Fixes #2352.
* Removed an extra bound check when selling items.
* Added a check to return failure when unable to delete an item.
* Added checks when counting sellable items in an Item Shop.
- Items that can't be sold, favorite items, rental items, and bound items will now be ignored unless the GM has required permissions.
Thanks to @chadn4u, @Jeybla, @Lemongrass3110!
2017-08-28 10:08:29 -04:00
Aleos
39a5d38b9d Corrected Fatal Menace behavior (#2371)
* Resolves an issue with targets in the Fatal Menace area not getting teleported with the player.
Thanks to @Tokeiburu!
2017-08-28 09:40:23 -04:00
Stolao
9db3c386ea Fix bAddEffOnSkill (#2370)
* Fixes #2357.
* Fixed a copy paste error.
2017-08-25 14:41:15 -04:00
Aleos
4539d557e2 Added script command sc_end_class (#2368)
* Added a new script command sc_end_class to remove status changes from any learned skills.
* Adjusted the custom Reset NPC to make use of this behavior.
Thanks to @sader1992!

* Follow up to f93680b
* Adjusted documentation.

* Follow up to f93680b
* Removed the check from script command resetskill.
* Added a new script command sc_end_class.

* Fixed a compile error
* Corrected the define of the script command.
* Adjusted some documentation.
* Reverted some formatting from the original commit.
Thanks to @sader1992 and @Lemongrass3110!
2017-08-25 13:26:22 -04:00
Lemongrass3110
1fc0ed600f Added support for the all 2017-06 clients 2017-08-21 00:10:06 +02:00
Lemongrass3110
3183c39cfe Fixed 2 compiler warnings
Fixes #2346

Thanks to @hurtsky
2017-08-20 15:01:05 +02:00
Lemongrass3110
6f985080a8 Follow up to 5fdebec
Fixed a typo
2017-08-18 11:49:20 +02:00
Lemongrass3110
5fdebec3af Fixed rebinding of mob view data for killed mobs
Fixes #2351

Thanks to @TesLA-Git
2017-08-18 11:47:40 +02:00
Lemongrass3110
d319ff7ca5 Fixed character creation for expired VIP accounts
Fixes #2333

Thanks to @Everade
2017-08-16 13:50:13 +02:00
Lemongrass3110
4cb4d60fee Fixed return value of unitattack for players
Fixes #2345

Thanks to @anacondaqq
2017-08-16 11:33:35 +02:00
Lemongrass3110
165197d26f Fixed cast time for the npcskill script command
Fixes #2342

Thanks to @Atemo
2017-08-16 09:40:38 +02:00
Jittapan Pluemsumran
bfb92940d5 Fixed std::string reference being an incomplete type in inter.h
Fixes #2339
2017-08-15 11:17:16 +07:00
Aleos
7554b53d68 Adjusted script command gettimestr (#2329)
* Fixes #2328.
* Added an optional parameter to pass in a Unix tick value to convert to a readable format.
Thanks to @hendra814 and @Lemongrass3110!
2017-08-14 13:51:18 -04:00
Lemongrass3110
d673d25978 Fixed another error from mobdb reloading
Thanks to @Everade
2017-08-14 04:22:55 +02:00
Jittapan Pluemsumran
cc1d26fe74 Inter server C++ conversion (#2322)
* Renamed inter.c to inter.cpp and refactored it

* Converted inter_server.conf to inter_server.yml

* Updated the makefiles

* Refactored inter-server storage handling logic

* Fixed a bug with wrong maximum being displayed
When you took out an item of the storage it would always display the maximum amount of the normal storage.

* Fixed a bug with storages that are over maximum

Thanks to @Akkarinage, @Lemongrass3110 and @Jeybla
2017-08-14 01:27:58 +02:00
Vincent Stumpf
f9c6b92a63 Fixes memory leak in char-server (#2335)
Fixes #2330

Allocated memory in various StringBuf instances was being cleared instead of freeing it completely.
2017-08-13 23:44:18 +02:00
Lemongrass3110
a2fc7d51b3 Fixed a PACKETVER mismatch for the random options
Fixes #2332

Thanks to @Milchdealer
2017-08-13 00:30:54 +02:00
Lemongrass3110
37f7fc5708 Fixed memory manager still using SVN revision 2017-08-12 16:50:00 +02:00
Lemongrass3110
dce6ff1bea Fixed a memory leak in the script engine
Returning NPC variables in a user defined script function inside the same NPC does not require to allocate any additional stack.

Fixes #1205

Thanks to @Jeybla
2017-08-11 22:52:51 +02:00
Lemongrass3110
abfd1980de Made view_data for mob unit changes persistent (#2316)
Made view_data for mobs changes persistent

Fixes #2269

Thanks to @Yuchinin
---
Fixed reloadmobdb breaking the view ids

Fixes #2326

Thanks to @karlseven
---
Allowed updating mob's class to a pc class
Fixed sex change so that the client is automatically refreshed
Respawn the monster on clientside if the class is changed

Thanks to @Jeybla and @aleos89 for helping!
2017-08-11 19:27:33 +02:00
Lemongrass3110
b30d0fdf64 New NPC IDs and mob ID placeholders 2017-08-11 00:53:35 +02:00
Lemongrass3110
74cc00f88e Follow up to ac1cf04
Thanks to @CairoLee
2017-08-10 23:33:41 +02:00
aleos
ac1cf0499a Follow up to dcbb2df
* Adjusted the checks to one-line.
* Corrected the map-server from spitting out an error for the achievements import file.
2017-08-08 21:12:20 -04:00
aleos
dcbb2df776 Corrected YAML file parsing
* Fixes #2323.
* YAML file parsing will now properly catch and display warnings when unable to read a file.
Thanks to @CairoLee!
2017-08-08 20:50:09 -04:00
Lemongrass3110
4a28c8c1b0 Follow up to 8310253
Achievement code now matches the Quest code.

Fixed a few small typos and removed some leftovers by @aleos89

Thanks to @CairoLee and @Tokeiburu
2017-08-09 00:45:51 +02:00
Jittapan Pluemsumran
71421a4268 Made global variables in header files extern and implement them in their respective source file. (#2318) 2017-08-08 15:33:39 +07:00
Lemongrass3110
8310253b84 Follow up to ee12429
The incomplete count was not updated before moving the memory that way the counter had the wrong value.
Also the memory manager would complain that the pointer is invalid when we have zero achievements.

Thanks to @CairoLee
2017-08-07 12:54:16 +02:00
Lemongrass3110
34aa59d82b Added missing MySQL column check for show_equip
Follow up to 983d164
2017-08-07 09:31:32 +02:00
Lemongrass3110
9084d01536 Fixed a compilation problem with CentOS
Fixes #2317

Thanks to @keitenai and @sanny1128
2017-08-07 07:59:09 +02:00
Jittapan Pluemsumran
a46e012619 Made cbasetypes.h more C++ compatible (#2315)
* Removed inline macro in cbasetypes.h
* Renamed swap macro to avoid name clash with std::swap
2017-08-07 06:33:47 +07:00
Lemongrass3110
829f0a1f59 Added dummy entries for the equip switch feature
With this the players will not get disconnected when they click the button or drag an item into the new part of the equip window.
2017-08-06 22:25:47 +02:00
Lemongrass3110
5424ab85c9 Fixed mob database reloading
Fixes #2304
Thanks to @uddevil and @anacondaqq

Closes #2305
Thanks to @vstumpf
2017-08-06 18:11:54 +02:00
Lemongrass3110
f8e4aabf87 Follow up to 70c14fa 2017-08-06 17:48:24 +02:00
Lemongrass3110
983d164b7d Fixed public equip switch not being saved
Fixes #2310

Thanks to @mrjnumber1
2017-08-06 13:49:29 +02:00
Lemongrass3110
43949b8ab6 Fixed misleading indentation in script.c
Fixes #2307

Thanks to @Akkarinage
2017-08-06 13:23:30 +02:00
Lemongrass3110
70c14fa567 Fixed achievement handling in OnPCStatCalcEvent
Fixes #2314

Thanks to @CairoLee
2017-08-06 13:10:34 +02:00
Lemongrass3110
ee1242908b Fixed a memory leak in achievementremove
Fixes #2313

Thanks to @CairoLee
2017-08-06 12:55:59 +02:00
Aleos
cd164d74cd Removed some hardcoded item checks (#2303)
* Fixes #991.
* Removed hardcoded checks for SC_ITEMBOOST, SC_EXPBOOST, and SC_JEXPBOOST.
* Players are able to still consume these items even if the status is already active.
* Corrected the item bonus for Malangdo Cat Can.
Thanks to @cydh!
2017-08-04 19:11:05 -04:00
Lemongrass3110
bbd42e7f12 Cleaned up character deletion code (#2296)
* Fixes #2271
Thanks to @Tokeiburu
2017-08-04 18:46:17 -04:00
Aleos
fe5f1e115d Added a new item flag for delayed consumption (#2300)
* Added a new item flag for delayed consumption
* Fixes #550.
* The new flag will never consume the item.
* Supports script command itemskill.
Thanks to @cydh!
2017-08-04 18:38:39 -04:00
Atemo
9d6b3d06a9 Fixed readparam when 2nd parameter is a variable
Related issue #2276
2017-08-04 15:45:57 +02:00
Temtaime
cd3f42eb6a Fix swapped accsessories (#2281)
* Enum was swapped, you can view it by calling @itemlist with one accessory equipped.
Thanks to @Temtaime!
2017-08-03 13:38:59 -04:00
aleos89
4c62f581a8 Corrected guild bound item retrieval deletion
* Corrected a SQL statement deleting all guild bound items in the inventory table for offline characters.
Thanks to @Canoe!
2017-08-01 14:20:58 -04:00
aleos89
c0556a397e Follow up to 6748ff7
* Fixed pre-increment and pre-decrement operators for achievement condition parsing.
Thanks to @Lemongrass3110!
2017-07-31 14:25:31 -04:00
aleos89
f4338adab7 Follow up to 6581bac
* Fixed some compile errors.
* Clarified documentation for script command achievementupdate a bit more.
2017-07-31 13:13:23 -04:00
aleos89
6581bac83b Added script command achievementupdate
* Updates the specified achievement's value.
Thanks to @Tokeiburu!
2017-07-31 12:57:39 -04:00