9795 Commits

Author SHA1 Message Date
Sader Fawall
9cba66c22e Fix string case in inarray command script (#3401)
* Fixes #3400.
Thanks to @anacondaqq and @sader1992!
2018-08-14 12:26:29 -04:00
Aleos
4befcf747f
Corrected SECURE_NPCTIMEOUT behavior (#3394)
* Fixes #3381 and fixes #3391.
* Properly end NPC sessions when a player times out.
Thanks to @mazvi, @anacondaqq, and @gustavobrigo!
2018-08-11 16:13:24 -04:00
Aleos
9ca000a4a7
Official Spiritual Sphere Absorption behavior (#3367)
* Follow up to 4f97c74.
* Fixes #3357.
* Updated Sphere Absorption to official behavior
* Sphere Absorption will fail if casted on an ally.
* Should only succeed on self or enemy targets.
* Removed Cursed Circle check as it's not needed anymore.
2018-08-10 20:29:05 -04:00
Yashim Wong
c731465a52 Updated Acid Terror damage modifier for renewal (#3346)
* Renewal formula adjusted to 80 * skillLevel + 200.
Thanks to @syracuase and @mrjnumber1!
2018-08-10 17:54:12 -04:00
Aleos
2ab298076c
Cleaned up header guard names (#3395)
* Fixes #3385.
* Updated the header guard names to C++ standards.
Thanks to @elfring's suggestion!
2018-08-10 15:57:50 -04:00
Aleos
48ae1a1e05
Cleaned up map storage type (#3384)
* Fixes #3369, fixes #3370, and fixes #3382.
* Converted maps storage container back to static array.
* Converted mapflag storage containers to unordered_map.
* Removed a lot of redundancy and recursive lookups.
* Fixed a couple short-circuit checks to help with performance.
* Fixed multiple instance creation/destruction issues.
* Fixed PK Mode attempting to set PvP on flags that are already active.
* Getting MF_RESTRICTED will return the map's zone value instead of the state.
* Converted mapflag macros to inline functions.
Thanks to @teededung, @lelouch22, @mazvi, @Lemongrass3110, and @cydh!
2018-08-10 13:52:07 -04:00
Cydh Ramdh
83c8183a2e
Added IG_PRIVATE_AIRSHIP (#3378)
* Item group for Private Airship tickets
2018-08-06 08:06:30 +07:00
Lemongrass3110
a05ed6e814
Fixed walk_choices's type (#3353)
Fixes #3310

Replaced some still hardcoded values with their define constants.
Added a function to check if a walk will be diagonal and fixed invalid calculation for it.

Thanks to @DavidPS92
2018-07-30 00:24:31 +02:00
Aleos
4f97c749c4
Corrected Spiritual Sphere Absorption and Cursed Circle interaction (#3358)
* Revert of 9a009bf.
* Spiritual Sphere Absorption should still take the spheres from the target even if Cursed Circle is used on the caster.
Thanks to @Raf4h!
2018-07-29 17:16:04 -04:00
Lemongrass3110
8dea04a8b3
Initial release of private airship system (#3354)
Fixes #3314 

Thanks to @aleos89 for his help.
2018-07-29 20:11:15 +02:00
Cydh Ramdh
3de9a44f9a
Fixes channel command crash (#3364)
* Fixed #3363
2018-07-29 17:48:24 +07:00
Aleos
584fcac43a Cleaned up map data storage (#3347)
Follow up to a942853.
Fixes #3336.
Moved map_data storage to std::map container.
Created map_getmapdata to obtain pointer to map_data.
Got rid of MAX_MAP_PER_SERVER define.
Resolved deletion of instances causing other instances to lose their intended map ID.
Refactored warp suggestions

Thanks to @teededung, @anacondaqq, @cydh and @Lemongrass3110!
2018-07-26 01:06:59 +02:00
Gustavo Brigo
952ac43e59 Fixed EXP bug and added failsafe to family check functions (#3350)
Fixes #3349
2018-07-25 21:58:58 +02:00
Lemongrass3110
6b3f0717c7
Hotfix for issue 3277 (#3279)
Fixes #3277 

Thanks to @cydh and @aleos89
2018-07-24 22:55:17 +02:00
Lemongrass3110
95c3aed810 Fixing party death icon in newer clients
Fixes #2356

Thanks to @admkakaroto and @4144
2018-07-23 23:05:18 +02:00
Aleos
9313922656
Further cleanup to mapflags (#3332)
* Follow up to a942853.
* Removed ADJUST_SKILL_DAMAGE define so that the mapflag is always enabled.
* Cleaned up atcommand mapinfo and skill_damage mapflag interaction.
* Cleaned up atcommand mapflag to not allow setting of special mapflags that require extra arguments (Please use script command setmapflag).
* Using script command setmapflag for MF_NOSAVE will default to SavePoint.
* Using script command setmapflag for MF_PVP_NIGHTMAREDROP will default to normal official drop values.
* Exported constants for skill_damage mapflag types.
Thanks to @ecdarreola, @cydh, and @Lemongrass3110!
2018-07-23 13:40:35 -04:00
Lemongrass3110
123303ef84 Fixed missing curly braces in reloadscript
Fixes #3330

Thanks to @hendra814
2018-07-19 08:26:06 +02:00
Aleos
a942853d55
Cleaned up the mapflag system (#2943)
* Created setter and getter functions.
* Adjusted all calls to use these functions.
* Converted mapflags to C++ map container.
* Converted drop_list to vector.
* Converted skill_damage ERS into vector and increased limit from UINT8 to UINT16.
* Cleaned up several functions to be more dynamic to reduce redundancy that was all over the place.
* Renamed nosumstarmiracle to nosunmoonstarmiracle.
* Adjusted skill_damage mapflag to use proper defined constants.
* Refactored map index into a vector.
Thanks to @Lemongrass3110 for a lot of help and @secretdataz!
2018-07-18 20:00:33 -04:00
Aleos
bbe552d1d3
Resolved Guild Storage Expansion not updating (#3321)
* Fixes #3317.
* Resolves the Guild Storage Expansion skill not refreshing the map server cached data.
* Updated some inter server checks to grab the proper max size of guild storages.
Thanks to @admkakaroto and @Lemongrass3110!
2018-07-18 17:10:07 -04:00
rAthenaAPI
8a353697b0 Effect State Update 2018-07-18 05:06:17 +02:00
Aleos
b409936f8d
Updated max recovery weight to 70% for renewal (#3309)
* Fixes #2622.
* Added a new battle config for renewal.
* Adjusted the battle config to support dropping the recovery weight to 0.
* Added the new weight limit packet.
Thanks to @functor-x and @Lemongrass3110!
2018-07-17 16:18:39 -04:00
Lemongrass3110
a5588dd9ab
Initial Release of Attendance Feature (#3297)
Thanks to @secretdataz and @aleos89 for their help.
Thanks to @Haikenz and @admkakaroto for testing.
Thanks to @Daegaladh for his ideas.
2018-07-16 21:39:42 +02:00
flamefury
030443c9d3 Negative MDEF should not increase damage taken from magic (#3190)
* Fixes #3189.
* MDEF should never go below 0.
Thanks to @flamefury!
2018-07-16 12:43:29 -04:00
flamefury
1a6bc209a8 Freezing and Burning can occur at the same time (#3313)
* Fixes #3312.
* Freezing and Burning should be able to be stacked.
Thanks to @flamefury!
2018-07-16 10:10:51 -04:00
Lemongrass3110
c4d7dc76d3
Hid timer function parameters in a macro (#3311) 2018-07-15 23:17:15 +02:00
Aleos
bfd7af3423
Fixed Guild Storage Expansion skill saving (#3306)
* Fixes #3301.
* Force the Guild Storage Expansion skill to save on level up so the next time the guild storage is opened the proper increase is shown.
Thanks to @spinzaku!
2018-07-10 16:46:20 -04:00
Aleos
042b88623b
Pets should mimic master's walk speed (#3303)
* Pets should have the same walk speed as their master.
* Corrected homunculus speed check to use the proper battle config.
2018-07-09 17:29:55 -04:00
Aleos
3de5824757
Adjusted Amistr's Defense behavior (#3300)
* Effect should not be shown above master.
2018-07-08 18:28:09 -04:00
Aleos
fdd2475622
Corrected some item bonuses not triggering (#3298)
* Fixes #3265.
* Fixes bAddDamageClass, bAddMagicDamageClass, bAddDefMonster, and bAddMDefMonster not checking for the correct source/target class.
Thanks to @uddevil!
2018-07-08 17:44:20 -04:00
Lemongrass3110
b2c026d4b0
Cleaned up Summer 2 code (#3294)
Fixes #3293

Thanks to @Everade for reporting.
2018-07-08 11:58:50 +02:00
Aleos
f2437f4a63
Updated Masquerade effects (#3291)
* Masquerades are now unable to effect Boss monsters.
2018-07-07 19:49:51 -04:00
Aleos
20a72e0c6b
Updated Axe Mastery behavior (#3292)
* Axe Mastery does not increase damage for 2H Swords.
2018-07-07 18:20:42 -04:00
Lemongrass3110
74efc7d65d Added empty packet functions for private airship
Thanks to @Daniel4rt
2018-07-07 18:47:38 +02:00
Sader Fawall
500cfdc41f Missing returns for inarray and countinarray (#3295)
Added some return cases if empty arrays are given to these two commands.

Thanks to @sader1992
2018-07-07 13:46:14 +02:00
Lemongrass3110
fe7c0a78ec
Refactored roulette system (#3271)
Fixes #2887 - thanks to @Everade
Fixes #3292 - thanks to @admkakaroto

Added a script command to open the roulette window from server side.
Added support for clients >= 2018-05-16
Fixed losing behavior for roulette
Enabled roulette system by default
Added a server side delay
Added missing sql log enum value 'Y'

Thanks to @Everade, @admkakaroto, @V0rr, @ecdarreola, @Haikenz and everyone else who contributed to this.
2018-07-06 22:39:58 +02:00
Aleos
d612788ed7
Updated Shield Spell behavior (#3290)
* Fixes #3236.
* Shield Spell is now canceled when the user switches shields.
Thanks to @EthernalFriend and @MrLekkz!
2018-07-06 13:30:38 -04:00
Aleos
6b148d5c35
Corrected SC_MTF_CRIDAMAGE bonus not triggering (#3289)
* Resolves SC_MTF_CRIDAMAGE never triggering the critical damage bonus.
2018-07-06 10:42:55 -04:00
Lemongrass3110
cea5ad7199
Fixed a bug with warlock's spheres (#3288)
Fixes #3264

Thanks to @nornane for reporting this and coming up with a solution.
2018-07-06 07:52:04 +02:00
Lemongrass3110
91169d7ebc
Fixed a few compiler warnings on clang (#3263)
Mostly pointer-bool-conversion and autological-pointer-compare
2018-07-05 22:53:20 +02:00
rAthenaAPI
e06984a73e Mob and NPC Identity Update 2018-07-04 05:01:03 +02:00
Aleos
e13ca63cc8
Added Guild Storage Expansion Skill (#3244)
* Fixes #499 and part of #1303.
* Implements Guild Storage Expansion Skill which requires client 2013-12-23 or newer (enable by default depending on client date in src/config/packets.hpp).
* Implements guild storage permission which requires client 2014-02-05 or newer.
* Expanded script command guildopenstorage return values.
2018-07-03 08:49:34 -04:00
Lemongrass3110
145b60f7b6 Added support for packet sending map data(0xAC5) 2018-07-02 22:39:06 +02:00
Lemongrass3110
3faf700443
Added possibility to log without attached player (#3260)
Fixes #2268

Thanks to @Akkarinage
2018-07-02 11:45:55 +02:00
Cydh Ramdh
ce9cbd2e65
Fixed logging of #CASHPOINTS and #KAFRAPOINTS (#3252)
* Fixes #2169
* #CASHPOINTS and #KAFRAPOINTS now will be logged correctly when used by scripting
* Fixed a bug where points removed cash as well
* Small cleanup for pc_paycash and pc_getcash
* Thanks to @Lemongrass3110, @ecdarreola
2018-07-02 13:21:41 +07:00
Lemongrass3110
b3a51eaa35
Fixed broken guild notices (#3262)
Fixes #641

Thanks to @tmav94, @RadianFord, @Akkarinage and @vykimo
2018-07-01 23:22:22 +02:00
Lemongrass3110
b3643bfe45
Added a 'force' option to attachrid (#3261)
Fixes #1763
2018-07-01 22:28:56 +02:00
Cydh Ramdh
e7fd6aa5bd
Enable autobonus to be reactivated (#3199)
* Fixes #3039, #3158
* Thanks to @Raf4h @laziem
2018-06-28 20:56:39 +07:00
Lemongrass3110
a4336fd8ae Fixed compiler warnings in malloc.cpp on x86
Fixes #3248

Thanks to @laziem
2018-06-27 22:42:11 +02:00
Lemongrass3110
796a67be4b
Fixed Silvervine Root Twist animation for players (#3255)
Fixed status changes that are displayed for players that walk into the area after status change start being sent out with an invalid duration, since the timer was not yet created and causing an infinite duration packet to be sent.

Fixes #3182

Thanks to @Everade
2018-06-27 22:08:52 +02:00
Lemongrass3110
55f1b01bd8
Removed useless debug variables for an old issue (#3247)
Closes #1986
2018-06-27 07:37:35 +02:00