18326 Commits

Author SHA1 Message Date
Lemongrass3110
c4026c08c8
Some bonus ignored left_cardfix_to_right (#8097)
Taken from #7024

Co-authored-by: munkrej <schmunk@posteo.de>
2024-01-12 11:42:08 +01:00
Atemo
360b8bc3e2
Corrected IG_GRAND_JUDGEMENT (#8095)
* Moved IG_GRAND_JUDGEMENT with other splash skills in skill_castend_damage_id

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>

Fixed #8080

Thanks to @Jaikayray
2024-01-11 15:31:17 +01:00
Lemongrass3110
96f40d9adc Converted some whitespaces to tabs 2024-01-11 00:47:57 +01:00
Atemo
a29e115a62
Corrected CD_ARBITRIUM_ATK area of damage (#8096)
* The splash area should be 9x9 according to skill description

Fixed #8079
Thanks to @Jaikayray
2024-01-10 23:57:51 +01:00
munkrej
60dbe5a42d
Cleanup of PATK calculation (#8094)
Follow up to 66dddb3 (rathena/rathena#7996)

Fixes RK_DRAGONBREATH handling when DK_DRAGONIC_AURA is not skilled
2024-01-08 21:10:11 +01:00
Atemo
a3cb48a341
Item DB correction/update (#8091)
* Corrected item Locations
* Added missing effect when autobonus is triggered for some snow and glacier enchants
* Updated item Trade
2024-01-08 20:24:23 +01:00
Atemo
1f3b42c175
Updated hidden garden instance (#8092)
* Monsters spawn times is significantly reduced.
2024-01-08 19:46:15 +01:00
Atemo
360710d2f0
Rebalance Abyss chaser 20221221 (#8081)
* Abyss Dagger
- Increases cooldown from 0.3 seconds to 0.4 seconds.
- Increases SP consumption from 64 to 76 based on level 5.
- Increases base damage from 2600%Atk to 4600%Atk based on level 5.

* Frenzy Shot
- Increases cooldown from 0.2 seconds to 0.35 seconds.
- Increases SP consumption from 55 to 65 based on level 10.
- Increases number of hit from 1 hit to 2 hits.
- Increases base damage from 4000%Atk to 6150%Atk based on level 10.
- Increases factor weight of CON in skill formula from 5 to 15.

* Deft Stab
- Removes a chance to trigger the skill one more time.
- Increases SP consumption from 62 to 72 based on level 10.
- Increases cooldown from 0.3 seconds to 0.7 seconds.
- Reduces base damage from 5850%Atk to 3750%Atk based on level 10.
- Changes damage logic from 5 split hits to 5 cumulative hits.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2024-01-06 19:58:18 +01:00
Lemongrass3110
644a22c5bb
Fixed convex mirror (#8084)
When the "NoSave" of SC_BOSSMAPINFO is removed, this could lead to issues after a character logs back in.

Fixes #8083

Thanks to @Gyakushinn
2024-01-05 21:50:59 +01:00
Atemo
ff90feaf85
Rebalance Meister 20221221 (#8076)
Axe Stomp
- Increases SP consumption from 74 to 85 based on level 5.
- Increases base damage from 4600%Atk to 5150%Atk per hit based on level 5.

Mighty Smash, Spark Blaster  and Triple Laser are already up-to-date
2024-01-02 20:39:49 +01:00
Atemo
2121aa2ed7
Rebalance Dragon Knight 20221221 (#8077)
* Madness Crusher
- Reduces SP consumption from 68 to 55 based on level 5.
- Increases base damage from 4400%Atk to 8350%Atk based on level 5.
- Increases factor weight of POW in skill formula from 7 to 10.

* Storm Slash
- Increases cooldown from 0.3 seconds to 0.35 seconds.
- Reduces SP consumption from 60 to 55 based on level 5.
- Increases base damage from 950%Atk to 2200%Atk per hit based on level 5.
- Increases the chance to double skill damage while under Giant Growth buff from 30% to 60%.

* Hack and Slasher
- Increases base damage from 7300%Atk to 7700%Atk per hit based on level 10.
- Reduces area of effect from 9 x 9 cells to 7 x 7 cells based on level 10.
- Applies critical damage, the critical chance is the user's Cri.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2024-01-02 19:07:54 +01:00
Atemo
091a6c5401
Rebalance Troubadour & Trouvere 20221221 (#8068)
* Rhythm Shooting
- Increases cooldown from 0.15 seconds to 0.35 seconds.
- Increases base damage from 800%/1400%Atk to 3700%/4550%Atk per hit based on level 5.
- Increases factor weight of CON in skill formula from 3 to 5 (7 on targets marked with sound brand).

Additionally
- The effect from Rhythm Shooting does not remove SC_SOUNDBLEND anymore (written in the skill description)

* Metallic Fury
- Reworks skill to dealing damage to surrounding enemies around the target (9 x 9 cells based on level 5).
- Increases cooldown from 0.3 seconds to 0.4 seconds.
- Increases global cool time from 0.3 seconds to 0.5 seconds.
- No longer remove sound brand debuff from target. (doesn't mention it changelog but it works)
- Increases base damage from 11000%Matk to 13000%/18000%(targets marked with sound brand)Matk based on level 5.
- Increases factor weight of SPL in skill formula (on targets marked with sound brand) from 1.5x of Stage Manner skill level to 2x of Stage Manner skill level.
2024-01-02 18:09:03 +01:00
Atemo
f22e423677
Rebalance Imperial Guard 20221221 (#8078)
* Cross Rain
- Reduces cooldown from 4.5 seconds to 2.4 seconds.
- Reduces skill duration from 4.5 seconds to 2.4 seconds based on level 10.
- Increases factor weight of Spear & Sword Mastery skill level in skill formula from 50/100 (Holy Shield) to 100/150 (Holy Shield) based on level 10.
- Increases factor weight of SPL in skill formula from 5 to 7.
- Reduces AP recovery rate from 7 to 4.

* Shield Shooting
- Reworks skill to dealing damage to surrounding enemies within 7 x 7 cells around the target.
- Reduces cast range from 11 cells to 9 cells.
- Increases factor weight of Shield Mastery skill level in skill formula from 75 to 250 based on level 5.
- Increases base damage from 11900%Atk to 14900%Atk based on level 5.
- Increases factor weight of POW in skill formula from 5 to 7.
- Increases factor weight of shield refine rate in skill formula from 4 to 25.
2024-01-02 14:32:39 +01:00
Vincent Stumpf
1c31d9c83e
Make the global packet_buffer owned by common (#8073) 2024-01-01 19:05:21 +01:00
Vincent Stumpf
3756872529
Fix token auth packet handling (#8071)
It should skip the entire packet
2023-12-30 18:26:53 -08:00
Lemongrass3110
fe9c959bf0
Removed flag parameter for MC_IDENTIFY (#8070)
Fixes #7634

Thanks to @OptimusM and @laziem
2023-12-30 19:07:38 +01:00
Atemo
756abe34d5
Rebalance Arch mage 20221221 (#8065)
* Rain of Crystal
- Reduces area of effect from 19 x 19 cells to 13 x 13 cells based on level 5.
- Increases SP consumption from 100 to 125 based on level 5.

* Crimson Arrow
- Reduces SP consumption from 94 to 90 based on level 5.
- Increases base damage of linear damage from 1500%Matk to 1750%Matk based on level 5.
- Increases base damage of explosion damage from 3000%Matk to 3500%Matk based on level 5.

* Storm Cannon
- Reduces SP consumption from 94 to 88 based on level 5.
- Increases base damage from 4750%/6250%Matk to 6000%/7500%Matk based on level 5.

* Rock Down
- Reduces SP consumption from 94 to 88 based on level 5.
- Increases base damage from 4750%/6250%Matk to 6000%/7500%Matk based on level 5.

* Frozen Slash
- Increases SP consumption from 96 to 115 based on level 5.
- Increases base damage from 4750%/6650%Matk to 4900%/6800%Matk based on level 5.

* Destructive Hurricane
- Increases cooldown from 2 seconds to 2.5 seconds.
- Increases base damage from 14250%Matk to 14850%Matk based on level 5.
- Reduces damage bonus from Climax level 3 from 200% to 150%.
- Changes damage modifier from Climax level 5 from 50% increasing to 20% reducing.
- Increases SP consumption from 132 to 186 based on level 5.

* Crystal Impact
- Reduces area of effect from 15 x 15 cells to 13 x 13 cells based on level 5.
- Increases SP consumption from 132 to 186 based on level 5.
- Reduces area of effect bonus from Climax level 5 from entire screen to 15 x 15 cells.


Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2023-12-30 14:52:34 +01:00
Atemo
23766e61c3
Rebalance Windhawk 20221221 (#8020)
* No Limits (Ranger)
- No longer be removed by Dispell or Clearance.

* Calamity Gale
- Increases duration from 60 seconds to 180 seconds.
- Reduces cooldown from 300 seconds to 180 seconds.

Note: it was not implemented
- No longer be removed when using No Limits.

* Gale Storm
- Reduces cooldown from 1.5 seconds to 1.2 seconds.
- Increases SP consumption from 100 to 120 based on level 10.
- Increases base damage from 9500%Atk to 10000%Atk based on level 5.
- Reduces area of effect from 11 x 11 cells to 9 x 9 cells based on level 10.

Note: CON weight was already 10
- Increases factor weight of CON in skill formula from 5 to 10.

* Crescive Bolt
- Increases cooldown from 0.15 seconds to 0.35 seconds.
- Increases global cool time from 0.3 seconds to 0.7 seconds.
- Increases base damage from 3400%Atk to 9400%Atk based on level 10.

Additionnally
- Removed leftover Deep Blind Trap / Solid Trap / Swift Trap / Flame Trap status ailments in `skills_db.yml` (from previous rebalance)
- Corrected WH HAWK BOOMERANG and WH_HAWKBOOMERANG formula according to the Korean description of the skill.
- Included WH_NATUREFRIENDLY in the damage formula of WH_HAWKRUSH and WH_HAWKBOOMERANG (x1.5 at level 5) (source: tests on KRO)

Thanks to @datawulf
2023-12-29 23:57:52 +01:00
Atemo
11e50dec41
Rebalance cardinal 20221221 (#8021)
* Framen
- Increases base damage from 4000%/4500%Matk to 4750%/5250%Matk based on level 5.

* Arbitrium
- Reduces cooldown from 1.5 seconds to 1 second.
- Increases SP consumption from 112 to 125 based on level 10.
- Applies AP recovery rate by 2.
- Increases base damage of area damage from 12500%Matk to 17500%Matk based on level 10.
- Increases factor weight of Fidus Animus skill level in skill formula of area damage from 100 to 500 based on level 10.
- Increases factor weight of SPL in skill formula from 7 to 10.

* Petitio
- Reduces area of effect from 9 x 9 cells to 7 x 7 cells based on level 10.
- Increases factor weight of Mace & Book Mastery skill level in skill formula from 100 to 500 based on level 10.
2023-12-29 22:54:14 +01:00
Lemongrass3110
7999ccb215
Refactored login-server clif to structs (#8058)
Communication between the login-server and the client is now done with structs.
Moved the definition of the global reusable packet buffer to socket.hpp
2023-12-29 22:04:42 +01:00
Atemo
0fe2d0a0fe
Rebalance inquisitor 20221221 (#8022)
* Oleum Sanctum
- Reduces cooldown from 2 seconds to 1.5 seconds.
- No longer require Holy Water on casting.
- Reduces area of effect from 11 x 11 cells to 9 x 9 cells based on level 5.

* Explosion Blaster
- Adds global cool time by 1 second.
- Increases SP consumption from 90 to 125 based on level 5.
- Reduces area of effect from 11 x 11 cells to 9 x 9 cells based on level 5.
- Reduces base damage of from 14000%Atk to 12000%Atk based on level 5.
- Increases base damage against Oleum Sanctum debuff from 16000%Atk to 17600%Atk based on level 5.
- Reduces factor weight of POW in skill formula (without Oleum Sanctum debuff) from 15 to 10.

* Massive Flame Blaster
- Adds global cool time by 0.5 seconds.
- Reduces area of effect from 11 x 11 cells to 9 x 9 cells.
- Increases base damage from 21500%/23000%Atk to 23000%/24500%Atk based on level 10.
2023-12-29 20:22:44 +01:00
Atemo
ccce839881
Rebalance shadow cross 20221221 (#8019)
* Savage Impact
- Reduces cooldown from 1 second to 0.7 seconds.
- Increases area of effect from 5 x 5 cells to 7 x 7 cells based on level 10.
- Applies AP recovery rate by 2.

* Shadow Stab
- The skill will deal damage for 2 hits.
- While under Cloaking Exceed buff, increases number of hit to 3 hits with higher damage per hit.
- Increases factor weight of POW in skill formula while under Cloaking Exceed buff from 5 to 7.
- Increases base damage from 1500%Atk to 1750%/2000%Atk per hit based on level 5.
2023-12-29 16:51:43 +01:00
Sola丶小克
b0971c0f67
Refactor some MySQL connection variables (#8059) 2023-12-29 15:37:01 +01:00
Lemongrass3110
9c06340f3a Fixed a warning related to [[fallthrough]]
Follow up to 61c2480

Thanks to @Pokye
2023-12-29 11:49:41 +01:00
Lemongrass3110
afbfd13606
Prevent clients to use server accounts (#8063)
Fixes #7772

Thanks to @Litro
2023-12-29 11:15:41 +01:00
Lemongrass3110
e4ec88c666
Added support for CZ_RESET_SKILL (#8062)
Fixes #7961
Added a dummy implementation to prevent players from disconnecting, until we know what that command should do.

Thanks to @jamesandrewww
2023-12-29 10:40:55 +01:00
Singe Horizontal
782299112b
Restores stat points override when loading db (#8061)
Fixes #8060
2023-12-29 01:34:19 +01:00
Vincent Stumpf
61c2480d89
Add explicit [[fallthrough]] attributes (#8054)
Fixes #7918
2023-12-29 01:08:24 +01:00
Lemongrass3110
b6f17692e9
Updated Hercules packets (#8056) 2023-12-29 00:20:09 +01:00
Lemongrass3110
e3a3bfc868
Fixed login_check_password (#8052)
Fixes #8043

Thanks to @LasherasGH
2023-12-28 23:56:23 +01:00
Atemo
79ea192032
Updated item DB up to december 19 2023 (#8057)
* Updated item DB up to december 19 2023
* Corrections in combo DB
* Removed duplicated combos
2023-12-28 14:32:48 +01:00
Vincent Stumpf
8336f046b7
Allow default sell values in npc shop scripts (#8050)
Fixes #6594
2023-12-27 22:16:04 +01:00
Sola丶小克
1f6ec24a33
Remove deprecated global sql settings code (#8055) 2023-12-27 17:31:04 +01:00
Vincent Stumpf
f2a3bad3e2
Cleanup uses of SWAP macro (#8051) 2023-12-27 11:36:46 +01:00
Lemongrass3110
82b36dc847
Fixed some compiler warnings (#8053)
Fixes #8044

Thanks to @Pokye
2023-12-27 10:58:14 +01:00
Lemongrass3110
cd0c44af60
Refactored script command rand (#8040)
Fixes #8041

Added support for int64, so the range of the random numbers that can be generated is much wider now.

Changed the logic to be more restrictive:
	(1) The range version is intended for positive numbers only.
	(2) If minimum and maximum are equal and no random value can be calculated.
Triggering the more restrictive behavior will trigger the script source (file) to be reported in the map-server.

Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2023-12-26 23:52:37 +01:00
Lemongrass3110
871c4e62cf Reverted variable rename
Follow up to 6750837
2023-12-26 22:04:38 +01:00
Vincent Stumpf
6750837854
Let rnd_value callers not care about order (#8046) 2023-12-24 15:42:02 -08:00
Lemongrass3110
ac85d44197
Refactored CZ_REQ_MERGE_ITEM (#8039)
Thanks to @secretdataz!
2023-12-20 13:39:11 +01:00
Lemongrass3110
c33bb0b726
Fixed NPC_EARTHQUAKE usages (#8038)
Fixes #8036

Thanks to @asydia
2023-12-20 00:41:57 +01:00
Lemon
7c153416bc
Improved randomness (part 1) (#7882)
Faster and with no module bias

Removed rnd_init, rnd_uint32 and rnd_uniform
From now on we will only use rnd_value(min, max) for values in range [min, max] and rnd_chance(chance, base) for chances

Fixes #7881
Fixes #7883
Fixes #7884
Fixes #7885

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2023-12-20 00:12:15 +01:00
idk-whoami
ad3a2e99eb
Follow up to c898007 (#8035)
Location correction of C_Imperial_Feather ID 5911

Thanks to @Pokye
2023-12-19 20:57:58 +01:00
Lemongrass3110
e0cf16d3e9
Fixed pc_isequip calls (#8037)
Fixes #8034

Thanks to @alisonrag
2023-12-19 20:22:48 +01:00
idk-whoami
c8980072a5
Corrected script for some item #26 (#8026)
Thanks to @Pokye, @Atemo
2023-12-15 15:59:55 +01:00
HAO YAN
7ee7a25887
Add autoloot script command (#8032) 2023-12-14 15:39:57 +01:00
AshiHanna
a7f0aab600
Add the stockall command (#8008)
* The command will transfer all items from the cart to the inventory based on the item type.
2023-12-12 08:12:06 -05:00
Singe Horizontal
53f1c5bb80
Default multi-processor compilation on VS (#8029) 2023-12-11 21:30:48 +01:00
HAO YAN
7db67c6207
Battleground and clan support for addrid (#7969) 2023-12-11 08:47:00 +01:00
HAO YAN
461294f423
Add channel_join script command (#7970) 2023-12-11 08:43:56 +01:00
Singe Horizontal
eec798bfc3
Restores a correct option index (#8031)
Fixes #8024 and #7956.
Fixes an issue with guild storage and retrieving guild bound items.
2023-12-10 00:28:00 -05:00