8488 Commits

Author SHA1 Message Date
Jittapan Pluemsumran
da21013254
Follow up to 1e8c27c.
Removed an unneccessary pointer. Thanks to @cydh
2016-08-15 16:31:48 +07:00
Jittapan Pluemsumran
1e8c27c085
Fixed compile error on VS2010
* unprofessional personal diary page 1
2016-08-14 23:23:11 +07:00
Jittapan Pluemsumran
8657c4210c
Follow up to f296409ada211a0aa89863db4d9603054845cf65
* Some variable and function leftovers clean-ups
2016-08-14 22:52:06 +07:00
Jittapan Pluemsumran
f296409ada
Initial Release of Random Option System
* Added basic support for random option system
* Don't forget to import upgrade_20160814.sql and upgrade_20160814_log.sql to make your existing rAthena installation functional!
2016-08-14 22:21:07 +07:00
Lemongrass3110
a87d86cb11 Fixed getinventorylist documentation
Fixes #1497.
Thanks to @Darkelfen for reporting it.

Additionally exported the EQP_* constants into the script engine.
Replaced some hardcoded equip positions with their respective constants.
2016-08-14 00:26:22 +02:00
Lemongrass3110
ebcb92363b Follow up to ede39b1
Fixed the compile errors on packet versions < 20150513
2016-08-13 22:38:18 +02:00
Lemongrass3110
ede39b1730 Refurbished hat effects
Follow up to 5da49b8
Thanks to @cydh for the good base in #1465.

Renamed the function from itemeffect to hateffect.
The effects now get sent to other players as well.
You can enable or disable one effect at a time with the script command now.
2016-08-13 21:56:58 +02:00
Lemongrass3110
2cbc9ac507 Fixed some compile warnings
Fixed a shadowed variable in clif_parse_WisMessage
Adjusted a hardcoded limitation to use the correct define for event name length
Removed the check if the target is dead for killing cloud(leftover from 99e49d9)
2016-08-12 16:46:52 +02:00
Lemongrass3110
9157318ee9 Script level up events from atcommands
Based on @Emistry's pull request HerculesWS/Hercules#1396:
Added a configuration to enable the atcommands baselevel and joblevel to trigger their respective npc events.
This will help you guys with testing your custom scripts that are listening to OnPCBaseLvUpEvent or OnPCJobLvUpEvent.
For safety reasons we only trigger the events on level increase.
2016-08-12 15:21:48 +02:00
Lemongrass3110
f560da84c6 Fixed a crash on invalid combo scripts
Fixes #1493
Thanks to @julia40124009 for reporting.
2016-08-12 14:37:39 +02:00
aleos89
e40c88ecbf Skill Tree cleanup
* Added an optional base level requirement for skills.
* Refactored some variable types and names.
2016-08-11 18:31:59 -04:00
Lemongrass3110
8857ff6279 Added custom battle config support
You can now define custom battle config structure members in src/custom/battle_config_struct.inc and initialize them in src/custom/battle_config_init.inc
You can put the configuration into any battle configuration file, but we recommend you to put it into conf/import/battle_conf.txt
2016-08-10 23:06:41 +02:00
aleos89
5fcb3bff05 Corrected Knuckle Arrow behavior (fixes #1483)
* Items that prevent knock back will stop Knuckle Arrow's knock back effect.
2016-08-09 17:42:08 -04:00
aleos89
99e49d9a45 Fixed Cloud Kill causing a map-server crash
* Follow up to e5a197a and 5fabab9.
2016-08-09 17:35:05 -04:00
aleos89
f200541657 Corrected Clearance and Phantom Thrust behavior (fixes #1476)
* Now only usable on monsters and party members.
* Corrected skill error message to official.
2016-08-09 17:29:20 -04:00
Playtester
72b61d742f GX Poison Duration (fixes #1486)
- The duration of GX poisons is now reduced by (VIT+LUK)/2 seconds
- The duration of Oblivion Curse is no longer reduced by INT
2016-08-08 21:28:00 +02:00
Jittapan Pluemsumran
5f981bc1b1
Implemented bNoMadoGear item bonus
* Support for upcoming Charleston cards
2016-08-07 18:20:30 +07:00
aleos89
676ae63cd8 Corrected Mystical Amplification behavior for renewal (fixes #913)
* Staff of Destruction and Sacrament will now lower Mystical Amplification's cast time.
* Release damage is no longer increased by Mystical Amplification.
* All hits from Water Ball, Jupiter Thunder, and Tetra Vortex have increased damage by Mystical Amplification.
2016-08-05 17:05:03 -04:00
Playtester
f7a276ec73 Voice of Siren duration (fixes #507)
- The minimum duration of Voice of Siren is now 10 seconds
2016-08-04 19:09:05 +02:00
aleos89
842e30ed8a Corrected progress bar behavior (fixes #1425)
* Skills/Items, that have pop-up menus, or active NPC send a work in progress message if players try to do anything else.
* If a progress bar is active the first attempt to walk cancels the progress bar while the second walk attempt moves the player.
* Applies to renewal mode only.
2016-08-02 17:25:25 -04:00
Lemongrass3110
5fabab9c1e Fixed a mapcrash caused by SC_CLOUD_KILL
Fixes #1462
Thanks to @Everade for reporting it to us.
2016-08-02 19:39:48 +02:00
aleos89
6bc2f62bff Removed unused variables
* Follow up to d1a957e.
2016-08-01 12:40:23 -04:00
Lemongrass3110
639830a004 Fixed a compile error
Follow up to 120df33
Sorry I did not wait for the build reports.
2016-07-30 00:16:28 +02:00
Limestone
120df3353e One Click Identify feature adjustments (#1463)
- In Official, you can also use Novice Magnifiers
- If you have both type of magnifiers in your inventory, it will always consume the normal magnifier first
2016-07-30 00:06:50 +02:00
Lemongrass3110
e99f17b3b2 Fixed the required levels for MC_CHANGECART
Thanks to @jgoog999 for his pull request(merges and closes #1461).
2016-07-29 19:48:41 +02:00
aleos89
52a74e8590 Updated Camouflage behavior - part 2
* Follow up to bec9845.
* Arrow Shower should not benefit from Camouflage.
* Sharp Shooting and Arrow Storm bonus should be applied to all targets in the area, not just the selected target.
Thanks to @Tokeiburu!
2016-07-29 13:39:51 -04:00
Lemongrass3110
5da49b87b5 Added hat effect packet and script support 2016-07-29 19:15:46 +02:00
Limestone
f0ac1d81c5 Implemented new costumes w/ visual effects
- ItemID (19022) // jRO Item
 - ItemID (20062)
 - ItemID (20099)
 - ItemID (20154)
 - ItemID (20209) // jRO Item
 - ItemID (20246)

Note 1: Status ID's that we still don't have their item informations
 - SC_FLOWERSMOKE
 - SC_HAPPINESS_STAR
 - SC_MAGICAL_FEATHER

Note 2: Some of the costumes will not show it's visual effects on 2014 clients downwards.
2016-07-29 10:31:35 +08:00
aleos89
d1a957efea Cleaned up parts of the VIP System
* Removed battle configs vip_exp_penalty_base_normal and vip_exp_penalty_job_normal as these are duplicates of other battle configs.
* Battle config vip_exp_penalty_base and vip_exp_penalty_job are now at a rate of 100 instead of 1 to match other configs.
* Added VIP Zeny Penalty config.
* Cleaned up various rate calculations.
* Removed various macro defines that aren't needed.
* Moved the player state for atcommand showrate to the VIP struct.
2016-07-28 19:28:36 -04:00
aleos89
1daa6fd65b Revert of efdc748
* Going to follow up later with a better fix.
2016-07-27 18:56:37 -04:00
aleos89
efdc748a7a Corrected bResEff behavior (fixes #996)
* Removed the common SC range check.
* A few of the Eff_* values are tied to a SC that's not within the common SC range.
2016-07-27 18:15:46 -04:00
aleos89
160f24d66a Corrected MVP Tomb behavior (fixes #1429)
* On Aegis there is a 9~ second delay before the tomb is spawned.
2016-07-27 16:49:32 -04:00
aleos89
bec9845499 Updated Camouflage behavior (fixes #1438)
* Camouflage now ends when attacking plant type monsters.
* Camouflage bonus is applied to the first skill after activating Camouflage.
* Corrected movement speed bonus checks.
* Removed INF3_NOENDCAMOUFLAGE enum as it is no longer needed.
* Updated skill_db documentation.
2016-07-26 16:58:44 -04:00
Cydh Ramdh
2a1aebaf64 Cleaned up char_del_option checks
This is a squash commit for @cydh's pull request #1299.

Cleaned up the `char_del_option` checks.
Added a comment for `char_del_option`, that only work for clients that send delete request by using 0x0068 or 0x01fb.
Added an enum for values.
Added a function to validate and adjust configuration data.
Resolved character deletion not working properly for clients 2015-10-01 and higher (fixes #1189)
Delete date should be sent as remaining time on some client versions.
Adjusted some comment wording.
Added empty/default birthdate deletion.
Made email deletion case insensitive.
2016-07-26 22:35:22 +02:00
aleos89
ffec87d29a Corrected item bonus WeaponMatkRate (fixes #1446)
* Item bonus formula was checking for an incorrect MATK value.
* Moved the bonus after the WMATK and Weapon Refine calculations so it's not zeroed out at the beginning.
2016-07-25 13:27:29 -04:00
aleos89
e24f2f4f97 Corrected Earth Shaker wall checks (fixes #1447)
* Earth Shaker is no longer able to hit targets behind walls.
2016-07-25 10:56:44 -04:00
aleos89
d5edd06c6d Corrected Mercenary skills (fixes #1442)
* Adjusted Scapegoat SP requirement from 10 to 5.
* Removed 100% HP requirement of Scapegoat.
* Recuperate now removes Deadly Poison.
2016-07-25 10:49:05 -04:00
Lemongrass3110
fa8296e3c2 Merge pull request #1437 from rathena/bonus/add_drop_rate
Added script bonuses to add player's drop rate

Thanks to @cydh
2016-07-23 19:10:55 +02:00
Lemongrass3110
e7882351d8 Cleaned up player specific drop rate calculations
Removed the src check for the new bonuses.
2016-07-23 18:43:09 +02:00
Jittapan Pluemsumran
6349802d25 Enable Ranger class in bodystyle atcommand 2016-07-22 13:43:57 +07:00
Cydh Ramdh
29379c3ea5 Added script bonuses in order to support official AddReceiveItem_Equip n
* `bonus2 bDropAddRace,r,x;` : Adds x% to player's drop rate when killing a monster with race r.
* `bonus2 bDropAddClass,c,x;` : Adds x% to player's drop rate when killing a monster with race c.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-07-19 16:43:05 +07:00
aleos89
e771472042 Constant cleanup
* Adjusted some IDs to constant values.
2016-07-14 13:51:00 -04:00
aleos89
1a0fb8f821 Updated Golden Thief Bug card immunity (fixes #1400)
* White Imprison and Hell's Plant are now blocked by Golden Thief Bug card.
* Removed an extra status end of White Imprison in Status Recovery.
2016-07-07 20:13:25 -04:00
aleos89
82250c24dd Fixed Leech End damage underflow (fixes #1419)
* Resolves an underflow issue resulting in INT_MAX damage.
2016-07-07 17:19:10 -04:00
Lemongrass3110
fbf7957d21 Changed command definition of atcommand channel
Follow up to 369799a.
Sorry to @secretdataz, it was actually my fault.
Thanks to @lighta for bringing this to our attention.
2016-07-06 14:52:13 +02:00
Jittapan Pluemsumran
369799a6c5
Made atcommand channel unusable by non-players. Closed #1342.
* The command can still be used in scripts if there is a player attached to the script.
2016-07-06 16:40:43 +07:00
aleos89
b3e1c52cbb Corrected Shield Press damage delay (fixes #1165)
* Damage should have a ~1 second delay as the shield animation falls.
2016-07-04 11:47:08 -04:00
Lemongrass3110
d632f100b5 Removed duplicate check in guild creation
Merged from HerculesWS/Hercules@0b7498b thanks to @MishimaHaruna.
2016-07-03 02:11:57 +02:00
Lemongrass3110
63f719a154 Fixed emperium deletion on guild creation
Merged from HerculesWS/Hercules@71c24de thanks to @4144.
2016-07-03 02:06:49 +02:00
Lemongrass3110
4744ee0731 Fixed instance idle timeout
Fixed instances of going into idle mode when there were still users left in the instance.
Thanks to @Darkelfen for reporting it.
Fixes #1412.
2016-07-03 01:52:06 +02:00