2131 Commits

Author SHA1 Message Date
Cydh Ramdh
3fce137cbb Follow up 4019fb4
- Wrong macro for itemdb_is_element, thx @exneval
- Incompatible type issue on UNT_BANDING. bugreport:8616 http://rathena.org/board/tracker/issue-8616-error-while-recompiling/
- Skill usage messages ot conf/msg_conf/map_msg.conf instead following official client fail message by clif_skill_fail() for each failure. (related with skill_require_db.txt)
--> "%s is required." (similar: 28 messages)
-->"[%s] Poison effect was applied to the weapon." (similar: 8 messages)
-->"Please equipped with a %s." (similar: 7 messages)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-07 09:54:59 +07:00
aleos89
4019fb4531 Bug Fixes
* Dragon Breath (Fire and Water) are no longer reduced by DEF or Flee. (bugreport:8378)
* Crush Strike no longer ignores caster's % damage cards.
* Phantom Thrust is now single enemy targetable.
* Fixed Gates of Hell SP cost, range, and sphere cost. (bugreport:7898)
* Cleaned up Tiger Cannon splash damage and remaining HP/SP consumption. (bugreport:8538)
* Fixed Rising Dragon HP/SP regen to work with Spiritual Cadence.
* Corrected Magic Decoy item requirement define not checking for PTS.
* Poem of Netherworld now targets everyone except party members. (bugreport:7741)
* Adjusted a couple skills that have infinite timers to not displays negative time to the client. (bugreport:8549)
* Fixed Sorcerer's Spirit max HP formula. (bugreport:8315)
* Fixed Banding not giving the Overawe effect. (bugreport:7641)
* Fixed Weapon Crush not casting at all. (bugreport:8583)
* Fixed Demonic Fire damage formulas from Fire Expansion.
* Fixed Fire Expansion - Smoke Powder not giving ranged and melee damage reduction. (bugreport:7841)
* Fixed Fire Expansion - Tear Gas not draining HP and not displaying the /cry emoticon. (bugreport:7841)
* Fixed Issen (Killing Stroke) damage formula for pre-renewal. (bugreport:4071)
* Adjusted Warg Strike to be a misc type attack and ignore target's Flee. (bugreport:7599)
* Updated Throw Kunai damage formulas for renewal and pre-renewal. (bugreport:7119)
* Severe Rainstorm is no longer castable on Land Protector. (bugreport:7097)
* Fixed Tropic, Chilly Air, Wild Storm, and Upheaval options not casting their specific autocast skills.
* Updated Fire Cloak, Water Drop, Wind Curtain, and Stone Shield to 100% property resistance and damage.
* Updated Heater, Cooler, Blast, and Cursed Soil damage formulas.
* Increased SP cost of Psychic Wave when Heater, Cooler, Blast, or Cursed Soil are active.
* Updated Zephyr Flee increase bonus.
* Fixed Elemental HP and ATK2 formulas.
* Fixed Sienna Execrate not consuming 2 Red Gemstones. (bugreport:7494)
* Fixed Shadow Chaser's Masquerade skills success rate formula. (bugreport:7436)
* Fixed Exceed Break to restore walk speed when cast is cancelled. (bugreport:7681)
* Vacuum Extreme no longer affects users who are in Hallucination Walk.
* Fixed Hallucination Walk missing magic avoidance.
* Adjusted Lif's Mental Change skill duration to 1 minute, 3 minutes, and 5 minutes respectively per level.
* Hovering will now specifically ignore Skid Trap, Land Mine, Ankle Snare, Flasher, Shockwave Trap, Sandman, Freezing Trap, Blast Mine, Claymore Trap , Quagmire, Gravitation Field, Volcano, Deluge, Whirlwind, Watery Evasion, Electric Walk, Fire Walk, Vacuum Extreme, Windmill, and Moon Slasher. (bugreport:7179)
* Raging Trifecta will now display an animation on usage. (bugreport:1307)
* Cleaned up Auto Shadow Spell check for the specific skills it can cast. (bugreport:8582)
2014-02-06 13:34:39 -05:00
Cydh Ramdh
3441d4a30b * Updated/added item_db, thank https://github.com/ROClientSide/Translation for some item view ids
* Follow up 0724d1e
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 19:07:05 +07:00
Cydh Ramdh
b4bdaebeeb * Replaced INF2_NO_AUTOSHADOWSPELL with INF2_AUTOSHADOWSPELL following AEGIS standard, reverted c9cf222.
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn/
* Removed temporary array while parsing shop NPC, makes remove the limit 100 items each NPC
* Added idRO cash trader according to Chinese New Year event

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-04 12:32:38 +07:00
Cydh Ramdh
c9cf2228a3 * Added skill INF2_NO_AUTOSHADOWSPELL for some skills that cannot be auto casted by Auto Shadow Spell as fix of bugreport:8582, http://rathena.org/board/tracker/issue-8582-shadow-chaserauto-shadow-spell-restricted-spells/
* Removed unused const.txt entries as fix of bugreport:8467, http://rathena.org/board/tracker/issue-8467-left-over-constants-from-mob-controller-system/

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-03 01:17:28 +07:00
Cydh Ramdh
26025e600b * Fixed DB Import that not being read some imported files. bugreport:8543 http://rathena.org/board/tracker/issue-8543-import-folder-nolonger-working/
* Fixed packet_db always be 45. bugreport:8487 http://rathena.org/board/tracker/issue-8487-packet-version-is-always-45-for-map-server/
* Follow up 46ca940

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-02 19:19:37 +07:00
Cydh Ramdh
0ef4047306 Follow up fd063a8 bugreport:8576. Added sc check itself before using sc->data[SC_ALL_RIDING], http://rathena.org/board/tracker/issue-8576-loyal-pets-causing-map-server-to-crash/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-29 20:28:36 +07:00
Lilith
fd063a8e2d * Merged from 3CeAM r689 & r690
- Removed OPTION_MOUNTING
 - Added SC_ALL_RIDING
 - Added new option in battle/player.conf for changing speed of players when mounted: 'rental_mount_speed_boost'
2014-01-28 07:41:06 -08:00
Cydh Ramdh
8fff37eadc * Fixed Fallen Angel behavior that consumes wrong ammo number
* Updated @iteminfo message, for ammo now show the ammo type instead "Arrow/Ammunition"
* Changed some clif_skill_fail messages
* Updated src documentaion for skill_check_castbegin and skill_check_castend

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-28 13:06:47 +07:00
aleos89
3181ff6af1 Follow up to c1871e9
* Fixed experience calculation line that was removed by accident.
* Removed some leftovers changes from tests.
Bug Fix
* Fixed Frigg's Song not giving max HP rate bonus.
2014-01-27 12:31:55 -05:00
aleos89
c1871e91dc Bug Fixes
* Fixed Arm Cannon target type to be ground. (bugreport:8496)
* Fixed Rampage Blaster damage formula. (bugreport:8480)
* Fixed Lightning Walk spirit sphere cost requirement. (bugreport:8474)
* Fixed Deadly Infect to not pass Guillotine Cross poisons to MVPs. (bugreport:8505)
* Fixed Gentle Touch - Cure HP recovery formula. (bugreport:8511)
* Fixed Tiger Cannon taking more HP and SP than it should. (bugreport:8538)
* Fixed Voice of Siren duration time. (bugreport:8382)
* Fixed script command sscanf to return -1 when a string is empty. Thanks to AnnieRuru. (bugreport:8562)
* Fixed VIP bonus experience being included in a monster's death when a Non-VIP kills the monster.
2014-01-27 09:56:16 -05:00
Euphy
11e507bbde Added battle config 'warg_can_falcon'. (tid:63060, credits: 3CeAM r112)
Fixed a documentation issue for @size. (bugreport:8547)
http://rathena.org/board/tracker/issue-8547-size-size/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-26 18:15:30 -05:00
Cydh Ramdh
34ac3bf3bc Fixed Cart Boost (Genetic effect) bureport:8553, http://rathena.org/board/tracker/issue-8553-cart-boost-can-be-dispelled/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-26 16:38:00 +07:00
Cydh Ramdh
a0760f171b * Updated Silent Breeze effect, only gives chance to give silence status to target and the caster (Eira), bugreport:8529, http://rathena.org/board/tracker/issue-8529-homunculus-s-eira-silent-breeze/
* Follow up 80f7984, and some minors

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-24 22:44:26 +07:00
aleos89
27cbc7ff24 Merge pull request #40 from Lemongrass3110/master
Added autotrade persistence support.
- Players who are autotrading during a crash/shut down will be restored on start up.
- Live vendor data is stored in SQL.
- Credits to Ind and Lemongrass.
2014-01-23 07:49:18 -08:00
Lemongrass3110
80f7984acc Dancing skills at invalid coordinates
Added a check whether the cells are valid or not.
Fixes: http://rathena.org/board/tracker/issue-8523-using-dance-skills-on-dark-map-will-crash-the-map-server/
http://rathena.org/board/tracker/issue-8317-warning-connection-to-char-server-lost/?st=40
2014-01-23 16:08:13 +01:00
Cydh Ramdh
a32d3a6e76 * Fixed bugreport:8471, http://rathena.org/board/tracker/issue-8471-star-gladiators-feeling-randomising-map/
* Follow up f4eb33e, 5a2849d

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-20 22:38:10 +07:00
Cydh Ramdh
f4eb33e176 * Fixed some typos on skill_copyable_db.txt that causing Shadow Slash (and other skill?) cannot be copied, bugreport:8500 http://rathena.org/board/tracker/issue-8500-plagi-buggi/
* Follow up f3bb209 also remove unused check of INF3_DIS_PLAGIA since using skill_copyable_db.txt now
* Follow up 96443cd

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-20 03:43:05 +07:00
Cydh Ramdh
5a2849d9ff Fixed bugreport:8514, http://rathena.org/board/tracker/issue-8514-map-server-crash/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-19 21:00:54 +07:00
Lemongrass3110
b7fd4dd274 Unneeded semicolons removed
Removed duplicate slashes
2014-01-14 23:38:12 +01:00
Cydh Ramdh
f3bb209e92 Follow up 6e9796b also as bugreport:8473 http://rathena.org/board/tracker/issue-8473-plagi-bug/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-13 12:40:06 +07:00
Cydh Ramdh
f46a7920e2 * Added warning message when addtimer script is failed, as bugreport:8459 http://rathena.org/board/tracker/issue-8459-addtimer-command-should-report-an-error-if-it-hits-max-eventtimer/
* Follow up 0f7ecd0, 308ee6c, 1f29f50
* Little source documentation updated on script.c

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-11 16:10:22 +07:00
aleos89
0f7ecd0c4d 3rd Class 2011 Post Balance Update
* Contains remaining formula updates for 3rd class skills.
* There are a few bug fixes and corrections to broken skills.
2014-01-10 10:36:53 -05:00
Lilith
32713b9526 * Follow up 40f7014
* Item bonus 'bAddClassDropItem' renamed to 'bAddMonsterIdDropItem'
* Added 2 new item bonuses: bonus3 bAddClassDropItem,n,x,y; & bonus3 bAddClassDropItemGroup,n,x,y; ( see doc/item_bonus.txt )
* Fixed Bug: http://rathena.org/board/tracker/issue-8439-bonus3-baddmonsterdropitem-not-specified-on-one-item%EF%BC%81/
2014-01-10 04:18:12 -08:00
lighta
b92230e33e Cppcheck
Fix typo in race bonus fix : race<RC_NONE_ && race<RC_MAX
Fix bugreport:8418 => clif_instance_changestatus possible mapcrash
Reduce lot of variable scope and fix unsafe scanf
2014-01-09 02:18:51 -05:00
aleos89
65d1ee32e4 Follow up to eca4fa0.
* Fixed a multi-hit damage issue for Falcon Assault (bugreport:8447).
* Fixed unsigned int specifier for sprint (bugreport:8448).
* Fixed WE_MALE and WE_FEMALE checking target rather than caster (bugreport:8449).
2014-01-08 15:27:33 -05:00
Cydh Ramdh
5143c4c36f * Follow up 51074a0: Remove ugly fixed array size! It increases memory usage too much!
* A little optimization on skill_db for skill requirement

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-08 22:14:36 +07:00
lighta
d6caec1c51 Various fixs
Fix bugreport:8418 (possible mapcrash from custom instance script)
Fix bugreport:8439 (pc_bonus_item_drop typos) thx to Baalberith
Fix some errors detected by cppcheck
upd install.sh (leftover of svn and wrong simlink)
2014-01-07 20:15:40 -05:00
aleos89
eca4fa0e38 Bug Fixes
* Fixed an operator check for WE_MALE and WE_FEMALE. Thanks Baalberith.
Optimizations
* Fixed a possible null pointer dereference in Spirit Ball check, Change Cart check, WE_BABY, MH_PYROCLASTIC, and MH_LIGHT_OF_REGENE.
* Fixed a reassigned value being reset before being checked.
* Fixed a homunculus expression always being false because of prior check.
* Fixed sprintf specifier output trying to display int value when return value is unsigned int.
* Fixed a redundant check for when monster's HP is less than 0 when HP is declared as an unsigned int.
* Fixed a redundant check for when uAccLen or uTokenLen are less then 0 when both are declared as unsigned int.
* Various other clean ups.
2014-01-06 14:20:50 -05:00
Matej Pristak
07727d50bc pc_get_child can return NULL > segfault 2014-01-02 00:33:26 +01:00
Cydh Ramdh
6e9796b023 * Follow up 28ecab5, added misisng db/import files
* Follow up 96443cd, seems like for final MaxSP use round() instead floor(). Removed unecessary floor() (Isn't by default, rounding from double to int will be rounded down like floor()?)
* A little clean up on skill_co_copy()

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-01 16:43:40 +07:00
lighta
28ecab5712 DB Import
Add folder import/ into db/ to load all customs
This folder is meant to hold all the customs file you wish override rA
one.
(In short it work like conf import)
related to tid:90199
2013-12-31 18:21:45 -05:00
lighta
b695ab3f41 Fix compilation issue
Follow up dae81222 (AEGIS class system) fix out of bound issue for
array.
(didn't check the x_ALL option system yet)
Follow up 7a9aa7fb Fix possible mapcrash due to offline player
Follow up 12007fef Fix some invalide string check and remove the
reverted sqlfiles
2013-12-30 15:21:25 -05:00
Cydh Ramdh
e18bf43547 * Revert this 487f84e, please import upgrade_20131231.sql. Thank Lemongrass3110 and Toshiro90
* Follow up 7a9aa7f, enum errors
* Follow up 12007fe, function return type error
* Follow up dae8122, 'skill' to 'skill_learnlv'?

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-31 01:52:14 +07:00
aleos89
7a9aa7fbcf Bugfixes
* Fixed WE_MALE and WE_FEMALE up to You to not consume HP/SP when it's below 10%. (bugreport:3546)
* Fixed WE_CALLPARTNER, WE_CALLPARENT, and WE_CALLBABY to not recall target if they are autotrading. (bugreport:2479)
* Fixed WE_BABY not checking for parents if they are in the same party and in the area. (bugreport:2518)
* Fixed Dragon Breath - Water not requiring a dragon. (bugreport:8237)
* Added a new config 'char_del_option' to set whether email or birthdate should be used for deleting characters. (bugreport:8240)
* Follow up to 9a5a6b9. Fixed a missing define check for 2013 clients when deleting a character. (bugreport:8399)
* Fixed Weapon Refining to use clif_upgrademessage. (bugreport:2135)
* Fixed script command 'prompt' not ending script state when player selects Cancel from menu. (bugreport:7932)
* Fixed nomineeffect display on GvG enabled maps. (bugreport:7754)
Others
* All items, except for Cash items, can no longer be used when storage is open.
* Defined constants for a lot of item and monster IDs used throughout the source.
* Follow up to 0f2dd7f. Corrected a change to the wrong hostname array.
2013-12-30 13:20:33 -05:00
Lilith
dae81222a8 * Added AEGIS 'CLASS_' enum
- Removed RC_BOSS, RC_NONBOSS, RC_NONDEMIHUMAN.
 - Added CLASS_NORMAL, CLASS_BOSS, CLASS_GUARDIAN enum.
 - Added CLASS_ALL, RC_ALL, ELE_ALL, SZ_ALL.
 - Item bonuses 'bAddDefClass' and 'bAddMdefClass' replaced by 'bAddDefMonster' and 'bAddMdefMonster'.
 - Item bonuses 'bIgnoreMdefRate' and 'bIgnoreDefRate' replaced by 'bIgnoreMdefRaceRate' and 'bIgnoreDefRaceRate'.
 - Added new item bonuses: bIgnoreDefClass, bIgnoreMdefRaceRate, bDefRatioAtkClass, bAddClass, bSubClass, bMagicAddClass, bWeaponComaClass, bHpDrainValueClass, bSpDrainValueClass, bIgnoreMdefClassRate.
 - Updated doc/item_bonus.txt
 - Updated db/re/level_penalty.txt & 'pc_level_penalty_mod' function.
 - Updated 'battle_calc_cardfix' function.
 - 'md->class_' replaced by 'md->mob_id'
2013-12-30 08:46:24 -08:00
lighta
744195a931 Leak and Optimisation
Fix many typo and optimisation found by :
http://rathena.org/cppreport/index.html
Fix multiple unsafe scanf of string
Fix multiple battle wrong check (elemental bonus)
Fix camouflage defense reduction and cap expiato def reduction
Fix geoip leak
Upd few documentation in doxygen style
Fix path working directory issue to start servers
(now you won't need to be in maindir to launch server)
2013-12-30 02:05:34 -05:00
lighta
cb7e4b44cd Misc Upd
Fix pneuma display for pre-re mode
Add char_maintenance mode to check trought gm_allow_group as a minimum
groupid to enter. (thx to SuperHulk)
Fix UB warning on bonus_script check by type
Properly initialize combo_idx check
2013-12-29 01:28:15 -05:00
Cydh Ramdh
f0c798846d Changed Sleep chance of Lullaby's effect. Chance is increased with INT, http://irowiki.org/wiki/Lullaby
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-29 02:02:37 +07:00
Cydh Ramdh
be05bc399b *Added 'status_icon' param for *bonus_script script, thank QQfoolsorellina for the suggestion (https://github.com/rathena/rathena/commit/99098c1#commitcomment-4558795)
--> bonus_script "<script code>",<duration>{,<flag>{,<type>{,<status_icon>{,<char_id>}}}};
* Please update your sql database (main database) with upgrade_20131227.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-27 18:17:41 +07:00
lighta
90ced830a4 Eleanor Tinder combo
Fix Eleanor Tinder-CBC-EQC being broken since hash:a506c7f due to a
little requirement check typo.
2013-12-27 04:13:30 -05:00
lighta
9cca188908 Itemtype
Fix itemtype IT_ARMOR and IT_WEAPON being inverted, bugreport:8180
please run tools/convert_itemtype.pl to update your dbs.
Upd athena-start having some issue for some os.
Fix a typo on DC_SERVICEFORYOU for val1 assignment.
2013-12-21 01:02:41 -05:00
Cydh Ramdh
e6b0acfb9d Follow up 4ec6925, thx lighta
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-21 11:57:46 +07:00
Cydh Ramdh
4ec69254c3 * Updated Dancer skill's effect: Service For You / Gypsy's Kiss, according to http://irowiki.org/wiki/Gypsy%27s_Kiss
* Fixed bugreport:8363, http://rathena.org/board/tracker/issue-8363-identify/

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-20 16:35:06 +07:00
lighta
854f8fc502 Quickfix
Follow up hash:0f2dd7fcf, fixed a typo on packet lenght for storagelist
this should fix bugreport:8344
Hotfix for bugreport:8333, (we're now checking if we fully add object on
map before attempting to spawn it)
2013-12-19 18:27:01 -05:00
Cydh Ramdh
432cdb7686 Implemented 'devotion_rdamage' on conf/battle/skill.conf for suggestion on http://rathena.org/board/topic/78620-renewal-devotion/
// Using 'old' behavior for devotion vs reflect damage? (Note 2)
// Default is 0 (official). If 'devotion_rdamage' is > 0 (chance to devot the reflected damage),
// when player with devotion attacks player with reflect damage ability (item bonus or skill),
// the damage will be taken by the person who provides devotion instead the attacker.
devotion_rdamage: 0

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-19 12:59:26 +07:00
Cydh Ramdh
3029d3bbc4 * Fxied Telekinesis Intense buff duration (thx Akuma)
* Fixed Earth Strain divest chance (part of rebalancing formula)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-08 16:27:28 +07:00
Cydh Ramdh
7107cc7ce9 * Fixed succes rate of Dark Crow
* Fixed damage rate bonus of Telekinesis Intense

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-07 14:28:37 +07:00
Cydh Ramdh
02d44bf822 Update 'RequirementRemoved' field on 'skill_copyable_db.txt', following 'RequiredEquipment' field on skill_require_db.txt
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-05 13:47:27 +07:00
Lilith-
823c5ae5ae * Follow up fff0437
Added missing 'sc_start' and 'status_change_end'
2013-11-25 05:10:34 -08:00