2131 Commits

Author SHA1 Message Date
aleos89
62a2813adc Bug Fixes
* Fixed Concentration ending when Frenzy is used. (bugreport:8942)
* Fixed Hells Plant hitting Ghost element enemies. (bugreport:8799)
* Forced guild notice changes to save immediately. (bugreport:8961)
* Fixed Cart Tornado damage formula. (bugreport:9065)
* Adjust Amistr's Castling to now switch to any target type. Still needs skill switching support. (bugreport:1784)
* Removed hard coded 1 second skill duration reduction for Spore Explosion.
* Fixed the party window not displaying the correct map name when in an instance. (bugreport:7949)
* Fixed hatching a pet causing client disconnections. (bugreport:9059) (Hercules 533ff4f)
* Updated Kagerou/Oboro skill cast times. (bugreport:9035)
* Removed deprecated negative nameid value for getitem/getitem2.
* Renamed incuvate to incubate throughout source and SQL.
* Added skill ID to the error display for battle_calc_attack to help resolve issues. (bugreport:8876)
* Cleaned and corrected some Sorcerer Elemental skills. (bugreport:9058)
* Cleaned up some more compile warnings.
2014-06-27 15:45:35 -04:00
lighta
b124498263 Fix -WShadow definition warning
Cleanup some leftover
2014-06-27 06:07:50 -04:00
Cydh Ramdh
e7b654aaab - Follow up a8a4425 (bugreport:9062)
- Added check for item group ID usage on item bonus
- Moved this '(sd->class_&MAPID_UPPERMASK) == MAPID_TAEKWON && sd->status.base_level >= battle_config.taekwon_ranker_min_lv && pc_famerank(sd->status.char_id, MAPID_TAEKWON)' to a macro 'pc_is_taekwon_ranker(sd)'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-26 22:12:19 +07:00
aleos89
fff4877004 Bug Fixes
* Fixed the cash shop stacking non-stackable items upon purchase. (bugreport:7580, bugreport:7879, bugreport:8224)
* Fixed an issue with selling pet eggs in the cash shop (Hercules d57781c)
* Cleaned up some compile warnings from CPPCheck. (bugreport:9043)
2014-06-24 14:09:17 -04:00
Cydh Ramdh
0fca530278 * Fixed bugreport:9034 (Hercules aff9c14)
* 'bonus_script' improvement:
-- Added flag values (partial merge from sc_config branch):
-- * 16  : Removeable by Banishing Buster.
-- * 32  : Removable by Refresh.
-- * 128 : Removable by Luxanima.
-- * 256 : Remove when Madogear is activated or deactivated.
-- * 512 : Remove when receive damage.
-- * 1024: Script is permanent, cannot be cleared by bonus_script_clear
-- Added 'bonus_script_clear' command to remove active bonus_script from player (works like sc_end) Thank Napster to mention this. (bugreport:9042)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-20 15:12:42 +07:00
Cydh Ramdh
267d521c00 Bug fixes:
-- Pin code issue after char_refac (bugreport:9027)
-- Delete date issue after char_refac (bugreport:9029)
-- Stuck when drag item from/to inventory/cart/storage if the item cannot be moved. (bugreport:8935)
Command:
-- Added @cloneequip to clone other's equipments.
-- Added @clonestat to clone other's statuses.
-- Thank Antares for the suggestion, http://rathena.org/board/topic/95076-new-atcommands-suggestion/
Permission:
-- Added 'bypass_stat_onclone' to make user who use @clonestat can bypass stat limit.
-- Change 'atcommand_enable_npc' to 'command_enable' permission to enable use command while talking with NPC. Suggested by @aleos long time ago.
Misc:
-- Correcting some checks for bAddEff bonuses.
-- Moved status point calculaiton formula to PC_STATUS_POINT_COST, removing redundancy in pc_need_status_point and pc_maxparameterincrease.
-- Added pc_is_same_equip_index function to move all item index checks, removing redundancy in some cases.
-- Some random in-source documentations.
-- Updated map_msg_idn.conf.

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-15 18:50:21 +07:00
aleos89
7cd82d00db Increased item ID array size.
- Increased limit from 32,767 to 65,535.
- Still uses same amount of memory with doubled usable size.
- Adjusted CARD0_PET from -256 to 256.
- Please run both SQL files after applying this update to avoid values becoming corrupt.
- Tested and works on clients 2012-04-10 and up thanks to Cydh.
- Removed an unused SQL file.
2014-06-12 11:29:10 -04:00
aleos89
b44e5e11f2 Bug Fixes
* Fixed characters moving to unavailable slots using Character Moving System. Thanks to Napster. (bugreport:8987)
* Implemented MD_RANDOMTARGET. (bugreport:8781) (Hercules 10e6f1a)
* Implemented a new define for renewal status point calculation to separate from default renewal define. Thanks to @cydh. (bugreport:8784)
* Follow up to f511107 to fix a compile warning.
* Forcefully save characters before opening a Vending Shop to prevent invalid data from saving. (bugreport:8955)
* Fixed 2013-12-23 client from disconnecting after executing /limitedsale command. Thanks to Napster. (bugreport:9011)
* Fixed Elemental Shield displaying a warning to the console. (bugreport:9016)
* Elemental Shield requires a Blue Gemstone to cast.
* Adjusted Flash Combo to only consume 65 SP.
* Added missing skill_require_db defines for Episode 14.3 Part 2 skills in the pre-renewal database.
2014-06-10 12:24:19 -04:00
Cydh Ramdh
a8a44254e1 * Bug Fixes & Misc
-- Compiling errors when VIP_ENABLE (bugreport:9013)
-- Taekwon skills leftover when player was in Taekwon Ranker then changes to other job (bugreport:8973)
-- Follow up f511107.Fixed parentheses statement.
-- Follow up 6afcdeb. Updated check for char table.
-- Follow up 794c1a8. Wrong SC constanta order.
* Battle Config Updates
-- 'transcendent_status_points', stat point bonus for trans classes.
-- 'revive_onwarp', disable/enable to revive a dead player when set new position (warping).
-- 'taekwon_ranker_min_lv', minimum level bonus of Taekwon Ranker.
-- 'fame_taekwon_mission', fame point gained when complete Taekwon Mission.
-- 'fame_refine_lv1', fame point when success to refine to +10 forged weapon level 1.
-- 'fame_refine_lv2', fame point when success to refine to +10 forged weapon level 2.
-- 'fame_refine_lv3', fame point when success to refine to +10 forged weapon level 3.
-- 'fame_forge', fame point when success to forge level 3 weapon with 3 additional ingredients.
-- 'fame_pharmacy_3', fame point when success do pharmacy 3 times in a row.
-- 'fame_pharmacy_5', fame point when success do pharmacy 5 times in a row.
-- 'fame_pharmacy_7', fame point when success do pharmacy 7 times in a row.
-- 'fame_pharmacy_10', fame point when success do pharmacy 8 times in a row.

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-08 17:04:37 +07:00
aleos89
70aa7e03ee Bug Fixes
* Fixed Spider Web and other trap skills not working correctly on GvG maps. (bugreport:8982)
* Fixed Cloaking Exceed not hiding players from demon and insect monsters. (bugreport:9001)
* Bloody Lust no longer affects monsters. (bugreport:8991)
* Ruwach will no longer damage players in Invisibility. (bugreport:8950)
2014-06-06 10:54:28 -04:00
aleos89
ce8b98b1f4 Bug Fixes
* Fixed Shield Spell not casting correctly. (bugreport:8948, bugreport:8999)
* Fixed Exceed Break attack increase not being applied. (bugreport:8993)
* Fixed Gentle Touch - Energy Gain not adding spirit spheres. (bugreport:9004)
* Updated Magnetic Field SP drain value.
2014-06-02 09:36:27 -04:00
Cydh Ramdh
794c1a8247 Bug fixes & Misc:
-- Map crashed because empty item_combo script (bugreport:8959)
-- Wrong MATK calculation of Distort Crescent/Zangetsu effect (SC_ZANGETSU) (bugreport:8998)
-- Wrong damage reduction of Sera's Pain Killer effect (SC_PAIN_KILLER) (bugreport:8994)
-- Fixed Shape Shift (NC_SHAPESHIFT) wrong requirement (bugreport:9002)
-- @itembound, getitembound usage. Not, now allowed for unspecified bound_type (thank Ceejay Abne! http://rathena.org/board/index.php?showtopic=94726)
-- Change check behavior for skill requirement level-dependent check.
-- Removed NC_REPAIR hardcoded requirement.
-- Moved the required equipped item to 'RequiredEquipment' on skill_require_db.txt.
-- Missing "Option_Ruwach" as contantan.
-- Corrected Chasewalk STR bonus, it's SC_CHASEWALK2, different with SC_INCSTR.
-- Corrected some Rebellion skill's effects.
-- USESKILL_FAIL_MADOGEAR message for failed skill that needs player has Madogear.
-- Changed skill name and description length to 31 chars.
-- Some documentation updates.
-- Follow up 0f2dd7f. (Well, using empty password in import file, won't works, if you want, empty the original conf file. Fix this later, related on 'sscanf' for those files)
-- Follow up 28c90bb, thank @julia40124009
-- Misc. :P

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-31 21:42:44 +07:00
aleos89
5ca8f406e4 Follow up to 1d1a58c when using self skills while storage is open. (Hercules 31486a8) 2014-05-23 12:18:27 -04:00
Cydh Ramdh
7f4a7ba26f * Changed itemgroup from array to DBMap
* Removed MAX_ITEMGROUP limit
* Changed player bonus fixed array
* Minor changes

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-23 01:49:49 +07:00
aleos89
1d8bec3100 Bug Fixes
* Adjusted Falcon Assault to take arrow elements into effect. (bugreport:7572)
* Cleaned up Self Destruction damage calculation. (bugreport:8941)
* Cleaned up Dragon Breath damage calculation.
* Fixed Millennium Shield, Crush Strike, and Refresh durations. (bugreport:8981)
* Fixed Makibishi area of effect. (bugreport:8963)
* Cleaned up some MOBID_* defines.
2014-05-21 09:54:56 -04:00
aleos89
577079b331 Bug Fixes
* Added missing feature flag for the Auction System. (bugreport:8980) (Hercules 646f7e2)
* Some more clean ups to skills that have a sliding effect. Thanks to exneval.
* Adjusted Flash Combo damage for renewal.
* Moved Explosion Spirits timer and added extra check to avoid map server crashes.
2014-05-17 14:59:59 -04:00
aleos89
e4ab3be344 Bug Fixes
* Fixed a typo in a define. Thanks to exneval.
* Fixed a potential crash with Ankle Snare. (bugreport:8977)
* Fixed a potential crash with Explosion Spirits SP recovery. (bugreport:8978)
* Cleaned up Fire Expansion - Acid, Varetyr Spear, Kunai, Dark Crow, Counter Slash, Taekwon Kicks, Freezing Trap, Weapon ATK Element bonus, and Force of Vanguard damage formulas.
* Added missing Research Fire Earth VIT bonus.
* Fixed some potential issues with ATK calculations. Follow up to 89ef868's battle calculation cleanup. Thanks to exneval.
* Another follow up to 89ef868 to resolve Extremity Fist sliding effect.
* Various clean-ups.
2014-05-16 13:31:03 -04:00
aleos89
b0bc48571b Bug Fixes
* Cleaned up Weapon Research and Cart Revolution bonuses.
* Added missing Hit bonus for Training Axe.
* Removed an extra check for Research Fire Earth.
* Updated Dragonology race bonuses rate for renewal.
* Fixed Knuckle Arrow sliding effect.
* Bows should not get a refine bonus.
2014-05-15 15:03:05 -04:00
aleos89
89ef868650 Bug Fixes
* Fixed Extremity Fist sliding issue getting players stuck in un-walkable cells. (bugreport:8949)
* Updated Cursed Circle against the target behavior.
* Updated Tinder Breaker snap behavior.
* Fixed Crush Strike to work with Auto Counter. (bugreport:6919)
* Fixed Fire Expansion - Acid skill animation.
* Fixed Spider Web not trapping targets. (bugreport:8958)
* Feint Bomb cannot be used on top of Land Protector.
* Fixed Slow Grace movement speed penalty. (bugreport:8946)
* Updated Camouflage to official effects.
* Fixed Beyond of Warcry decreasing critical rather than increasing.
* Fixed Zephyr flee bonus to be a solid 25 increase.
* Decrease Agi, Quagmire, Slow Grace, and Adoramus are no longer affected by SC_SPEEDUP1.
* Fixed Warg Strike to be a weapon attack type. (bugreport:8917)
* Fixed Explosion Spirits to double SP regen tick rather than halve SP regen rate. (bugreport:8936)
* Fixed Millennium Shield, Crush Strike, and Refresh having their cooldown values in the wrong field. (bugreport:8957)
* Cleaned up the status change table for 3rd class skills applying/removing SCB's that should/shouldn't be calculated.
* Updated Saturday Night Fever to official effects.
* Updated Berserk damage formula for renewal versus pre-renewal.
* Fixed Masquerade - Laziness not reducing movement speed.
* Updated the behavior of Frigg's Song.
* Updated Light of Regen, Xeno Slasher, and Silent Breeze skills.
* Updated several Homunculus S skill cast values.
* Deadly Infect will now only spread for short ranged attacks.
* Abundance and Guillotine Cross Poisons no longer overlap.
* Fixed Upheaval and Cursed Soil not giving their respective Max HP bonuses. (bugreport:8951)
* Fixed Solid Skin not giving DEF bonus.
* Fixed Stealth Field to properly hide players.
* Burning now reduces MDEF and has an icon.
* Updated the way skills that give equipment attack are calculated. Thanks to exneval.
* Updated the official item delay message.
* Cleaned up some other issues/left overs.
2014-05-14 14:35:24 -04:00
aleos89
c046668034 Bug Fixes
* Updated Earth Strain's equipment divest chance to include Base Level and DEX. (bugreport:8922)
* Updated some skill usages on certain maps. (bugreport:8923)
- Masquerade - Ignorance is no longer usable in instances.
- Dimension Door, Chaos Panic, Bloody Lust, and Sling Item are no longer usabled in towns.
* Updated Earth Drive and Shield Press damage formulas.
* Fixed Raigekisai dealing damage too quickly which was causing double damage. (bugreport:8926)
* Electric Shocker, Reverberation, and Poem of Netherworld cannot be knocked back.
* Updated the effect of Poem of Netherworld, Reverberation, Electric Shocker, and Wall of Thorn to official.
* Updated the skill unit layouts for Man Hole, Dimension Door, Chaos Panic, Maelstrom, and Bloody Lust.
* Zephyr will no longer affect Elementals.
* Dragon Breath and Self Destruction will no longer consider VVS and masteries.
* Updated Vellum Weapons item script to official.
* Masquerades cannot be casted on MVPs.
* Unequipping Hovering Booster will remove Hover.
* Fixed a typo in the map_msg.
* Updated the monster mode documentation.
2014-04-24 12:05:22 -04:00
aleos89
f7c09d95fd Bug Fixes
* Spell Fist will now double damage with Double Attack and fixed damage formula. (bugreport:7024)
* Follow up to 06986d6 to fix Fire Expansion casting the wrong Acid Demonstration skill (magic type). Thanks to @Traxis.
* Fixed Rebound not removing the Decrease Agility status icon. (bugreport:8910)
* Fixed Full Throttle SP reduction rate.
* Gates of Hell now uses weapon element and is forced neutral for the final element. (bugreport:8875)
* Fixed Auto Counter to work with Crush Strike. (bugreport:6919)
* Fixed Masquerade-Groomy renewal ASPD penalty.
* Updated Acceleration, Hovering, Self Destruction, Shapeshift, Emergency Cool, Magnetic Field, Neutral Barrier, Stealth Field, and Repair skill item requirements to only check the player's inventory rather than equipment list. (bugreport:8911)
* Fixed Magnetic Field to stop players from walking in non-PvP maps. (bugreport:8911)
* Charms will now be removed when another Charm element is used. (bugreport:8914)
* Crazy Weed now destroys Man Hole and Dimensional Door.
* Man Hole and Hells Plant are able to be casted on top of players. (bugreport:8918)
* Items are now usable while stuck in Man Hole. (bugreport:8918)
* Fixed Extremity Fist naturally regaining SP during the 5 minute cooldown. (bugreport:8920)
* Fixed an issue with Extremity Fist position updating.
* Fixed Issen's damage calculation order of magnitude. Thanks to @chriser-.
* Updated the SCS_NOCAST table.
2014-04-21 14:49:39 -04:00
aleos89
d1e04fa3c1 Follow up to 1d1a58c to revert some Reading Spellbook conversions. 2014-04-16 13:42:48 -04:00
aleos89
1d1a58cdcb Bug Fixes
* Removed unused guild aura leftovers and fixed some other issues with setting the guild aura. (bugreport:8892)
* Fixed Fire Expansion Acid to be a magic type attack. Thanks to exneval.
* Cleaned up some remaining issues with Issen. (bugreport:8905)
* 16th Night (Izayoi) should remove fixed cast time from all skills.
* Circle of Nature is now part of Group B songs.
* Updated Reading Spell Book spell memorization to official.
* Updated homunculus skill cooldowns.
* Added missing Holy element bonus for Hesperus Lit.
* Fixed Coluseo Heal and Praefatio not giving a party bonus. (bugreport:8904)
* Fixed the status icon for ALL_RIDING not being displayed at login.
* Adjusted the notice display order when players login. (Hercules df1952d)
* Self skills can now be used while storage is open. (Hercules 6f6a6b3)
* Cleaned up SC_NOCHAT/Manner system. (Hercules 94ef1ee)
2014-04-16 11:06:09 -04:00
aleos89
06986d6540 Bug Fixes
* Updated Fire Expansion to official effects. (bugreport:8893)
* Updated Illusion Doping area of effect and hit reduction. (bugreport:8560)
* Cleaned up Full Throttle.
-- Thanks to exneval.
2014-04-13 15:46:49 -04:00
aleos89
d3d34aa5d2 Bug Fixes
* Follow up to 2fe8140 to fix quest_db.txt not being imported anymore. (bugreport:8891)
* Fixed Epiclesis to only run every 3 seconds and added animation display for healing HP and SP. (bugreport:8890)
2014-04-11 11:15:10 -04:00
aleos89
0bbfdfbd85 Bug Fixes
* Fixed Gentle Touch - Energy Gain not gaining spheres. (bugreport:8882)
* Adjusted Full Throttle's cooldown to be 30 minutes. (bugreport:8887)
* Warmth of the Sun/Moon/Stars are now placeable on Land Protector. (bugreport:175)
* Fixed Mechanic's Axe Mastery to give (4 * skill level) ATK bonus for Mace weapons.
* Cleaned up Cart Boost and Camouflage bonus damage.
* Fixed Envenom pre-renewal bonus damage missing. (bugreport:7953)
* Fixed Eska not reducing movement speed. (bugreport:2792)
* Fixed Marsh of Abyss reducing movement speed below 50%. (bugreport:7424)
2014-04-10 11:15:30 -04:00
aleos89
e07a11186d Updated clif_message enum and appropriate clif_msg* functions. 2014-04-09 15:10:58 -04:00
aleos89
81ca299d91 Bug Fixes
* Fixed Overbrand swing damage ground placement. (bugreport:8856)
* Fixed Wug Dash not getting ATK bonus from Tooth of Wug.
* Cleaned up Gates of Hell damage formula.
* Corrected Hell Gate skill define to be passive.
* Added missing immobilization duration reduction for Poem of Netherworld and blocked it from working on MVP. (bugreport:8877)
* Cleaned up NPC_RUN to show e_hlp and not get stuck in a follow state. (bugreport:8875)
* Fixed item bonus DefRatioAtkEle/DefRatioAtkRaceDefRatioAtkClass not working for left handed weapons. (bugreport:8495, bugreport:8808, bugreport:8847)
* Fixed SubSize/SubRace/SubClass stacking to create 100+% immunity. Thanks to @cydh. (bugreport:8827, bugreport:8879)
* Small cleanup to clif_parse_StatusUp.
* Fixed Sling Item to copy the source skill ID and not the dummy ID.
* Fixed spirit spheres not giving ATK bonus. (bugreport:8130, bugreport:8285, bugreport:8686)
* Acid Demonstration is now forced to neutral in renewal.
* Follow up to e2d2494 to fix cooldown for Unlimit.
* Follow up to e2d2494 to clean up some compile warnings.
* Follow up to da0da73 to fix SC_ITEMSCRIPT to only use an icon if val2 is not empty.
2014-04-09 10:10:32 -04:00
aleos89
3269d0f9af Follow up to 26afd76 to fix Elemental Shield. (bugreport:8872) 2014-04-04 19:13:43 -04:00
aleos89
e2d2494e13 Bug Fixes
* Fixed Main Frame Restructure not giving DEF bonus when wearing Madogear. (bugreport:8863)
* Updated some more damage formulas for Kagerou skills.
* Fixed critical damage bonus from Monster Transformation system.
* Fixed Fire Trap and Ice Trap Burning/Freezing chance.
* Cleaned up the visual effects for Ranger traps.
* Odins Power now decreases DEF/MDEF by 40 at level 2. (bugreport:8869)
* Added skill define for Overbrand's Plus Attack.
* Fixed an issue with Overbrand's pierce damage placement. (bugreport:8856)
* Fixed Unlimit not updating DEF/MDEF on players and increased the cooldown to 5 minutes. (bugreport:8870)
* Few status icon updates.
* Fixed two compile warnings when the VIP system is enabled.
2014-04-04 15:37:29 -04:00
aleos89
d876272283 Bug Fixes
* Cleaned up the card fix calculations once more. (bugreport:8848)
* Fixed Kaite pre-renewal effect. (bugreport:6415)
* Fixed a possible crash from Elemental Action.
* Cleaned up the costume atcommand messages.
* Fixed a few issues from the CppCheck report.
2014-04-03 14:38:58 -04:00
aleos89
44ddd96365 Bug Fixes
* Updated Poem of Braggi cast time reduction bonus from Musical Lessons to only be 1% per level.
* Updated Don't Forget Me ASPD decrease and movement speed formulas.
* Updated many renewal and some pre-renewal status changes that effect ASPD to official.
* Cleaned up some various status change formulas.
2014-04-02 15:23:35 -04:00
aleos89
744eb0e532 Follow up to 0fed97c to include a warning when skill_unit_layout/skill_nounit_layout has overflowed to prevent future issues. 2014-04-01 15:08:25 -04:00
aleos89
0fed97c1d9 Bug Fixes
* Follow up to 6e795af expiration timer passing wrong time value. Thanks to @MrKeiKun.
* Follow up to 26afd76 to force players to use skill_sit before pc_setsit to invoke pc_stop_walking and pc_stop_attack first.
* Follow up to 26afd76 to revert change on Extremity Fist status icon.
* Fixed some Gentle Touch - Revitalize typos.
* Fixed some Gentle Touch - Energy Gain typos. (bugreport:8846)
* Corrected Explosion Spirits effect for renewal. (bugreport:8842)
* Rebound status from Full Throttle will now disable HP and SP regeneration.
* Fixed Mainframe Restructure not giving DEF bonus. (bugreport:8840)
* Added Hiding and Sight to the list of skills not usable while riding Mado using _INF3 and removed hardcoded checks.
* Increased the max skill unit layout to accommodate the addition of Fire Rain. (bugreport:8775)
* Fixed Unlimit to not work with Warg skills and sets DEF/MDEF to 1 per Ziu's tests.
* Fixed damage and life (hits) for Wall of Thorn.
* Added an extra check for Crescent Elbow to check for short range and to handle knockback with the autospell skill.
2014-04-01 14:26:37 -04:00
aleos89
26afd769ce Bug Fixes
* Fixed Chorus songs causing the map server to crash. (bugreport:8817, bugreport:8819)
* Updated renewal Arrow Shower area to be 5x5 for levels 6-10.
* Neutral Barrier should effect all targets and only block Earth Quake splash damage.
* Only party and guild members should be affected by Stealth Field.
* Fixed Cloud Kill layout to be 7x7.
* Feint Bomb should explode after half a second.
* Fixed Fire Rain unit ID causing Fire Wall, Ice Wall, and other unit skills to display improperly. (bugreport:8775)
* Updated the effects of Banana Bomb, Concentrated White Potion Z, and Vitata 500.
* Fixed Gentle Touch - Revitalize HP regeneration calculation.
* Fixed Gentle Touch - Change making MDEF go below 0 and doing too much damage. (bugreport:8690)
* Fixed Gentle Touch - Energy Gain not adding spirit balls when doing damage.
* Fixed Gentle Touch - Cure to heal players who are wearing a shield with the Golden Thief Bug card. (bugreport:8815)
* Fixed Tear Gas /sob emoticon not stopping when the skill ended.
* Fixed Kagerou/Oboro charms not applying to specific skills. (bugreport:8823)
* Updated some other Kagerou/Oboro skills. Thanks to idAthena.
* Players will stop attacking when forced to sit through skill_sit. (bugreport:8796)
* Fixed Extremity Fist not removing natural SP regen flag and adjusted the icon to show for the 5 minute duration. (bugreport:8811)
* Implemented the official effect for Chaos Panic. (bugreport:8520)
* Fixed a small typo for the knockback of Crescent Elbow.
* Fixed Cross Slash not checking for players wearing Shields + Dagger/Sword. (bugreport:8797)
* Synced up the 3rd class pre-renewal skill database files with the renewal skill database files.
2014-03-28 15:12:23 -04:00
aleos89
1f26499994 Bug Fixes
* Fixed Group A Songs not showing their respective skill animation. (bugreport:7379)
* Fixed Cart Revolution pushing targets East rather than West. (bugreport:8806)
* Chemical Protection should not remove Strip status. (bugreport:8807)
* Concentration now casts Endure. (bugreport:4262, bugreport:8756)
* Fixed the Riding Mount icon not showing up after relogging for Dragons and Mado Gear. (bugreport:8805)
* Crescent Elbow will now knock the target back 8 cells.
* Other miscellaneous cleanups.
2014-03-20 12:59:18 -04:00
lighta
51f26d43d2 Follow up e0c8e01
Move skill_get_cooldown_ into pc_get_skillcooldown
and add a short src_doc description to promote his usage
(and avoid duplicate code)
Fix few cppcheck issues (variable scope optimisation mostly)
2014-03-18 17:36:23 -04:00
aleos89
e0c8e01e08 Fixed Release not storing the cooldown of the skill that is released. (bugreport:8800) 2014-03-18 15:13:19 -04:00
aleos89
c7c5f7e89e Bug Fixes
* Fixed Venom Splasher consuming a second Red Gemstone. (bugreport:8506)
* Corrected Final Strike's damage formula. (bugreport:8648)
* Shield Boomerang should always be a neutral attack.
* Shield Chain should always take the element of the weapon.
* Updated Occult Impact damage and force element to neutral on final attack. (bugreport:7462)
* Added a list of skills that get forced to neutral for the final attack in renewal mode. Merge from idAthena.
2014-03-17 14:37:28 -04:00
aleos89
79fbd3bc69 Bug Fixes
* Updated Pointpoint Attack to also have a chance to break Helm equips. (bugreport:8735)
* Fixed Feint Bomb stacking with Hiding and Stealth. (bugreport:8346)
* Updated the trigger area of Feint Bomb to be 3x3 and AoE is 5x5. (bugreport:8346)
* Fixed Chemical Protection not removing Strip effects. (bugreport:8746)
* Fixed Warg Strike's Warg requirement, reverted to misc attack, and ignores target's Flee. (bugreport:8732)
* Warg Bite and Warg Dash now ignore target's Flee.
* Corrected Epiclesis HP/SP recovery timer. (bugreport:8751)
* Fixed Crimson Moon not working with Epiclesis.
* Updated Spirit Sphere requirement for Gentle Touch - Cure to 1.
* Fixed Shield Boomerang not taking weapon element into account. (bugreport:8757)
* Homunculus skill re-use delay is no longer reset when vaporized.
* Lauda Agnus and Lauda Ramus can now be casted when the caster is not in a party.
* Cart Revolution will now always knock targets to the West (added config to disable). (bugreport:8753)
* Updated all non-3rd class skills cast times. (Hercules e2fdc3b)
* Corrected Prestige magic evasion formula. (bugreport:8737)
* Poem of Netherworld will now only effect enemies except in WoE. (bugreport:8771)
* Poem of Netherworld can be removed by Status Recovery and Lion Howling.
* Updated Deep Sleep, Crystalize, and Vacuum Extreme to use base status. (bugreport:8749)
* Self Destruction now ignores target's DEF cards.
* Fixed Raising Dragon not recovering SP. (bugreport:8769)
* Fixed Charm bonuses for Kagerou/Oboro. (bugreport:8319)
* Moved calculation for Chorus bonus.
* Fixed Over Brand damaging targets on the entire map. (bugreport:8736)
* Fixed Cast Ninja Spell not randomly picking a status ailment to cast on target. (bugreport:8774)
2014-03-17 11:37:36 -04:00
Cydh Ramdh
dd67f9de96 Bug Fixes:
- 'hp_rate' and 'sp_rate' config aren't working. http://rathena.org/board/tracker/issue-8742-max-hpsp-battleconf-not-working/
- Mercenary DB that aren't being read properly whic also happens for Homunculus DB. http://rathena.org/board/tracker/issue-8761-mercenary-db-import-folder-issue/
- Fixed Elemental DBs that aren't being imported yet. (also changed to sv_readdb)

Rebellion Skill Updates:
- Some updates according to kRO updates on http://forums.irowiki.org/showpost.php?p=1364894&postcount=579, http://forums.irowiki.org/showpost.php?p=1388802&postcount=981, and http://forums.irowiki.org/showpost.php?p=1389627&postcount=1008
- Partial merge from idAthena.
- Using 0x107 as temporary marker on mini-map for Crimson Marker target.
- Some stuffs maybe still wrong, feel free to report/fix it.
- Thank people on those links, Ziu, and idAthena.

Misc changes:
- Changed some function names for homunculus.c/h with prefix hom_* and mercenary.c/h with prefix mercenary_*
- Change unnecessary 'int' return value tos 'void'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-13 23:59:29 +07:00
Cydh Ramdh
0766c73229 Bug fixes
* Fixed wrong bonus for Max HP (bugreport:8679)
* HP/SP respawn (restart_hp_rate and restart_sp_rate) should be work now (bugreport:8642)
* Fixed MVP drop that failed to make random order (bugreport:8665)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-08 04:27:36 +07:00
aleos89
2dece5586d Bug Fixes
* Follow up to 2cd1e8c compile error. (bugreport:8733)
* Implemented official hiding effect for Feint Bomb. (bugreport:8346)
2014-03-07 15:51:16 -05:00
aleos89
2cd1e8c393 Bug Fixes
* Reverted a change made to Raising Dragon for HP/SP Regen.
* Fixed Rage Burst not consuming Rage Counters on use. (bugreport:7975)
2014-03-07 14:19:09 -05:00
aleos89
5aa2f17fc1 Bug Fixes
* Fixed Guild Auras applying to other guilds. (bugreport:7073) (Hercules 81caf70, 7fc0697, eb53067)
* Fixed wrong packet being used for storages on 20071002 and older clients.
2014-03-07 11:53:14 -05:00
aleos89
df1b99212b Bug Fixes
* Updated /stats+ to support 2013-12 and newer clients. (bugreport:8726) (Hercules 42b5c04)
* Guild auras will no longer be removed on Land Protector. (Hercules 186fbc5)
* Fixed the animation for logout. (Hercules 3f473c2)
2014-03-06 15:14:26 -05:00
aleos89
499010d34c Bug Fixes
* Fixed Gates of Hell range check. (bugreport:8680) (Hercules d554d61)
* Updated All Odin Power to official effects. (Hercules d554d61)
* Removed the range check from Hell Gate.
* Sorcerer Insignias are now disabled on Land Protector.
* Fixed Rush Windmill adding BATK rather than WATK.
2014-03-06 13:18:37 -05:00
aleos89
f6cc486ab7 Bug Fixes
* Taekwon stances will now be removed on logout to prevent them being permanently on when a Taekwon is no longer ranked. (bugreport:8614)
* Added a battle config (taekwon_mission_mobname) for Taekwon Mission to check for kills based on monster names, off by default. (bugreport:8614) -- Credits to clydelion for the base.
* Removed a case that ignores damaging a target when they are on the same cell as the caster for Frost Nova. (bugreport:8705)
* Removed a skill unit check for Overbrand. (bugreport:8711)
2014-03-04 13:53:58 -05:00
aleos89
4534bd4b1d Follow up to 96c768f.
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Fixed Circling Nature HP regeneration formula. (bugreport:8670)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8715)
* Fixed Overbrand skill attack. (bugreport:8627)
2014-03-03 09:11:25 -05:00
aleos89
96c768f9b7 Bug Fixes
* Fixed Severe Rainstorm damage formula. (bugreport:8581)
* Caster can no longer switch equips for the duration of Severe Rainstorm. (bugreport:8581)
* Cleaned up Demonic Fire and Fire Expansion combos. (bugreport:8620)
* Fixed Dragon Breath - Fire/Water damage formula and not being reduced by DEF or Flee. (bugreport:8620)
* Fixed the movement speed formula for Camouflage. (bugreport:8619)
* Fixed Overbrand Brandish area damage. (bugreport:8627)
* Fixed cast time for Magical Amplification.
* Fixed Moonlit Serenade MATK increase. (bugreport:8697)
* Fixed Phantom Thrust not casting. (bugreport:8652)
* Fixed Gentle Touch - Cure healing formula. (bugreport:8699)
* Fixed Wall of Thorns not dealing damage to players who touch it. (bugreport:8673)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8286)
* Fixed Feint Bomb damage formula. (bugreport:8593)
* Fixed Circling Nature HP recovery and SP consumption being reversed. (bugreport:8670)
* Fixed Judex area of effect to be 3x3. (bugreport:8672)
* Fixed Abracadabra skill "Summon Monster" not displaying the monster's name. (bugreport:8671)
* Fixed Sight Blaster duration. (bugreport:8656)
* Fixed Ignition Break area of effect damage. (bugreport:8653)
* Fixed Poem of Netherworld not immobilizing enemies. (bugreport:8607)
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Adjusted Tiger Cannon damage formula and allow to bypass target's flee. (bugreport:8625)
* Fixed Self Destruction not working on self. (bugreport:8633)
* Fixed Repair not healing or consuming item requirements. (bugreport:8633)
* Fixed Silver Sniper and Magic Decoy AI types not being counted towards the land skill limit. (bugreport:8407)
* Fixed Silver Sniper bonus ATK formula.
* Fixed Magic Decoy maximum HP formula.
* Fixed Lion Howling damage formula. (bugreport:8654)
* Fixed Rapid Throw (Muchanage) damage formula. (bugreport:7861)
* Stasis no longer allows casting of Chorus skills.
* Fixed Chorus skills not checking for additional partners. (bugreport:6052)
* Body Paint no longer removes Chase Walk or Invisibility. (bugreport:6801)
* Recognized Spell is no longer cleared by Dispell or Abundance. (bugreport:6718)
* Epiclesis now removes Cloaking Exceed and will heal while in the Frenzy state. (bugreport:6679)
* Renovatio now heals while in the Frenzy state. (bugreport:6679)
* Fixed Firing Trap not having the fire element. (bugreport:8707)
* Fixed Icebound Trap not having the water element. (bugreport:8707)
* Fixed Axe Tornado not doing less damage for targets outside of the 5x5 area of effect.
* Updated the list of effects that Inspiration makes the caster immune to. (bugreport:5735)
* Cleaned up the effects of Vacuum Extreme to work as it should in GvG maps. (bugreport:6031)
* Corrected durations for Millennium Shield, Crush Strike, Refresh, and Weapon Crush.
2014-02-28 15:18:45 -05:00