2131 Commits

Author SHA1 Message Date
aleos89
06eab75006 Cleaned up Impressive Riff ASPD formula
* Renewal - No longer has to be /10 each time.
* Pre-renewal - Calculated separately from renewal formula.
2016-06-29 10:14:59 -04:00
aleos89
82af619dfd Refactored clif damage type calls
* Cleaned up the calls for e_damage_type to use the constant value.
2016-06-27 12:48:26 -04:00
Jittapan Pluemsumran
26aa69d6ef
ECL_SQUOIA now removes SC_DECREASEAGI 2016-06-24 20:16:49 +07:00
aleos89
aa5d7a4d2d Corrected Knuckle Arrow's effect (fixes #1071)
* Caster will now move beside the target, not on top of the target.
* Boss monsters and knock back immune players (through items or Basilica) are not pushed and don't receive the bonus damage.
2016-06-07 10:06:23 -04:00
aleos89
ab576e9bf8 Corrected Warmer's effect (fixes #1097)
* Moved the healing effect to status change timer.
* Warmer's effect will now last the entire life of the unit.
* Warmer's effect will now be removed when a player leaves the unit.
* Corrected Cloud Kill unit flag not being applied.
2016-06-06 09:47:03 -04:00
aleos89
e39293f129 Follow up to 19f2bc5
* Reverted parts of the Earth Quake cleanup.
* Added the missing 100% damage increase for levels 5 and higher.
* Corrected the hit rate to be 2x not 1.2x.
* Commented out the unofficial ATK2 damage increase.
2016-06-02 18:39:17 -04:00
Playtester
1640b40236 Official Enchant Blade damage (fixes #975)
- Implemented the fully official damage calculation for this skill, it's now 100% accurate
** Partially reverted c3f4618
** The damage bonus is: [((SkillLv x 20) + 100) x srcBaseLevel / 150] + srcINT + srcMATK - tarMDEF - tarMDEF2
** The damage bonus from base level and INT is calculated when the status change starts
** The damage bonus from MATK and the reduction from MDEF/MDEF2 is calculated per hit
2016-05-26 20:06:24 +02:00
Jittapan Pluemsumran
6f0ed156f4
Fixed #1114
Made Rhydo rune undispellable.
Correct variable type in Old Glast Heim script.
Thanks to @nehpetskie
2016-05-25 19:18:07 +07:00
aleos89
cc30d9df09 Resolved some map blocks not getting freed
* Fixes Bio Explosion, Suicide Bombing, and Summon Legion not properly freeing map blocks.
Thanks to @Tokeiburu!
2016-05-23 14:55:49 -04:00
aleos89
4f3468958f Added a map cell check for Shadow Leap (fixes #1291)
* Resolves players being able to enter non-walkable parts of maps.
Thanks to @Tokeiburu!
2016-05-21 09:47:59 -04:00
aleos89
19f2bc597c Corrected NPC Earthquake skill (fixes #1289)
* Properly implemented the skill as a unit skill.
* Corrected the damage calculation and removed attempts at diving by zero.
* The skill now ignores the target's defense.
2016-05-20 14:00:58 -04:00
Jittapan Pluemsumran
4a671ea379 Merge pull request #1183 from secretdataz/fix/holywater
Aqua Benedicta/Water Ball official behavior. Fixes #1119
2016-05-20 19:10:45 +07:00
Jittapan Pluemsumran
935235cea0
Item bonus bAddEff should not effect the user when hit by own skill. Fixes #720 2016-05-20 13:01:24 +07:00
aleos89
fe4eefb787 Implemented script command active_transform (fixes #1006)
* Works the same as script command transform and can be stacked with it as well.
* active_transform has display priority if transform is active.
Thanks to Ziu and @Darkelfen!
2016-05-16 14:15:22 -04:00
aleos89
4c617bcd59 Corrected Graffiti removing all units (fixes #1263)
* Graffiti will no longer remove all units of the Rogue class.
* Graffiti will now fail to cast again if a Graffiti already exists on the map.
* Graffiti should only be removed on map changes, but Remover/Cleaner still removes it (custom) since the skill was never officially implemented.
2016-05-14 09:39:40 -04:00
Florian Wilkemeyer
f7bc696335 map-server: increased size of skilldb_id2idx[] array, to prevent out-of-bounds access.
Bug:
It was Initially declared as size of UINT16_MAX (0xffff) but as the skill-id itself which will be used
as offset can reach this value, it's too small.
2016-05-04 21:57:10 +02:00
Playtester
8a37f1b2a9 Marionette Control, Mechanic Back/Front Slide
- Marionette Control now has a range of 7 (fixes #1239)
- Mechanic Back/Front Slide skills are no longer blocked by gear that makes you knock-back immune (fixes #1227)
2016-05-03 22:04:43 +02:00
Playtester
89f86b2533 Lunatic Carrot Beat, Catnip Meteor, Grand Cross (fixes #1219)
- Lunatic Carrot Beat and Catnip Meteor now deal 300% to 700% damage which is calculated once and split between multiple hits rather than calculating damage per hit; despite this, they can still hit plants
- Reduced cast time of Lunatic Carrot Beat from 3000ms to 1500ms and cooldown from 8000ms to 6000ms according to latest tests on kRO
- Fixed Catnip Meteor still having a fixed cast time
- Increased stun chance of Lunatic Carrot Beat from 10% to 20%
- Increased curse chance of Catnip Meteor from 10% to 20%
- Increased cast time of Grand Cross in pre-re to 3000ms (see #1140)
- Fixed Grand Cross sometimes having 4 intervals instead of 3 (see #1140)
2016-05-02 23:27:08 +02:00
aleos89
cb52138eaa Corrected Tiger Cannon combo bonus (fixes #1233)
* Tiger Cannon combo bonus should not be applied when used through Flash Combo.
* Follow up to e30df46.
2016-05-02 13:01:18 -04:00
aleos89
ba1c45c45d Fixed an issue with Chorus skill range (fixes #1162)
* Follow up to 497cca1.
* Resolves some Chorus skills not activating properly.
2016-04-29 16:21:11 -04:00
Florian Wilkemeyer
2a60f56a7a map-server: skill-subsystem: removed yet another useless DBMap (skilldb_id2idx).
As a skill ID is UINT16 && our skill index is also UINT16 - there is absolutly NO need for a B-Tree.
The lookup id2idx is done really often. so a tree-traversal is a bit too costly here.

The new -array based- implementation will consume 256 KiB on 32 Bit && 512 KiB memory to provide
a static lookup table.
2016-04-23 16:45:45 +02:00
Florian Wilkemeyer
80d4474bc7 map-server: cleanup: skilldb_name2id declared in header not in source-file. 2016-04-23 16:24:07 +02:00
aleos89
55e4df14c2 Overhaul of the mob mode system
* This rewrite allows for better adaptation from the Aegis Class and Attribute fields.
* Refactored the renewal level penalty function.
* Slaves are now properly assigned an official slave mode of CanWalk, CanAttack, and NoRandomWalk.
* Removed extra Boss checks and adjusted others to use their proper functions.
* Properly implemented Skill Immunity mode to match Aegis.
* Separated MVP and Boss modes.
-- MVP mode defines when mobs should give MEXP, MVP Drops, and show the MVP sign.
-- MVP now have their own item drop configurations.
* Updated the mob_db and mob_skill_db to match the new mode structure.
-- Included a Perl tool (tools/convert_monstermode.pl) to allow people to convert their custom mobs to the new mode structure.
Thanks to @Playtester and @Lemongrass3110 for help with debugging and information!
2016-04-18 14:49:27 -04:00
aleos89
e30df46797 Fixed Tiger Cannon and Sky Net Blow splash damage (fixes #1025)
* Tiger Cannon and Sky Net Blow will now properly give Combo State bonus damage to splash targets.
* Corrected Flash Combo not delaying attacks, acting, and item usage for the entire cast time.
2016-04-17 10:51:16 -04:00
Jittapan Pluemsumran
77212ece52
Follow up to 21c636c
Move CELL_CHKLANDPROTECTOR check to ST_WATER check
2016-04-17 18:30:55 +07:00
Jittapan Pluemsumran
21c636c12b
Correct Aqua Benedicta interaction with Watery Evasion to match official behavior. Fixes #1119 2016-04-17 17:45:02 +07:00
aleos89
63e772956b Corrected some skills healing immune targets (fixes #1109)
* Gentle Touch - Cure and Tuna Belly will no longer heal Emperium or Barricades.
Thanks to @admkakaroto and @Darkelfen!
2016-04-15 10:50:13 -04:00
Playtester
7e97b0db86 Summoner skill status changes
* Until tested, Summoner skills will now use the default renewal base duration for their status changes
-- Bleeding: 120s
-- Stun: 5s
* Moved status change durations to duration2 for these skills
2016-04-13 18:14:49 +02:00
Playtester
87471044aa Auto spell error log (fixes #1154)
* When using auto spell, it will no longer print error messages to the map-server when no valid skill was selected

Note: This needs to be done because the client sends us random IDs if the user simply presses on "Ok" without selecting a skill, so it's technically not an error, but expected behavior that needs to be handled.

Special thanks to @anacondaqq and @stealth62 for helping to reproduce the error.
2016-04-11 19:51:51 +02:00
aleos89
17685a3247 Fixed Heaven Drive not doing any damage (fixes #1156)
* Moved the Silver Vine Root Twist cancellation from Heaven Drive to skill_additional_effect as it was breaking out of the switch before skill_attack.
2016-04-11 09:45:03 -04:00
Playtester
98dc0608c7 Catnip Meteor (follow-up to 1365d94, hopefully fixes #1149)
* Fixed Catnip Meteor not deploying units when using a catnip fruit

Special thanks to @MysticFurur0RE
2016-04-07 21:49:41 +02:00
aleos89
2305a66101 Resolved a flag overlap for status_change_clear_buffs
* Small follow up to 894d6f2.
* Resolves Chemical Protection flag coinciding with the Lux Anima flag.
* Changed all bitmask values to readable constants.
2016-04-06 09:09:39 -04:00
Aleos
8a3c6727a2 Merge pull request #1130 from rathena/cleanup/status-mode-access
Standardized access to mode fields
* Preparation for future update.
Thanks to @Lemongrass3110!
2016-04-05 12:51:56 -04:00
aleos89
8d43623a2b Resolved several compile warnings
* Miscellaneous compile warning fixes.
2016-04-04 13:27:43 -04:00
Cydh Ramdh
29f66186cd Fixed #1131 - Corrected KO_MAKIBISHI item required.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-04-04 08:11:14 +07:00
Playtester
75fce5df98 Provoke chance and animation (fixes #1132)
* The Provoke chance is now 70% + 3%*skill_lv + srcBaseLevel% - tarBaseLevel%
* When Provoke fails, it will no longer make the caster display any animation
2016-04-03 13:39:32 +02:00
Lemongrass3110
b6abe3fcbf Standardized access to mode fields
Additionally cleaned RC2 access too.
2016-04-03 03:10:25 +02:00
aleos89
e0edc9956b Follow up to 19e4f59
* Fixed a compile error.
2016-04-02 11:59:27 -04:00
aleos89
19e4f599de Updated Arrullo and Deep Sleep Lullaby (fixes #1063)
* Deep Sleep status is now avoidable thus removing the 5 second minimum duration.
* Corrected the success chance for Arrullo and Deep Sleep Lullaby being 10x higher.
* Deep Sleep status duration is now BaseDuration - 25 * tarBaseINT - 50 * tarBaseLevel.
-- Deep Sleep Lullaby duration is doubled with BaseDuration - 50 * tarBaseINT - 50 * tarBaseLevel.
2016-04-02 11:03:56 -04:00
Playtester
3cad4cd3a7 Sura combos, Tumbling (follow-up to 7ccca9d, fixes #1100)
* Sura combos will now target the trigger of the combo if you currently don't have any auto-target
* Fixed Tumbling sometimes displaying the stance even though it didn't trigger
* Fixed Tumbling not triggering when suffering the "Burning" status effect
2016-04-01 23:38:01 +02:00
aleos89
c75ffa15d5 Updated Offertorium curing status list (fixes #1111)
* Removes Magnificat, Blind, Curse, Poison, Hallucination, Confusion, Bleeding, Burning, Freezing, Mandragora Howling, Paralysis, Pyrexia, Death Hurt, Leech End, Venom Bleed, Toxin, and Magic Mushroom.
* Doesn't prevent the above statuses from being used again.
* Moved status removal to status_change_start overlap check.
2016-04-01 07:58:11 -04:00
aleos89
fe97051adf Updated Warmer effect (fixes #1097)
* Warmer should not re-apply status immunities every 3 seconds.
* Warmer status immunity should end once outside of the unit.
2016-03-29 11:01:58 -04:00
Playtester
1365d9418e Meteor Storm, Catnip Meteor (fixes #983)
* Official implementation of Meteor Storm behavior
-- It deploys all units directly at castend
-- Each unit has a different expiration time
-- On the last interval of a unit the meteor will appear
-- When the unit expires, it will deal damage
-- If the unit gets removed at any time, no meteor will appear and no damage will be dealt
* It is now easily possible to configure Meteor Storm behavior via database files, no more extra coding required
* Fixed Meteor Storm sometimes dealing damage even though no meteor appeared
* Fixed Meteor Storm being able to hit through walls when the caster has moved in the meantime
* Catnip Meteor will now create 3-7 meteors depending on level
* Catnip Meteor now has an interval of 500ms instead of 1000ms
* Catnip Meteor now has a curse duration of 20s instead of 5s
2016-03-28 16:37:46 +02:00
Playtester
894d6f2fe6 Tarot Card/Gospel vs Chemical Protection (fixes #1108)
* The High Priestess Card from Tarot Card of Fate now removes Chemical Protection (all)
* Gospel now removes Chemical Protection (all) on the caster
2016-03-28 10:20:27 +02:00
aleos89
88d2dde632 Updated Volcanic Ash effect (fixes #1090)
* No longer gives 150% increased damage to fire type attacks.
* No longer damages self and allies on normal map types.
2016-03-26 10:25:22 -04:00
Playtester
7ccca9ddbb Combo activation and targeting (fixes #1100)
* You no longer need to use combo skills on the enemy that triggered the combo except for Flying Side Kick
* Taekwon stances can now activate even when another stance is still active
2016-03-26 12:18:23 +01:00
Cydh Ramdh
cbfa9c9ea1 Merge branch 'feature/exp-giving-script'
Merge pull request #1032 from rathena/feature/exp-giving-script

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-26 01:45:36 +07:00
aleos89
6dc437fd08 Implemented the official effect of Vellum Vanish (fixes #900 and fixes #1021)
* The Vellum Vanish bonus only refers to bHPVanishRaceRate and bSPVanishRaceRate.
* Requires client 2013-03-20 and newer to display blue damage.
* Properly displays blue damage being done for SP Vellum Vanish.
* Vellum Vanish items no longer deal physical damage except on skill usage.
* Skill usage with Vellum Vanish does not cause vanish.
* HP and SP Vellum Vanish items do not stack (SP will override HP).
2016-03-23 14:25:58 -04:00
aleos89
242b3c1ab4 Corrected item requires for Repair (fixes #1076)
* No longer requires Magic Gear Fuel.
* Repair Kit will now be properly checked.
2016-03-22 12:35:25 -04:00
Playtester
989a2525ec Skills vs Icewalls/Traps, Talkie Box, Feint Bomb
* Implemented official behavior when attacking icewalls and traps with skills (fixes #1056)
-- Skills hitting icewalls and traps: Arrow Shower, Cold Slower, Tornado Kick, Sightless Mind, Meteor Assault, Spread Attack, Throw Huuma, Sightrasher, Sight Blaster, Earth Shaker, Rampage Blaster, Feint Bomb, Magnum Break, Fire Trap, Ice Trap, Cart Revolution, Napalm Vulcan, Triple Attack, Occult Impaction, Throw Spirit Sphere, Asura Strike, Spear Stab, Spiral Pierce, Holy Cross
-- Can target icewalls and traps but have strange behavior: Bowling Bash, Focused Arrow Strike, First Wind
-- Can hit icewalls and traps, but not target traps: Grimtooth, Raging Thrust, Blitz Beat, Napalm Beat, Fireball, Vulcan Arm, Tiger Cannon
-- Can hit icewalls and traps ONLY in PVP: Dragon Breath, Suicidal Destruction, Axe Tornado, Sky Blow
-- Can hit icewalls only: All other single target skills, Counter Slash
-- Can target icewalls but have strange behavior: Brandish Spear, Wind Cutter, Cannon Spear, Flame Launcher
-- Can not hit icewalls and traps: All unit skills, Frost Nova, Comet, Arms Cannon, Fatal Menace, Lion Howling
-- Can destroy traps but not hit icewalls: Claymore Trap
* When monsters use skills, they hit icewalls and traps and the damage displays, but they will no longer deal actual damage to the icewall or trap
-- Added an option to skill.conf with which you can define which types can damage icewalls and traps, by default it's 1 (player only), if you want to revert to previous behavior, set it to 31 (all)
* Fixed an issue where traps could not hit icewalls and other traps in PVP
* Taekwon combos can now trigger on traps
* Fixed an issue that caused damage to be displayed twice when attacking a trap with certain skills
* Fixed Feint Bomb causing knock-back to the target (see #1070)
* Fixed Talkie Box being triggered by monsters (fixes #1074)
2016-03-20 17:44:47 +01:00