8409 Commits

Author SHA1 Message Date
LordWhiplash
43caf7cc0a
SU_HISS Perfect dodge fix (#4991)
* Fixes #4990.
* Adds missing x10 rate for perfect dodge calculations.
Thanks to @Balferian and @LordWhiplash!
2020-05-21 09:02:23 -04:00
Aleos
0fba10c324
Fixes a potential crash with atcommand time (#4989)
* Fixes #4960.
* Adds a timer data validation check for atcommand time.
Thanks to @marky291!
2020-05-20 21:21:31 -04:00
Aleos
70d6876494
Corrects NPC_DARKBREATH behavior (#4982)
* Fixes #4864.
* Adjusts damage formula to official.
* Adjusts damage type from Misc to Magic.
* Skill now has a 50% success chance to damage the target.
* Removes Flee and Defense Card ignore flags.
Thanks to @Masao87 and @mrjnumber1!
2020-05-20 18:50:04 -04:00
Aleos
a34a2f6de0
Fixes Blood Sucker not being able to be recast (#4968)
* Fixes #4964.
* Fixes Blood Sucker not being able to be recast on another map if caster dies while active.
* Minor cleanups and added safety checks.
Thanks to @Everade!
2020-05-20 17:20:37 -04:00
Aleos
ab628b2369
Remove Summoner Hide when changing maps (#4958)
* Fixes #4953.
* Remove Summoner Hide when changing maps to avoid equipment from being stripped due to the inability to change equipment while the status is active.
Thanks to @Everade!
2020-05-20 16:54:42 -04:00
LordWhiplash
746c1bdfa9
Fixes MO_EXTREMITYFIST (#4886) 2020-05-20 22:18:31 +02:00
CairoLee
bf4b41bd66
Fixes a crash caused by invalid skill ID (#4935)
* Fixes #4934.
* Fixes a potential crash when using atcommand useskill.
Thanks to @Stingor and @CairoLee!
2020-05-20 09:22:53 -04:00
Aleos
5d4fd1d3b7
Resolves Autospell displaying errors to console (#4921)
* Fixes #4883
* Fixes Autospell displaying invalid skill errors when clicking Ok or Cancel.
Thanks to @admkakaroto!
2020-05-19 17:19:34 -04:00
Aleos
18b642c174
Skill Database cleanups (#4902)
* When reloading the skill_db clear out Abra, Magic Mushroom, and Reading Spell Book databases as well.
* Fixes NC_SHAPESHIFT and NC_REPAIR checking an invalid ItemCost slot based on the old implementation.
* Updated a lot of references to the old skill databases.
2020-05-19 15:32:57 -04:00
Aleos
d9f533165e
Fixes Adoramus' interaction with Land Protector (#4920)
* Fixes #4876.
* Adoramus should not do damage to anyone inside the range of Adoramus.
Thanks to @teededung and @Tokeiburu!
2020-05-18 16:51:46 -04:00
Aleos
44e5c5bcc7
Job Improvement Project - Rune Knight (Part 2) (#4709)
* Fixes #4708.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=243&curpage=1
Thanks to @ecdarreola, @Litro, @Haydrich, and @LordWhiplash!
2020-05-18 13:35:07 -04:00
Aleos
a23c84d345
Job Improvement Project - Guillotine Cross (#4705)
* Fixes #4704.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=243&curpage=1
Thanks to @Angelic234, @nehpetskie, @ecdarreola, @Haydrich, @Badarosk0, and @LordWhiplash!
2020-05-18 10:47:21 -04:00
Aleos
fde031fb19
Job Improvement Project - Minstrel/Wanderer (#4701)
* Fixes #4211.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=235&curpage=1
* kRO Changelog 2: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Angelic234, @Litro, @LordWhiplash, @Feelmeone, @ecdarreola, and @teededung!
2020-05-18 09:44:12 -04:00
Aleos
15c954ef23
Fixes instance map name faults (#4945)
* Fixes #4915.
* Fixes instance map names when it reaches 1000.
* Fixes instances with more than 8 character crashing the client.
* Other minor cleanups.
Thanks to @voyfmyuh and @Atemo!
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2020-05-17 15:28:13 -04:00
Mark Hester
f60da2b3fa
Allow blank SQL passwords (#4827)
* Allow blank password for log and login schema.
Thanks to @marky291!
2020-05-13 22:02:10 -04:00
Aleos
061e586a1f
Few Genetic skill fixes (#4813)
* Fixes Acid Demonstration to use the target's VIT and not casters.
* Fixes Fire Expansion - Acid to behave like Acid Demonstration.
* Fixes Crazy Weed not doing 2 damage attacks.
* Crazy Weed is now a long ranged physical attack.
* Adjusts Hell's Plant behavior to no longer be removed on map change.
* Adds missing status icon for Hell's Plant.
* Fixes Hell's Plant attack formula when learning Summon Flora.
* Hell's Plant now uses the caster's weapon as the element.
* Hell's Plant no longer ignores the target's DEF and Element.
* Fixes Hell's Plant removing Thorns Trap.
* Removes fixed cast time from Xeno Slasher.
* Adds new Genetic Pharmacy potions (items are disabled until int32 item ID support).
* Fixes Spore Explosion's splash attack doing the same damage as the initial.
Thanks to @teededung, @Badarosk0, @cahya1992, and @OptimusM!
2020-05-13 21:02:57 -04:00
Daegaladh
132e74bd13 Follow up to c4609b19d6910ae05d6424a8cb1da2142d870ef0 2020-05-14 02:57:13 +02:00
Daegaladh
5154e07899 Follow up to 73140bd078036ef173568918102e42f824ee148c 2020-05-12 23:09:22 +02:00
Daegaladh
48fd0e859b Follow up to 8d2c26d115f0c44fb2d53efb5409c43ad0103946 2020-05-10 15:54:43 +02:00
Yashim Wong
8d2c26d115
Removed sonic blow attack animation (#4926) 2020-05-10 13:49:46 +07:00
Sader Fawall
49c4ddf8f9
npctalk script command now accepts color parameter (#4910)
Co-authored-by: Jittapan Pluemsumran <secret@jittapan.app>
Co-authored-by: Lemongrass3110 <lemongrass3110@users.noreply.github.com>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2020-05-10 13:34:00 +07:00
Daegaladh
c4609b19d6
Follow up to b2aa7e698da55bcae198dfcda7ab706f35d958e3 2020-05-10 05:30:24 +02:00
~Neutral~
39f3a17f54
Fixed Dual Wielding Axes breaking when they should be unbreakable (#4518) 2020-05-10 04:21:41 +02:00
Daegaladh
73140bd078
Fixed monster messages not loading (#4908) 2020-05-09 15:53:17 +02:00
Kreustoo
d1719f670f
Adds missing args for round/ceil/floor (#4899)
* Fixes #4898.
* Only missing one integer in parameter in BUILDIN_DEF2, already ready to read in the definition of the function.
Thanks to @Kreustoo!
2020-05-08 08:28:14 -04:00
Aleos
931155ee33
Job Improvement Project - Super Novice (#4429)
* Fixes #4427.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Rytech2!
2020-05-07 14:48:44 -04:00
Aleos
5e8d9aafab
Job Improvement Project - Kagerou & Oboro (#4425)
* Fixes #4424.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Badarosk0, @OptimusM, @teededung, and @Angelic234!
2020-05-06 13:36:27 -04:00
Daegaladh
c6aceea6c3
Follow up to fe14af99625d16f3c7ef1e8192a2d3b0214f33f1
* Thanks to @CairoLee
2020-05-06 16:38:30 +02:00
Eric Liu
24ea092dd2
Fix bonuses for SJ_STARSTANCE and SJ_LUNARSTANCE (#4884)
* Fix Max HP bonus for SJ_LUNARSTANCE

* Fix missing ASPD bonus in renewal for SJ_STARSTANCE
2020-05-04 12:20:11 -04:00
Aleos
ea59d80490
Corrects Feint Bomb not hiding the caster (#4874)
* Resolves an issue with Feint Bomb not hiding the caster.
Thanks to @Badarosk0!
2020-05-04 11:56:14 -04:00
Aleos
9309986a86
Heat Barrel should be giving fixed ASPD (#4867)
* Heat Barrel's ASPD bonus should be a fixed amount, not at a rate.
Thanks to @LordWhiplash!
2020-05-04 10:20:25 -04:00
Aleos
9794aa2b80
Fixes an issue with status timers being destroyed (#4885)
* Fixes #4856.
* Follow up to d1f8c8c and 652d77e.
* A missing break from an old commit along with a refactor in code resulted in a "valid" fall through and breaking status change timers.
* Also fixes a potential crash with Book of Creating Star.
Thanks to @OptimusM, @technoken, @sader1992, @mazvi, and @akiyamamio16 for helping debug!
2020-05-03 11:30:50 -04:00
Aleos
e92f88a030
Fixes battle config skill_removetrap_type (#4865)
* Fixes an array out of bounds check when attempting to return used traps to a player through HT_REMOVETRAP.
Thanks to @marky291!
2020-04-30 13:51:09 -04:00
Daegaladh
40c776340f Follow up to 77dd729d770bcc9fc508ff09160419224bf5120b 2020-04-30 18:51:41 +02:00
Aleos
8f19cfc3a1
Fixes Weapon Crush and Weapon Blocking combo (#4809)
* Fixes #4808.
* Weapon Crush now uses SC_WEAPONBLOCK_ON to track the target instead of SC_COMBO.
* Also fixes Quick Draw Shot target selection.
* Quick Draw Shot and Weapon Blocking should be considered a combo and not end physical attacks when casting them.
* SC_QD_SHOT_READY will no longer become active if the player has 193+ ASPD.
* SC_QD_SHOT_READY will now end once Quick Draw Shot has been casted.
* Cleans up skill_check_condition_sc_required and removes duplicate code.
Thanks to @wdivet, @LordWhiplash, and @ecdarreola!
2020-04-30 12:17:50 -04:00
Aleos
da523d9fcd
Stop vending when an invalid list is received (#4868)
* Fixes #4778.
* Vending will now be stopped if an invalid list is received.
Thanks to @blipblopblip!
2020-04-30 11:12:54 -04:00
Daegaladh
be0c0efe40
Follow up to 38cf16edbaa36836072780b4481023e57e014892
*Thanks to @aleos89 and @LordWhiplash
2020-04-30 16:49:40 +02:00
Aleos
2ca94ad411
Adds back removed skills from kRO (#4803)
* Fixes #4802.
* Adds back AB_EUCHARISTICA, GN_SLINGITEM, and GN_MAKEBOMB.
* Adds back CR_CULTIVATION for renewal.
* Skills are disabled in the skill tree database but gives easy ability to re-enable.
* Fixes an issue with pre-renewal produce database spitting errors when using any production-type skills.
Thanks to @trinitynetworks!
2020-04-30 09:33:38 -04:00
Eric Liu
331b31d8cf
Fix WZ_HEAVENDRIVE skill ratio (#4862)
* Adjusted to account for the default 100.
Thanks to @Latiosu!
2020-04-29 21:08:56 -04:00
Daegaladh
fe14af9962
Fixed duplicate itemshops and pointshops (#4850) 2020-04-30 01:44:53 +02:00
Eric Liu
4829f3775d
Fix Lord of Vermilion damage (#4855)
* Fixes #4852.
* Fixes Lord of Vermilion damage not accounting for the total of each hit.
Thanks to @mazvi and @Latiosu!
2020-04-29 10:55:06 -04:00
Daegaladh
ca56c060cf
Added independent idle time and settings for homunculus share (#4761)
* Follow up to 921b3e2c3e9eae36cbf2ca35bcede6e0d73ba074
2020-04-27 20:21:22 +02:00
Aleos
312df0f10c
Job Improvement Project - Rebellion (#4428)
* Fixes #4426.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Tokeiburu, @OptimusM, @admkakaroto,@cahya1992, @Tolimatoi, and @Badarosk0!
2020-04-24 13:58:09 -04:00
Cydh Ramdh
d9ab23ae0f
Fixed Max HP & SP rate bonus (#4828)
* Fixed #4264
* Added new SCs for proper HP & SP Pill usages
* Thanks to @Daegaladh
2020-04-24 11:53:08 +07:00
Eric Liu
e764fdd4b5
Fix Heaven's Drive damage (#4835)
* Fixes #4834.
* Fixes Heaven's Drive damage in renewal mode.
Thanks to @Latiosu!
2020-04-23 21:30:19 -04:00
Aleos
b65443d8f5
Removal of OnPCStatCalcEvent (#4831)
* Fixes #4812.
* This script event can be replaced with the other various player script events.
* The trigger during equipment changing causes headache across other calculation events in source.
2020-04-23 16:53:07 -04:00
Daegaladh
058ad2c67e
Fixed duplicated skill status check when switching weapons (#4806)
* Thanks to @aleos89
2020-04-16 16:21:25 +02:00
Daegaladh
ba76880364
Fixed vending and chatrooms checking for NPCs nearby (#4805)
* Thanks to @cydh
2020-04-16 16:20:52 +02:00
aleos
44b80448df Removes target SP consumption from Tiger Cannon
* Removes target SP consumption based on damage dealt by Tiger Cannon.
* This effect was removed in #4256 but accidentally merged back in through #3659.
Thanks to @Badarosk0!
2020-04-14 12:16:53 -04:00
Lemongrass3110
6570489a84 Fixed Soul Reaper's Soul Collect behavior
Added missing status change cancel condition, when the player has reached the maximum amount of soul spheres.
Fixed duration display on the client.
Some cleanup of duplicate code.

Thanks to @aleos89
2020-04-14 15:25:04 +02:00