8409 Commits

Author SHA1 Message Date
Lemongrass3110
f79cac8509
Fixed bodystyle for unsupported jobs (#4792)
Adds missing checks for Super Novice Expanded, Star Emperor and Soul Reaper.

Enables bodystyles saving by default, since all sprites have been released officially long enough.

Adjusted the mismatching default value for max_body_style.

Fixes #4787

Thanks to @reunite-ro
2020-04-13 18:38:49 +02:00
Lemongrass3110
1f63265a3b Follow up to 6fe0ed5
Thanks to @Daegaladh
2020-04-09 21:51:33 +02:00
Aleos
8716121b4c
Fixes to Battleground script commands (#4764)
* Fixes #4763.
* Cleans up script commands bg_getareausers and bg_get_data.
Thanks to @voyfmyuh and @Lemongrass3110!
2020-04-09 14:18:50 -04:00
Daegaladh
42f695fe8e
Fixed autotraders counting for instance requirements (#4779) 2020-04-09 18:03:18 +02:00
Aleos
d421225c4f
Fixes Acid Demonstration for pre-renewal (#4775)
* Fixes #4770.
* Adds back missing case for pre-renewal damage calculation.
* Adds back long ranged check for Neutral Barrier in pre-renewal.
Thanks to @danieljorge17!
2020-04-09 11:45:52 -04:00
Kakaroto
a741540366
Hateffect Update (#4780)
Minor Hateffect update.
2020-04-09 17:07:57 +02:00
Lemongrass3110
6fe0ed5819
Fixed a problem with walking NPCs (#4782)
Walking NPCs are not supported on official servers.
Therefore we have to respawn the NPC units as player units before they start walking.
After they stop walking we respawn them as NPC units again so that they show the bubbles for talking to them again.
Since player sprites have a small aura during spawning hardcoded in the client, this aura will be shown each time they begin walking now.

Fixes #4505

Thanks to @RagnaWay and @aleos89
2020-04-09 17:03:37 +02:00
Aleos
03fa1af7a8
Fixes Soul Unity being removed on map change (#4754)
* Fixes #4733.
* Soul Unity should not be removed on map change.
Thanks to @Balferian!
2020-04-08 13:46:43 -04:00
Aleos
00943a2c5f
Corrects Star Emperor stances (#4753)
* Fixes #4744.
* Adds missing stance skill requirements.
* Adds Stance values to csv2yaml for skill_db conversions.
Thanks to @iubantot and @attackjom!
2020-04-08 13:27:12 -04:00
Aleos
06c159c405
Refactored Instances to utilize C++ features (#3163)
* Fixes #3087 and fixes #3095.
* Converts database file to YAML.
* Converts static array to unordered_map which frees up pre-allocated memory that may never be fully used.
* Got rid of all DBMap/ERS features.
* Removes MAX_INSTANCE_DATA in favor of INT_MAX.
* Includes TXT converter.
Thanks to @Lemongrass3110, @secretdataz, @Atemo, @lighta, @InusualZ, @Angelic234, @Normynator, @cydh, and @ecdarreola!
2020-04-08 12:52:45 -04:00
Aleos
7507065885
Corrects Brandish Spear damage stacking (#4740)
* Fixes #4739.
* Follow up to 24ecebc.
* Resolves Brandish Spear damage doing more damage than it should.
Thanks to @violent01!
2020-04-07 16:59:38 -04:00
Daegaladh
3424928fa1
Added missing restrictions when writing a mail (#4772) 2020-04-06 22:19:12 +02:00
Aleos
02e61abbdd
Fixes a compile error for older clients (#4776)
* Fixes #4773.
* Resolves a compile error for clients older than 20150513 quest objectives.
Thanks to @Cainho!
2020-04-06 16:05:25 -04:00
Daegaladh
38cf16edba
Fixed Throw Spirit Sphere/Finger Offensive hits depending on the number of spirit spheres (#4771) 2020-04-06 20:36:22 +02:00
Daegaladh
dad85750fb
Hides players with 'hide_session' and '/ignoreall' from whisper messages (#4762) 2020-04-06 20:34:27 +02:00
Aleos
af8dd8b28d
Fixes issue with power skills (#4751)
* Fixes #4743.
* Resolves an issue with power skills and default data defined in the skill's array.
* Adds back linear determination and documentation for it.
* Adds a check in the converter to not print out values of 0 for levels 6 and higher for skill unit layout and skill unit range.
* Removes these values from the skill database.
Thanks to @Surefirer and @teededung!
2020-04-06 10:44:17 -04:00
Aleos
a67f5c5d6a
Fixes heal item recovery effects (#4750)
* Fixes #4748.
* Recovery item effects should be multiplicatively stacked.
Thanks to @Singe-Horizontal!
2020-04-05 15:22:36 -04:00
victorgawk
044acebd75
Added config option for legacy NPC EMOTION behavior (#4728)
Co-authored-by: Victor Ferreira <victor.ferreira@esig.com.br>
2020-04-02 11:04:07 +02:00
Aleos
6edcf4a3a1
Fixes Wall of Thorn knockback (#4685)
* Fixes #4645.
* The knockback should be based on self and not the caster of the skill.
Thanks to @devLOOLP!
2020-03-31 08:20:04 -04:00
Aleos
2f326bf04a
Converted Quest Database to YAML (#4064)
* Changes TimeLimit format to be human readable.
* Converts title to string.
* Converts objectives and drop items to vectors.
* General clean ups and optimizations.
* Got rid of dummy_quest.
* Added TXT to YAML converter.
Thanks to @Atemo and @Normynator!
Co-authored-by: atemo <capucrath@gmail.com>
2020-03-30 13:17:19 -04:00
Aleos
bdd63022a9
Fixes Assumptio status in renewal (#4736)
* Adjusts Assumptio to increase hard defense, not soft.
* Adjusts CASH_ASSUMPTIO status icon to follow as well.
Thanks to @LordWhiplash!
2020-03-27 13:09:19 -04:00
Aleos
652d77eb02
Job Improvement Project - Genetic (#3284)
* Fixes #2571.
* Updates Homunculus skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=218&curpage=1
* Updates Genetic skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Tokeiburu, @Badarosk0, @Balferian, and @Haydrich!
2020-03-25 13:26:26 -04:00
Aleos
24ecebcaf3
Fixes Brandish Spear from renewal balance (#4711)
* Fixes #4707.
* Follow up to ea8da71.
* Skill now applies long range damage.
* Skill now does 3 hits.
* Target's placement in the AoE does not affect damage; it's all the same for each target.
* Updates strength bonus.
* Reverts Mercenary Brandish Spear to pre-renewal effects.
Thanks to @violent01 and @mrjnumber1!
2020-03-24 18:33:01 -04:00
aleos
0021b6d577 Revert "SQL synchronization"
This reverts commit 53761b952af832455526401acfc8b388a60a5d84.
2020-03-24 17:49:00 -04:00
rAthenaAPI
53761b952a SQL synchronization 2020-03-24 18:38:07 +01:00
Aleos
412d90048d
Implemented Star Emperor and Soul Reaper classes (#4386)
* Initial implementation of these two classes skills.
* Includes kRO balancing patch: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3921697
Thanks to @Rytech2, @Mateuus, @nubspixel, @exneval, @idamonli, @hotspicy945, @admkakaroto, @cahya1992 and @RagnaWay!
2020-03-24 13:37:58 -04:00
Atemo
157392cd1a
Fixed npc_enable_sub (#4717)
Fixed an issue introduced in 67a07fd4d6
Fixed #4716 

Thanks to @SOSKaito
2020-03-18 20:56:45 +01:00
Atemo
73fe0d26b7
Added setquest, erasequest, completequest, checkquest atcommand (#4692)
@ setquest : self explaining
@ erasequest : self explaining
@ completequest : give and complete the quest
@ checkquest : display the quest status HAVEQUEST, HUNTING, PLAYTIME
2020-03-18 19:14:15 +01:00
atemo
80810e24f8 Follow-up de80c5aab6
Fixed a typo in clif_changeoption
2020-03-13 15:21:27 +01:00
Yashim Wong
d9f61e7803
Fixes Rogue Backstab Double Hit (#4703)
* Fixes #4702.
* Skill no longer ignores the target's flee.
* Skill now deals 2 hit when using dagger instead of doubling the damage.
Thanks to @yashimwong!
2020-03-13 09:25:01 -04:00
San
58e82dc149
Adds config for Land Protector Behavior (#4675)
Adds config for Land Protector Behavior
* This battle config option adds the ability to change Land Protector to the old behavior.
* Related to #1404 and #4412.
* Thanks to @Cydh for the initial release. Thanks to @Tydus1 for the pull request!
2020-03-11 18:29:58 -04:00
Atemo
de80c5aab6
[Suggestion] Implement cloakonnpc/cloakoffnpc (#4688)
* The player can interact with a NPC cloaked by cloakonnpc command (click, mob event..) but the NPC trigger area is disabled (= the OnTouch* part is disabled).
* The changes last until the player leaves the map, logs out, or the npc option is updated by disablenpc/enablenpc/hideonnpc/hideoffnpc/cloakonnpc/cloakoffnpc commands.

Thanks to @aleos89
2020-03-11 22:47:23 +01:00
Yashim Wong
e2de896414
Removes Bowling Bash Chain Damage (#4695)
* Fixes #4693.
* Removes Bowling Bash chained damage stacking on top of itself.
Thanks to @violent01 and @yashimwong!
2020-03-11 16:55:53 -04:00
Atemo
67a07fd4d6
Small update of npc_enable_sub (#4673)
* With this update a player standing on a NPCTYPE_WARP disabled will be warped when the npc is enabled
2020-03-10 17:42:41 +01:00
Aleos
1453bcad4f
Small fix to skill_damage_db parsing (#4696)
* Fixes #4690.
* Ignore the space after damage rate.
Thanks to @Tutankhaten!
2020-03-09 16:05:10 -04:00
Aleos
1961e0ee88 Removes incorrect MSVS file copy
* Fixes #4697.
* Follow up to ea8da71.
Thanks to @Tutankhaten!
2020-03-09 14:19:56 -04:00
Aleos
ea8da71cdd
Rebalancing of 1st/2nd/Transcendent class skills (#4072)
* Fixes #3715.
* kRO changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7040
* Refactored size_fix database to YAML.
Thanks to @flamefury for his translations!
Thanks to @Angelic234, @mrjnumber1, @Badarosk0, @OptimusM, @attackjom, @Playtester, Melvo, @cydh, @cahya1992, Sigma, @whupdo, @teededung, @ecdarreola, @hotspicy945, @RagnaWay, @sader1992 for bug testing!
2020-03-06 10:57:19 -05:00
Aleos
850904ab3e
Corrects a compile warning (#4689)
* Fixes #4686.
* Corrects a compile warning for an uninitialized variable.
Thanks to @Tutankhaten!
2020-03-06 10:38:10 -05:00
Aleos
496f362ec9
Fixes skill database reloading (#4669)
* Fixes #4660.
* Resolves an issue with skill database reloading not clearing the previous data first.
* While clearing the YAML cache it will also resize the cache to the previous capacity.
Thanks to @teededung!
2020-03-04 13:03:06 -05:00
Aleos
5c35ec7d69
Corrects skill_damage_db parsing (#4667)
* Fixes #4574.
* Removes the usage of atoi as any failure returns 0.
* Adds checks for cases of invalid data.
* General cleanups and fixes.
* Fixes the import database documentation.
Thanks to @Skormie!
2020-03-04 12:33:37 -05:00
rAthenaAPI
35b2f69530 Effect State Update 2020-03-04 05:05:27 +01:00
Amir Azman
b143241222
Fix Typo in Cleans up Summoner dual-cast attacks commit (Map Crash Issue) (#4677)
* Fixes #4676.
*  Fixes a typo in Professor’s Dual Casting check.
Thanks to @reunite-ro!
2020-03-01 15:45:23 -05:00
Joam
18ab64f2a1
Fix missing check element for non-damage skill (#4664)
* Fixes #4661.
* Resolves an issue with an element resistance check.
Thanks to @reunite-ro and @attackjom!
2020-02-26 08:04:26 -05:00
Aleos
836eda4879
Cleans up Summoner dual-cast attacks (#4658)
* Cleans up Summoner dual-cast attacks Bite, Silvervine Stem Spear, Scar of Tarou, and Picky Peck so that they behave like Professor's Double Casting.
* Adjusts success formula.
Thanks to @Rytech2!
2020-02-25 19:58:12 -05:00
Aleos
97372ff423
Adds reload attendance database atcommand (#4657)
* Fixes #4656.
* Adds an atcommand option for reloading the attendance database.
* Adds missing headers for attendance database.
* Adds missing reload options in the atcommand configuration.
Thanks to @lelouch22's suggestion!
2020-02-23 17:10:17 -05:00
Aleos
1fc4b8de20
Battleground Queue fixes (#4648)
* Fixes #4644.
* Initialize all battleground queues at startup to reduce overhead of creation/deletion during live server.
* Removes lots of duplicate code between team checks.
* Adds missing checks for script commands bg_leave and bg_desert to only warp players out using the Battleground Queue System.
* Adds documentation for script commands bg_leave and bg_desert to state players will be warped out after when using the Battleground Queue System.
* Optimizes join logic to add new players to the end of the queue rather than the front.
* Cleans up the client messages so certain responses are cleared when they need to be.
Thanks to @Balferian and @Lemongrass3110!
2020-02-20 22:25:14 -05:00
Aleos
b13bc7402c
Resolves an issue with mob avail options (#4651)
* Fixes #4647.
* Resolves an issue with mob avail options not properly checking the state of the option label.
Thanks to @Litro!
2020-02-17 20:30:05 -05:00
Lemongrass3110
d165c19b73 Fixed jump_zero for conditions over INT32_MAX
Thanks to @Atemo
2020-02-17 22:50:19 +01:00
rAthenaAPI
390eb9772a Effect State Update 2020-02-16 11:05:27 +01:00
rAthenaAPI
1e091cd58a Effect State Update 2020-02-14 02:20:45 +01:00