9337 Commits

Author SHA1 Message Date
Atemo
7d8530e3b1
Fix for issue #3540 "IM_NONE idle timer" (#3550)
* Fix for issue #3540 "IM_NONE idle timer"

* Cleaned redundant map_getmapdata

Thanks to @aleos89 !
2018-10-09 22:58:41 +02:00
Cydh Ramdh
0f8ce36746
ers_destroy called too early in do_final_instance (#3533)
* Fixed #3532
2018-10-02 08:22:29 +07:00
Aleos
926e37cb65
Corrected some GCC 7.1+ compile warnings (#3522)
* Fixes #2787 and fixes #3513.
* Resolved some format-truncation warnings.
* The remaining will be fixed at a later time.
Thanks to @RadianFord and @Lemongrass3110!
2018-09-28 13:57:27 -04:00
Cydh Ramdh
3e1105b0cf
Updates Item Sell checks (#3491)
* Added config values for `allow_bound_sell`
  * 0x4 allows bound item to be sold at NPC Shops
  * 0x8 restrict only guild leader who can sell guild bound item at NPC Shops or Itemshops
* Added config to allow rental items can be sold at NPC `rental_transaction` (planned for more config values based on #3490). Default to `yes` allowed to be sold, still can be restricted by item_trade, item id based.
* Fixed itemshop which ignores another item stack in inventory even for same item currency
* Fixed exploit potential by using Itemshop & Pointshop
* Now equipped item cannot be sold at NPC
* Typo and grammar fixes. Thanks to @aleos89 and @secretdataz
2018-09-27 13:54:28 +07:00
rAthenaAPI
79766cd99e Effect State Update 2018-09-25 22:06:43 +02:00
Aleos
7040057a9f
Corrected Taekwon Mission mob generator (#3509)
* Fixes #3499.
* Corrected the way target monsters are generated for Taekwon Mission.
* Requires: The mob ID is in the range [MOBID_PORING, MOBID_GREEN_IGUANA], the mob must have below 30,000 HP, the mob must give Base EXP, the mob must be CLASS_NORMAL.
* Added a new mob group: MOBG_Taekwon_Mission
* Removed hard coded checks.
* Created constants for random monster group flags.
Thanks to @mrjnumber1, @Lemongrass3110, and @cydh!
2018-09-25 13:32:11 -04:00
Aleos
8fc790339d
Corrected Union of the Sun Moon and Stars HP cost (#3507)
* Fixes #3500.
* Corrected the HP cost formula to reflect Aegis.
Thanks to @mrjnumber1 and @Lemongrass3110!
2018-09-25 13:04:50 -04:00
Aleos
147e8da2e4
Corrected Critical bonuses (#3506)
* Fixes #3501.
* Critical bonuses bCritAtkRate and bCriticalLong should not be applying to skills.
Thanks to @mrjnumber1!
2018-09-25 12:27:30 -04:00
Aleos
f0dfdf9219
Cleaned up equipment stripping skills (#3493)
* Fixes #3476.
* Centralized all equipment stripping skills to skill_strip_equip.
* Updated success rates and durations to match official.
Thanks to @mrjnumber1!
2018-09-24 14:51:51 -04:00
Cydh Ramdh
b614092b75
Updates inf3 in skill_db (#3488)
* Added inf3 0x100000 for skill is not blocked by SC_AUTOGUARD (physical-skill only)
* Added inf3 0x200000 for skill is not blocked by SC_UTSUSEMI or SC_BUNSINJYUTSU (physical-skill only)
* Changed `NK_NO_CARDFIX_ATK` check to the flag above
* Applied those new inf3 flags for skills which are `weapon`-type and have `0x8`-nk
2018-09-21 09:52:56 +07:00
Atemo
a12f1ce02f
EDP renewal change (#3485)
This setting only affects renewal mode:
- Switch to a different weapon or unequip a weapon now cancel EDP
- EDP can't be used with fist (right hand check only)

Thanks to @aleos89 and @cydh !
2018-09-19 00:33:45 +02:00
Aleos
0d77398385
Cleaned up Banding behavior (#3486)
* Fixes #3478.
* Adjusted Banding to use proper party counting functions.
* Corrected the DEF and HP Regen bonus for Banding.
* Banding Defense will no longer stack on itself.
Thanks to @admkakaroto and @exneval!
2018-09-18 11:05:27 -04:00
rAthenaAPI
e49505472e Effect State Update 2018-09-18 05:06:10 +02:00
keitenai
3cd7717324 Update documentation typo error (#3489)
* Replace wrong spelling "errur" to "error"
* Thanks to @keitenai
2018-09-14 15:09:50 +07:00
Sader Fawall
ca83d35285 Fix some error and warning in the NPC sample folder (#3458)
* exported EQI_MAX for getequipid.txt
2018-09-12 23:14:46 +02:00
Aleos
e6e0511cf7
Corrected a check for skill usage restrictions (#3472)
* Resolves an issue where the usage of self skills while a storage is open was causing the entire check to fail.
Thanks to @Tokeiburu!
2018-09-12 11:03:14 -04:00
rAthenaAPI
3ac7781c9d Effect State Update 2018-09-12 04:05:57 +02:00
Aleos
d17ddf41fe
Corrected some weapon bonuses (#3466)
* Fixes #3465.
* Item bonuses AddEle, AddRace, AddClass, and AddSize now work with shields.
Thanks to @laziem!
2018-09-05 13:46:20 -04:00
Aleos
d3d8f3c5a7
Implemented official ammo equip behavior (#3438)
* Fixes #1155.
* Added specific checks for weapons when equipping ammo.
* Ammo is removed if the required weapon is removed.
* Added battle configs to disable behavior.
Thanks to @Atemo, @exneval, and @benching!
2018-09-05 10:44:34 -04:00
Aleos
618fc37eab
Resolved Dynamic Mobs issue (#3467)
* Fixes #3464.
* Fixes Dynamic Mobs not being properly reloaded.
Thanks to @Litro!
2018-09-05 10:22:30 -04:00
rAthenaAPI
3c157f221d Effect State Update 2018-09-05 04:06:07 +02:00
keitenai
d7d012c5c1 atcommand identifyall follow up (#3463)
Fixed unreferenced local variable "i"
2018-09-03 10:03:16 +07:00
Aleos
386ee35507
Updated mob_drop parsing (#3452)
* Fixes #3172.
* Mob Drop Database now updates an item's values if it is already dropped by a monster.
Thanks to @teededung!
2018-08-31 19:01:40 -04:00
Aleos
048de6c90a
Cleaned up map property functions (#3460)
* Follow up to da83e61.
* Stop players from attacking when disabling PvP/GvG from script commands.
* Removes redundancy.
2018-08-31 18:42:18 -04:00
Aleos
d699defa74
Updated Arch Bishop skills from kRO maintenance (#3258)
* Fixes #3231.
* Updated Arch Bishop skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=222&curpage=1.
* Added two new skills: Vituperatum and Convenio.
Thanks to @secretdataz, @Rytech2, @Angelic234, @ecdarreola, @redlightliu, @laziem, @xTakami, @admkakaroto, @Tokeiburu, and @flamefury!
2018-08-31 09:19:59 -04:00
Atemo
fd4f7ccd5c Suggestion: identifyall script command (#3419)
* Implemented script command identifyall.
Thanks to @secretdataz for suggestions!
2018-08-30 10:03:03 -04:00
Aleos
3569789ab0
Corrected server info display (#3434)
* Fixes #3431.
* Corrected the VIP EXP bonus amount being displayed incorrectly for the personal information packet.
Thanks to @hendra814!
2018-08-29 09:29:21 -04:00
rAthenaAPI
fe9dbf4787 Mob and NPC Identity Update 2018-08-29 05:00:48 +02:00
Aleos
ae7cb65a96
Fixed a potential crash (#3439)
* Fixes #3413 and fixes #3437.
* Removed extra dynamic storage clearings.
Thanks to @ecdarreola and @mazvi!
2018-08-28 19:22:41 -04:00
aleos
5581da4bc4 Follow up to e469f5f
* Corrected map loaded message when no maps are removed.
2018-08-28 11:03:34 -04:00
Aleos
da83e61738
Corrected some map property issues (#3435)
* Resolves PvP timers and effects not displaying properly.
* Resolves any GvG effects not displaying properly.
* If PvP or GvG is disabled, stop players from attacking.
* Moved PvP timer and attack functions to appropriate locations.
* Removed redundancy from atcommands.
2018-08-27 20:28:18 -04:00
Aleos
0f7f66396c
Corrected Blast Mine and Claymore Trap behavior (#3373)
* Fixes #3362.
* Damage should be split among targets.
Thanks to @zakudam!
2018-08-27 19:19:36 -04:00
aleos
e469f5fb62 Corrected a map server notification
* Corrected the removed maps notification not displaying properly.
2018-08-27 18:22:23 -04:00
Aleos
bde33e762c
Cleaned up map data checks (#3405)
* Fixes #3398 and fixes #3402.
* Sped up pc_isUseitem, pc_setpos, and pc_dead map data checks.
Thanks to @uddevil!
2018-08-27 18:03:38 -04:00
Aleos
a5af358bf7
Updated mapcache tool (#3406)
* Fixes #3046.
* Mapcache tool now reads the import directory.
Thanks to @secretdataz suggestion!
2018-08-27 14:16:08 -04:00
Atemo
c856b07c45
Suggestion of 'killedgid', variable set when a monster is killed containing the monster game ID (#3418) 2018-08-23 15:49:32 +02:00
Atemo
d8bcc912d8
Fix for issue #3412 'Global instance timer' (#3414)
On official server the instance timer starts when the instance is created.
2018-08-23 15:48:54 +02:00
Aleos
7730160299
Corrected a compilation error (#3423)
* Fixes #3422.
* Resolves CELL_NOSTACK having a compile error when enabled.
Thanks to @SnotraRM!
2018-08-23 09:21:02 -04:00
Kakaroto
ef2bf5b0ef Insignia MATK Fix (#3404)
Fix of the magic attack bonus of the skills was not increasing.
2018-08-18 14:19:28 +07:00
Lemongrass3110
f42696bfd7 Added new quest info icons
Fixes #3374

Thanks to @Balferian
2018-08-18 00:08:20 +02:00
Lemongrass3110
ae89b3a7b2 Fixed a possible mapserver crash 2018-08-16 21:15:25 +02:00
Atemo
3d8104d7fb
Suggestion: checkwall script command (#3393)
* Added checkwall script command
- Included the checkwall in npc folder
2018-08-14 20:58:49 +02:00
Sader Fawall
9cba66c22e Fix string case in inarray command script (#3401)
* Fixes #3400.
Thanks to @anacondaqq and @sader1992!
2018-08-14 12:26:29 -04:00
Aleos
4befcf747f
Corrected SECURE_NPCTIMEOUT behavior (#3394)
* Fixes #3381 and fixes #3391.
* Properly end NPC sessions when a player times out.
Thanks to @mazvi, @anacondaqq, and @gustavobrigo!
2018-08-11 16:13:24 -04:00
Aleos
9ca000a4a7
Official Spiritual Sphere Absorption behavior (#3367)
* Follow up to 4f97c74.
* Fixes #3357.
* Updated Sphere Absorption to official behavior
* Sphere Absorption will fail if casted on an ally.
* Should only succeed on self or enemy targets.
* Removed Cursed Circle check as it's not needed anymore.
2018-08-10 20:29:05 -04:00
Yashim Wong
c731465a52 Updated Acid Terror damage modifier for renewal (#3346)
* Renewal formula adjusted to 80 * skillLevel + 200.
Thanks to @syracuase and @mrjnumber1!
2018-08-10 17:54:12 -04:00
Aleos
2ab298076c
Cleaned up header guard names (#3395)
* Fixes #3385.
* Updated the header guard names to C++ standards.
Thanks to @elfring's suggestion!
2018-08-10 15:57:50 -04:00
Aleos
48ae1a1e05
Cleaned up map storage type (#3384)
* Fixes #3369, fixes #3370, and fixes #3382.
* Converted maps storage container back to static array.
* Converted mapflag storage containers to unordered_map.
* Removed a lot of redundancy and recursive lookups.
* Fixed a couple short-circuit checks to help with performance.
* Fixed multiple instance creation/destruction issues.
* Fixed PK Mode attempting to set PvP on flags that are already active.
* Getting MF_RESTRICTED will return the map's zone value instead of the state.
* Converted mapflag macros to inline functions.
Thanks to @teededung, @lelouch22, @mazvi, @Lemongrass3110, and @cydh!
2018-08-10 13:52:07 -04:00
Cydh Ramdh
83c8183a2e
Added IG_PRIVATE_AIRSHIP (#3378)
* Item group for Private Airship tickets
2018-08-06 08:06:30 +07:00
Lemongrass3110
a05ed6e814
Fixed walk_choices's type (#3353)
Fixes #3310

Replaced some still hardcoded values with their define constants.
Added a function to check if a walk will be diagonal and fixed invalid calculation for it.

Thanks to @DavidPS92
2018-07-30 00:24:31 +02:00