9337 Commits

Author SHA1 Message Date
Sader Fawall
49c4ddf8f9
npctalk script command now accepts color parameter (#4910)
Co-authored-by: Jittapan Pluemsumran <secret@jittapan.app>
Co-authored-by: Lemongrass3110 <lemongrass3110@users.noreply.github.com>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2020-05-10 13:34:00 +07:00
Daegaladh
c4609b19d6
Follow up to b2aa7e698da55bcae198dfcda7ab706f35d958e3 2020-05-10 05:30:24 +02:00
~Neutral~
39f3a17f54
Fixed Dual Wielding Axes breaking when they should be unbreakable (#4518) 2020-05-10 04:21:41 +02:00
Daegaladh
73140bd078
Fixed monster messages not loading (#4908) 2020-05-09 15:53:17 +02:00
Kreustoo
d1719f670f
Adds missing args for round/ceil/floor (#4899)
* Fixes #4898.
* Only missing one integer in parameter in BUILDIN_DEF2, already ready to read in the definition of the function.
Thanks to @Kreustoo!
2020-05-08 08:28:14 -04:00
Aleos
931155ee33
Job Improvement Project - Super Novice (#4429)
* Fixes #4427.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Rytech2!
2020-05-07 14:48:44 -04:00
Aleos
5e8d9aafab
Job Improvement Project - Kagerou & Oboro (#4425)
* Fixes #4424.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Badarosk0, @OptimusM, @teededung, and @Angelic234!
2020-05-06 13:36:27 -04:00
Daegaladh
c6aceea6c3
Follow up to fe14af99625d16f3c7ef1e8192a2d3b0214f33f1
* Thanks to @CairoLee
2020-05-06 16:38:30 +02:00
Eric Liu
24ea092dd2
Fix bonuses for SJ_STARSTANCE and SJ_LUNARSTANCE (#4884)
* Fix Max HP bonus for SJ_LUNARSTANCE

* Fix missing ASPD bonus in renewal for SJ_STARSTANCE
2020-05-04 12:20:11 -04:00
Aleos
ea59d80490
Corrects Feint Bomb not hiding the caster (#4874)
* Resolves an issue with Feint Bomb not hiding the caster.
Thanks to @Badarosk0!
2020-05-04 11:56:14 -04:00
Aleos
9309986a86
Heat Barrel should be giving fixed ASPD (#4867)
* Heat Barrel's ASPD bonus should be a fixed amount, not at a rate.
Thanks to @LordWhiplash!
2020-05-04 10:20:25 -04:00
Aleos
9794aa2b80
Fixes an issue with status timers being destroyed (#4885)
* Fixes #4856.
* Follow up to d1f8c8c and 652d77e.
* A missing break from an old commit along with a refactor in code resulted in a "valid" fall through and breaking status change timers.
* Also fixes a potential crash with Book of Creating Star.
Thanks to @OptimusM, @technoken, @sader1992, @mazvi, and @akiyamamio16 for helping debug!
2020-05-03 11:30:50 -04:00
Aleos
e92f88a030
Fixes battle config skill_removetrap_type (#4865)
* Fixes an array out of bounds check when attempting to return used traps to a player through HT_REMOVETRAP.
Thanks to @marky291!
2020-04-30 13:51:09 -04:00
Daegaladh
40c776340f Follow up to 77dd729d770bcc9fc508ff09160419224bf5120b 2020-04-30 18:51:41 +02:00
Aleos
8f19cfc3a1
Fixes Weapon Crush and Weapon Blocking combo (#4809)
* Fixes #4808.
* Weapon Crush now uses SC_WEAPONBLOCK_ON to track the target instead of SC_COMBO.
* Also fixes Quick Draw Shot target selection.
* Quick Draw Shot and Weapon Blocking should be considered a combo and not end physical attacks when casting them.
* SC_QD_SHOT_READY will no longer become active if the player has 193+ ASPD.
* SC_QD_SHOT_READY will now end once Quick Draw Shot has been casted.
* Cleans up skill_check_condition_sc_required and removes duplicate code.
Thanks to @wdivet, @LordWhiplash, and @ecdarreola!
2020-04-30 12:17:50 -04:00
Aleos
da523d9fcd
Stop vending when an invalid list is received (#4868)
* Fixes #4778.
* Vending will now be stopped if an invalid list is received.
Thanks to @blipblopblip!
2020-04-30 11:12:54 -04:00
Daegaladh
be0c0efe40
Follow up to 38cf16edbaa36836072780b4481023e57e014892
*Thanks to @aleos89 and @LordWhiplash
2020-04-30 16:49:40 +02:00
Aleos
2ca94ad411
Adds back removed skills from kRO (#4803)
* Fixes #4802.
* Adds back AB_EUCHARISTICA, GN_SLINGITEM, and GN_MAKEBOMB.
* Adds back CR_CULTIVATION for renewal.
* Skills are disabled in the skill tree database but gives easy ability to re-enable.
* Fixes an issue with pre-renewal produce database spitting errors when using any production-type skills.
Thanks to @trinitynetworks!
2020-04-30 09:33:38 -04:00
Eric Liu
331b31d8cf
Fix WZ_HEAVENDRIVE skill ratio (#4862)
* Adjusted to account for the default 100.
Thanks to @Latiosu!
2020-04-29 21:08:56 -04:00
Daegaladh
fe14af9962
Fixed duplicate itemshops and pointshops (#4850) 2020-04-30 01:44:53 +02:00
Eric Liu
4829f3775d
Fix Lord of Vermilion damage (#4855)
* Fixes #4852.
* Fixes Lord of Vermilion damage not accounting for the total of each hit.
Thanks to @mazvi and @Latiosu!
2020-04-29 10:55:06 -04:00
Daegaladh
ca56c060cf
Added independent idle time and settings for homunculus share (#4761)
* Follow up to 921b3e2c3e9eae36cbf2ca35bcede6e0d73ba074
2020-04-27 20:21:22 +02:00
Aleos
312df0f10c
Job Improvement Project - Rebellion (#4428)
* Fixes #4426.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Tokeiburu, @OptimusM, @admkakaroto,@cahya1992, @Tolimatoi, and @Badarosk0!
2020-04-24 13:58:09 -04:00
Cydh Ramdh
d9ab23ae0f
Fixed Max HP & SP rate bonus (#4828)
* Fixed #4264
* Added new SCs for proper HP & SP Pill usages
* Thanks to @Daegaladh
2020-04-24 11:53:08 +07:00
Eric Liu
e764fdd4b5
Fix Heaven's Drive damage (#4835)
* Fixes #4834.
* Fixes Heaven's Drive damage in renewal mode.
Thanks to @Latiosu!
2020-04-23 21:30:19 -04:00
Aleos
b65443d8f5
Removal of OnPCStatCalcEvent (#4831)
* Fixes #4812.
* This script event can be replaced with the other various player script events.
* The trigger during equipment changing causes headache across other calculation events in source.
2020-04-23 16:53:07 -04:00
Daegaladh
058ad2c67e
Fixed duplicated skill status check when switching weapons (#4806)
* Thanks to @aleos89
2020-04-16 16:21:25 +02:00
Daegaladh
ba76880364
Fixed vending and chatrooms checking for NPCs nearby (#4805)
* Thanks to @cydh
2020-04-16 16:20:52 +02:00
aleos
44b80448df Removes target SP consumption from Tiger Cannon
* Removes target SP consumption based on damage dealt by Tiger Cannon.
* This effect was removed in #4256 but accidentally merged back in through #3659.
Thanks to @Badarosk0!
2020-04-14 12:16:53 -04:00
Lemongrass3110
6570489a84 Fixed Soul Reaper's Soul Collect behavior
Added missing status change cancel condition, when the player has reached the maximum amount of soul spheres.
Fixed duration display on the client.
Some cleanup of duplicate code.

Thanks to @aleos89
2020-04-14 15:25:04 +02:00
Lemongrass3110
f79cac8509
Fixed bodystyle for unsupported jobs (#4792)
Adds missing checks for Super Novice Expanded, Star Emperor and Soul Reaper.

Enables bodystyles saving by default, since all sprites have been released officially long enough.

Adjusted the mismatching default value for max_body_style.

Fixes #4787

Thanks to @reunite-ro
2020-04-13 18:38:49 +02:00
aleos
9db44eca7d Fixes Instance database converter
* Fixes the output of AdditionalMaps to not print as a sequence.
Thanks to @Atemo!
2020-04-09 16:13:17 -04:00
Lemongrass3110
1f63265a3b Follow up to 6fe0ed5
Thanks to @Daegaladh
2020-04-09 21:51:33 +02:00
Aleos
8716121b4c
Fixes to Battleground script commands (#4764)
* Fixes #4763.
* Cleans up script commands bg_getareausers and bg_get_data.
Thanks to @voyfmyuh and @Lemongrass3110!
2020-04-09 14:18:50 -04:00
Daegaladh
42f695fe8e
Fixed autotraders counting for instance requirements (#4779) 2020-04-09 18:03:18 +02:00
Aleos
d421225c4f
Fixes Acid Demonstration for pre-renewal (#4775)
* Fixes #4770.
* Adds back missing case for pre-renewal damage calculation.
* Adds back long ranged check for Neutral Barrier in pre-renewal.
Thanks to @danieljorge17!
2020-04-09 11:45:52 -04:00
Kakaroto
a741540366
Hateffect Update (#4780)
Minor Hateffect update.
2020-04-09 17:07:57 +02:00
Lemongrass3110
6fe0ed5819
Fixed a problem with walking NPCs (#4782)
Walking NPCs are not supported on official servers.
Therefore we have to respawn the NPC units as player units before they start walking.
After they stop walking we respawn them as NPC units again so that they show the bubbles for talking to them again.
Since player sprites have a small aura during spawning hardcoded in the client, this aura will be shown each time they begin walking now.

Fixes #4505

Thanks to @RagnaWay and @aleos89
2020-04-09 17:03:37 +02:00
Aleos
03fa1af7a8
Fixes Soul Unity being removed on map change (#4754)
* Fixes #4733.
* Soul Unity should not be removed on map change.
Thanks to @Balferian!
2020-04-08 13:46:43 -04:00
Aleos
00943a2c5f
Corrects Star Emperor stances (#4753)
* Fixes #4744.
* Adds missing stance skill requirements.
* Adds Stance values to csv2yaml for skill_db conversions.
Thanks to @iubantot and @attackjom!
2020-04-08 13:27:12 -04:00
Aleos
06c159c405
Refactored Instances to utilize C++ features (#3163)
* Fixes #3087 and fixes #3095.
* Converts database file to YAML.
* Converts static array to unordered_map which frees up pre-allocated memory that may never be fully used.
* Got rid of all DBMap/ERS features.
* Removes MAX_INSTANCE_DATA in favor of INT_MAX.
* Includes TXT converter.
Thanks to @Lemongrass3110, @secretdataz, @Atemo, @lighta, @InusualZ, @Angelic234, @Normynator, @cydh, and @ecdarreola!
2020-04-08 12:52:45 -04:00
Aleos
7507065885
Corrects Brandish Spear damage stacking (#4740)
* Fixes #4739.
* Follow up to 24ecebc.
* Resolves Brandish Spear damage doing more damage than it should.
Thanks to @violent01!
2020-04-07 16:59:38 -04:00
Daegaladh
3424928fa1
Added missing restrictions when writing a mail (#4772) 2020-04-06 22:19:12 +02:00
Aleos
02e61abbdd
Fixes a compile error for older clients (#4776)
* Fixes #4773.
* Resolves a compile error for clients older than 20150513 quest objectives.
Thanks to @Cainho!
2020-04-06 16:05:25 -04:00
Daegaladh
38cf16edba
Fixed Throw Spirit Sphere/Finger Offensive hits depending on the number of spirit spheres (#4771) 2020-04-06 20:36:22 +02:00
Daegaladh
dad85750fb
Hides players with 'hide_session' and '/ignoreall' from whisper messages (#4762) 2020-04-06 20:34:27 +02:00
Aleos
af8dd8b28d
Fixes issue with power skills (#4751)
* Fixes #4743.
* Resolves an issue with power skills and default data defined in the skill's array.
* Adds back linear determination and documentation for it.
* Adds a check in the converter to not print out values of 0 for levels 6 and higher for skill unit layout and skill unit range.
* Removes these values from the skill database.
Thanks to @Surefirer and @teededung!
2020-04-06 10:44:17 -04:00
Aleos
a67f5c5d6a
Fixes heal item recovery effects (#4750)
* Fixes #4748.
* Recovery item effects should be multiplicatively stacked.
Thanks to @Singe-Horizontal!
2020-04-05 15:22:36 -04:00
victorgawk
044acebd75
Added config option for legacy NPC EMOTION behavior (#4728)
Co-authored-by: Victor Ferreira <victor.ferreira@esig.com.br>
2020-04-02 11:04:07 +02:00
Aleos
6edcf4a3a1
Fixes Wall of Thorn knockback (#4685)
* Fixes #4645.
* The knockback should be based on self and not the caster of the skill.
Thanks to @devLOOLP!
2020-03-31 08:20:04 -04:00