9337 Commits

Author SHA1 Message Date
vakhet
cdce4cd794
Correcting import due to compiler warning (#4613) 2020-02-08 16:35:38 +01:00
Lemongrass3110
ee96438607 Fixed a map-server crash
Fixes #4614

Thanks to @reunite-ro
2020-02-08 16:35:02 +01:00
Daegaladh
77dd729d77
Fixed SA_FREECAST aspd calculation (#4570)
* Thanks to @Lemongrass3110
2020-02-07 22:05:33 +01:00
Aleos
e6a6c0533c
Updated 3rd class from RO 16th Anniversary Patch (#3659)
* Fixes #3602 and fixes #3653.
* Updated the 3rd class skills according to the RO 16th Anniversary Patch.
* Complete changelog here: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3890090&curpage=1
Thanks to @Badarosk0, @OptimusM, @Victor214, @Rytech2 and @laziem!
2020-02-07 10:39:35 -05:00
Lemongrass3110
b0ac1717f2
Added an option to block discount in shop (#4606)
This is required for the correct implementation of #4387
2020-02-07 00:29:33 +01:00
Lemongrass3110
83da86c301 Fixed ITEM_ENCHANTARMS and LG_SHIELDSPELL
Fixes #4604
Also fixes csv2yaml for highly customized skill databases.

Thanks to @mazvi
2020-02-05 23:40:59 +01:00
Lemongrass3110
57e50a1906 Fixed remove trap skills
Fixes #4605

Thanks to @Angelic234 and @mazvi
2020-02-05 23:29:01 +01:00
Sader Fawall
5386a5bcf4
Fixed some skill crit bonuses (#4454)
* Fixes #4128, fixes #4453, and fixes #4460.
* Resolves critical item bonus not applying to skills.
Thanks to @sader1992!
Co-Authored-By: Cydh Ramdh <cydh@pservero.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-02-05 14:38:56 -05:00
Daegaladh
4a1e904149
Fixed Hocus and Improvised Song ignoring mapflags (#4488)
* Fixed skills casted by SA_ABRACADABRA and WM_RANDOMIZESPELL ignoring critical mapflags
2020-02-05 15:15:14 +01:00
userid0
f76bc09fbe
Fixed a compiler warning in pc.cpp (#4601)
fix warning C4804: '>': unsafe use of type 'bool' in operation
2020-02-04 22:04:43 +01:00
Atemo
ac0d17f4aa
Corrected getfreecell command for flag 2 (#4491)
* Little simplification of the code
* Extends the target type for flag 2 to match the docs (target applicable for player, monster, pet, homunculus)
Thanks to @Lemongrass3110
2020-02-04 19:58:04 +01:00
Atemo
78eb1bcd7b
Additional check in map_mapid2mapname (#4373)
* The mapid2name script command didn't check if the map existed (potential crash)
2020-02-04 15:01:00 +01:00
rAthenaAPI
6c8840ca54 Effect State Update 2020-02-04 05:05:35 +01:00
Lemongrass3110
0b3430c777
Fixed some database redundencies (#4565)
Cleaned redundancies in guild members and friends table

Fixes #4564

Thanks to @Everade
2020-02-03 20:27:11 +01:00
Lemongrass3110
b86926a7a2
Fixed a compiler warning in script.cpp (#4586)
Fixes #4582

Thanks to @idk-whoami and @aleos89
2020-02-03 14:44:58 +01:00
Lemongrass3110
a323474433 Fixed a few hard coded element checks 2020-02-02 20:01:55 +01:00
aleos
abc027b47f Skill YAML fixes
* Fixes an issue with knockback converting the wrong column.
* Fixes an issue with skills containing multiple elements converting the wrong column.
Thanks to @mazvi and @Lemongrass3110!
2020-02-02 13:42:53 -05:00
Lemongrass3110
0105116338 Fixed variable cast times
Thanks to @mazvi again.
2020-02-02 17:58:44 +01:00
Lemongrass3110
5cf7aceb2a Fixed some bugs with the new skill db
Fixes #4590

Thanks to @mazvi
2020-02-02 16:04:11 +01:00
Lemongrass3110
990c81f024 Fixed a few bugs in the mob avail converter
Thanks to @Everade
2020-02-02 15:06:45 +01:00
aleos
7bdfe81867 Skill Ammo requirement fixes
* Fixes #4589.
* Resolves an issue with the skill converter outputting the incorrect ammo type requirement.
* Also fixes an issue with physically attacking targets while having a status option active.
Thanks to @mazvi!
2020-02-01 16:06:13 -05:00
Aleos
1b8c2e517d
Cleaned up CSV2YAML skill database label (#4585)
* Strips the "_Skill" from TargetType.
* Cleaned up documentation header to match.
2020-02-01 09:53:27 -05:00
aleos
ecd2a9af87 Fixes script command resetskill
* Follow up to dca3797.
* Resolves a missing skill index lookup during skill reset.
Thanks to @mmanlapat!
2020-02-01 08:54:34 -05:00
Aleos
dca3797d44
Converted the skill database to YAML (#4531)
* Combines skill_cast_db, skill_castnodex_db, skill_copyable_db, skill_nonearnpc_db, skill_require_db, and skill_unit_db into skill_db.
* Introduces a cached YAML class for quicker lookups.
* General cleanups and optimizations.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-31 14:14:08 -05:00
Aleos
de9f667d2f
Corrects Max Baby Third Parameter issue (#4578)
* Fixes #4576.
* Added missing case for returning battle config for Baby Third classes.
Thanks to @reunite-ro!
2020-01-29 17:03:24 -05:00
Daegaladh
ed51647311
Fixed hom_idle_no_share exp check (#4557)
* Follow up to 921b3e2c3e9eae36cbf2ca35bcede6e0d73ba074
2020-01-28 21:29:30 +01:00
Jittapan Pluemsumran
082766defc Revert "Overed Boost now decreases homun's hunger level by half (#4218)"
This reverts commit 77fa9dbcbe6ad702ca5549f4ae2fba5983c4c9d0.
2020-01-26 23:33:32 +07:00
yoonjunho1994
77fa9dbcbe Overed Boost now decreases homun's hunger level by half (#4218)
Fixes #4217
2020-01-26 22:37:11 +07:00
Lemongrass3110
97894a627a
Fixed SG_FEEL dialog cancel (#4566)
Fixes #3535

Thanks to @anacondaq
2020-01-25 23:45:39 +01:00
Lemongrass3110
e1c40cc741
Fixed a pvp bug with option invisible (#4563)
Fixes #4230

Thanks to @Stingor
2020-01-25 17:23:08 +01:00
gamingmagic
e2a1bb3f0c Fixed sitting issue for devoted players (#4538)
Fixes #1927

If aplayer is under devotion and gets attacked he will remain sitting server side, while standing up client side. This will result in the player not being able to move anymore, until he sat down/stood up again.

Since this is the real behavior on AEGIS we added a configuration for the fix, which will be enabled by default, since we think this is broken behavior. You can always turn it off in case you want to mimic official behavior.

Additionally fixed the devoting player as well:
The devoting player should also stand up when the devoted player is hit.
If the player is missed or he lucky dodges and no damage is dealt, no damage packet should be sent to the devoter.
Additionally fixed that the devoter did not use the waving damage animation, because the amotion and dmotion values were not sent.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-25 13:57:28 +01:00
Aleos
bd2d82157a
Fixed Expanded Baby parameter cap (#4551)
* Fixes #4350.
* Resolved Expanded Baby classes parameter cap defaulting to the upper class.
* Fixes baby parameters for Summoners as well.
* Removed redundant baby checks due to correct order now.
Thanks to @bgamez23!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-24 10:56:39 -05:00
Aleos
271489960a
Corrected Feint Bomb infinite status (#4550)
* Fixes #4508.
* Resolves an issue where Feint Bomb was giving users infinite duration from AoE statuses.
Thanks to @laziem!
2020-01-23 16:09:52 -05:00
Daegaladh
921b3e2c3e
Added conf option for homunculus idle no share (#4548)
* Added conf option to make characters stop receiving exp/drop from homunculi when they are idle
2020-01-22 18:55:59 +01:00
Lemongrass3110
a4c75d4771
Fixed compilation on GCC < 5.1 (#4552)
Fixes #4544
2020-01-22 16:06:58 +01:00
rAthenaAPI
87f66ed0f0 Effect State Update 2020-01-22 14:05:38 +01:00
rAthenaAPI
5b5e352945 Effect State Update 2020-01-22 13:05:22 +01:00
rAthenaAPI
ef9cbc3459 Effect State Update 2020-01-21 07:05:38 +01:00
rAthenaAPI
858c9bf4f7 Effect State Update 2020-01-21 05:05:32 +01:00
Sader Fawall
fc1c05aee9 Announce Accept Char id (#4203)
Adjusted script command announce to accept charID
* Fixes #3901.
* Script command announce will now accept a character ID to display locally.
Thanks to @sader1992!
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-17 21:22:49 -05:00
Aleos
bf9a3b47fe
Removed an extra status calculation for players (#4525)
* Follow up to 2732176.
* Fixes #4150.
* Removed an extra status calculation for players resulting in some status data being nullified.
* Adjusted status calculation for autobonus and unequipping items.
* Cleaned up delayed damage logic.
Thanks to @cydh, @Hatfun, and @NeutralDev!
2020-01-17 20:30:35 -05:00
Aleos
69b68bc2f5
Fixed CSV2YAML not freeing memory (#4542)
* Fixes #4541.
* CSV2YAML tool will now free the memory on each database conversion.
Thanks to @Lemongrass3110!
2020-01-17 19:13:47 -05:00
Sader Fawall
4f0894c4f9 Fixed unitwalk with the same event name (#4204)
Fixes #4118
2020-01-18 00:29:56 +01:00
Lemongrass3110
8f512d8abb Fixed a newly introduced stack bug
Fixes #4537

Thanks to @Triedge
2020-01-14 09:47:28 +01:00
Lemongrass3110
e72c7360cf
Added int64 support to the script engine (#4522)
Added support for signed 64 bit integer value computation into the script engine.
This is required because newer official features require support for bigger numbers inside the scripts.

This also cleans up a lot of messy code and fixes a few issues like script stack corruptions.

Thanks to @aleos89 and everyone who supported me with this.
2020-01-13 14:44:48 +01:00
Daegaladh
78a02330b2
Follow up to e27aa8b2d82620aa461291b293e00afb7c79e0cb (#4509)
* Additional configs for boss idle AI
2020-01-11 15:14:33 +01:00
~Neutral~
bc5b147644 Fixed bonus2 bRegenPercentHP and SP (#4511) 2020-01-05 00:08:19 +01:00
Lemongrass3110
eb9ae813b5
Fixed pet eggs as mail attachments (#4506)
Fixes #4327

Thanks to @RadianFord
2020-01-04 03:22:10 +01:00
Daegaladh
e27aa8b2d8
Additional configs for mobs idle AI (#4503)
* Added conf options to enable/disable monsters using idle skills and move when there's no players nearby.

Thanks to @aleos89
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-03 00:20:50 +01:00
Aleos
c52b3b784a
Expanded a couple baby job names (#4500)
* Expanded Job_Baby_Rune -> Job_Baby_Rune_Knight, Job_Baby_Bishop -> Job_Baby_Arch_Bishop, Job_Baby_Cross -> Job_Baby_Guillotine_Cross, Job_Baby_Guard -> Job_Baby_Royal_Guard, and Job_Baby_Chaser -> Job_Baby_Shadow_Chaser.
* Expanded related MAPID/EAJ constants as well.
* Added deprecation notice for old constants.
* Updated database and NPC scripts to use new constants.
2020-01-01 22:53:40 -05:00