9337 Commits

Author SHA1 Message Date
Aleos
972a14e4ed
Corrected Rebellion cast times (#3928)
* Fixes #3858.
* Corrected cast times and duration for several Rebellion skills.
Thanks to @siriousb!
2019-03-23 17:38:13 -04:00
Aleos
9500c06dab
Corrected unit calculation with setunitdata (#3978)
* Fixes #3953.
* Resolved an issue with monster's class not being properly recalculated when using script command setunitdata. For now, just allow switching between CLASS_NORMAL and CLASS_BOSS.
* Fixed HP and MaxHP adjustment for monster, homunculus, mercenary, elemental, and NPC.
* Fixed MaxSP adjustment for homunculus and elemental.
* Fixed Size adjustment for monster, homunculus, mercenary, and elemental.
* Fixed Race adjustment for monster, homunculus, mercenary, and elemental.
* Fixed the Map ID string check to support all unit types.
Thanks to @teededung and @SeravySensei!
2019-03-23 16:15:28 -04:00
Aleos
ed83999de4
Corrected Vellum and Vanish item bonuses (#4030)
* Fixes #4016.
* Cleaned up the way Vellum damage and Vanish damage are calculated.
* Implemented bonus3 bSPVanishRate/bHPVanishRate.
* Updated Mental Destroyer item bonus.
* Cleaned up and added documentation.
Thanks to @Balferian!
2019-03-23 15:02:49 -04:00
Cydh Ramdh
bce4e0b660
Fixes #4026 (#4027)
* Fixed flag's overwritten for bonus3 bSubEle and bonus3 bAddEle
2019-03-22 07:09:14 +07:00
rAthenaAPI
e6f1f21ddc Mob and NPC Identity Update 2019-03-19 04:00:47 +01:00
Sean Allen
bf27041e7b Fixed LGTM formatting alert (#3987) 2019-03-18 00:02:25 +01:00
Lemongrass3110
232b3885b5
Fixed csv2yaml for guild skill tree (#4018)
It now properly uses skill names instead of the skill id.

Fixes #4017
2019-03-17 21:54:09 +01:00
Daegaladh
cbe0d6b271 Splitted guild_skill_tree.txt into re and pre-re (#3841)
Converted Guild Skill Tree database to YAML

Please run csv2yaml to convert your existing databases if necessary.

Thanks to @aleos89, @Atemo and @Lemongrass3110
2019-03-11 19:57:52 +01:00
Aleos
54ac2ae132
Fixed an issue with AG_BATTLE and AG_TAMING (#4006)
* Added a missing assignment for achievement monster targets.
Thanks to @teededung and @Lemongrass3110!
2019-03-09 14:17:11 -05:00
Jittapan Pluemsumran
f5e8af0d9c Fixed possible null pointer dereference in Taekwon Mission skill logic. Fixes #3996
Thanks to @cydh
2019-03-05 15:00:04 +07:00
Lemongrass3110
c2899d754f
Added the skeleton for the yaml converter (#3991)
Updated travis to build tools as well.

Thanks to @aleos89 for this help.
2019-03-01 00:41:20 +01:00
Aleos
78eed02273 Updated the YAML parsing method (#3694)
Synchronized the process of loading and parsing YAML databases.
Provides more robust parse warnings/errors.
Added Header checks to validate database versions.
Adjusted root keys to a standard name of Body.
Adjusted inter-server storages, achievements, and attendance to follow the new format.

Fixes #3483

Thanks to @Lemongrass3110!
2019-02-28 22:19:39 +01:00
BrOgBr
757a459320 Fixed a duplicate path status (#3975)
* Fixed a duplicate path status
Thanks to @zhqfdn
2019-02-24 16:01:47 +01:00
Mark Hester
ec6c36983c Better itemdb_read_flag error message (#3971)
* Removed a redundant message.
Thanks to @marky291!
2019-02-22 13:43:21 -05:00
Mark Hester
a5c93b60a6 Definitions for DB Pathing (#3964)
* Added the use of DBPATH/DBIMPORT definition for guild EXP, job information, level penalties, and map cache to remove hardcoded values.
Thanks to @marky291!
2019-02-22 09:02:08 -05:00
keitenai
bfb6b831f8 Minor clean up in clif_displaymessage function (#3957)
* Clean up `clif_displaymessage` function
2019-02-21 17:25:58 +01:00
Lemongrass3110
913cf8751f
Added correct allocation info to strlib (#3946)
This way you can really see where your memory leaks from StringBuf, SQL Queries or other functions that use this really come from.
2019-02-18 20:10:03 +01:00
Lemongrass3110
fc92a97978
Fixed an issue with progressbars (#3945)
Additionally if progress was being canceled and a message window was active, the user would be stuck, because no close button would show.

Fixes #3944

Thanks to @teededung, @cahya1992 and @Atemo
2019-02-18 19:31:05 +01:00
Aleos
47866f6065
Cleaned up cmake output (#3941)
* Follow up to d649ede.
* Renamed svnversion.h to version.hpp.
2019-02-15 23:10:17 -05:00
rAthenaAPI
063892f20a Effect State Update 2019-02-14 11:05:43 +01:00
rAthenaAPI
06d68f4edb Effect State Update 2019-02-14 10:09:57 +01:00
rAthenaAPI
90d5b47025 Effect State Update 2019-02-13 05:05:58 +01:00
rAthenaAPI
df01a921ba Effect State Update 2019-02-13 04:05:57 +01:00
Aleos
5d69a4fee8
Fixed Camouflage (#3933)
* Fixes #3788.
* Fixes the Provoke icon getting removed when clif_changeoption is called and it's not an infinite duration.
Thanks to @Everade!
2019-02-12 10:53:10 -05:00
Aleos
d649ede46b
Corrected script commands containing arrays (#3932)
* Corrects a potential map-server crash with script commands min, max, getpartymember, getguildmember, getunits, getmapunits, getareaunits, getunitdata, and channel_setgroup when a character variable is used when no character is attached to the script.
Thanks to @Tokeiburu and @Atemo!
2019-02-11 12:23:04 -05:00
Aleos
c5a5c54518
Converted remaining C comments (#3927)
* Converted remaining documentation that references .c or .h files.
2019-02-09 15:08:45 -05:00
Daegaladh
35611e78e1
Fixed Ice Wall units to match their official behavior (#3935) 2019-02-09 13:51:20 +01:00
Atemo
747781fb89
Fixed bg_get_data script command (#3921)
* In some cases the command didn't return the members ID for 'type 1'
2019-02-07 16:26:06 +01:00
Aleos
5908c0484f
Corrected script command getmapxy (#3922)
* Fixed an issue with floating NPC being on an 'invalid' map and attempting to store the map name.
Thanks to @Atemo!
2019-02-06 12:34:13 -05:00
Atemo
92de3065e2
gvg warning (#3919)
* pvpon, pvpoff, gvgon, gvgoff, gvgon3, gvgoff3 now display a message when the map doesn't exist
* The command don't return SCRIPT_CMD_FAILURE anymore when the mapflag is already in the state
2019-02-06 15:27:04 +01:00
aleos
42b71e6f6e Follow up to 1f97bea
* The skill ID check should only take place on parsing bonus2, bonus3, bonus4, or bonus5.
2019-02-05 22:16:28 -05:00
Aleos
360cc25cc9 Corrected some card combos (#3903)
* Fixes #3492.
* Resolved some item combo cards that transformed the wearer causing the stats to come awry.
* Cleaned up some documentation.
Thanks to @BrOgBr, @raelemagy, @mrjnumber1, and @Everade!
2019-02-05 16:39:06 -08:00
Aleos
2ae2f25f4b
Fixed accessory equipping with cards (#3913)
* Fixes #3908.
* Accessories that have cards which require specific left/right locations must take priority.
* Sped up position checking.
Thanks to @Badarosk0 and @Lemongrass3110!
2019-02-05 19:08:04 -05:00
Aleos
1f97beae27
Cleaned up script command argument parsing (#3910)
* Cleaned up the way script commands parse arguments.
* script_isstring and script_isint will now properly check variable references.
* This allows script command arguments to contain variables without having to make source side adjustments.
* Reverted several script commands that reference the data directly.
Thanks to @Lemongrass3110!
2019-02-05 18:50:54 -05:00
Aleos
f235d89e76
Added item bonus bNoWalkDelay (#3906)
* Fixes #131 and fixes #2699.
* Added item bonus bNoWalkDelay to replace infinite SC_ENDURE bonus in items.
* Added a warning if INFINITE_TICK is detected in the item combo bonus.
* Included some minor cleanups and additions.
Thanks to @exneval, @c0nflicts, and @esu1214!
2019-02-05 12:23:36 -05:00
Lemongrass3110
8e325e4116 Fixed some more server crashes
Thanks to @functor-x
2019-02-05 00:06:09 +01:00
Atemo
b032aae30a
Added the battle_config limits (from pc_changelook) to changelook script command (#3899) 2019-02-04 23:30:35 +01:00
Lemongrass3110
25aaeec135
Fixed a possible script exploit (#3920)
Thanks to @functor-x
2019-02-04 18:31:07 +01:00
Lemongrass3110
dd08423484
Fixed a possible pet server crash (#3912)
Thanks to @functor-x
2019-02-03 23:54:20 +01:00
Lemongrass3110
2c47569ffb
Fixed a possible mail send server crash (#3914)
Thanks to @functor-x
2019-02-03 23:32:57 +01:00
Aleos
26720f041a
Updated script command getmapxy parameters (#3890)
* Fixes #3100.
* Script command getmapxy will now allow integer values for the search value.
* Deprecated UNITTYPE constants as they were replaced by BL.
* Defaulted BL_PC as the target for script command getmapxpy.
* Updated script command getunittype return value to return BL constants.
* Updated scripts to new BL constants.
Thanks to @pajodex's suggestion and @Lemongrass3110!
2019-01-30 17:10:33 -05:00
norm
de8c707f07 Changed skip into error (#3698)
Problem:
if common fails target map/char/login will be disabled.

Solution:
if common fails stop cmake execution and throw an error, this will avoid building only mapcache and common_base.
2019-01-30 00:05:32 +01:00
Aleos
fe12d6f016
Corrected Sling Item bonuses (#3845)
* Fixes #3810.
* Partial revert of eae1161.
* Removed the item database bonuses from Throwing Increase HP/SP Potions and moved them back to source as these items require the caster's Base Level.
* Concentrated White Potion Z should only increase HP regeneration rate (not the interval).
* Vitata 500 should increase SP regeneration rate (not the interval).
Thanks to @Everade!
2019-01-29 17:50:13 -05:00
Aleos
298cfefd2d
Corrected status attack's element (#3873)
* Fixes #3861.
* Status attacks should always be forced to neutral.
Thanks to @Tokeiburu!
2019-01-29 17:19:16 -05:00
Lemongrass3110
19eef173c1
Disconnect player on map-server switch failure (#3895)
Fixes #3894

Thanks to @LunarSHINING
2019-01-29 16:08:40 +01:00
Aleos
626c2b7ff1
Updated Quagmire status removal list (#3802)
* Quagmire will now remove Crazy Uproar.
Thanks to @mrjnumber1!
2019-01-29 09:38:23 -05:00
rAthenaAPI
80375c55f8 Mob and NPC Identity Update 2019-01-29 04:00:46 +01:00
Lemongrass3110
db3267a868
Fixed a crash from MVP Ladder Warper (#3888)
Fixed a bug where 3 scripts would be running at the same time on the same character.

Fixes #3881

Thanks to @bgamez23
2019-01-24 20:10:53 +01:00
Aleos
6c86492764
Corrected a few potential crash points (#3874)
* Fixes #3872.
* Added a couple more map data validity checks on block list counting functions.
* QD Shot should no longer remove the read status.
* Dragon Trail should no longer end the Crimson Marker status.
* Some other minor optimizations/cleanups.
* Fixed a va_arg corruption
Thanks to @attackjom, @Lemongrass3110, and @teededung!
2019-01-23 20:27:41 -05:00
Daegaladh
a9f868f85f
Fixed CDP not failing when haven't met the requirements (#3887) 2019-01-23 18:45:44 +01:00