4264 Commits

Author SHA1 Message Date
ai4rei
5ae9f931de * Fixed formatted broadcast messages not working with 2010-11-24aRagexeRE and later (bugreport:4872, since r14120).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14803 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-28 14:19:56 +00:00
ai4rei
40ec74d163 * Extended debugging code for bugreport:3504 (related r14599).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14801 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-21 15:58:13 +00:00
Gepard
e9be30aea1 * Fixed quest_check checking exactly 3 quest objectives instead of MAX_QUEST_OBJECTIVES (since r13959).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14800 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-20 03:06:40 +00:00
ai4rei
97eded0c3e * Updated packet for the view players' equip feature for 2010-11-24aRagexeRE+ and made it support robes (follow up to r14797).
- Fixed spawn/walking packets using wrong variable for shifting buffer reference (since r14797).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14799 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-18 02:10:38 +00:00
ai4rei
847809a9e7 * Added support for visible garments/robes.
- For SQL apply upgrade_svn14797.sql to upgrade table `char`; for TXT no action is necessary, as it upgrades itself.
- This also fixes NPCs not being visible with clients 2011-01-11aRagexeRE+ (bugreport:4865).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14797 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-16 20:15:20 +00:00
ai4rei
dc6ae732e4 * Some cleanups related to player and monster states.
- Moved user_font and bg_id out of states as they are data, not states.
- Reordered members of state structs so that bitfields are packed together (less memory gets wasted).
- Other insignificant code tweaks.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14795 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-16 12:18:24 +00:00
ai4rei
84fcf0da35 * Added more packets for clients 2010-11-23aRagexeRE+ provided by Shinryo.
- Fixed missed updates for packet version bump in previous revision.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14792 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-10 19:13:58 +00:00
ai4rei
b3ec545cee * Fixed switching between musical weapons would cancel ongoing dance skills (bugreport:4756, since r3538).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14790 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-10 14:31:27 +00:00
ai4rei
40b140b335 * Fixed @changegm not updating guild window interface after changing the guild leader (bugreport:408, since r2622, related r3185).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14788 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-10 07:13:38 +00:00
ai4rei
a94aea7582 * Moved duel code into a separate file.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14785 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-09 12:07:58 +00:00
ai4rei
c5b8c85a4f * Changed pc_jobid2mapid to use a 1:1 mapping which is less prone to errors and faster than the previous method (follow up to r14755).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14782 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-09 08:38:02 +00:00
ai4rei
b0ad05d803 * Fixed monster skill associated emotions were always ignored when having less than three digits ( = all ) (bugreport:4842).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14778 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-07 16:10:02 +00:00
ai4rei
e3e12bb261 * Throwing around with packet updates.
- Clarified the description for role-change chatroom packets 0xe0 (CZ_REQ_ROLE_CHANGE) and 0xe1 (ZC_ROLE_CHANGE).
- Fixed auction window opening packet 0x25f (ZC_AUCTION_WINDOWS) had also a close button packet attached (since r12270).
- Fixed auction search results packet 0x252 (ZC_AUCTION_ITEM_REQ_SEARCH) obtaining only a WFIFO buffer of 20 bytes, regardless of the amount of results (since r12301).
- Fixed auction search result item type was .W instead of .L, which also eliminates the unknown field after it (since r12301).
- Fixed an odd packet in clif_Auction_close, which is supposed to have layout of 0x25e, while using 0x25d as packet type (since r12323).
- Resolved unconfirmed fields in clif_party_show_picker (follow up to r13987).
- Updated packet layouts for auction in packet_db.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14777 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-07 14:14:30 +00:00
brianluau
c775425157 - Changed 'specialeffect' when <send_target> is SELF, it will display the effect to the attached RID (if there is one) instead of the npc. (topic:243842)
- Changed 'movenpc' to accept an optional argument for direction. (topic:206973)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14776 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-06 23:49:05 +00:00
ai4rei
f49808fa5d * Resolved some pc_setparam issues.
- Fixed HP/MaxHP/SP/MaxSP could be set to arbitrary values, thus disregarding configuration limits and causing client crashes on certain conditions (bugreport:4177).
- Fixed HP/SP not getting adjusted to MaxHP/MaxSP respectively, when the max. value is reduced below the value of the cur. value.
- Fixed STR/AGI/VIT/INT/DEX/LUK values could be set beyond character's max. stat limit.
- Fixed Gender not being limited to male/female.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-06 18:38:08 +00:00
ai4rei
04d4e18863 * Improved changes to script command 'waitingroom' from r14772.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14773 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-06 16:55:59 +00:00
ai4rei
fbb16c5ccb * Fixed script command 'warpwaitingpc' not checking, whether or not the player still has required amount of Zeny (since r14765).
- Fixed warping through 'warpwaitingpc' to savepoint would take the fee twice ( missing {} ).
- Fixed random warping through 'warpwaitingpc' would not take away fee Zeny at all.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14772 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-06 16:06:28 +00:00
ai4rei
202bdda8d5 * Paying and obtaining Zeny (pc_payzeny/pc_getzeny) no longer silently reverses the effect for negative amounts, that is, getting Zeny instead of paying up and vice versa (since r8273, related r8072).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14766 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-05 08:14:54 +00:00
Kisuka
bf12d754cc - Completed L0ne's 2007 request for 'waitingroom' to support required zeny and level.
- Updated NPC files which required the waitingroom update.
- Added Poring War script.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14765 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-04-05 06:00:20 +00:00
Paradox924X
6cc9f191f1 Prevented SC_EXPBOOST, SC_JEXPBOOST and SC_ITEMBOOST (used by Battle Manuals and Bubble Gum) from being dispelled by Gospel. (bugreport:4836)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14763 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-28 04:39:51 +00:00
ai4rei
bba102a818 * Added separate character state for vending (like for buyingstore), instead of vender_id != 0 (follow up to r14682, related r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14762 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-27 18:43:31 +00:00
ai4rei
2971fb3e9a * Added support for tracking state of client command /effect through packet 0x21d (CZ_LESSEFFECT).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14761 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-27 18:17:05 +00:00
ai4rei
13d8ac9537 * Fixed battlegrounds chat packet 0x2dc (ZC_BATTLEFIELD_CHAT) being sent with the battleground id rather than the account id of the talking player (since r13593).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14760 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-25 17:31:28 +00:00
Gepard
4698c6c569 * Fixed possible client crash when monster is class-changing to mob_avail'd one.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14754 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-22 02:42:12 +00:00
ai4rei
6aa18784a3 * Random accumulated tweaks and fixes.
- Added a error message to npc_enable, to spot disablenpc/enablenpc/hideoffnpc/hideonnpc on non-existing NPCs (related r14750).
- Replaced inlined npc_name2id code with calls to npc_name2id.
- Open Buying Store skill is now exempted from noskill mapflag like Vending as well (bugreport:4815, follow up to r14713).
- Fixed signed constant being returned as unsigned value in get_percentage (bugreport:4765, since r12679).
- Replaced strlen checks, which checked whether or not a string is empty, with first-byte checks.
- Fixed enabling 'fakename' not clearing party and guild name and cleaned up atcommand 'fakename' code.
- Cleaned up party/guild name code in clif_charnameack (follow up to r14737).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14751 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-20 20:19:23 +00:00
Gepard
f0fb5249a1 Removed leftovers of old charcommand config (follow-up to r13403).
Added check to ensure character `rename` status will be saved if changed.
Fixed Beast Strafing (HT_POWER) damage formula and SP requirement provided by Playtester (bugreport:4675, since r4392).


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14748 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-19 21:40:15 +00:00
ai4rei
dd28b6b2b1 * Fixed pet database reading displaying wrong amount of read entries per file (bugreport:4797).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14746 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:48:05 +00:00
ai4rei
9f7d93be5a * Fixed canceling item appraisal window (Magnifier and Identify) would prevent players from using any follow up skills (bugreport:4809, since r14545).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14745 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:36:22 +00:00
ai4rei
0f68f25c54 * Fixed monsters getting warped when stepping on an NPC warp when at least one of the bits of setting 'mob_warp' was set (bugreport:4766, since r12757).
- Fixed option 'monster_ai' referring to setting 'mob_npc_warp' rather than 'mob_warp' (follow up to r8135).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14744 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-15 18:10:13 +00:00
ai4rei
44294eb3b1 * Fixed a typo in npc_touchnext_areanpc (NPC's map being used as it's x-coordinate), which caused ::OnTouch_ invokation to affect different area than intended (bugreport:4814, since r14097).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14743 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-14 15:08:54 +00:00
ai4rei
015d2ae95c * Fixed @item2 and script command 'getitem2' not taking MAX_REFINE define into consideration (bugreport:4804).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14739 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 18:55:27 +00:00
ai4rei
ed0711d6a1 * Fixed @str/@agi/@vit/@int/@dex/@luk commands setting a stat to 0 (rather than 1), when exact amount is subtracted (bugreport:4803, since r14493).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14738 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 14:11:35 +00:00
Kisuka
91250a364c - Added official behavior of displaying party names.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-08 12:44:53 +00:00
ai4rei
c9a3277785 * Cleaned up packet dumping code.
- Replaced utils function 'dump' with 'WriteDump' (files) and 'ShowDump' (console), and used those to replace inlined code in clif (related r10947).
- Fixed clif_parse_debug not printing anything, when it is used with a variable length packet.
- Added ability to dump invalid packets through define DUMP_INVALID_PACKET (clif.c).
- Removed code to dump all incoming packets, as that can be achieved with the DUMP_UNKNOWN_PACKET code as well when needed (from r1009, related r10947).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14734 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-07 09:51:33 +00:00
ai4rei
a54e55ae82 * Minor clean-ups to buyingstore and searchstore code (follow up to r14732).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14733 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-06 22:57:58 +00:00
ai4rei
6b74ef9b50 * Implemented search store info system (aka. vending and buying store search) together with related items.
- Requires 2010-08-03aRagexeRE or later and can be disabled in 'conf/battle/feature.conf'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14732 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-06 19:16:09 +00:00
ai4rei
ffe2f08b20 * Fixed possible crash in script_reportdata, when a script string becomes NULL.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14731 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-05 08:53:26 +00:00
ai4rei
a8b582fbf8 * Fixed recursive map_quit invocation when a buying store is auto-closed (login when @autotrade/logout) (bugreport:4796, since r14724).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14730 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-04 10:17:22 +00:00
ai4rei
9a7c05e962 * Updates to the super novice's guardian angel prayer effect and related handling code.
- Removed the server-side chat tracking code (since r492) responsible for invoking the effect, since this functionality is handled by the client (invocation also processed by the server). This also fixes the missing 7 lines requirement on the server-side handling (bugreport:4786).
- Updated the checks in the client-invoked code part and documented the packet.
- Now only the prayer in client-side data\msgstringtable.txt (lines 791~794) applies.
- The prayer is no longer blocked by noskill-restrictions.
- Exp at 0% and 100% no longer causes the effect to trigger.
- Fixed the exp percent check to also check one digit after the decimal point (requirement is 10.0% not 10%).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14729 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-02 11:55:27 +00:00
ai4rei
57dc2cdfcf * Fixed packet 0x839 (new guild member expel notification) was expected on clients 2010-06-08aRagexeRE~2010-07-30aRagexeRE, although those do not implement it (bugreport:4789, since r14718, related r14368).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14728 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-01 22:24:18 +00:00
ai4rei
c9d4af2383 * Updates to various custom stuff that buying stores might/are expected to support (follow up to r14713).
- Buying store no longer works on novending maps/cells (bugreport:4778).
- MANNER_NOROOM mute flag now affects buying stores as well (like vending).
- Enabled @autotrade for buying stores.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14724 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-23 21:00:48 +00:00
ai4rei
824b3f8a47 * Fixed whispering to NPCs (::OnWhisperGlobal) not working for NPCs whose unique name is different from the display name (bugreport:4776, since r2624).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14723 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-23 20:14:45 +00:00
ai4rei
b70116a541 * Fixed SP regen not stopping when Maximize Power (BS_MAXIMIZE) is in effect.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14720 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-21 01:27:49 +00:00
ai4rei
7aedde90e8 * Updated guild expel notification packet 0x15c (ZC_ACK_BAN_GUILD) for clients 2010-06-08aRagexeRE and newer to 0x839.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14718 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-20 01:21:12 +00:00
ai4rei
bc951500fd * Removed '.txt' from log config info messages, as the values already have an extension (since r197, related r196).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14717 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 21:40:16 +00:00
ai4rei
3f4cacac0b * Fixed buying stores could be opened and sold to regardless of distance between seller and buyer (since r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14715 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 18:47:45 +00:00
ai4rei
50eab8f576 * Fixed 'feature.conf' not getting loaded and a typo buying store feature setting name (follow up to r14713).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14714 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 13:23:42 +00:00
ai4rei
ce3f78556c * Implemented buying store system (aka. reverse vending, purchase shop) together with related skill and items, without NPCs.
- For SQL apply upgrade_svn14713_log.sql to upgrade tables `picklog` and `zenylog`; for TXT no action is necessary.
- Requires 2010-04-20aRagexeRE or later and can be disabled in 'conf/battle/feature.conf'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14713 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-19 12:59:36 +00:00
ai4rei
5ed2bd8367 * Merged enumeration update from renewal [14699/branches/renewal] for a future commit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-17 20:16:42 +00:00
ai4rei
86091a86f7 * Added support for client GM command /check (related r12076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14707 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-15 11:47:31 +00:00