8516 Commits

Author SHA1 Message Date
Lemongrass3110
639830a004 Fixed a compile error
Follow up to 120df33
Sorry I did not wait for the build reports.
2016-07-30 00:16:28 +02:00
Limestone
120df3353e One Click Identify feature adjustments (#1463)
- In Official, you can also use Novice Magnifiers
- If you have both type of magnifiers in your inventory, it will always consume the normal magnifier first
2016-07-30 00:06:50 +02:00
Lemongrass3110
e99f17b3b2 Fixed the required levels for MC_CHANGECART
Thanks to @jgoog999 for his pull request(merges and closes #1461).
2016-07-29 19:48:41 +02:00
aleos89
52a74e8590 Updated Camouflage behavior - part 2
* Follow up to bec9845.
* Arrow Shower should not benefit from Camouflage.
* Sharp Shooting and Arrow Storm bonus should be applied to all targets in the area, not just the selected target.
Thanks to @Tokeiburu!
2016-07-29 13:39:51 -04:00
Lemongrass3110
5da49b87b5 Added hat effect packet and script support 2016-07-29 19:15:46 +02:00
Limestone
f0ac1d81c5 Implemented new costumes w/ visual effects
- ItemID (19022) // jRO Item
 - ItemID (20062)
 - ItemID (20099)
 - ItemID (20154)
 - ItemID (20209) // jRO Item
 - ItemID (20246)

Note 1: Status ID's that we still don't have their item informations
 - SC_FLOWERSMOKE
 - SC_HAPPINESS_STAR
 - SC_MAGICAL_FEATHER

Note 2: Some of the costumes will not show it's visual effects on 2014 clients downwards.
2016-07-29 10:31:35 +08:00
aleos89
d1a957efea Cleaned up parts of the VIP System
* Removed battle configs vip_exp_penalty_base_normal and vip_exp_penalty_job_normal as these are duplicates of other battle configs.
* Battle config vip_exp_penalty_base and vip_exp_penalty_job are now at a rate of 100 instead of 1 to match other configs.
* Added VIP Zeny Penalty config.
* Cleaned up various rate calculations.
* Removed various macro defines that aren't needed.
* Moved the player state for atcommand showrate to the VIP struct.
2016-07-28 19:28:36 -04:00
aleos89
1daa6fd65b Revert of efdc748
* Going to follow up later with a better fix.
2016-07-27 18:56:37 -04:00
aleos89
efdc748a7a Corrected bResEff behavior (fixes #996)
* Removed the common SC range check.
* A few of the Eff_* values are tied to a SC that's not within the common SC range.
2016-07-27 18:15:46 -04:00
aleos89
160f24d66a Corrected MVP Tomb behavior (fixes #1429)
* On Aegis there is a 9~ second delay before the tomb is spawned.
2016-07-27 16:49:32 -04:00
aleos89
bec9845499 Updated Camouflage behavior (fixes #1438)
* Camouflage now ends when attacking plant type monsters.
* Camouflage bonus is applied to the first skill after activating Camouflage.
* Corrected movement speed bonus checks.
* Removed INF3_NOENDCAMOUFLAGE enum as it is no longer needed.
* Updated skill_db documentation.
2016-07-26 16:58:44 -04:00
Cydh Ramdh
2a1aebaf64 Cleaned up char_del_option checks
This is a squash commit for @cydh's pull request #1299.

Cleaned up the `char_del_option` checks.
Added a comment for `char_del_option`, that only work for clients that send delete request by using 0x0068 or 0x01fb.
Added an enum for values.
Added a function to validate and adjust configuration data.
Resolved character deletion not working properly for clients 2015-10-01 and higher (fixes #1189)
Delete date should be sent as remaining time on some client versions.
Adjusted some comment wording.
Added empty/default birthdate deletion.
Made email deletion case insensitive.
2016-07-26 22:35:22 +02:00
aleos89
ffec87d29a Corrected item bonus WeaponMatkRate (fixes #1446)
* Item bonus formula was checking for an incorrect MATK value.
* Moved the bonus after the WMATK and Weapon Refine calculations so it's not zeroed out at the beginning.
2016-07-25 13:27:29 -04:00
aleos89
e24f2f4f97 Corrected Earth Shaker wall checks (fixes #1447)
* Earth Shaker is no longer able to hit targets behind walls.
2016-07-25 10:56:44 -04:00
aleos89
d5edd06c6d Corrected Mercenary skills (fixes #1442)
* Adjusted Scapegoat SP requirement from 10 to 5.
* Removed 100% HP requirement of Scapegoat.
* Recuperate now removes Deadly Poison.
2016-07-25 10:49:05 -04:00
Lemongrass3110
fa8296e3c2 Merge pull request #1437 from rathena/bonus/add_drop_rate
Added script bonuses to add player's drop rate

Thanks to @cydh
2016-07-23 19:10:55 +02:00
Lemongrass3110
e7882351d8 Cleaned up player specific drop rate calculations
Removed the src check for the new bonuses.
2016-07-23 18:43:09 +02:00
Jittapan Pluemsumran
6349802d25 Enable Ranger class in bodystyle atcommand 2016-07-22 13:43:57 +07:00
Cydh Ramdh
29379c3ea5 Added script bonuses in order to support official AddReceiveItem_Equip n
* `bonus2 bDropAddRace,r,x;` : Adds x% to player's drop rate when killing a monster with race r.
* `bonus2 bDropAddClass,c,x;` : Adds x% to player's drop rate when killing a monster with race c.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-07-19 16:43:05 +07:00
aleos89
e771472042 Constant cleanup
* Adjusted some IDs to constant values.
2016-07-14 13:51:00 -04:00
aleos89
1a0fb8f821 Updated Golden Thief Bug card immunity (fixes #1400)
* White Imprison and Hell's Plant are now blocked by Golden Thief Bug card.
* Removed an extra status end of White Imprison in Status Recovery.
2016-07-07 20:13:25 -04:00
aleos89
82250c24dd Fixed Leech End damage underflow (fixes #1419)
* Resolves an underflow issue resulting in INT_MAX damage.
2016-07-07 17:19:10 -04:00
Lemongrass3110
fbf7957d21 Changed command definition of atcommand channel
Follow up to 369799a.
Sorry to @secretdataz, it was actually my fault.
Thanks to @lighta for bringing this to our attention.
2016-07-06 14:52:13 +02:00
Jittapan Pluemsumran
369799a6c5
Made atcommand channel unusable by non-players. Closed #1342.
* The command can still be used in scripts if there is a player attached to the script.
2016-07-06 16:40:43 +07:00
aleos89
b3e1c52cbb Corrected Shield Press damage delay (fixes #1165)
* Damage should have a ~1 second delay as the shield animation falls.
2016-07-04 11:47:08 -04:00
Lemongrass3110
d632f100b5 Removed duplicate check in guild creation
Merged from HerculesWS/Hercules@0b7498b thanks to @MishimaHaruna.
2016-07-03 02:11:57 +02:00
Lemongrass3110
63f719a154 Fixed emperium deletion on guild creation
Merged from HerculesWS/Hercules@71c24de thanks to @4144.
2016-07-03 02:06:49 +02:00
Lemongrass3110
4744ee0731 Fixed instance idle timeout
Fixed instances of going into idle mode when there were still users left in the instance.
Thanks to @Darkelfen for reporting it.
Fixes #1412.
2016-07-03 01:52:06 +02:00
aleos89
e5a197ad70 Corrected Cloud Kill effect (fixes #407)
* Properly implemented the Cloud Kill status icon.
* Poison duration is not reduced and lasts if the target leaves the AoE.
- Walking into the AoE a second time resets the Poison status.
2016-07-02 19:49:58 -04:00
aleos89
10d1020008 Fixed Elemental Change skills versus players (fixes #1411)
* Should not be usable on players or Status Immune monsters.
2016-07-02 19:24:24 -04:00
aleos89
9f68f7817c Corrected an issue with script command set
* Follow up to fd48238.
* Added a few checks so the optional value for script command setr doesn't conflict with the optional character ID value.
2016-07-01 17:46:59 -04:00
aleos89
fd482381f6 Script engine fixes/additions (fixes #1212)
* Follow up to c3193f3.
* Resolved some issues with += and -= operators.
* Cleaned up post ++ and -- operators.
* Implemented pre ++ and -- operators.
Thanks to Hercules!
2016-07-01 17:13:50 -04:00
Lemongrass3110
b1b43bb0df Removed hardcoded aloevera restriction
Additional changed some hardcoded ids to constants.
2016-07-01 00:33:43 +02:00
Lemongrass3110
d6d92a4b8e Small follow up to fe11416 2016-06-30 01:03:17 +02:00
aleos89
fe11416429 Streamlined renewal ASPD skill and potion calculations
* Only calculate the specific ASPD type (fixed or rate) when needed.
* Condensed some fixed ASPD bonus checks.
2016-06-29 13:23:54 -04:00
aleos89
06eab75006 Cleaned up Impressive Riff ASPD formula
* Renewal - No longer has to be /10 each time.
* Pre-renewal - Calculated separately from renewal formula.
2016-06-29 10:14:59 -04:00
aleos89
b99114c0ce Corrected Swing Dance ASPD bonus
* Wrong status change value was being applied.
2016-06-28 14:00:06 -04:00
aleos89
cccb740817 Adjusted atcommand showexp display (fixes #1401)
* Follow up to d2bbd91.
* When no base or job EXP is given the message won't display.
2016-06-28 09:27:25 -04:00
aleos89
c2035f0477 Follow up to 82af619
* Resolved a compile error.
2016-06-27 14:33:22 -04:00
aleos89
82af619dfd Refactored clif damage type calls
* Cleaned up the calls for e_damage_type to use the constant value.
2016-06-27 12:48:26 -04:00
aleos89
562a1a7b61 Removed some leftover variables
* Follow up to 65b716f.
2016-06-24 13:06:55 -04:00
Jittapan Pluemsumran
26aa69d6ef
ECL_SQUOIA now removes SC_DECREASEAGI 2016-06-24 20:16:49 +07:00
Lemongrass3110
f03174123e Fixed full throttle status icon
It now displays the time correctly.
Fixes #1384 thanks to @julia40124009
2016-06-23 15:55:28 +02:00
Jittapan Pluemsumran
b95df50cd1
Follow up to 6412c82
Correct typo in the code
2016-06-23 17:14:02 +07:00
Cydh Ramdh
6412c82d59 Follow up d2bbd913ec886b1f4466f8d7651aba88f0de2b93
* Clean up `party_exp_share` for Renewal.
* Updated `party_exp_share` source doc.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-06-23 10:42:59 +07:00
Cydh Ramdh
d2bbd913ec Fixed #1383: 0 EXP oddity for 'even share' party EXP
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-06-23 08:48:21 +07:00
Lemongrass3110
2534588af6 Added const support to mob race2 db 2016-06-23 01:16:27 +02:00
Lemongrass3110
65b716f586 Removed some hardcoded mob ids
Created some race2 values for mobs used in the Manuk and Splendide status changes
2016-06-23 00:41:21 +02:00
Lemongrass3110
9558ef0868 Moved mob random groups constants
Added/Moved the two missing groups into src.
All of them are exported now directly through script_constants.h
2016-06-22 21:04:53 +02:00
Jittapan Pluemsumran
c658ea23d4
Follow up to 33270ed.
Change type of running_npc_stat_calc_event variable to bool.
2016-06-22 17:54:40 +07:00