Commit Graph

9399 Commits

Author SHA1 Message Date
Aleos
60d03a1978 Fixes Rolling Cutter counter not resetting (#5082)
* Fixes #5052.
* Fixes Rolling Cutter counter not resetting with blown-type attacks/movements.
Thanks to @LordWhiplash!
2020-06-15 08:42:18 -04:00
Lemongrass3110
d929a87d9d Small signedness cleanup 2020-06-15 13:44:13 +02:00
Lemongrass3110
60a2f2fc14 Fixed sending of storages full of equip (#5102)
Fixes #5084

Thanks to @laziem, @Hope8888 and @qwerty7vp
2020-06-15 13:40:09 +02:00
Aleos
5647c875d6 Adds support for sharing battle-type Achievements (#5021)
* Fixes #5018.
* Adds support for sharing battle-type Achievements when killing monsters.
* The behavior mimics Quest objectives.
* Adds a battle_config to easily toggle (off by default until confirmed on kRO).
Thanks to @MccloudBR's suggestion!
2020-06-12 13:02:50 -04:00
Aleos
c875ebd5e2 Fixes Rune Mastery visual effects (#5027)
* Fixes #5023.
* Fixes Rune Mastery displaying a success effect under the failure effect when a Rune fails to be produced.
Thanks to @Masao87!
2020-06-12 10:53:14 -04:00
Aleos
e4e593fbbe Fixes Ensemble skills behavior (#5014)
* Fixes #4987.
* Ensemble skills apply SC_ENSEMBLEFATIGUE which should disable skill casting and reduces movement speed/ASPD by 30%.
* Applies SC_ENSEMBLEFATIGUE to both the caster and partner.
Thanks to @LordWhiplash!
2020-06-12 10:11:57 -04:00
Aleos
2b0d13b231 Cleans up Genetic creation skills (#4957)
* Fixes #4930.
* Fixes Mix Cooking quantity calculation to be based off the difference of the good and bad stat.
* Fixes Mix Cooking failure to create a random amount of failure material that's independent of the initial quantity calculation.
* Fixes Create Bomb to behave similar to Mix Cooking without the failure materials.
* Fixes Special Pharmacy quantity calculation to be based off of the difference of the good and bad stat along with a base quantity depending on the level used.
Thanks to @mrjnumber1 and @SeravySensei!
2020-06-12 08:31:04 -04:00
Aleos
6ce5ba10b4 Corrects Hell's Plant behavior (#4966)
* Skill is no longer a unit skill but a status.
* Adjusts the attack rate timer to official.
* Skill does not proc cards.
* Skill does not reflect damage.
Thanks to @Tokeiburu, @ecdarreola, and @attackjom!
2020-06-12 08:11:25 -04:00
Sader Fawall
f481cc9c46 Fixed crash on deleting soul balls (#5077)
Fixes #5076
2020-06-10 23:31:53 +02:00
flamefury
39fb658810 Fixes Acolyte/Priest self-AoE skill ranges (#5056)
* Animations for Angelus, Impositio Manus, Suffragium, Magnificat, and Gloria no longer play for party members who are within skill range but outside of visible viewing range.
* Fixes AoE size of Magnificat and Impositio Manus.
* Fixes SP consumption of Impositio Manus.
* Fixes the splash range for Angelus and Gloria.
Thanks to @flamefury!
2020-06-10 08:51:57 -04:00
Lemongrass3110
db1277e76b Fixed some invalid packet version checks (#5072)
Fixes #5069

Thanks to @sader1992
2020-06-09 22:41:54 +02:00
Daegaladh
02e15335dd Cleaned up chlogif_parse functions (#5070)
*Thanks to @aleos89
2020-06-09 22:21:00 +02:00
Lemongrass3110
79feae3629 Fixed a problem with kafra points in the cashshop
Fixes #5057

Thanks to @mazvi and @Stingor
2020-06-09 16:24:46 +02:00
rAthenaAPI
152b4bd6a3 Mob and NPC Identity Update 2020-06-09 06:00:30 +02:00
Atemo
ee111cdef2 Costume exchange NPC in malangdo (#4839)
* Initial implementation of the costume exchange NPC in malangdo
* Initial implementation of the costume enchant npc 'Aver De Dosh'
* Initial implementation of the costume enchant npc 'Lace La Zard'
* Added the groups box IG_Enchant_Stone_Box (number 5 to 15)
* Updated the aegis item name of the costumes
* Corrected the equipment location of some costumes

Thanks to @RagnaWay, @peney7 and @teededung for the review !
2020-06-08 22:03:48 +02:00
Aleos
35c3301dda Clean up Summoner Power skill checks (#4999)
* Centralized the Summoner Power skill tree checks into one function.
* Fixes a couple passive skill bonuses not being recalculated when reaching 20 investment points.
Thanks to @exneval and @Balferian!
2020-06-06 22:42:30 -04:00
Aleos
4d962d6f87 Fixes Bard and Dancer Soul Link bonus (#5055)
* Fixes #4801.
* Fixes Bard and Dancer not gaining the opposite class's skills.
* Cleans up check to not be reliant on sketchy index checks.
Thanks to @ihernandeza, @gidzdlcrz, and @Lemongrass3110!
2020-06-06 21:52:59 -04:00
Lemongrass3110
8efd61f9b2 Deprecates support for old compilers (#5051)
Fixes #4646

Switches AppVeyor build worker image to Visual Studio 2015.
Fixed a bug with serv.bat, since crashes would result in a negative number sometimes, the crash would not be detected and would not be reported.

Thanks to @aleos89
2020-06-05 20:04:02 +02:00
Yashim Wong
444ad785be Fixed QD Shot Not Triggerring When ASPD is 193 (#5048) 2020-06-05 14:45:53 +02:00
Lemongrass3110
d87ac21986 Added support for skill scale display (#5041)
Fixes #4530

Thanks to @Balferian
2020-06-04 19:53:19 +02:00
Lemongrass3110
3ab1ada8d9 Removed account gender (#5006)
Adds an upgrade script to change all existing entries to the respective gender in their account.
Cleanup of a few strange design decisions in the character server code.
Removed SEX_ACCOUNT.

Thanks to @Daegaladh for his help.
2020-06-04 17:23:50 +02:00
Lemongrass3110
afaee2f01d Fixed some compiler warnings
Follow up to 45cd580

Thanks to @aleos89
2020-06-03 23:28:50 +02:00
Lemongrass3110
e2185b8c7d Fixed an issue with storages
Thanks to @Daegaladh
2020-06-03 23:10:59 +02:00
Daegaladh
b758a60bee Fixed death counter not being properly reseted with Super Novice link
*Follow up to 929c30c414
2020-06-03 17:12:05 +02:00
Lemongrass3110
45cd5808b7 Initial support for newer packet versions (#4944)
Basic support for packets up to April 2020
Changing the default packet version to 2020-04-01

Thanks to everyone involved!
2020-06-03 16:35:10 +02:00
Daegaladh
929c30c414 Fixed death counter not updating properly
Also fixes Super Novice bonus not being removed on death and a possible crash
*Thanks to @aleos89
2020-06-03 04:46:33 +02:00
Lemongrass3110
47ebf332ab Follow up to b10caa0 2020-06-02 23:58:57 +02:00
Lemongrass3110
b394b93100 Fixed instance YAML conversion handling 2020-06-02 20:12:02 +02:00
Lemongrass3110
b10caa039b Fixed slave recalculation on reloadmobdb
Slaves sometimes ended up with weird status calculations or insane speed, because their status got recalculated before their master and this way their speed could not be copied from the master.

Thanks to @Daegaladh
2020-06-02 19:37:33 +02:00
SeravySensei
cd0937c468 Fix missing pet egg checks (#5029)
Fixes #5024
2020-05-31 16:11:01 +02:00
Aleos
4f68d0c144 Fixes Mercenary kill counter (#5010)
* Fixes #4329.
* The master or the Mercenary are able to increase the kill count.
Thanks to @Indigo000!
2020-05-28 13:22:31 -04:00
Aleos
023dcac49f Adjusts Reverberation behavior (#5013)
* Reverberation no longer uses any sub-attack skill.
* Adjusts hit count to be split on each hit.
Thanks to @attackjom!
2020-05-28 11:37:31 -04:00
Atemo
7efd696af7 Added several check for OnTouch and OnTouch_ before running the event (#5009)
* Check if the player is still in npc range
* Check if the player is still able to interact with the npc
* Check if the npc is cloaked
2020-05-27 15:52:37 +02:00
Aleos
0e42b738c5 Fixes looter mobs getting stuck (#5000)
* Follow up to b6b6b13.
* Fixes #4941.
* Fixes cases of monsters getting stuck when they lose sight of their target item that is looted by another monster.
Thanks to @iraciz and @SeravySensei!
2020-05-26 10:30:59 -04:00
Aleos
7cc59c6708 Adjusts a few checks for item tradability (#4995)
* Follow up to bfb6972.
* Adds a new return array for script command inventorylist: `@inventorylist_tradable`
* Adjusts script command countitem to not count rental items.
2020-05-25 20:28:11 -04:00
Aleos
14c388b401 Resolves some Battleground issues (#4725)
* Queue data will now be kept available until a Battleground event is over.
* Players can now join an active Battleground.
* Adds a more detailed queue state tracking feature.
* When a battleground is being prepared and not enough players click accept, stop the battleground from beginning.
* When a player logs off or leaves a queue they will now properly be removed from the queue.
* Cleans up MinPlayers and MaxPlayers parsing to not accept values less than 1.
* Resolves players not being able to join an active battleground (up to MaxPlayers) unless someone quit early.
* Adds a team size priority check to avoid adding more players to a larger team.
* Fixes battlechat messages.
* Adds a battle_config to disable the ability for players on maps with MF_NOWARP to join Battlegrounds.
* Adds a new optional ActiveEvent label to the database.
* Fixes a typo in Flavius 2 during unbooking process.
* Cleans up the behavior of the Battle Therapists to use areapercentheal and areawarp.
* Fixes KVM score not properly set on the first Battleground.
* Fixes the global timer checks not ending the main timers on Flavius and Tierra Gorge.
* Added an extra bg_reserve on global timer checks in case someone tries to join the battleground just before it's ended.
* Fixed OnReadyCheck being called on global timer checks, causing the battlegrounds to start when there were no players on the map.
* Fixed a bug on Tierra Gorge where multiple barricade walls could be stacked.
* Fixes Croix also receiving 9 badges when Guillaume wins.
* Adjusts StartDelay default to 0.
* Add a database setting to give the ability to enable or disable joining as an individual, party, or guild.
* Add a database setting to restrict jobs from entering Battlegrounds.
* Better documents script commands bg_reserve and bg_unbook.
* Other fixes and cleanups.
Thanks to @roSBK and @Daegaladh, @admkakaroto, @Artuvazro, and @Atemo!
Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2020-05-25 12:39:36 -04:00
rAthenaAPI
e6bffc11fe Effect State Update 2020-05-24 14:05:26 +02:00
aleos
81a2b8c995 Fixes NPC_DARKBREATH attack type
* Follow up to 70d6876.
* Fixes #4997.
* The attack type for NPC_DARKBREATH will now properly read the database value.
Thanks to @qwerty7vp!
2020-05-22 09:19:41 -04:00
LordWhiplash
46aa15a182 Summoner corrections (#4993)
* Fixes SU_POWEROFSEA max HP and max SP bonus when investing more than 20 skill points.
* Fixes SU_SPIRITOFLAND and SU_CN_POWDERING combo's perfect dodge bonus.
Thanks to @LordWhiplash, @qwerty7vp, and @Balferian!
2020-05-21 22:24:29 -04:00
Atemo
b8ee97b6a1 Added rental_item_novalue config (#3749)
* Added a config to always sell the rental items to NPC for 0

Thanks to @Lemongrass3110, @cydh, @aleos89, @Daegaladh for the review !
2020-05-21 21:13:45 +02:00
LordWhiplash
43caf7cc0a SU_HISS Perfect dodge fix (#4991)
* Fixes #4990.
* Adds missing x10 rate for perfect dodge calculations.
Thanks to @Balferian and @LordWhiplash!
2020-05-21 09:02:23 -04:00
Aleos
0fba10c324 Fixes a potential crash with atcommand time (#4989)
* Fixes #4960.
* Adds a timer data validation check for atcommand time.
Thanks to @marky291!
2020-05-20 21:21:31 -04:00
Aleos
70d6876494 Corrects NPC_DARKBREATH behavior (#4982)
* Fixes #4864.
* Adjusts damage formula to official.
* Adjusts damage type from Misc to Magic.
* Skill now has a 50% success chance to damage the target.
* Removes Flee and Defense Card ignore flags.
Thanks to @Masao87 and @mrjnumber1!
2020-05-20 18:50:04 -04:00
Aleos
20945d71db Removes nullpo checks from CSV2YAML (#4979)
* Fixes #4791.
* Removes two nullpo checks from CSV2YAML.
* Fixes undefined reference compile errors.
Thanks to @ecdarreola!
2020-05-20 18:09:44 -04:00
Aleos
a34a2f6de0 Fixes Blood Sucker not being able to be recast (#4968)
* Fixes #4964.
* Fixes Blood Sucker not being able to be recast on another map if caster dies while active.
* Minor cleanups and added safety checks.
Thanks to @Everade!
2020-05-20 17:20:37 -04:00
Aleos
ab628b2369 Remove Summoner Hide when changing maps (#4958)
* Fixes #4953.
* Remove Summoner Hide when changing maps to avoid equipment from being stripped due to the inability to change equipment while the status is active.
Thanks to @Everade!
2020-05-20 16:54:42 -04:00
LordWhiplash
746c1bdfa9 Fixes MO_EXTREMITYFIST (#4886) 2020-05-20 22:18:31 +02:00
CairoLee
bf4b41bd66 Fixes a crash caused by invalid skill ID (#4935)
* Fixes #4934.
* Fixes a potential crash when using atcommand useskill.
Thanks to @Stingor and @CairoLee!
2020-05-20 09:22:53 -04:00
Aleos
5d4fd1d3b7 Resolves Autospell displaying errors to console (#4921)
* Fixes #4883
* Fixes Autospell displaying invalid skill errors when clicking Ok or Cancel.
Thanks to @admkakaroto!
2020-05-19 17:19:34 -04:00
Aleos
18b642c174 Skill Database cleanups (#4902)
* When reloading the skill_db clear out Abra, Magic Mushroom, and Reading Spell Book databases as well.
* Fixes NC_SHAPESHIFT and NC_REPAIR checking an invalid ItemCost slot based on the old implementation.
* Updated a lot of references to the old skill databases.
2020-05-19 15:32:57 -04:00