8070 Commits

Author SHA1 Message Date
Cydh Ramdh
739a8f5831 Fixed #176 Stealth Field effect
* Should drains 3% caster's SP each 3 seconds
* Speed penalty for not the caster

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-16 20:53:30 +07:00
Cydh Ramdh
17ffda6235 Fixed 'wrong' mapname in party info window when member is in instance.
... I think I saw the report somewhere ...

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-16 00:02:41 +07:00
Lighta
d92a8df4c2 Remove some duplicate code 2015-03-15 05:52:53 -04:00
Lighta
d1eeda3466 Fix 'make tools' target for ./configure
Fix update.pl wasn't able to recompile due to path error.
2015-03-15 04:24:58 -04:00
aleos89
bae469e6c6 Follow up to 9d247d8
* Disable Packet Obfuscation if it's enabled and client version is below 2011-08-17.
2015-03-14 14:31:04 -04:00
aleos89
5a9ffc489f Follow up to 9f6f55c.
* Fixed Dragon Breath skill type checks.
* Adjusted Camouflage to account for ground-based skills.
- Thanks to @reigneil.
2015-03-14 12:38:14 -04:00
Aleos
9d247d88c1 Merge pull request #312 from rathena/feature/official_packet_obfuscation
Added Packet Obfuscation support
* More info: https://rathena.org/board/topic/101092-packet-obfuscation-support/
2015-03-14 12:25:27 -04:00
aleos89
1b69b981fa More cleanups
- Enabled Packet Obfuscation by default.
- Added a bit of documentation.
2015-03-14 11:45:42 -04:00
Cydh Ramdh
3b197eb76c Added optional param <char_id> for some script commands:
* getexp <base xp>,<job xp>{,<char_id>};
* equip <item id>{,<char_id>};
* unequip <equipment slot>{,<char_id>};
* delequip <equipment slot>{,<char_id>};
* breakequip <equipment slot>{,<char_id>};
* clearitem {,<char_id>};
* openmail {<char_id>};
* openauction {<char_id>};
* setquest <ID>{,<char_id>};
* completequest <ID>{,<char_id>};
* erasequest <ID>{,<char_id>};
* changequest <ID>,<ID2>{,<char_id>};
* checkquest(<ID>{,PLAYTIME|HUNTING{,<char_id>}})
* isbegin_quest(<ID>{,<char_id>})
* showevent <icon>{,<mark color>{,<char_id>}}
* setd "<variable name>",<value>{,<char_id>};

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-14 19:19:53 +07:00
Cydh Ramdh
5f21afb255 Added script command optional param for account/char id
* `set`, added char id -> set <var>,<value>{,<charid>}
* `rentitem`, added account id -> rentitem <item id>,<time>{,<account_id>};
* `rentitem2`, added account id -> rentitem2 <item id>,<time>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>{,<account_id>};
* `strcharinfo`, added char id -> strcharinfo <type>{,<char_id>};
* `getequipisequiped`, added char id -> getequipisequiped <equipment slot>{,<char_id>};
* `repair`, added char id -> repair <broken item number>{,<char_id>};
* `repairall`, added char id -> repair {<char_id>};

Added macros
* Macro to replace a check "if there's additional param for account/char id then get the value or use attached rid"
* script_accid2sd(<param_location_for_account_id>,sd,<fail action>)
* script_charid2sd(<param_location_for_char_id>,sd,<fail action>)
* script_nick2sd(<param_location_for_char_id>,sd,<fail action>)

TODO:
* Add optional param for CharID/AccountID/Nick for other necessary commands

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-14 18:52:18 +07:00
Playtester
16d747af48 - Fixed trap HP and knock back (fixes #338)
* Talkie Box and all ranger traps no longer can be destroyed by HP damage
* Electric Shock can now be knocked back
2015-03-14 11:50:59 +01:00
aleos89
9f6f55c07c Bug Fixes
* Fixed #167 - Dragon Breath burning chance is now 15% for all levels. Also corrected damage calculation. Thanks to @exneval.
* Fixed #270 - Cleaned up Reverberation and how it's triggered.
* Fixed #321 - Follow up to 1b6be4e. Fixed MATK calculation for for all player, monster, homunculus, mercenary, etc.
* Fixed #332 - Camouflage now hides player from targeting skills. Added missing DEF/DEF2 bonus.
* Fixed #335 - Check to make sure script has data before trying to free null values.
* Fixed Full Throttle SP drain amount and movement speed increase value. Updated cooldown value to 30 minutes.
* Fixed Bloody Lust skill type from magic to none.
* Fixed Mix Cooking, Make Bomb, Special Pharmacy, Change Material, and Rune Mastery success and fail animations.
* Cleaned up some more compile warnings.
2015-03-13 17:49:38 -04:00
aleos89
1b6be4e0df Bug Fixes
* Fixed #145 - Corrected the duration of Frigg's Song ending too quickly.
* Fixed #202 - Added damage bonus for Rifle when using Piercing Shot (renewal).
* Fixed #257 - Adjusted get_status() in athena-start to return the correct string.
* Fixed #272 - Blood Lust not leeching HP from target.
* Fixed #298 - Corrected the renewal calculation of ATK and ASPD for Homunculus.
* Fixed #309 and #313 - Cleaned up warnings during compile.
* Fixed #321 - Monsters not calculating MATK at spawn (renewal).
* Added missing renewal calculations for Mercenary.
2015-03-11 10:10:05 -04:00
Playtester
ad8e22139f Kaahi and Arrow Shower RE fixes
- Removed Kaahi timer system (fixes #320)
* Kaahi will now heal BEFORE the damage is dealt
* Heals will no longer get lost due to timer system
* Decreased Kaahi duration 1800->350 seconds
- Implemented recent Arrow Shower Renewal updates (fixes #310)
* Arrow Shower now has 3x3 AoE on level 1~5 and 5x5 AoE on level 6~10
* Arrow Shower now has a fixed after cast delay of 500ms
* Note: The bug that causes the skill to hit twice is still present (couldn't fix it)
2015-03-07 19:27:49 +01:00
aleos89
1be5665580 Small cleanup
- Fixed some compile warnings when Packet Obfuscation is disabled.
2015-03-06 09:48:08 -05:00
aleos89
86f1cebee8 Merge branch 'master' of https://github.com/rathena/rathena into feature/official_packet_obfuscation 2015-03-06 09:41:41 -05:00
Cydh Ramdh
6472425c10 Something left behind...
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-05 00:14:30 +07:00
Cydh Ramdh
73bfa215e5 Fixed #317
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-04 23:49:56 +07:00
Cydh Ramdh
5c24534b51 Expanded msg len for e_msg in pc_useitem to CHAT_SIZE_MAX
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-04 23:12:48 +07:00
Cydh Ramdh
f05119b36c Packet Obfuscation support
* Enable it by uncomment `#define PACKET_OBFUSCATION` in mmo.h
* Obfuscation keys are defined in db/packet_db.txt, each packet_ver has their own default keys (for temperory lookup) in `packet_keys:` right after `packet_ver:`
* Keys can be refined (user-defined keys) by defining the keys in `packet_keys_use:` in file db/[import/]packet_db.txt
* This feature only for client 20110817 or newer
* `@reloadpacketdb` won't changes the keys, so make sure define everything before run the map-server.

Thank to @icxbb-xx, @aleos, 5a942993dd

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-03-01 15:16:56 +07:00
Playtester
d4aa4c70a7 Walkpath loop fix (fixes #198)
- Move requests one cell west will now be ignored if the target cell is occupied
- You can now set official_cell_stack_limit to 0 to completely disable it including the limitation above
2015-02-28 15:41:18 +01:00
Cydh Ramdh
7d42cf2ba4 Follow up fa75733cc109f926b1df4156ccdf1292c78f8f79
* `getiteminfo` fix after `elvmax` added

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-28 13:05:06 +07:00
Aleos
d8ecfeb48b Merge pull request #307 from rathena/hotfix/issue296
Fixes #296
- Warg Strike can now trigger by Fist, Dagger, and Bow (no restrictions).
2015-02-27 10:59:01 -05:00
Cydh Ramdh
72a831aa2f Added "clear" for item group
* It is: <IG>,clear,0,0

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-27 11:29:41 +07:00
Cydh Ramdh
63b85277f5 Follow up 881bdb08714b257b5789da80c0f6017a9185ee62
* Added IG_Old_Ore_Box to db/const.txt with value 422

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-27 03:32:37 +07:00
Cydh Ramdh
714e670327 Follow up 20695d629a59310a9e6a04c2234bbf4870609d90
* Fixed #304
* Fixed #308

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-27 02:49:19 +07:00
aleos89
cec6ed110f Fixes #296
Warg Strike can now trigger by Fist, Dagger, and Bow (no restrictions).
2015-02-24 21:32:01 -05:00
aleos89
04359e04ec Fixes #301
Fixed status_percent_heal() not healing based on Max HP/SP.
2015-02-23 15:42:06 -05:00
Lemongrass3110
0e015ac370 Merge pull request #299 from RagnarokNova/patch-5
Fixed up Sorcerer's Elemental Sympathy

Thanks to @RagnarokNova
2015-02-21 22:10:02 +01:00
aleos89
d3625e5c10 Cleaned up merge issues. 2015-02-21 15:43:58 -05:00
Nova
537fb42a4b Fixed up Sorcerer's Elemental Sympathy
Without this, having level 1 ES would set your Elemental Summon to only have 5% of their original health, instead of adding 5% to the max HP.
2015-02-20 17:00:57 -08:00
Cydh Ramdh
c92915b6cd DEFAULT_MAP clean up
* Moved hardcoded `DEFAULT_MAP`, `DEFAULT_MAP_X`, and `DEFAULT_MAP_Y` definition to conf/char_athena.conf: `default_map`, `default_map_x`, and `default_map_y` for `DEFAULT_MAP`
* Default map existance check only will be checked once, after map_index finished load by char-server, previously map-server also do a check that maybe cause unnecessary debug message
* `instance_start` value should be init'd with `map_num` not by `map_num + 1`. I was causing send extra 1 empty map to char-server.
* A little clean up in `chmapif_parse_getmapname()` and `doc/packet_interserv.txt`

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-19 15:02:14 +07:00
Cydh Ramdh
2ae4bcb694 Implemented 'NeedLevel' for Homunculus skill tree
* Changed 'JobLevel' to 'NeedLevel' and don't make it as optional.
* Make sure homun_skill_tree.txt column number is 15!

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-16 00:38:09 +07:00
Cydh Ramdh
36be5aa5b9 Homunculus intimacy check
* Moved out intimacy required to evo the homun to conf/battle/homunc.conf: 'homunculus_evo_intimacy_need'
* Moved out intimacy reset after evo the homun to conf/battle/homunc.conf: 'homunculus_evo_intimacy_reset'
* Follow up eca4fa0e38c060c0f9918d11899ee00d099a16f7, missed the '/100' for intimacy info.
* Corrected intimacy set after using skill 'HVAN_EXPLOSION' to 1 (100, Hate with passion) instead of 2 (200, is for HFLI_SBR44)
* Init 'hardcoded' homunculus intimacy grade tables for some lookups

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-16 00:32:41 +07:00
Cydh Ramdh
3c202388e5 Bug fixes:
* Fixed wrong check while reading homun_skill_tree.txt, causing homunculus skill tree doesn't follow prerequisite skills.
* Follow up 083cf5d9626b7aafd9856f406d3f9d2a98e19cbe, homunculus def & mdef aren't resetted on calculation.
* Reduce max Homunculus skill tree to 8 (previously using MAX_SKILL_TREE fro player, 84)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-15 16:07:58 +07:00
Cydh Ramdh
ddfe1683a5 Skill ID in array leftover~
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-15 13:34:11 +07:00
Cydh Ramdh
f1d7cc5777 Homunculus skill tree fix.
~ Thank Philippe Girard

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-15 10:18:37 +07:00
Cydh Ramdh
d5b271b926 Merge pull request #289 from rathena/feature/bonus_HPSP_VanishRace
Bonus HP/SP Vanish updates:
* Added 'bonus3 bHPVanishRaceRate,r,n,x' (2074) and 'bonus3 bSPVanishRaceRate,r,n,x' (2075)
* Corrected documentation about 'bHPVanishRate' and 'bSPVanishRate', rate should be n/100%, 10000 for 100%
* 'bHPVanishRate' and 'bSPVanishRate' applied regardless the target's Race and map (before, if target is player bHPVanishRate only works in PVP/GVG maps)
* Changed Velum item scripts:
  * (1294) Velum_Scare to 'bonus3 bSPVanishRaceRate,RC_Player,10000,10;'
  * (1395) Velum_Buster to 'bonus3 bSPVanishRaceRate,RC_Player,10000,10;'
  * (18113) Velum_Arbalest to 'bonus3 bSPVanishRaceRate,RC_Player,10000,4;'
  * (21002) Velum_Katzbalger to 'bonus3 bHPVanishRaceRate,RC_Player,10000,8;'
2015-02-13 16:45:23 +07:00
Cydh Ramdh
bf6d2f0197 Merge pull request #263 from rathena/cleanup/bonus_script
Bonus Script clean up
* Removed fixed array size (MAX_PC_BONUS_SCRIPT) of bonus_script on players, changed to link list.
* Changed fixed script string on player's bonus_script to StringBuf, reduce memory usage for each connected player.
* Added new flags to expand duplicated script and flag to allow duplicate script.
* Reduced buf length from 1024 to 512 on bonus_script_data (used for saving/loading bonus_script from char-server). Still, MAX_PC_BONUS_SCRIPT is used to gives limit data can be loaded.
* Merged 'pc_bonus_script_clear_all' to 'pc_bonus_script_clear'
* Now bonus script will be saved on auto-save timer or other save request, prevent losing the bonus when "something" happen. But, saving when player is quitting will removes the bonus that won't be saved on logout.
* Fixed Superstar_Snack (22843) and Sealed_Dracula_Card (22846) fields

NOTE:
Please import 'upgrade_20150131.sql' for `bonus_script` table changes

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-13 16:37:28 +07:00
Cydh Ramdh
4726f4c968 Fixed warning from unused variables
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-13 16:28:55 +07:00
Cydh Ramdh
ebc009e252 Wrong documentation 4cf7acc65203acef252d6f299ab01e14acf2f007 :P
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-13 16:12:07 +07:00
Cydh Ramdh
4cf7acc652 A follow up of 2ef7a7daa8f7fdc74cf4e9b3815c1345c777a06d
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-13 15:19:29 +07:00
Cydh Ramdh
2ef7a7daa8 Bonus HP/SP Vanish updates:
* Added 'bonus3 bHPVanishRaceRate,r,n,x' (2074) and 'bonus3 bSPVanishRaceRate,r,n,x' (2075)
* Corrected documentation about 'bHPVanishRate' and 'bSPVanishRate', rate should be n/100%, 10000 for 100%
* 'bHPVanishRate' and 'bSPVanishRate' applied regardless the target's Race and map (before, if target is player bHPVanishRate only works in PVP/GVG maps)
* Changed Velum item scripts:
  * (1294) Velum_Scare to 'bonus3 bSPVanishRaceRate,RC_Player,10000,10;'
  * (1395) Velum_Buster to 'bonus3 bSPVanishRaceRate,RC_Player,10000,10;'
  * (18113) Velum_Arbalest to 'bonus3 bSPVanishRaceRate,RC_Player,10000,4;'
  * (21002) Velum_Katzbalger to 'bonus3 bHPVanishRaceRate,RC_Player,10000,8;'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-13 01:39:17 +07:00
Cydh Ramdh
9d3d34205f Skill DB clean ups
* Changed skill_db array to better memory allocation.
* Reduced MAX_SKILL_LEVEL from 100 to 10 (part of Hercules 0f4a50d135), also has changes on skill_get checks for skill level that more than 10.
* Reduced MAX_SKILL from 5020 to 1200 (actually only 1109 skills are used).
* Added macros for checking Homunculus, Guild, Mercenary, & Elemental skill ranges.
* Added skill check & index validation when player logged in and when @reloadskilldb.
* Corrected `enum e_skill_flag` order for SKILL_FLAG_REPLACED_LV_0's sake.
* Merged 'addtoskill' script command just as alias of 'skill' script command.
* Fixed #277
* Changed 'skill' script command flag to constant value

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>

NOTE:
* Decreased memory usage by map-server reduced up to 50 MB.
* Decreased memory for each player because of mmo_charstatus::skill[] only has 1200 array, before is 5020.
* Please use skill_get_index() for accessing sd->status.skill[] or skill_db[], don't reckless use skill_id as array index.
* Please import upgrade_20150211_skillset.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-12 15:50:50 +07:00
Cydh Ramdh
892e961823 * Fixed Superstar_Snack (22843) and Sealed_Dracula_Card (22846) fields
* Removed debug leftover

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-12 14:57:59 +07:00
Lemongrass3110
12a0b0533b Follow up to 083cf5d
Fixed a compilate error when renewal aspd calculation was disabled.
Fixes #284
2015-02-11 23:58:28 +01:00
aleos89
831dcc2608 Follow up to 083cf5d
- Fixed MATK calculation for pre-renewal.
- Resolved compile warnings.
2015-02-11 09:56:44 -05:00
Lemongrass3110
d98c0dd4e3 Fixed duplicate pickup animation for thief's pick stone
Fixes #276
2015-02-10 23:17:21 +01:00
aleos89
769a27287f Follow up to 083cf5d
- Fixed compile warnings.
2015-02-10 14:58:17 -05:00
aleos89
083cf5d962 Bug Fixes
* Fixed Severe Rainstorm not being able to be copied by Reproduce. (bugreport:9361)
* Fixed #137 - Updated Homunculus S Race and Element values to official.
* Fixed #163 - Proper renewal calculations for Homunculus. Merge from HerculesWS/Hercules@8faef4f
* Fixed #254 - Corrected King's Grace cooldown to be 60 seconds.
* +20 Foods cannot be dispelled or removed by death.
2015-02-10 12:13:08 -05:00