8478 Commits

Author SHA1 Message Date
Kakaroto
87b858199b Pet Fix Client after 20180704 (#4202)
A minor fix that corrects a problem when hatching eggs from pets to clients after 20180704.

Fixes #4190 

Thanks @4144 and @Asheraf
2019-07-07 20:13:24 +02:00
Aleos
32525bad55
Corrected autospell stacking (#4227)
* Resolves an issue with autospell bonuses stacking too generously.
Thanks to @Playtester!
2019-07-03 10:15:26 -04:00
rAthenaAPI
b49bc103fe Effect State Update 2019-07-03 05:06:20 +02:00
Atemo
912d97e460
Fixed a clone issue (#4226)
* Fixed a potential crash when using a clone
* Fixed #4225

Thanks to @laziem and @aleos89 !
2019-07-01 22:15:01 +02:00
Atemo
5fae7c26c1
convertpcinfo script command (#3924)
Implemented convertpcinfo script command
* The command allows to convert more easily a player data to another.
* It fails silently if the character is not found/online.

Thanks to @aleos89, @Normynator, @cydh !
2019-07-01 21:06:55 +02:00
Atemo
c1975d7ea3
instance_live_info command (#3099)
Implemented instance_live_info script command to retrieve some data of running instances

Thanks to @Jeybla, @cydh, @Lemongrass3110 and @aleos89 for the review !
2019-06-25 21:48:44 +02:00
Joam
aae31a19a5 Update Itemdb (JRO item) (#4161)
* The items implementation is based on JRO description instead of IRO description
* Yinyang combo items will be implemented later when more infos will be available
2019-06-25 20:03:33 +02:00
flamefury
19835b638b Sense - show 0 for negatives (#4213)
* Fixes #4212.
* Sense's negative informational stats will now be capped to 0.
Thanks to @flamefury!
2019-06-24 13:41:37 -04:00
Aleos
a548f20c94
Corrected PK Mapflag assignment (#4165)
* Fixes an issue with different player versus player mapflags not being checked before applying the PK mapflag.
Thanks to @LiamKarlMitchell!
2019-06-04 09:34:30 -04:00
Atemo
f8ea43ebc7
getmapflag MF_RESTRICTED (#4193)
* Corrected the value returned by getmapflag script command for MF_RESTRICTED
2019-06-03 20:45:19 +02:00
Aleos
052a4fd1e4
Corrected Weapon Forging inventory search (#4192)
* Fixes an issue with Weapon Forging not checking for index 0.
Thanks to @Tokeiburu!
2019-06-03 11:49:08 -04:00
Aleos
754274bc58
Corrected Enchant Arms for older clients (#4196)
* Fixes Enchant Arms displaying an incorrect status icon for clients older than 2015-11-04.
Thanks to @Daegaladh and @Lemongrass3110!
2019-06-03 10:32:12 -04:00
Aleos
8cfee2c872
Corrected a potential crash from equip switch (#4198)
* Resolves a potential crash with the equip switch feature and invalid items.
Thanks to Melvo and @functor-x!
2019-06-03 09:04:25 -04:00
norm
8ed3d0583a Fixes problem with PR #4148. (#4176)
* Fixes the disappearing item mentioned in PR #4148.
* Should now mirror kRO behavior when cart is full.
Thanks to @Normynator!
2019-05-31 13:30:54 -04:00
Sader Fawall
a3fc44ef8a viewpoint command update (#4143)
* Added the optional parameter 'char ID' to the command
2019-05-23 20:11:45 +02:00
Sader Fawall
ddb7d90396 Fix getareaunits coordinates (#4155)
Co-Authored-By: AnnieRuru <annieruru@users.noreply.github.com>
2019-05-20 16:36:16 +02:00
Jittapan Pluemsumran
7ad1b32d7d Additional fixes for cart exploit (#4148)
* Fixes #4146.
* Reverted some of 7f772c3 as this falls into a larger refactor scope.
* Resolved an issue where items could not be picked up from the cart when the overweight message was sent to the player.
* Added missing e_additem_result constants.
Thanks to @secretdataz, @Normynator, and @cydh!
2019-05-14 14:19:26 -04:00
Aleos
69843289c9
Fixed some bonuses getting capped (#4137)
* Fixes #4135.
* Fixes several item bonuses getting their bonus capped when they shouldn't be.
Thanks to @Badaroks0!
2019-05-10 08:41:16 -04:00
Jittapan Pluemsumran
7f772c32d3
Fixed potential race-condition possibility in cart item transaction (#4139)
Co-authored-by: Cydh Ramdh <cydh@users.noreply.github.com>
Co-Authored-By: Aleos <aleos89@users.noreply.github.com>
2019-05-02 21:01:18 +07:00
rAthenaAPI
8906dc9762 Effect State Update 2019-05-01 08:05:31 +02:00
rAthenaAPI
94c4e9f471 Effect State Update 2019-05-01 07:06:02 +02:00
Joam
79ba5aa991 Renewal hateffect update (#4102)
* Updated items with new hat effects.
Thanks to @attackjom!
2019-04-26 18:05:35 -04:00
Atemo
3d8c20f6b9
unitwarp npc - issue #4087 (#4104)
* Fixed issue #4087 
* Added an extra map check in npc_touch_areanpc
* Move the npc warped by unitwarp to the new map.

Thanks to @aleos89 for the review and @Litro for testing !
2019-04-25 15:07:20 +02:00
Aleos
53cedb72af
Corrected Cross Slash (#4121)
* Fixed Kagerou/Oboro Cross Slash div_ check looking for the status change rather than the skill ID.
Thanks to @mrjnumber1!
2019-04-23 09:59:51 -04:00
Yashim Wong
d05c6035f2 Corrected checks for weapon attack calculation (#3469)
* Fixes #3371.
* Fixed instruments (W_MUSICAL, W_WHIP) not receiving attack bonus from DEX.
Thanks to @Rayvis and @yashimwong!
2019-04-23 08:51:12 -04:00
Aleos
ce1508a01c
Corrected Enchant Arms status icon (#3661)
* Enchant Arms should display a status icon depending on the element (skill level) being used.
Thanks to @mrjnumber1!
2019-04-19 21:30:03 -04:00
Aleos
53f5013149
Added an item group for Token of Siegfried (#4047)
* Fixes #4041.
* Created an item group used to remove hard coding of Token of Siegfried.
* Added the other Token of Siegfried's to work with this feature.
Thanks to @daisyanne1380!
2019-04-19 10:33:35 -04:00
Aleos
21a5854c16
Cleaned up instance script commands (#4090)
* Script command instance_id now supports an instance mode argument. If no mode is given it will return the attached script's instance.
* Script commands instance_destroy, instance_npcname, instance_mapname, instance_announce now attach themselves to the script's instance by default.
* Script commands instance_enter and instance_warpall attach themselves to the player's IM_PARTY instance by default.
* Added getvariableofinstance command (similar to getvariableofnpc) to retrieve the instance variable outside the instance.
* Update documentation to match changes.
Thanks to @vykimo, @Atemo, and @Lemongrass3110!
2019-04-19 09:02:42 -04:00
Aleos
c264d3e94a
Corrected script command logmes (#4103)
* Fixed a potential crash with attempting to log a message with a floating NPC.
Thanks to @Akkarinage!
2019-04-18 14:28:49 -04:00
CairoLee
94324bc2d7 Ensure the mysql server host support full length domain (#4092) 2019-04-17 17:59:42 -04:00
Aleos
8df036c428
Fixed AG_BATTLE and AG_TAMING achievements (#4065)
* Fixes #4015.
* Fixes a potential crash from AG_BATTLE and AG_TAMING achievements.
* General cleanups.
Thanks to @Atemo!
2019-04-17 12:23:43 -04:00
Atemo
8975682fed
Corrected countitem_sub return value (#4110)
* Corrected countitem_sub return value in case of failure
2019-04-17 17:50:30 +02:00
Aleos
3057af757d
Corrected a compile error (#4107)
* Fixes a compile error for clients older than 2014-10-08 which don't support pet autofeed.
Thanks to @Normynator!
2019-04-15 13:42:47 -04:00
Atemo
04c6303eb9
Implemented (the old) Nightmarish Jitterbug instance (#4061)
* Implemented NPC_REVERBERATION (some parts are from https://github.com/idathena/trunk credit to @exneval)

Credit to @RagnarokNova for some texts correction and for the monster spawn ([source](https://rathena.org/board/topic/104496-nightmareish-jitterbug-episode-143/))
Credit to https://www.divine-pride.net/ for the monsters datas.
2019-04-13 15:12:30 +02:00
Aleos
f047a6a510
Cleaned up countitem-type script commands (#3657)
* Fixes #3612.
* Separated the countitem-type script commands into their own functions.
* Created a global count function to be used between them.
Thanks to @kisuka, @Normynator and @Atemo!
2019-04-12 13:13:35 -04:00
Aleos
06020502b8
Adjusted pet walk speed (#4083)
* Added battle config pet_walk_speed.
* Resolves some pets walking too slow.
2019-04-11 18:49:07 -04:00
Atemo
9aa5f7d834
Added several warning messages (#4062)
* enablenpc / disablenpc / hideoffnpc / hideonnpc now display the npc source when the npc named doesn't exist
* Added the NPC source to status_set_viewdata when no view data has been found
* Added export_deprecated_constant3 to display the constant name replacing the deprecated
* Removed the debug message from `@ warp` when the map name is wrong
* Added clif_name_area to UMOB_LEVEL on setunitdata and a capvalue to UPET_HUNGER
* areamonster now checks if the monster ID exists

Thanks to @Normynator and @aleos89 for the review!
2019-04-10 15:59:42 +02:00
rAthenaAPI
26ebaf732c Effect State Update 2019-04-09 13:05:32 +02:00
rAthenaAPI
5cbbec78b9 Effect State Update 2019-04-09 12:06:41 +02:00
Aleos
a0bcb92b8a
Added caps to item bonus rates (#4081)
* Fixes #4069.
* Added caps to item bonus rates so that they don't exceed the -10000~10000 range.
* Added warning messages when initial rate exceeds range.
* Added a missing vector size check for HP/SP Vanish bonus.
Thanks to @Litro and @Lemongrass3110!
2019-04-08 10:11:56 -04:00
rAthenaAPI
4ef5764d8d Effect State Update 2019-04-06 10:05:39 +02:00
rAthenaAPI
c2fbfdd4b7 Effect State Update 2019-04-06 09:18:47 +02:00
Cydh Ramdh
a8185e6294
Fixes #4066 (#4070)
* Fixed Defending Aura effect taking twice as incorrect Devotion behavior (leftover from old fixes)
2019-04-05 07:32:35 +07:00
Aleos
7c313a776a
Updated Firewall cast check (#3556)
* Firewall should check at cast begin if unit max count has been reached.
* Removed redundancy with the unit max count checks by merging into a single function.
Thanks to @mrjnumber1!
2019-04-04 18:57:17 -04:00
Aleos
c977558cfd
Adjusted OnTouch overlap behavior (#2382)
* Fixes #1939 and fixes #2274.
* OnTouch NPC are now able to overlap one another and properly trigger as they do on official servers.
* When entering an overlap area it should trigger both NPC.
* Walking from overlap area to either NPC should trigger neither.
* Walking from one NPC to the other (skipping the overlap area) should trigger the NPC area you enter.
* Entering an OnTouch area will no longer stop the player from walking unless a message or menu window opens (or other events that should stop the player).
* Resolves OnTouch_ overlapping issues.
* Dead players don't trigger OnTouch_ anymore.
* Hidden players don't trigger NPC clicks when OnTouch_ label is defined.
Thanks to @Tokeiburu, @Lemongrass3110, @Atemo, and @Normynator!
2019-04-03 19:25:47 -04:00
rAthenaAPI
98a685d706 Effect State Update 2019-04-03 07:05:57 +02:00
rAthenaAPI
83a0ae9480 Effect State Update 2019-04-03 05:06:00 +02:00
Atemo
66b8273221
Corrected block_action behaviour (#4071)
* Corrected block_action behaviour
* reloadscript command doesn't remove PCBLOCK_IMMUNE anymore
* Corrected a typo on MorseCave.txt

Thanks to @CairoLee and @ElinhoPP !
2019-04-02 18:48:46 +02:00
Atemo
e172c4365d
Added setpcblock to some official scripts (#4067)
* Added setpcblock to official scripts to mimic some npc interaction.
* Clean-up the docs.
* Added the WORK_IN_PROGRESS message when PCBLOCK_USEITEM and PCBLOCK_SKILL are enabled.

Thanks to @aleos89 for the review!
2019-04-02 02:12:10 +02:00
Atemo
7dde174c83
setpcblock script command (#4052)
* Added setpcblock and getpcblock script commands.
'setpcblock' command prevents/allows the player from doing the given type of action.
'getpcblock' command return the bit-mask value of the currently enabled block flags.

The available type are:
	PCBLOCK_MOVE
	PCBLOCK_ATTACK
	PCBLOCK_SKILL
	PCBLOCK_USEITEM
	PCBLOCK_CHAT
	PCBLOCK_IMMUNE
	PCBLOCK_SITSTAND
	PCBLOCK_COMMANDS
	PCBLOCK_NPCCLICK
	PCBLOCK_EMOTION
	PCBLOCK_ALL

Thanks to @sigtus, @secretdataz, @Lemongrass3110 and @aleos89 for the help and reviews !
Credit to https://github.com/HerculesWS/Hercules/pull/842 for the idea.
2019-03-31 18:28:55 +02:00