14879 Commits

Author SHA1 Message Date
Lemongrass3110
b196b46bd5 Follow up to f42c2ff
Fixes some missing randoms

Thanks to @aleos89
2017-10-15 02:19:58 +02:00
Aleos
2606cf977f Migrated skill.c to C++ (#2500)
* Migrated skill.c to C++
* Needed in preparation for future projects.
2017-10-14 13:03:27 -04:00
Lemongrass3110
f42c2ff211 Moved some remaining constants into src (#2501)
* Moved all npc view constants into src

Source side the constants will use Gravity's naming standard(JT_*)
NPC side still supports the old names without JT_

* Moved all effect constants into src

Added check for effect validation to atcommand effect and all script commands using them
Removed the unused and broken function unit_changeviewsize from unit.c
Replaced a lot of hardcoded effect ids with their respective constants
Cleaned up the effect documentations

* Moved all hat effect constants into src

Added check for effect validation to script command hateffect
2017-10-14 18:13:51 +02:00
Aleos
951ff55573 Updated Convex Mirror to match official behavior (#2506)
* Updated Convex Mirror to match official behavior
* Fixes #2498.
* When a MVP dies it will only show the respawn time once instead of flooding the chat window.
* The Boss icon will now properly display itself when the MVP respawns if the player has already consumed a Convex Mirror.
* Converted some integers to constant values.
* Made use of the other BOSS_INFO packet messages.
* Properly end the status when the player changes maps.
* Small cleanups and updated status change documentation.
Thanks to @esu1214 and @Lemongrass3110!
2017-10-14 11:45:24 -04:00
aleos
76923ac506 Corrected some refiner checks
* Follow up to e24d30a.
* Fixes #2505 and fixes #2507.
* Added a missing material check for Suhnbi.
* Added a missing safe limit check for normal refiners. Safe limit was always 0.
Thanks to @mazvi, @Mickosis, and @cydh!
2017-10-14 09:11:30 -04:00
aleos89
3ab39c4cb3 Follow up to 6a2c122
* Removed an unused variable.
2017-10-13 09:53:36 -04:00
rAthenaAPI
57113d1fbb SQL synchronization 2017-10-12 17:04:12 +02:00
Aleos
6a2c1229d0 Updated Rebellion class (#1692)
* Updated Rebellion class
* Information based on Rebellion Awakening patch from kRO.
- http://ro.gnjoy.com/news/update/View.asp?seq=183&curpage=1
* Fixes #859 and fixes #1449.
Thanks to @RagnarokNova and Fyrus for their information!
2017-10-12 11:04:03 -04:00
rAthenaAPI
db2d332cab SQL synchronization 2017-10-11 15:24:39 +02:00
Lemongrass3110
705cc5a869 Mob DB placeholders
kRO patch 2017-10-11
2017-10-11 15:24:06 +02:00
Aleos
fa425b834f Updated callshop selling list variables (#2480)
* Updated callshop selling list variables
* Updated script command callshop OnSellItem list to include random item options.
* See documentation for more information.
2017-10-10 12:15:51 +02:00
rAthenaAPI
7898a667df SQL synchronization 2017-10-09 14:37:51 +02:00
Jey
3e78cc1c3a Fixes item positions
* 28310,Earring_Of_Sarah_L
* 28311,Earring_Of_Sarah_R
* Closes #2493
* Thanks to @Yuchinin
2017-10-09 14:35:59 +02:00
rAthenaAPI
9e1c5dbec1 SQL synchronization 2017-10-09 03:55:27 +02:00
Jeybla
828f78322b Adds a duplicate name check for the itemdb. (#2492)
* Fixes #2487
* Fixes some duplicate itemdb entries.
2017-10-09 03:55:12 +02:00
Jey
ff6722c924 Follow up to fb882c4aa09af17992f5073f1f32566d9ff7e21f
* Fixes #2489
* Thanks to @Yuchinin
2017-10-08 20:20:33 +02:00
rAthenaAPI
ba7a766472 SQL synchronization 2017-10-08 16:50:46 +02:00
Jittapan Pluemsumran
800fd3da45 Fixed Zaha Doll Hat not being refinable. Fixes #2485
Thanks to @uddevil
2017-10-08 21:50:38 +07:00
rAthenaAPI
8a93b12020 SQL synchronization 2017-10-08 00:58:05 +02:00
Atemo
319fc4d18c Fixed a duplicate aegis name
Thanks @Jeybla !
2017-10-08 00:57:43 +02:00
Aleos
54a119c56a Resolves Skill Unit Database parsing issue (#2484)
* Fixes #2483.
* Properly trims the target field so it can be processed accurately.
2017-10-07 17:29:50 +02:00
Jeybla
b8562932cf Removes SCRIPT_CALLFUNC_CHECK ifdef-directives. (#2482)
* Closes #2205
* The SCRIPT_CALLFUNC_CHECK define was to enforce function
  calling with callfunc in scripts. Because I don't think calling
  functions without callfunc will give us performancy issues,
  this check is simply removed by this commit.
2017-10-07 16:59:45 +02:00
Jeybla
2676d05394 Jobmaster update (#2369)
* Major changes due to readability and some corrections
* Adds the option to disable Rebirth Classes
* Adds the possibility to give players job related 
  Equipment (mostly weapons) on job change
* Adds more level requirement settings
* Adds BabyExpanded and BabySummoner Jobs
* Thanks to @Braniff, @mazvi, @Mikegyver, @Lemongrass3110, @Akkarinage, @Stolao and @secretdataz!
2017-10-06 17:40:39 +02:00
rpdigos
fb882c4aa0 Fix a couple of warnings. (#2462)
* Fix a couple of warnings.
Thanks to @rpdigos!
2017-10-06 10:58:17 -04:00
Jey
ae0da362f8 Follow up to fe75aea
* Fixes a compile warning
* Thanks to @Haikenz
2017-10-06 02:23:56 +02:00
Aleos
fe75aeab50 Corrected character slot movement (#2452)
* Corrected character slot movement
* Resolves characters changing slots (on the char-selection screen) to the first empty slot rather than to the actual slot index.
Thanks to @Tokeiburu, @Lemongrass3110, and @Jeybla!
2017-10-05 18:31:30 -04:00
Aleos
0068268337 Follow up to 2c8ab4f
* Fixed some typos.
Thanks to @Akkarinage!
2017-10-05 14:27:19 -04:00
aleos89
9210bf5d68 Follow up to 2c8ab4f
* Fixed some visual issues for the contributing documentation.
2017-10-05 14:04:25 -04:00
aleos89
2c8ab4ff79 Updated the contributing documentation
* Updated the label documentation.
2017-10-05 13:57:43 -04:00
Jittapan Pluemsumran
872cb42a48 Fixed a bug where refine bonuses was being incorrectly parsed. Fixes #2456
Thanks to @hc3490
2017-10-05 22:43:38 +07:00
rAthenaAPI
6f634735aa SQL synchronization 2017-10-05 08:17:51 +02:00
rAthenaAPI
1679521a4b SQL synchronization 2017-10-05 08:17:41 +02:00
Jittapan Pluemsumran
67518f4def Merge pull request #2470 from rathena/feature/moscovia_cards
Implemented cards for Moscovia monsters
2017-10-05 13:17:33 +07:00
Aleos
53ba373c43 Corrected Overed Boost behavior (#2474)
* Fixes #2473.
* Skill was draining double homunculus hunger and double master SP.
Thanks to @Everade!
2017-10-04 21:14:55 -04:00
rAthenaAPI
1aa8c072b7 SQL synchronization 2017-10-04 16:38:29 +02:00
Atemo
0791adb4f4 Corrected duplicate item name follow up 7f9747c15d (diff-23f1393132fc5ca16140f50c9591e550R4554) 2017-10-04 16:38:00 +02:00
rAthenaAPI
771d4b94ba SQL synchronization 2017-10-04 16:30:35 +02:00
Atemo
7f9747c15d Aegis item name (#2451)
* Correct Aegis item name from https://rathena.org/board/topic/107649-aegis_id2name_v2/

Thanks @esu1214
2017-10-04 16:30:28 +02:00
Atemo
75653d9da1 Adjust Wood_Goblin_Card item script from the description 2017-10-04 00:00:36 +02:00
Lemongrass3110
b8844a0973 Fixed @Atemo's comments 2017-10-03 15:46:45 +02:00
Lemongrass3110
77a7bc2d9a Fixed a missing comma 2017-10-03 14:55:29 +02:00
Jey
6b6717748e Fixes homunculus being able to attack from Manhole
* Fixes #2068
2017-10-03 08:07:57 +02:00
Jey
215aa158ed Follow up to aa6e8987db08ecd7dfb06ab55f4e44009e174175.
* Fixes compile warnings.
2017-10-02 22:16:12 +02:00
Jittapan Pluemsumran
fc8534f766 Implemented cards for Moscovia monsters 2017-10-02 23:34:35 +07:00
rAthenaAPI
5b874a15f1 SQL synchronization 2017-10-02 18:19:47 +02:00
Jittapan Pluemsumran
091738ac7e Implemented Terra Gloria cards (#2464) 2017-10-02 23:19:27 +07:00
Jeybla
aa6e8987db Merge pull request #2466 from rathena/refactor/mob_cpp
* Convert mob.c to mob.cpp.
2017-10-02 17:49:55 +02:00
Jittapan Pluemsumran
16d8abbd0f Merge pull request #2468 from MuzTank/issue-1432
Added AB_RENOVATIO as reproducible skill.
2017-10-02 21:43:27 +07:00
Edwin
2df18b12e6 Added AB_RENOVATIO as reproducible skill. 2017-10-02 15:00:45 +07:00
Jittapan Pluemsumran
f20ac015d1 Fixed random options with negative values being stored as 0 in database. (#2465)
* Made random option database columns signed
* Negative values can now be stored for random options
* Fixed #2415
Thanks to @uddevil

* Follow up to ea28ff4. Updated main SQL scripts.
2017-10-02 09:05:41 +07:00