978 Commits

Author SHA1 Message Date
Atemo
fc4f82838e
Corrected guild relay script (#5131)
Corrected the value of the variable guildtime to match the value in official script.

Fixed #1785

Thanks to @Lemongrass3110
2020-06-23 01:43:42 +02:00
iraciz
fad58cd3c1
add cutins for Friendship Quest (#5004) 2020-06-08 23:52:59 +02:00
Daegaladh
d1e5127728
Fixed getcharid error in Continental Guard quest (#4970) 2020-05-18 18:52:08 +02:00
Daegaladh
fb890c747c
Fixed Piano Key Quest hidden warp position in pre-re (#4888) 2020-05-10 04:12:29 +02:00
Atemo
85dc43c692
Fixed an issue in Umbala Domestic Dispute Quest (#4790)
Closed #4729
2020-04-13 16:45:19 +02:00
Daegaladh
9993639177
Updated Cat Paw texts and name (#4515) 2020-01-05 19:01:52 +01:00
Daegaladh
305c51ede9
Fixed official Cat Paw addition exploit (#4514)
* Fixes an exploit where you could save in Manuk and Splendide fields and open Warp Portal to these maps for other players
2020-01-05 18:13:28 +01:00
Daegaladh
1bd33fb108
Fixed 'Finding the Moving Island' quest spawning the wrong monsters on pre-renewal (#4490) 2019-12-22 01:46:30 +01:00
Daegaladh
354c632732
Fixed place names and other typos (#4475)
* Fixed common misspelled names from iRO and other typos.
2019-12-15 20:55:19 +01:00
JohnnyPlayy
081b7cd388 Lighthalzen Quest NPC ID Fix (#4392)
* Changed NPC view ID to constants.
2019-10-12 12:15:01 -04:00
Aleos
995fb2a0a1
Corrected NPC view constant verification (#4398)
* Fixes #4397.
* Corrected NPC view constant verification stopping at the first digit found resulting in invalid results.
Thanks to @Lemongrass3110!
2019-10-09 12:05:08 -04:00
JohnnyPlayy
ce42168b0d Updated Young Man Position (#4319)
* Updated Young Man position for Renewal.
2019-09-16 10:44:14 -04:00
Atemo
ddb9e814a2
Corrected dandelion request script (#4309)
An undefined label was called

Thanks to @dragonis1701 !
2019-09-14 19:03:02 +02:00
Atemo
34971e57fa
Wounded Morroc cooldown (#4207)
* Fixed an issue with a cooldown after killing Wounded Morroc
* Fixed #4205 

Thanks to @Tokeiburu !
2019-06-11 15:44:12 +02:00
Balfear
f0f94f0c1e Wrong NPC coordinate (#4023)
* Changed the coordinate of the last Piano Key Quest NPC.
Thanks to @Balferian!
2019-03-19 12:20:47 -04:00
Atemo
e74e1e1191
Corrected several npc name in quests_ein.txt (#4013)
Fixed #4012
Thanks to @Indigo000 !
2019-03-14 15:17:11 +01:00
zackdreaver
fc7e46e890 Adjusted some NPC names (#3896)
* follow up https://github.com/rathena/rathena/pull/3224

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* Changed "Cougar" to "Kuuga" in Ninja and KagerouOboro job change NPC

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* Changed "Gaebolg" to "Geoborg" in some NPC dialogues

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* changed "Kuuga" to "Kuuga Gai", thanks to @ Daegaladh

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* changed "Guide Gion" to "Leader Gion"

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* changed "Wildcat Joe" to "Red Leopard Joe"

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* changed "family" to "Clan"

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* revert 705ecc5069ca4abe1e1b1bcc25e048b3a7691eeb

Signed-off-by: zackdreaver <zackdreaver@gmail.com>

* adjusted capital letter

Signed-off-by: zackdreaver <zackdreaver@gmail.com>
2019-02-07 18:01:29 +01:00
Aleos
26720f041a
Updated script command getmapxy parameters (#3890)
* Fixes #3100.
* Script command getmapxy will now allow integer values for the search value.
* Deprecated UNITTYPE constants as they were replaced by BL.
* Defaulted BL_PC as the target for script command getmapxpy.
* Updated script command getunittype return value to return BL constants.
* Updated scripts to new BL constants.
Thanks to @pajodex's suggestion and @Lemongrass3110!
2019-01-30 17:10:33 -05:00
Daegaladh
c96671fc2f
Fixed wrong exp values on 13.1 and 13.2 quests and other minor fixes (#3847) 2019-01-18 16:04:42 +01:00
Atemo
756ef38bc9
Fix for issue #3701 (#3702)
Thanks to @teededung for reporting it
Fixed #3701
2018-11-30 15:53:07 +01:00
Atemo
78edf851a0
Suggestion of implementation of is_party_leader and is_guild_leader script commands. (#3617)
* Implemented is_party_leader and is_guild_leader script commands.

Thanks to @cydh !
2018-11-06 16:28:09 +01:00
Lemongrass3110
7066cac9a4
Fixed some conditions in LV4 weapon quest (#3630)
Fixes #3627

Thanks to @SnotraRM
2018-10-28 16:30:40 +01:00
Atemo
9780b461f5
Clean-up HTF instance and fixed a quest warning in High Laphine#grenouille npc (#3457) 2018-09-01 22:19:24 +02:00
zackdreaver
91667a9a11 Update Renewal and Pre-renewal Morocc NPCs (#2977)
Fixes #3392 

Thanks to @zackdreaver, @AzarthMZintos and @Lemongrass3110
2018-08-17 10:27:26 +02:00
BrOgBr
fa4021d217 Fixed a mistake in 2008 headgear quest (#3344)
Fixes  #3343

Thank you @Kutikuti
2018-07-25 21:04:16 +02:00
Atemo
7a8ac46421
Banquet for Heroes ep 16.1 (#3234)
Banquet for Heroes ep16.1 - walkthrough conversion
* Added main quests of ep16.1 and the quests entries
*** Walther's daily quest will be enabled after quest_db refactor
* Added instances Ritual of Blessing and Room of Consciousness
* Added monsters spawn and entries on prt_prison, prt_cas and prt_q maps
* Prontera castle map changed in this ep
- Moved some NPCs from prt_castle to prt_cas
- Added warps on prt_cas
- Succession of the Prince quest is removed in ep16.1

Thanks to @admkakaroto, https://www.divine-pride.net/ 
@yoonjunho72, @teededung, @ecdarreola, @spinzaku and to all the contributors !
2018-07-13 15:49:33 +02:00
Atemo
12f62e6302
Quest warning in quests_amatsu.txt (#3296) 2018-07-07 15:53:25 +02:00
Atemo
532e043490
Fixed issue #3286 and corrected npc name (#3287)
Thanks to @AzarthMZintos !
Fixed #3286
2018-07-05 02:13:12 +02:00
Atemo
6e8599cd5b
Extra npc checks (#3274)
* Extra checks
- Added some extra check in npcs script to prevent wrong behaviour
2018-07-03 23:24:04 +02:00
Atemo
3a8814ac4e
Fixed Regenschirm Guard Laboratory Permit issue (#3056)
Thanks to @juanfus !
2018-04-16 17:01:01 +02:00
syracuase
8530a7b1fe Job Level check for Blacksmith and Alchemist (#2819)
* Job Level check for Blacksmith and Alchemist
2018-01-21 14:51:38 +01:00
Lemongrass3110
16780638be
Fixed a few name typos with Niflheim (#2782)
Thanks to @Daegaladh for his input
2018-01-09 23:36:20 +01:00
Lemongrass3110
a65e7dbf46 Fixed F_SexMes call
Fixed #2785

Thanks to @insanchen
2018-01-07 21:07:34 +01:00
Cydh Ramdh
bb4a88a362
Update Megingard Seal Quest
* Wrong Item ID for for Baphomet Doll (750). 744 is Bouquet
2017-12-06 08:24:55 +07:00
Atemo
ea88ea5054
Emoticons constant name (#2527)
This PR change the emoticons constant name to match emoticonlist from client side.
Note: the previous emoticons names are now deprecated.

Additionnally emotion and unitemote scripts commands are being merged together to the new format
-> emotion <emotion number>{,<target>};
Where target use the target Game ID (GID) of the unit (npc, pet, character etc..).

* unitemote is now deprecated.
* Additionnally fixed incorrect variable in quests_brasilis.txt

Thanks to @aleos89 and @Lemongrass3110 !
2017-11-10 18:35:21 +01:00
Lemongrass3110
f42c2ff211 Moved some remaining constants into src (#2501)
* Moved all npc view constants into src

Source side the constants will use Gravity's naming standard(JT_*)
NPC side still supports the old names without JT_

* Moved all effect constants into src

Added check for effect validation to atcommand effect and all script commands using them
Removed the unused and broken function unit_changeviewsize from unit.c
Replaced a lot of hardcoded effect ids with their respective constants
Cleaned up the effect documentations

* Moved all hat effect constants into src

Added check for effect validation to script command hateffect
2017-10-14 18:13:51 +02:00
keitenai
f4de91b407 Fixed incorrect use of 'close' command 2017-08-14 23:25:29 +08:00
Jeybla
9e6b02ae59 Fixes a getcharid error message. (#2106)
* In quests/quests_morroc.txt Continental Guard.
2017-04-29 19:20:25 +02:00
Atemo
73b798bf12 Removed extra semi-colon 2017-04-06 14:40:36 +02:00
Atemo
f6488a2a9e Corrected a warp destination typo in The Sign quest (credit c215c9c21a) 2017-03-06 23:26:10 +01:00
Atemo
c6e09fdf35 Added parenthesis in tu_ma_th01.txt 2017-03-06 23:21:05 +01:00
Lemongrass3110
800f22b77b Removed an unused character variable
Fixes #1976
2017-03-02 23:20:45 +01:00
Atemo
c6470ff4ff Clean-up permanent monster spawn: (#1831)
* Clean-up permanent monster spawn:
- <delay1>,<delay2>,<event> are actually optionnal field
- <event> value 0 and 1 are meaningless (actually event name with length < 4 are skipped)

* Exported monster AI constants

* Updated docs for monster size constants (already exported)
Notes:
- the default size for monster script cmd was small not medium
- monster script cmd now display a warning for size above SZ_BIG (previously SZ_ALL)

* - Fixed an issue to make <xs> and <ys> optionnals
- Updated npcs scripts

* Leftover in the docs for permanent monster spawn

* Corrected english docs. Credit to @aleos89
Added additionnal warning for xs / ys negative input. Credit @Lemongrass3110 

Thanks to @cydh for the idea
2017-01-22 19:03:08 +01:00
Lemongrass3110
2043c95e66 Refactored hardcoded npc event names (#1767)
While refactoring those events the following other changes were made:

Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.

The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.

All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).

All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).

Renamed a few events in the script configuration to match the other names

Added constants for months and weekdays

Additionally added constants for gettime types to make it easier to read.

Replaced all existing usages I found with their proper new syntax or better fitting functions.
2017-01-10 22:58:04 +01:00
Lemongrass3110
988bf12887 Fixed announces from Koschei the Immortal
Original Commit HerculesWS/Hercules@dbc54ea
Thanks to @landergate
2017-01-06 17:15:19 +01:00
Atemo
a9faab82cb Fixed incorrect OnTouch label in Crow of Destiny Quest (issue #1840) and in Guild dungeon 2 event. Thanks @Tokeiburu 2016-12-29 23:00:37 +01:00
Cydh Ramdh
2896d894d1 Official Random Coordinates for Savepoint (#1756)
* Added parameters for `savepoint are range for `x` and `y` for random savepoint coordinates.
* Added documentation for new savepoint params. Credits to @aleos89
* Updated savepoint on script to follow official behaviour (random save in 3x3). All credits to @Atemo
2016-12-20 17:16:42 +07:00
Atemo
45bc42c305 Fix wrong command usage at sign quest
Credit Hercules@47834e8f6db03689595946af0cd95748005126c7
2016-12-09 19:58:01 +01:00
Lemongrass3110
9040613fa6 Added missing empty newlines to a lot of files 2016-11-23 13:54:45 +01:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00