191 Commits

Author SHA1 Message Date
ultramage
e12b04e850 Added error reporting for invalid rows in skill db files.
Fixed skill_castnodex_db.txt not being parsed correctly.
Fixed a search&replace typo in skill_db.txt.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11728 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-11-13 07:48:44 +00:00
ultramage
f7d4427c1a Changed the skill_db.txt skill names in comments into actual columns, now the server reads these instead of a hardcoded array (see topic:170438).
Corrected skill db loading code which was using a totally wrong column count in sevreal cases (or didn't do any checks at all).
Cleaned up skill db lookup code
 * added some well-behaved functions to replace macros (skill_get_index)
 * used skill_get_index() to replace often occuring blocks of code that did the skill_id -> skilldb_index calculation in-line

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11657 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-11-05 08:59:19 +00:00
ultramage
989a557598 Removed some long-unneccessary debug messages (from r1105).
Removed function skill_count_target() because it's a duplicate (see topic:169337).
Renamed skill_get_pl to skill_get_ele (because it retrieves element ids).
The block_list structure now uses the BL_ enums instead of 'unsigned char'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11640 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-11-02 15:54:27 +00:00
Playtester
b2aeae0dcc * Added trap mode to Firepillar
- tell me if it breaks something

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11639 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-11-02 12:30:19 +00:00
Playtester
9ec6519201 * Some small db updates
- fixed Bongun Card thanks to Gepard
- updated Ifrit Card to official
- Fire Wall now has 2 cells knockback
- set interval values of Fire Wall and Fire Formation to 20ms

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-26 10:17:06 +00:00
Playtester
0e39094a11 Fixed Bowling Bash doing more than 1 tile knockback
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11547 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-22 19:34:06 +00:00
Playtester
6bcbcb11bb * Further optimization of the skill unit code
- removed code for Crimson Fire Formation it now uses the same code as Fire Wall
- added same knockback behavior as Fire Wall for Fire Formation
- Heat now does 50 hits a second in pvp too
- please let me know of any bugs that might appear

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11510 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-18 18:07:09 +00:00
ultramage
425112aef3 * Fixed a copy-paste mistake in disguise code (from r5833)
* Commented out clif_skill_damage2() as it is not used anymore
* Made Venom Splasher a splash attack that distributes damage
* Fixed displaying of several splash skills (see bugreport:238)
- added flag SD_PREAMBLE for skills that need the 'magic' packet (fixes Grimtooth / Cart Revolution displaying out of sync)
- hacked together Venom Splasher's "no animation for central mob"
- hacked in a custom packet to make Dragonfear display semi-correctly

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11491 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-16 19:00:03 +00:00
Playtester
7d23a41f0b Cosmetical changes
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11484 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-16 00:20:42 +00:00
L0ne_W0lf
34a1e73c9f Readded Sonic Acceleration to the skill DB. -_-
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11481 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-15 18:14:25 +00:00
L0ne_W0lf
d43329708f Implemented new skill "Enlarge Weight Limit R", and increased MAX_SKILL_TREE by 1.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11476 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-10-15 05:55:55 +00:00
skotlex
c6d05bc0f3 - Gravitional Field is now a MISC type of attack.
- battle_calc_return_damage now is only for BF_WEAPON attacks, added skill_magic_reflect to check whether a spell is bounced back or not.
- Magic reflection now effectively switches the caster/target (after damage has been calculated)
- Now when GTB completely blocks a spell, the spell animation will still come off, but with a single bolt and MISS damage.
- Removed hom_setting&0x2 since Homunculus can be hit by land spells.
- Monster Property now gives a Skill Failed message when attempted on players.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11203 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-09-14 18:46:41 +00:00
skotlex
7233562a1a - Removed bonus bAddEffWhenHitShort as it is unneeded and unused.
- Corrected getpetinfo so it actually returns "null" when there's no pet and you request the name (the docs state it so).
- Also cleaned up a bit getpetinfo
- Added gethominfo (which behaves in the same way as getpetinfo).
- The 'maxcount' skill_db field now can store independant values per skill-level, required for Kamaitachi since it uses different range values per level.
- Corrected bonus3 bAutoSpell(WhenHit) to select target enemy (rather than self) for skills with inf self and inf2 'don't target self' (aka: auto-select target skills).
- Corrected map_foreachinpath to do a wall check for targets beyond the initially selected tile.
- Corrected Kamaitachi's range to be 9, and the path range to be 4+SkillLv


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11169 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-09-10 17:07:35 +00:00
skotlex
81faa4770b - Oops, forgot to add the Pulse Strike damage modifier.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11055 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-20 19:02:01 +00:00
Playtester
3f5d2a35b0 Fixed the damage area of the "path damage" skills
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11004 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-14 15:59:02 +00:00
skotlex
2d6cef47d6 - Modified map_foreachinrange so that you can also specify the max length of the path to use. The max_count field in the skill_db is used to specify this range for path-type skills (Sharpshooting, Kamaitachi and the NPC Breath skills.
- Implemented the 'new' NPC skills described here: http://ro.doddlercon.com/wiki/index.php?title=Monster_Skills . It is mostly complete, but the new status changes (slow cast, critical wounds, etc) don't have any visual effects yet (icon or opt changes? I don't know if they should have). Also I could not find the unit_id for Evil Land, so it looks just like Sanctuary for now. Apart from those, the only skills which I couldn't get to display properly are the Breath skills (with the exception of Fire Breath).
- skill_calc_heal now takes the target as argument to properly support Critical Wounds
- battle_calc_return_damage now takes a flag to know if the attack was direct or not, needed since Magic Mirror also reflects indirect attacks.
- cleaned up the 'description' field in skill.c, added skill_get_desc to it
- Removed 'splash' support from Lex Divina as it is no longer needed.
- Modified the way Sight/Sightblaster work so that the skill id is no longer guessed (needed to properly acquire the splash range for Wide Sight)
- Corrected gtb_sc_immunity setting not taking effect if your block value was the same (that is, if the config said 30%, then you would only get status change immunity at 31%, nor 30%)
- Uncommented the 'new' npc skills from mob_skill_db as they are implemented now.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@11000 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-14 00:05:13 +00:00
Playtester
9b5a8b8ede Added remaining 11.2 skill db entries
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10983 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-11 11:58:10 +00:00
Playtester
caffb97cde * Implemented 11.2 skills in the skill_db
- note that the code for them is still missing

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10982 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-11 11:17:16 +00:00
Playtester
babd639fca * Raised splash range of Focused Arrow Strike and First Wind
- temporary fix until the real area calculation is added
- also started adding some of the 11.2 skills

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10978 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-10 17:09:34 +00:00
Playtester
a1205df084 * Fixed damage of NPC_COMBOATTACK
- also reverted some custom skill changes

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10972 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-09 19:41:52 +00:00
skotlex
9e9847a83e - Fixed some missing max levels for npc skills
- Expanded isloggedin script command to support an optional argument (char id)
- Expanded warpparty command to accept target "Leader", this will warp the party to the leader.
- Added a summon structure to handle non-dead-branch mob-groups since the current implementation totally fails for mob groups that don't have MANY integrants
- Fixed mobs not attempting an IDLE skill right before unlocking a target.
- Removed a useless variable in the pet_data structure


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10961 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-08-08 01:55:58 +00:00
DracoRPG
b2950fb9d8 Added Job_Alchemist constant, Job_Alchem should now be considered deprecated
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10904 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-07-23 22:54:37 +00:00
ultramage
3f722ba896 - added temp skill db entries and corrected some existing ones (see topic:157041)
- removed txt converters from txt build (they need mysql files so they don't belong there)
- eol-style for newly added file

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10867 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-07-08 15:47:26 +00:00
Playtester
ea4b252218 * Attempt to fix Kyrie Eleison not castable on enemy players
- please test, I can't double client to test it in pvp
- don't forget to recompile before testing

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10459 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-05-05 09:11:52 +00:00
skotlex
b6e3783be6 - Updated the skill_db, some mob skills seem to be better to a range of -9 than 9.
- Corrected the pet_db information for Xmas Goblin and Rice Cake.
- Replaced all struct map_session_data to TBL_PC in script.c
- Pressure no longer vaporizes plants.
- Corrected pc_setregstr to handle a null str argument.
- Corrected @reloadbattleconf causing a add_timer_func "already existing function" error.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10326 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-23 19:08:34 +00:00
Playtester
593c3952b2 Fixed various mob skills not being ranged
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10269 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-16 18:54:37 +00:00
Playtester
4ce5ddc065 Added some splash ranges for MVP level skills
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10265 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-15 20:23:36 +00:00
Playtester
ef10fe3a04 * Kyrie Eleison cannot be cast on mobs anymore
- also some small mob skill changes to work with the new code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10239 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-12 18:32:12 +00:00
skotlex
f1bf0b8e80 - Changed the meaning of inf2=0x1000. Now it is used to "disable usage on enemies", which only works for non-aggressive (inf!=1) skills.
- If a skill is party/guild only (inf2 0x400/0x800) it will also be castable on enemies if the skill's inf is 1 (offensive target)
- Corrected the mob behaviour when it locks into an enemy it can't chase. Previously it would get stuck on a lock->unlock->lock loop, with each unlock resetting the "random walk" timer, causing the mob to just idle in place. Now they will attempt idle skills and no longer reset the "random walk" timer, so they behave as if they were in Idle state properly.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10234 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-12 15:19:49 +00:00
Playtester
5d0f037f75 * Ganbantein now has a range equal to the level used
- only mobs use levels higher than 1

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10218 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-04-11 18:25:37 +00:00
ultramage
478b4b58e8 Fixed typos from previous revisions :)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10098 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-30 17:01:53 +00:00
skotlex
47ab9dbbf8 - Added "do_abort" function to the core. It is invoked when the server has received a Segmentation Fault or Floating Point Exception signal. Currently the only one that uses it is the map-server, which then attempts to save all online characters before aborting.
- Note that due to the current coding of the sig plugin, do_abort will not be invoked if you use it! This plugin needs to be updated...
- Cleaned up a bit the change element code. val1 is the elemental level, val2 is the element now.
- Hardcoded the element and elemental level of SC_CHANGEUNDEAD.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10089 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-29 20:34:17 +00:00
skotlex
e377e96bc9 - Increased Improve Concentration's hide-revealing range to 3 (7x7)
- Cleaned up a bit the Ankle Snare status code.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10042 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-20 21:14:55 +00:00
skotlex
2907fa6467 - Removed the last argument from skillitem, the skill name passed to the client should always be of the type "AL_HEAL" anyway.
- Added skill ITEM_ENCHANTARMS, this is what weapon enchanting items should use.
- Corrected itemskill calls in the item_db, also made the weapon enchanting items invoke the ITEM_ENCHANTARMS skill. Corrected Holy Egg not being type 11 (delay consume)
- Updated item_db.sql with item_db information.
- Added support for specifying different elements per skill level in the skill_db
- Added bonus bNoKnockback
- Corrected typo in bonus bSubRace2 (it was called bSPSubRace2 for some reason)
- Corrected login sql server not resetting your account state to 0 when the banuntil duration expires.
- Corrected use of UINT_MAX instead of INT_MAX in some jailing check.
- Made the skillatk bonus it's own function, it can now be used to boost Heal/Sanctuary/Potion Pitcher and Slim Pitcher as well.
- Cleaned up TK_WARMWIND to use the element acquired from the skill_db rather than hardcoded values.
- Corrected Teleport's save map entry being sent without the .gat extension.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10031 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-19 19:44:21 +00:00
skotlex
a132a2c72c - Increased Shield Chain's range by one. It is now a ranged skill.
- Added SC_CHANGEUNDEAD to differentiate it from the other elemental change skills. It now fails on Undead/Dark elemental targets.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@10008 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-14 19:33:58 +00:00
skotlex
07e53259a5 - Corrected the define for NK no cardfix (def).
- Updated skills that shouldn't ignore the target's cards: Smoking, Fling, Zenynage
- Fixed the char sql server not escaping the server name before inserting it on the ragsrvinfo table.
- Corrected @lvup not doing the party even share check.
- Corrected breaker's misc part not ignoring element.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9969 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-06 16:16:25 +00:00
skotlex
0c7ca5de82 - Added NK value 0x80: ignore target's cards (0x8 will now only ignore attacker's cards).
- Corrected the NK values of skills (0x08 -> 0x80): Self Destruction, Smoking, Pressure, Fling, Zeny Nage, BioExplosion
- Soul Burn & Gravitation got NK 0x80 (previously hardcoded)
- Corrected Soul Breaker ignoring target's cards instead of the caster's.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9967 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-05 22:00:01 +00:00
skotlex
58da8d54fb - Soul Breaker no longer ignores elemental adjustments.
- Simplified the Utsusemi/Bunsinjyutsu check to only block weapon skills that do not ignore offensive cards.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9960 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-03-05 16:24:13 +00:00
skotlex
182ccc62a8 - The NK value of the skill_db has been made a hexadecimal value, and expanded to include more information about a skill's damage properties: 0x8 - ignore caster's cards, 0x10 ignore element adjustments, 0x20 ignore target's defense, 0x40 ignore target's flee.
- Magic attacks always ignore flee, and misc attacks always ignore defense.
- Autoguard will no longer work on skills that don't take in card adjustments
- utsusemi & bunsinjyutsu no longer work on skills that don't take in card adjustments.
- Corrected damage of the NPC elemental attack skills, Blood Drain and Energy Drain


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9906 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-23 21:55:18 +00:00
skotlex
c1044cf02f - Reverted Venom Splasher's element to take your weapon's
- reverted the item skill usage update since Flywings and the like do not use skill use scripts anymore.
- Restored tid when a castend-id skill becomes castend-pos, fixes certain skills, most notably Resurrect Homunculus.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9858 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-13 00:17:32 +00:00
skotlex
68e1eb420a - Corrected range of self destruction / bio explosion to be equal to their splash range.
- Corrected Spider Web casting around caster instead of target's position
- Corrected a possible crash during login due to checking for the incorrect variable (lets pc_calc_status be invoked when it shouldn't)
- Reenabled the base status aspd calculation for homunc (status_calc_bl calculates battle_status, status_calc_homunculus calculates base_status, they are not the same!)
- Corrected the meaning of "skill_display_fail&2", made 2 the default setting.
- Added bounds checking to map_foreachincell
- Opt2 values (poison, blind, and so on) are now resent on warp/map-change
- Corrected description of isloggedin script command.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9853 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-12 18:02:41 +00:00
skotlex
6e7a224bd1 - Fixed skill range considerations using skill_get_range rather than skill_get_range2
- Corrected the range of EnergyDrain/BloodDrain (when Tharis says the range is 7, that means 7 without the cells on which the chars stand, so that means 9 in eA terms)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9833 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-09 17:12:05 +00:00
ultramage
34d8dc0ad3 Fixed a skill_db.txt typo for AS_ENCHANTPOISON introduced in r9794
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9825 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-08 13:57:10 +00:00
skotlex
d47a0a0d52 - Fixed a bunch of probably incorrect logical comparisons.
- Some small updates on the skill_db file (some max levels of npc skills, some elements for skills that didn't really need them)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9823 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-08 05:34:12 +00:00
skotlex
6597b8c74b - Updated the range of BioExplosion and Self Destruction so they count as ranged skills.
- Removed old script bonuses bMatk, bMatk1, bMatk2
- Fixed char-server not sending online notification when a party member logs in.
- When skill range by distance is set, the distance checked for is now 5 cells rather than 3.
- Fixed bMatkRate bonuses not applying to status earned modifications to int/matk.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9816 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-07 17:46:50 +00:00
skotlex
facb8af27f - Updated the code so that now a range of a skill is determined by the skill's range in the db. Now only skills with less than 5 cells of range are melee.
- The inf2 parameter of the skill_db is now red as an hexadecimal.
- Updated comments and inf2 values of the skill_db to use the new format.
- Soul Change now can't be casted on self.
- Updated range of Grandcross, Granddarkness and Gospel to 5 so when they attack their attack type is counted as ranged.
- Splitted the super novice flag in two, to keep seperate counters for the chant and for the self-revival. The self-revive will now trigger only once per level per session, if you relog you can have it trigger again.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9794 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-05 23:10:47 +00:00
skotlex
d2574dfd69 - Fixed a duplicate warp name in Rachel
- Fixed Venom Splasher not being Poison elemental
- Cleaned up #blv
- Fixed the skill tree not always updating when using @allskill
- Probably fixed the target-change on melee attack setting not working.
- Moved the deletion of the invincible timer when using skills so that it is not deleted for skills such as Ashura (when just selecting a target)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9791 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-02-05 18:16:33 +00:00
skotlex
39381ad474 - 'Long Range Attacked' mob skill conditions will no longer trigger on magic attacks.
- Changed the element of Blood Drain from 'take weapon's element' to Dark. And Blood Drain/Energy Drain have a range of 7 now.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9747 54d463be-8e91-2dee-dedb-b68131a5f0ec
2007-01-30 18:22:11 +00:00
FlavioJS
637ae9a4dc - Massive EOL normalization & 'svn:eol-style native' flag setting for all txt/conf/h/c files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9410 54d463be-8e91-2dee-dedb-b68131a5f0ec
2006-12-05 13:23:07 +00:00
skotlex
00409a92bb - Corrected KiriKage's range so it works correctly when used by non-players or when use weapon's range is used.
- Changed service for you's flags so it affects all players on range.
- Corrected the skill animation for Absorb Spirits
- Cleaned up a bit the implementation of how Gravity Field blocks the caster from moving.
- Mob class-changing will fail if the new class is the same as the previous one.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@9325 54d463be-8e91-2dee-dedb-b68131a5f0ec
2006-11-27 14:58:50 +00:00