8088 Commits

Author SHA1 Message Date
Cydh Ramdh
dd67f9de96 Bug Fixes:
- 'hp_rate' and 'sp_rate' config aren't working. http://rathena.org/board/tracker/issue-8742-max-hpsp-battleconf-not-working/
- Mercenary DB that aren't being read properly whic also happens for Homunculus DB. http://rathena.org/board/tracker/issue-8761-mercenary-db-import-folder-issue/
- Fixed Elemental DBs that aren't being imported yet. (also changed to sv_readdb)

Rebellion Skill Updates:
- Some updates according to kRO updates on http://forums.irowiki.org/showpost.php?p=1364894&postcount=579, http://forums.irowiki.org/showpost.php?p=1388802&postcount=981, and http://forums.irowiki.org/showpost.php?p=1389627&postcount=1008
- Partial merge from idAthena.
- Using 0x107 as temporary marker on mini-map for Crimson Marker target.
- Some stuffs maybe still wrong, feel free to report/fix it.
- Thank people on those links, Ziu, and idAthena.

Misc changes:
- Changed some function names for homunculus.c/h with prefix hom_* and mercenary.c/h with prefix mercenary_*
- Change unnecessary 'int' return value tos 'void'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-13 23:59:29 +07:00
aleos89
bebfb06159 Follow up to f916504. Forgot to increase packet length. (bugreport:8745) 2014-03-13 11:23:03 -04:00
aleos89
165609d487 Fixed elemental reductions stacking to eventually cause 100% immunity. Thanks to Jey. (bugreport:8695) 2014-03-13 10:47:47 -04:00
Cydh Ramdh
0766c73229 Bug fixes
* Fixed wrong bonus for Max HP (bugreport:8679)
* HP/SP respawn (restart_hp_rate and restart_sp_rate) should be work now (bugreport:8642)
* Fixed MVP drop that failed to make random order (bugreport:8665)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-03-08 04:27:36 +07:00
aleos89
2dece5586d Bug Fixes
* Follow up to 2cd1e8c compile error. (bugreport:8733)
* Implemented official hiding effect for Feint Bomb. (bugreport:8346)
2014-03-07 15:51:16 -05:00
aleos89
2cd1e8c393 Bug Fixes
* Reverted a change made to Raising Dragon for HP/SP Regen.
* Fixed Rage Burst not consuming Rage Counters on use. (bugreport:7975)
2014-03-07 14:19:09 -05:00
aleos89
5aa2f17fc1 Bug Fixes
* Fixed Guild Auras applying to other guilds. (bugreport:7073) (Hercules 81caf70, 7fc0697, eb53067)
* Fixed wrong packet being used for storages on 20071002 and older clients.
2014-03-07 11:53:14 -05:00
aleos89
df1b99212b Bug Fixes
* Updated /stats+ to support 2013-12 and newer clients. (bugreport:8726) (Hercules 42b5c04)
* Guild auras will no longer be removed on Land Protector. (Hercules 186fbc5)
* Fixed the animation for logout. (Hercules 3f473c2)
2014-03-06 15:14:26 -05:00
aleos89
499010d34c Bug Fixes
* Fixed Gates of Hell range check. (bugreport:8680) (Hercules d554d61)
* Updated All Odin Power to official effects. (Hercules d554d61)
* Removed the range check from Hell Gate.
* Sorcerer Insignias are now disabled on Land Protector.
* Fixed Rush Windmill adding BATK rather than WATK.
2014-03-06 13:18:37 -05:00
aleos89
d010f67ac2 Bug Fixes
* Updated Sightrasher area to be 15x15. (bugreport:8701)
* Added missing accuracy decrease and Base Level damage modifier for Fatal Menace. (bugreport:8723)
* Warg Strike issues: (bugreport:8724)
-- Fixed Warg Strike not working while using Warg Ride.
-- Warg Strike is now a neutral element.
-- Warg Strike attack type is now a weapon.
-- Warg Strike will no longer ignore target's Flee.
* Warg Bite is now a neutral element.
2014-03-06 10:23:12 -05:00
aleos89
c547d24652 Follow up to f916504.
* Fixed a compile error.
2014-03-06 07:48:04 -05:00
aleos89
931f26065c Teleport and Map Warp Portals
- Added a battle_config to allow avoidance of Teleporting on top of Map Warp Portals. (bugreport:8584)
- Officially no one has been able to Teleport on top of a Map Warp Portal.
2014-03-05 15:31:31 -05:00
aleos89
f9165044ca VIP System Additions
* GM's (or group IDs > VIP group ID) will not be able to become VIP.
* Adjusted @whodrops and @mobinfo to account for VIP rates.
2014-03-05 10:45:53 -05:00
aleos89
f6cc486ab7 Bug Fixes
* Taekwon stances will now be removed on logout to prevent them being permanently on when a Taekwon is no longer ranked. (bugreport:8614)
* Added a battle config (taekwon_mission_mobname) for Taekwon Mission to check for kills based on monster names, off by default. (bugreport:8614) -- Credits to clydelion for the base.
* Removed a case that ignores damaging a target when they are on the same cell as the caster for Frost Nova. (bugreport:8705)
* Removed a skill unit check for Overbrand. (bugreport:8711)
2014-03-04 13:53:58 -05:00
Euphy
4a84de748c Merge pull request #49 from CairoLee/master
- Add instance_enter2 script command
2014-03-03 16:41:29 -05:00
aleos89
4534bd4b1d Follow up to 96c768f.
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Fixed Circling Nature HP regeneration formula. (bugreport:8670)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8715)
* Fixed Overbrand skill attack. (bugreport:8627)
2014-03-03 09:11:25 -05:00
Matej Pristak
d98cf33cbb oops, forgot one thing 2014-03-02 23:32:53 +01:00
Matej Pristak
a5b2b4ed49 temporary fix for vending items not saving correct cart ID > prompt player to relog if we have a new item in cart 2014-03-02 23:21:33 +01:00
Euphy
cad0a57865 Replaced 'getserverdef' command with 'script_hardcoded_constants' function in source. These constants can now be directly accessed in scripts. (Hercules 950e3eb)
- Relocated 'Option_*' constants from 'db/const.txt' to source; added OPTION_COSTUME compound. (Hercules a5728fd)
- Added MAX_CHAT_USERS define. (Hercules 950e3eb)
- Follow-up ca9642a: applied 'Loc' changes to Pre-Renewal database.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-01 15:42:49 -05:00
aleos89
96c768f9b7 Bug Fixes
* Fixed Severe Rainstorm damage formula. (bugreport:8581)
* Caster can no longer switch equips for the duration of Severe Rainstorm. (bugreport:8581)
* Cleaned up Demonic Fire and Fire Expansion combos. (bugreport:8620)
* Fixed Dragon Breath - Fire/Water damage formula and not being reduced by DEF or Flee. (bugreport:8620)
* Fixed the movement speed formula for Camouflage. (bugreport:8619)
* Fixed Overbrand Brandish area damage. (bugreport:8627)
* Fixed cast time for Magical Amplification.
* Fixed Moonlit Serenade MATK increase. (bugreport:8697)
* Fixed Phantom Thrust not casting. (bugreport:8652)
* Fixed Gentle Touch - Cure healing formula. (bugreport:8699)
* Fixed Wall of Thorns not dealing damage to players who touch it. (bugreport:8673)
* Fixed Flash Combo spirit sphere requirement. (bugreport:8286)
* Fixed Feint Bomb damage formula. (bugreport:8593)
* Fixed Circling Nature HP recovery and SP consumption being reversed. (bugreport:8670)
* Fixed Judex area of effect to be 3x3. (bugreport:8672)
* Fixed Abracadabra skill "Summon Monster" not displaying the monster's name. (bugreport:8671)
* Fixed Sight Blaster duration. (bugreport:8656)
* Fixed Ignition Break area of effect damage. (bugreport:8653)
* Fixed Poem of Netherworld not immobilizing enemies. (bugreport:8607)
* Fixed Rampage Blaster damage formula. (bugreport:8646)
* Adjusted Tiger Cannon damage formula and allow to bypass target's flee. (bugreport:8625)
* Fixed Self Destruction not working on self. (bugreport:8633)
* Fixed Repair not healing or consuming item requirements. (bugreport:8633)
* Fixed Silver Sniper and Magic Decoy AI types not being counted towards the land skill limit. (bugreport:8407)
* Fixed Silver Sniper bonus ATK formula.
* Fixed Magic Decoy maximum HP formula.
* Fixed Lion Howling damage formula. (bugreport:8654)
* Fixed Rapid Throw (Muchanage) damage formula. (bugreport:7861)
* Stasis no longer allows casting of Chorus skills.
* Fixed Chorus skills not checking for additional partners. (bugreport:6052)
* Body Paint no longer removes Chase Walk or Invisibility. (bugreport:6801)
* Recognized Spell is no longer cleared by Dispell or Abundance. (bugreport:6718)
* Epiclesis now removes Cloaking Exceed and will heal while in the Frenzy state. (bugreport:6679)
* Renovatio now heals while in the Frenzy state. (bugreport:6679)
* Fixed Firing Trap not having the fire element. (bugreport:8707)
* Fixed Icebound Trap not having the water element. (bugreport:8707)
* Fixed Axe Tornado not doing less damage for targets outside of the 5x5 area of effect.
* Updated the list of effects that Inspiration makes the caster immune to. (bugreport:5735)
* Cleaned up the effects of Vacuum Extreme to work as it should in GvG maps. (bugreport:6031)
* Corrected durations for Millennium Shield, Crush Strike, Refresh, and Weapon Crush.
2014-02-28 15:18:45 -05:00
Sean Allen
233d7aca0b Update script.c
- Update instance_enter DEF
- Remove instance_enter2 DEF
2014-02-24 03:14:19 +08:00
Sean Allen
d068dff52f Update script.c
- Update instance_enter
2014-02-24 03:10:36 +08:00
CairoLee
1f426bcb07 - Add instance_enter2 script command 2014-02-24 00:45:57 +08:00
Cydh Ramdh
072e98bdf2 Spiritball typo
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-23 19:17:11 +07:00
Cydh Ramdh
98f7a78133 int is too much for 'i' that limited to MAX_SKILL_LEVEL 100. :P
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-23 19:13:26 +07:00
Cydh Ramdh
992c382562 Updated documentation for spiritball script commands
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-23 19:05:16 +07:00
Cydh Ramdh
a607a42ea3 Merge branch 'rathena/master' 2014-02-20 10:45:49 +07:00
Cydh Ramdh
521104a282 * Fixed bugreport:8663 http://rathena.org/board/tracker/issue-8663-importjob-db1-errors/
* Follow up 8800f32

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-17 12:35:41 +07:00
Euphy
27a0f3f88e Added 'OnPCStatCalcEvent' trigger. (tid:77230, credits: @QQfoolsorellina, AnnieRuru)
This label triggers whenever a player's stats are recalculated.
http://rathena.org/board/topic/77230-onpcstatcalcevent/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-15 12:40:43 -05:00
Euphy
f3777cce0e Implemented @warp suggestions.
This will display map name suggestions when attempting to @warp to a non-existent map.
To enable, turn on 'feature.warp_suggestions' in 'conf/battle/feature.conf'.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-13 21:17:57 -05:00
Euphy
222b773c20 Added support for constants in NPC sprite IDs. (Hercules 124ab2a, e9b4aec)
Fixed some typos in source files.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-13 11:01:20 -05:00
Cydh Ramdh
01314ae5c5 * Fixed bugreport:8632 http://rathena.org/board/tracker/issue-8632-map-server-crash/
* Revert mvptomb_destroy changes at 5988c7a, bugreport:8634 http://rathena.org/board/tracker/issue-8634-memory-issues-with-update-consistent-and-persistent-lag/
* Fixed bugreport:8640 http://rathena.org/board/tracker/issue-8640-bonus-baddmonsteriddropitem/

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-13 11:39:42 +07:00
Euphy
877af1cfab Added optional 'dragon color' parameter to @mount. (tid:79844)
http://rathena.org/board/topic/79844-mount/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-11 22:53:17 -05:00
Euphy
eba153919e Added script command 'getguildmember', similar to 'getpartymember'. (tid:78308, credits: AnnieRuru, GodLesZ)
http://rathena.org/board/topic/78308-getguildmember/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-11 15:12:47 -05:00
Euphy
a2d095f5c4 Item database update.
- Added/edited itemscripts for some new items.
- Corrected the persistence of many Hit- and Flee-increasing consumables, as they should dispel upon death. (incl. bugreport:8626)
http://rathena.org/board/tracker/issue-8626-accuracy-30-scroll-effect-when-death/

Hercules merges:
- Added optional 'count' parameter to script command 'successrefitem'. (9d1f80e)
- Atcommand bindings are now case-insensitive, like normal atcommands. (92be98c)
- Consumables without expire time no longer stack with rental items. (afcb4bc, bugreport:8458)
http://rathena.org/board/tracker/issue-8458-rent-item-bug/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-10 16:13:53 -05:00
Cydh Ramdh
842e35c293 Merge branch 'rathena/master'
Conflicts:
	src/map/script.c
2014-02-10 19:05:45 +07:00
Euphy
de46393592 Improved 'client_hash_check' config. (Hercules e4a1ca2)
- Added option to disable hash check by GM group_id (specify 'disabled' as hash for a certain group_id to let them log in with any client, even if 'client_hash_check' is enabled.
- Updated and reworded related documentation for the feature.

Improvements on script command 'axtoi'; added 'strtol'. (Hercules 1cf7c1e)
- Added script command 'strtol' (conforming to the ISO C90 function).
- Modified script command 'axtoi' to internally use 'strtol' instead of an unnecessary separate implementation.

Cleaned up many sections of script documentation, and modernized syntax in examples.
Added documentation for 'rentitem2' and 'makeitem2'. (follow-up 339c0a8)

Added 'true' (1) and 'false' (2) as script constants.

'freeloop' argument is now optional, and will only return the value of freeloop if no argument is given. (tid:92470)
http://rathena.org/board/topic/92470-freeloop-optional-argument/

Added a missing mapflag to custom 'devil_square' script. (bugreport:8611)
http://rathena.org/board/tracker/issue-8611-devil-square-bug/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-08 15:32:28 -05:00
Cydh Ramdh
339c0a8c48 * Added script commands2, rentitem2 and makeitem2, suggestion http://rathena.org/board/topic/90918-emistrys-rentitem2-be-added-to-svn/
-- *rentitem2 <item id>,<time>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
-- *rentitem2 "<item name>",<time>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
-- from http://www.eathena.ws/board/index.php?showtopic=241313&view=findpost&p=1315831
-- *makeitem2 <item id>,<amount>,"<map name>",<X>,<Y>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
-- *makeitem2 "<item name>",<amount>,"<map name>",<X>,<Y>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
-- Credits for the script author(s) & contributor(s)
-- NOTE: I didn't make the documentation yet
* Follow up 3441d4a

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-08 16:34:55 +07:00
Cydh Ramdh
3fce137cbb Follow up 4019fb4
- Wrong macro for itemdb_is_element, thx @exneval
- Incompatible type issue on UNT_BANDING. bugreport:8616 http://rathena.org/board/tracker/issue-8616-error-while-recompiling/
- Skill usage messages ot conf/msg_conf/map_msg.conf instead following official client fail message by clif_skill_fail() for each failure. (related with skill_require_db.txt)
--> "%s is required." (similar: 28 messages)
-->"[%s] Poison effect was applied to the weapon." (similar: 8 messages)
-->"Please equipped with a %s." (similar: 7 messages)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-07 09:54:59 +07:00
aleos89
4019fb4531 Bug Fixes
* Dragon Breath (Fire and Water) are no longer reduced by DEF or Flee. (bugreport:8378)
* Crush Strike no longer ignores caster's % damage cards.
* Phantom Thrust is now single enemy targetable.
* Fixed Gates of Hell SP cost, range, and sphere cost. (bugreport:7898)
* Cleaned up Tiger Cannon splash damage and remaining HP/SP consumption. (bugreport:8538)
* Fixed Rising Dragon HP/SP regen to work with Spiritual Cadence.
* Corrected Magic Decoy item requirement define not checking for PTS.
* Poem of Netherworld now targets everyone except party members. (bugreport:7741)
* Adjusted a couple skills that have infinite timers to not displays negative time to the client. (bugreport:8549)
* Fixed Sorcerer's Spirit max HP formula. (bugreport:8315)
* Fixed Banding not giving the Overawe effect. (bugreport:7641)
* Fixed Weapon Crush not casting at all. (bugreport:8583)
* Fixed Demonic Fire damage formulas from Fire Expansion.
* Fixed Fire Expansion - Smoke Powder not giving ranged and melee damage reduction. (bugreport:7841)
* Fixed Fire Expansion - Tear Gas not draining HP and not displaying the /cry emoticon. (bugreport:7841)
* Fixed Issen (Killing Stroke) damage formula for pre-renewal. (bugreport:4071)
* Adjusted Warg Strike to be a misc type attack and ignore target's Flee. (bugreport:7599)
* Updated Throw Kunai damage formulas for renewal and pre-renewal. (bugreport:7119)
* Severe Rainstorm is no longer castable on Land Protector. (bugreport:7097)
* Fixed Tropic, Chilly Air, Wild Storm, and Upheaval options not casting their specific autocast skills.
* Updated Fire Cloak, Water Drop, Wind Curtain, and Stone Shield to 100% property resistance and damage.
* Updated Heater, Cooler, Blast, and Cursed Soil damage formulas.
* Increased SP cost of Psychic Wave when Heater, Cooler, Blast, or Cursed Soil are active.
* Updated Zephyr Flee increase bonus.
* Fixed Elemental HP and ATK2 formulas.
* Fixed Sienna Execrate not consuming 2 Red Gemstones. (bugreport:7494)
* Fixed Shadow Chaser's Masquerade skills success rate formula. (bugreport:7436)
* Fixed Exceed Break to restore walk speed when cast is cancelled. (bugreport:7681)
* Vacuum Extreme no longer affects users who are in Hallucination Walk.
* Fixed Hallucination Walk missing magic avoidance.
* Adjusted Lif's Mental Change skill duration to 1 minute, 3 minutes, and 5 minutes respectively per level.
* Hovering will now specifically ignore Skid Trap, Land Mine, Ankle Snare, Flasher, Shockwave Trap, Sandman, Freezing Trap, Blast Mine, Claymore Trap , Quagmire, Gravitation Field, Volcano, Deluge, Whirlwind, Watery Evasion, Electric Walk, Fire Walk, Vacuum Extreme, Windmill, and Moon Slasher. (bugreport:7179)
* Raging Trifecta will now display an animation on usage. (bugreport:1307)
* Cleaned up Auto Shadow Spell check for the specific skills it can cast. (bugreport:8582)
2014-02-06 13:34:39 -05:00
Lemongrass3110
27d270d641 Character deletion fix
Fixed a problem where the client froze in a "Please wait" state because it got a packet it was not meant to get.
Also fixed wrong deletion times.

Fixes:
http://rathena.org/board/tracker/issue-8456-delete-character-delay-bug/
http://rathena.org/board/tracker/issue-8601-character-deletion-bug/
http://rathena.org/board/tracker/issue-8399-character-deletion-bug/

Minor follow up to 996ee3d:
Forgotten import, which got ignored by Visual Studio.
2014-02-06 11:08:30 +01:00
Lemongrass3110
996ee3d4e9 Buyingstore persistency Beta
Changed the loading process to clean up if there are some leftovers(corrupt tables).

Modified the loading query to also take in the zeny limit as criteria, since it would not make sense to set up an autotrader that already has reached his limit(this case should not be possible, if you do not modify the values in your MySQL table by hand).

Enjoy and do not forget to run the upgrade .sql files.
2014-02-06 09:56:00 +01:00
Lemongrass3110
ff9b6253c2 Minor bug fix
If a player did not meet the requirements to reopen the buyingstore/vending for whatever reason the character is now set offline.

A possible examples I have tested with is to change the area where the player's shop was to novending, which will not allow him to open the shop in this area.
2014-02-06 09:56:00 +01:00
Lemongrass3110
b3506fb8f5 Buyingstore persistency
Basic features of @autotrade persistency now also available for buyingstores.
2014-02-06 09:55:59 +01:00
Cydh Ramdh
a862051cd3 * Follow up c1871e9,3181ff6. Moved vip base and job exp bonus calculation to the pc_calcexp with another exp bonus
* Follow up 3441d4a

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 23:39:22 +07:00
Cydh Ramdh
3441d4a30b * Updated/added item_db, thank https://github.com/ROClientSide/Translation for some item view ids
* Follow up 0724d1e
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 19:07:05 +07:00
Cydh Ramdh
b4bdaebeeb * Replaced INF2_NO_AUTOSHADOWSPELL with INF2_AUTOSHADOWSPELL following AEGIS standard, reverted c9cf222.
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn/
* Removed temporary array while parsing shop NPC, makes remove the limit 100 items each NPC
* Added idRO cash trader according to Chinese New Year event

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-04 12:32:38 +07:00
Cydh Ramdh
96a7e476f5 Fixed bugreport:8599 http://rathena.org/board/tracker/issue-8599-about-his-items-the-ig-thing/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-03 21:45:57 +07:00
Cydh Ramdh
fb42cbf073 * Follow up 96443cd, fixed wrong type for base sp calculation when dividing sp_factor also as fix of bugreport:8450 (http://rathena.org/board/tracker/issue-8450-max-sp-wrong-bug-in-pre-re%EF%BC%81/)
* Follow up 26025e6, wrong path. Fixed bugreport:8594 (http://rathena.org/board/tracker/issue-8594-too-many-columns-in-job-db1txt/)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-03 19:45:15 +07:00
Cydh Ramdh
c9cf2228a3 * Added skill INF2_NO_AUTOSHADOWSPELL for some skills that cannot be auto casted by Auto Shadow Spell as fix of bugreport:8582, http://rathena.org/board/tracker/issue-8582-shadow-chaserauto-shadow-spell-restricted-spells/
* Removed unused const.txt entries as fix of bugreport:8467, http://rathena.org/board/tracker/issue-8467-left-over-constants-from-mob-controller-system/

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-03 01:17:28 +07:00