4932 Commits

Author SHA1 Message Date
ai4rei
63321f205e * Moved script constant manipulation code into separate functions script_get_constant / script_set_constant. [Ai4rei]
- Added protection against overwriting existing names in script constant creation code.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 10:43:51 +00:00
ai4rei
da989bb356 * Added support for new delayed character deletion.
- Asks for birth date associated with the account and has a waiting time of 24 hours by default (setting).
- For SQL apply upgrade_svn14700.sql to upgrade table `char`; for TXT no action is necessary, as it upgrades itself.
- This completes support for clients 2010-08-03aRagexeRE and later.
* Updated login sql engine version, missed during `birthdate` addition (follow up to r14672).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14700 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 02:36:43 +00:00
ai4rei
4592b9832d * Updates to various client packets.
- Renamed clif_set0199 and clif_send0199 to clif_map_property and clif_map_property_mapall respectively and added an enumeration for currently known map properties.
- Renamed clif_set01D6 to clif_map_type and added an enumeration for currently known map types.
- Resolved undocumented field of packet 0x22e (ZC_PROPERTY_HOMUN) to attack range.
- Fixed aspd field of packet 0xbd (ZC_STATUS) getting filled with karma value.
- Removed commented clif_skillinfo (duplicate of clif_item_skill).
- Other minor comment updates and 'FIXME' assignments.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14698 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 00:37:33 +00:00
ai4rei
bc2ec92a4a * Replaced 'nameid < 500' checks in script commands 'countitem', 'countitem2' and 'autoequip' with stricter ones.
- This should stop meaningless itemdb_search warnings from said commands when an invalid item id is used.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14696 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 12:18:46 +00:00
ai4rei
1bb6a3d506 * Fixed NPCs with closing parenthesis in their name could not be duplicated (bugreport:3235).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:45:10 +00:00
ai4rei
0045508031 * Fixed closing 'switch' curly not causing script EOL processing to trigger, leading to the script line after the switch being handled as belonging to the curly-less statement block (bugreport:3273, since r3422).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14694 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:02:57 +00:00
ai4rei
8dc5d7029c * Fixed non-windows 'findfile' utils function missing a 'closedir' call (bugreport:4739, since r1629).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14692 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-02 20:00:12 +00:00
ai4rei
2bc3dafd59 * Inventory and Cart item arrays are no longer getting compacted on each log-in/teleport/warp.
- This also resolves yet another issue caused by r14685 (bugreport:2604).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14691 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 20:40:16 +00:00
ai4rei
7557d37013 * Various accumulated cleanups and fixes.
- Improved the compile speed for files which include common/socket.h on windows builds (related r10471).
- Moved FIFOSIZE_SERVERLINK define from common/mmo.h to common/socket.h (since it is a server connection FIFO size setting).
- Fixed script command 'areamobuseskill' canceling monster's skill cast before it determined it's new target, which could be 'none' (bugreport:3272, since r13897).
- Added a protection against attempts to read an empty backup / write to a full backup in skill_dance_switch as per TODO from r11347.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14690 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 12:39:54 +00:00
ai4rei
8fb6c1f646 * Fixed faulty WFIFO reallocation causing memory exhaustion (bugreport:4737, since r1816, related r11503, r11571, r11886 and r12232).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14689 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 11:30:57 +00:00
ai4rei
9492535e65 * Fixed equipped items' bonus no longer working after log-in until next status recalc, due to missing pc_setequipindex which was previously called by pc_checkitem (bugreport:2604, since r14685).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-30 21:36:11 +00:00
ai4rei
884cb80892 * Removed @aw/@away which duplicates and collides with client's /am (away message) (bugreport:1235, topic:163083, since r4351).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14686 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-29 11:30:24 +00:00
ai4rei
342f5db18c * Fixed a map-server crash when invalid items are deleted (option 'item_check') from a logging-in character (bugreport:2604).
- This removes the pc_checkitem call from pc_authok, as the check is done in clif_parse_LoadEndAck as well, after first status calc has taken place.
- Inventory list is now sent before pc_checkitem in clif_parse_LoadEndAck, so that deleted items do not show up as 'unknown item'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14685 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-29 10:46:01 +00:00
ai4rei
b3efe1d8b4 * Fixed @accept not checking, whether or not a duel is already full (bugreport:2740, since r4111).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14684 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-28 02:20:13 +00:00
ai4rei
7a85df4fe0 * Resolving allow/deny IP rules not working (bugreport:2632).
- Fixed 'mask' being filled with 'ip' when standard mask was specified (since r9647).
- Fixed 'ip' and 'mask' (bit mask) being stored in wrong byte order (network order instead of host order) (since r10162).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14683 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-28 01:38:33 +00:00
ai4rei
0f1c66191c * Fixed buyers, that are currently in a vending shop could be fooled into buying an item at different price than they see by reopening the vending shop (bugreport:4728).
- This implements the official vending shop unique id handling (previously mistaken for char id), made compatible with packets before it's introduction (follow up to r14234).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14682 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-26 11:52:44 +00:00
ai4rei
dd4a090c69 * Some cleaning here and there.
- Fixed a typo in basejob_baseclass_upper sample script (since r3893).
- Fixed (for sake of consistency) usage of 'sd' before corresponding nullpo check in party_invite (bugreport:2752).
- Fixed atcommand config reading would not cap level for charcommands, when using atcommand level as fallback (bugreport:2961, since r13409).
- Removed orphaned clif_mob_hp declaration from clif.h (bugreport:2788, since r2092).
- Removed unnecessary look-up in itemdb_available macro, as dummy_item is considered unavailable.
- Removed leftover shortlist linked-list struct (followup to r10507).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14680 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-23 18:07:00 +00:00
ai4rei
639bafa88e * Fixed solo dance/star gladiator warm AoE no longer following the owner and cloaking wall rules no longer working (bugreport:4720, since r14671).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14677 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-19 21:13:59 +00:00
ai4rei
178cc183ab * Fixed a map-server crash, when a script attempts to call a local function, which has only a forward declaration. Such functions now count as script parse error (bugreport:4009, since r3422).
* Fixed definitions of local functions would set a label reference, even when their name was already taken (follow up to r14600, since r3422).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14675 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-16 12:51:27 +00:00
ai4rei
a4b7cce2c5 * Various accumulated insignificant fixes to documentation, examples and comments.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14674 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-15 20:12:51 +00:00
ai4rei
7919c7d9fc * Added 'birthdate' field to account data. For SQL apply upgrade_svn14672.sql to upgrade table login; for TXT no action is necessary, as it upgrades itself.
- Control panel developers are encouraged to enable players to modify this value, as it is required for new character deletion (2010-08-03aRagexeRE and later, not yet implemented).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14672 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 23:38:31 +00:00
ai4rei
a7810e9646 * Removed unconditional redundant status change checks before status_change_end calls (follow up to r12890).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14671 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 22:04:20 +00:00
ai4rei
ad4e9bbee1 * Replaced remaining occurences of '-1' with 'INVALID_TIMER', where appropriate (follow up to r12998).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 21:00:38 +00:00
ai4rei
47ca51f9e2 * Removed 'gui' plug-in (support plug-in for 3rd party eAthena GUI front-ends) (topic:262934).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14669 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 12:22:12 +00:00
ai4rei
0204e9c914 * Fixed mapflags 'restricted', 'nocommand', 'bexp' and 'jexp' still not getting completely initialized upon @reloadscript (bugreport:4710, follow up to r14548).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14668 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 20:09:22 +00:00
ai4rei
3e4934d780 * Removed ladmin (remote administration tool), all related support code and the checkversion.pl tool with it's support code, which was shared with ladmin (topic:262934, related bugreport:1147, bugreport:1889, r9408 and r9610).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14667 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 11:42:12 +00:00
ai4rei
43ce11026b * Fixed chrif-packet processing considering free/unused packet IDs incorrectly as variable length packets (-1 = variable length, 0 = disabled packet).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14666 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 11:10:23 +00:00
ai4rei
ba5d1ec3ac * Added support for creating account through the console-plugin on login-server (replaces ladmin functionality unavailable through atcommands).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14665 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 10:27:17 +00:00
ai4rei
4f517e1ebb * Reformatting and minor cleanups to console-plugin related code.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14664 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 09:34:49 +00:00
ai4rei
825df9dda1 * Fixed script command 'cleararray' setting 1 element more, than it is told to (bugreport:2047, since r12253).
- Fixed 'inaccessible element 127' issue in 'cleararray', 'setarray' (since r10813) and 'copyarray' (since r14608) script commands (bugreport:864, related r12253, follow up to r14608).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14663 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 20:45:18 +00:00
ai4rei
5a2da0f184 * Fixed monster level not getting updated in monster name (option 'show_mob_info'), when a monster levels up (option 'mobs_level_up') (follow up to r8644, related r187).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14662 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 10:17:52 +00:00
ai4rei
4cd68d40e1 * Made script command 'charisalpha' always return 1 when 'isaplha' is true, rather than to return the return value of 'isalpha' which is only defined as zero/non-zero and can be different from 1 (bugreport:2024, related r2003).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14661 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 09:56:19 +00:00
ai4rei
ab332bd663 * Fixed packet_len entry for packet 0x289 (ZC_PC_CASH_POINT_UPDATE) not matching the actual size used in clif_cashshop_ack (bugreport:4701, since r14639, follow up to r12264).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14660 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-09 16:37:43 +00:00
ai4rei
5f93676dea * Fixed script command 'progressbar' resuming fails on second invocation, when there was no script pause between the first and second call (bugreport:4698, since r14024).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14659 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:28:41 +00:00
ai4rei
c8f5056a4a * Fixed kill steal protection result in skill casting (unit_skilluse_id2) not getting evaluated (bugreport:1808, since r12203).
- Moved kill steal protection in skill casting to be only executed, after the actual target has been determined and validated (since r12203).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14658 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:25:59 +00:00
ai4rei
bc191110f2 * Applied fix provided by Valaris to make /pvpinfo actually work. (bugreport:1785, since r1602).
- Filled-in missing packet fields and documented the packet. Note, that this command does not show anything outside of PvP maps (client-side limitation).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14657 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:19:07 +00:00
ai4rei
f543097124 * Fixed @homlevel usage message stating, that deleveling is possible, although it is not (bugreport:1485, since r10272).
- The command now fails, if it is given a zero or negative value.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14656 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:05:13 +00:00
brianluau
6db17907b0 - Removed extra slashes in item_db.txt (bugreport:4686)
- Removed punctuation from Time2Str script function.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14655 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 08:55:02 +00:00
ai4rei
b7ab5cac1d * Fixed @alootid using 'autolootitem' (internal name) in it's usage message (bugreport:1445, since r12203).
- Reworded the turn off message of @alootid.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14654 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-07 22:06:07 +00:00
ai4rei
7c8ea87859 * Fixed script command 'deletearray' deleting incorrect amount of array elements from arrays with empty elements (bugreport:4628).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14652 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-06 06:00:30 +00:00
ai4rei
03933a951b * Fixed ends of statement blocks missing script EOL processing, thus causing 'next line' label (-) to misbehave in statement blocks without additional curly braces (bugreport:4417, since r3422).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14651 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-05 10:37:25 +00:00
ai4rei
2cfd322c38 * Added support for removal of trailing comments to sv_readdb (bugreport:4680).
- Disabled monster BACSOJIN_T (1996) whose drop White Snake Hat (5411) is not enabled (was hidden by '//', which would cause errors now) (since r14412).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14649 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-04 18:59:50 +00:00
ai4rei
7eae5b9381 * Fixed local files could not be aliased with resnametable.txt in grfio (bugreport:2203, since r5152).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14648 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-02 00:20:51 +00:00
ai4rei
630a5810e9 * Cleanups to grfio.
- Replaced strncpy with safestrncpy (bugreport:3080).
- Ensured, that all local paths are normalized and work whether or not the data dir ends with '/'.
- Local files are no longer added to the GRF+alias file list (apparently served to cache file size, with no performance gain).
- Buffer for files is no longer allocated with 1024 extra bytes, but only 1 for zero-termination of text files.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14647 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-02 00:07:58 +00:00
ai4rei
0a86d090c1 * Updates to map cache generator tool.
- Removed unmaintained grfio library copy and made the tool use the one in /common instead (related r12726).
- Updated makefile to use compile options/libraries determined by configure (bugreport:1109).
- Fixed error messages from the tool and grfio library overlapping each other (bugreport:2403).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14646 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-01 20:43:02 +00:00
ai4rei
bf53c4e2a8 * Pending trade requests no longer prevent a character from trading someone else instead (official).
- This fixes trade window displaying wrong name when attempting to deal multiple characters (bugreport:344).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14645 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-01 01:05:32 +00:00
ai4rei
75ca2f146a * Fixed improper use of itemdb_search. It does not return NULL but a dummy item, if the item id is invalid.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14642 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-30 17:23:54 +00:00
ai4rei
ad0f39a6ec * Made remaining csv databases (guild, castle, homunculus, itemdb, mercenary) use sv_readdb, where applicable (follow up to r14524, r14526 and r14532).
- Few databases remain unchanged, which have either a custom layout or are otherwise incompatible with sv_readdb.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14640 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-30 01:25:19 +00:00
ai4rei
33d2446b11 * Collection of random insignificant changes.
- Added progress indication on map-server shutdown when objects are removed from maps, as it takes significant amount of time to complete.
- Moved ers_free in db_obj_vclear, so that the node pointer is not used for comparison after it has been freed.
- Some documentation of shop packets.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14639 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-29 21:31:36 +00:00
ai4rei
73ea4abec4 * Fixed 'console' plugin not working on Windows, due to NULL passed to CreateThread instead of required pointer to thread id variable.
- Fixed 'console' plugin causing delete_timer error when it fails to load, due to uninitialized variable.
* Renamed plugin.def to sample.def and added 'sample' plugin exports into it, as it's purpose is nothing than a sample right now.
- Also added .def files for 'gui' and 'pid' plugins as MSVC does not export everything automatically and missing event export cause the plugins silently failing.
- Added VS6, VS8 and VS9 projects for compiling plug-ins, which can be used on Windows.
* The plug-in system will now report, if it cannot import an event function.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14638 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-29 05:14:16 +00:00