Commit Graph

1416 Commits

Author SHA1 Message Date
Cydh Ramdh
fd1b360c93 Merge pull request #896 from rathena/hotfix/issue779
Fixed #779 
* Fixed 'Elemental Resistance Potions' doesn't work without changing any equipment.
* Moved player's Elemental resistance & attack bonus from status_calc_pc_ that need SCB_BASE to status_calc_atk_ele_pc and status_calc_def_ele_pc as a child of SCB_ATK_ELE and SCB_DEF_ELE (doesn't need to calculate everything just for these points)
2016-01-27 12:37:09 +07:00
Cydh Ramdh
7426c4bf2f Merge pull request #891 from rathena/hotfix/issue879
* Fixed #879. Added check while equipping Gun-type weapon X Ammo (bullets and grenades).
* Fixed Gunslinger's Spread Shot can be used by equipping Shotgun + Bullet or Grenade Launcher + Grenade.
2016-01-25 10:43:25 +07:00
Napster
d70b1734c8 Add support body style implementation
* This feature require the client support before 2015-05-13 or newer
   Make sure you data&lub support for this

  note : read info to https://rathena.org/board/topic/104205-2015-client-support/

  Special Thanks you to Rytech, @aleos89
2016-01-12 01:55:30 +07:00
Cydh Ramdh
0ffbc20fd4 Follow up c699304bd9, removed redundant check. Thank @Lemongrass3110
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-07 06:18:38 +07:00
Cydh Ramdh
c699304bd9 Gunslinger Fixes
* Fixed #879. Added check while equiping Gun-type weapon X Ammo (bullets and grenades).
* Fixed Gunslinger's Spread Shot can be used by equipping Shotgun + Bullet or Grenade Launcher + Grenade.
* Fixed Gunslinger's Mine (Ground Drift) must cannot be casted on target's foot and must cannot be stacked.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-07 00:54:57 +07:00
Lemongrass3110
d32c857e16 Renamed custome headgear constans in src
They now match with those currently used in scripts and also match the ones for normal headgears and additionally they are easier to understand.
2016-01-06 00:08:27 +01:00
aleos89
27e90f8f45 Fixed #828
* Resolves required equipment check needing all equipment given to be equipped rather than just one. Thanks to @Paoly28.
2015-12-11 08:47:32 -05:00
aleos89
b0e289fbf3 Follow up to 89a33a7
* Added missing status change defines to const database.
* Updated documentation for bSateNoRecoverRace.
2015-12-10 11:36:13 -05:00
Cydh Ramdh
7489fab958 Spaces cleanup follow up 2b5332a3b1
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-12-09 20:17:20 +07:00
Cydh Ramdh
96119fb1d0 Follow up c4fe3be0a1
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-12-09 19:42:01 +07:00
Cydh Ramdh
241e10b92c Follow up 89a33a77ad
* Corrected documentaion of `bStateNoRecoverRace`
* Added `bStateNoRecoverRace` to const.txt

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-12-09 05:26:18 +07:00
aleos89
89a33a77ad Updated Genetic Sling Item effects
* Moved all item effects to source.
* Updated HP/SP Increase Potions to use the official statuses.
* Updated Vellum Flail to use the official status instead of Critical Wound.
Thanks to @exneval.
2015-12-08 14:38:55 -05:00
aleos89
523cb145f5 Follow up to a7b8fd4
* Resolves a check for skills that have required equipment items to check for all items in the list.
* Fixes #782 - Removed renewal items from pre-renewal skill requirements for 3rd classes.
2015-12-03 11:20:12 -05:00
Atemo
c3125026d2 Merge branch 'master' into academie 2015-11-29 16:03:09 +01:00
Atemo
3e7b90d8cb Coquille 2015-11-29 16:00:17 +01:00
Lemongrass3110
86d6113801 VS 2015 support(commit 4/4)
Fixed all compiler warnings for the default settings(defines). There might be a lot with different packetversions or other setings. Feel free to create a issue on github if you find any.
2015-11-29 14:23:21 +01:00
Atemo
c3e56b9c1b Update 2015-11-26 23:11:22 +01:00
Atemo
9b13351817 Merge branch 'master' into academie 2015-11-24 18:01:09 +01:00
icxbb-xx
8c6b720e8f Fixed #767
- Visuals effect from headgear not remove when rent of item expire
* Thank you to @admkakaroto
2015-11-20 12:39:27 +07:00
lighta
65b6861e84 Small cleanup
And updata mapcache to use DBPATH instead rechecking RENEWAL macro,
(code duplication)
Make mapcache use cli.o to give some feedback on arguments given.
2015-11-18 06:34:14 -05:00
lighta
8703eacfe4 Merge branch 'academie' of https://github.com/rathena/rathena into academie 2015-11-17 22:19:38 -05:00
Atemo
1e80d1b720 Removed comment and corrected typo 2015-11-18 03:36:37 +01:00
lighta
4342221a1e Follow up a7b8fd4a5d
Fix an invalid check on skill_parse_row_requiredb() for EQUIP_REQUIRE
Fix itemdb_group_free call in itemdb_read_itemgroup_sub using real
va_list, (preventing compilation on ARM)
Add some notes.
2015-11-17 00:21:05 -05:00
Atemo
cc8edaaac6 Merged novice academie from Hercules 21564acf13
-> All Credit to Kisuka for this big work.

Added news commands to alter questinfo conditions :
- setquestinfo_level : Add level range criteria for quest info with quest id 'quest_id'.
- setquestinfo_req : Add quest requirement for quest info with quest id 'quest_id'.
   -> Player have / doesn't have the required quest.
- setquestinfo_job : To add additionnal job criteria.
-> Credit to Cydh !
2015-11-16 00:34:00 +01:00
lighta
09ddcdfe2a Merge pull request #731 from lighta/master
Type enforcement
2015-11-15 19:14:39 -04:00
aleos89
10fcd20fa8 Renewal Skill Cast Formula Fixes
* Resolves several issues with renewal cast times. Includes fixes for for items and skills that grant additions/reductions to cast time.
* Fixes #549
* Fixes #592
* Fixes #657
-- Thanks to @exneval.
2015-11-09 11:03:29 -05:00
lighta
46d417a458 merge master into cppcheck 2015-10-30 02:48:40 -04:00
aleos89
dc533fe2e1 Core Cleanup
* Removed a useless parameter from elemental_delete().
2015-10-29 17:45:30 -04:00
Cydh Ramdh
055f6d86a2 Follow up 214ff17c19, fixed errors and warnings in MSVS
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-21 20:29:46 +07:00
lighta
214ff17c19 Replace macro max and min, by some inline functions :
-To avoid having long operation repeated twice, peoples shouldn'tuse long operation into does macro but they do so...
-To avoid double increment or thing like such.
-Yes this involve some implicite cast sometime, but that still better then redo 10 dereference...
2015-10-21 04:12:01 -04:00
Cydh Ramdh
857b82d6ee Fixed #635, thank @julia40124009.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-11 20:50:45 +07:00
Cydh Ramdh
927d1e2f5c * Fixed #629. Thank @anacondaqq and @theultramage
* Added optional param `char_id` for `instance_enter`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-10 19:04:15 +07:00
Cydh Ramdh
fd7d6c31fd Follow up 99783689, typos. Thank @WhySoSexyMate
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-08 15:41:33 +07:00
Lemongrass3110
a597e7bd34 Some more pointer casts and enum fixes. 2015-10-03 01:46:47 +02:00
Cydh Ramdh
e112fc1c50 Fixed #647. Fail to get parameter value from readparam if the parameter given is constant as param-type value. So for an example, readparam(BaseLevel) will be fine now, the result same as like BaseLevel itself.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-27 21:44:54 +07:00
Napster
e56f329d5d Follow up fa40773 :
* Revert change some code
2015-09-13 08:48:53 +07:00
Napster
93666ce79a Follow up fa40773 :
* Fixed compile warning.
2015-09-12 22:40:43 +07:00
Napster
fa40773e82 * Fixed #630 Cart is not showing. 2015-09-12 21:51:03 +07:00
Cydh Ramdh
997836897f Follow up 43068e1777:
* Eff_Crystalize on Sropho_Card (4522) has defined duration.
* Bonus added:
  * `bonus4 bAddEff,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when attacking
    * Just like `bonus3 bAddEff,eff,n,y;` but with user-defined duration;
  * `bonus4 bAddEffWhenHit,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when being hit by physical damage
    * Just like `bonus3 bAddEffWhenHit,eff,n,y;` but with user-defined duration;
  * bonus5 bAddEffOnSkill,sk,eff,n,y,t;
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when using skill sk
    * Just like `bonus4 bAddEffOnSkill,sk,eff,n,y;` but with user-defined duration;

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-05 08:19:23 +07:00
Cydh Ramdh
4a55439550 * Typo in const.txt for SC with ID 608, SC_HASTEATTACK_CASH -> SC_ATTHASTE_CASH.
* Move 'dummy' skill lookup to `skill_dummy2skill_id` so can be used for item bonus for revelant skill.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-02 23:02:13 +07:00
Aleos
6295c77d39 Merge pull request #457 from rathena/feature/script_engine_upgrade
Script Engine Upgrade
* More information here: https://rathena.org/board/topic/102946-script-engine-upgrade/
2015-08-31 14:26:15 -04:00
aleos89
eb0a79f1bf Bug Fixes
* Fixes #587 - Corrected Amistr Defence to properly calculate VIT for renewal and DEF for pre-renewal.
* Fixes #588 - Fixed skills not being properly removed when being copied by Plagiarism or Reproduce.
* Fixes #589 - Blessing no longer gives stat bonuses when Curse is active.
* Fixes #599 - Fixed a possible crash by Praefatio.
* Fixes #601 - Exceed Break now cancels when switching weapons and is properly removed on misses.
2015-08-28 15:05:24 -04:00
aleos89
9738c825cc Follow up to f53916e
* Fixed remaining memory leak.
* Cleaned up and optimized a few more ERS allocations.
2015-08-25 10:31:38 -04:00
aleos89
d95f5d2db7 Bug Fixes
* Fixes #447 - Added script command 'unitblockmove' to be used with OnTouch and Unit Commands.
* Fixes #448 - Leech End will no longer get a player stuck in stand/sit modes.
* Fixes #503 - Added script command 'ignoretimeout' which disables the SECURE_NPCTIMEOUT of a specific script.
* Fixes #521 - Pre-renewal Shield Chain should always be Neutral damage.
* Fixes #532 - Fixed an issue with the 'item_check' config not saving the unique ID when enabled.
* Fixes #537 - Arms Cannon is now a single unit target skill.
* Fixes #541 - Cleaned up Ignition Break damage formula.
* Fixes #543 and Fixes #552 - Cleaned up Reverberation to match official. Now splits damage among targets.
* Fixes #546 - Updated Randomize Spell to the latest official skill list and rates.
* Fixes #547 - Escape is now a self skill and can use normal Traps if no Alloy Traps are available.
* Fixes #551 - Great Echo and Sound of Destruction can now blocked by Pneuma.
* Fixes #556 - Adjusted Arrullo, Deep Sleep Lullaby, Netherworld, and Voice of Siren duration formulas to properly account base/job levels.
* Fixes #561 - Pre-renewal Tiger Cannon now properly removes HP when casting skill.
* Fixes #576 - Shield Spell, Exceed Break, Overbrand, Moon Slasher, Piety, Earth Drive, and Hesperuslit no longer have fixed cast time.
* Cleaned up Shadow Formation SP Drain formula to be 11-skill_lv per second.
* Sound of Destruction is now a placement skill type.
* Updated variable cast time for Windmill Rush from 2 seconds to 1 second.
2015-08-17 14:13:22 -04:00
Cydh Ramdh
c0e4b06005 Implemented 'Broadcast Obtain Special Item'
* Added flag &16 to add manually special item that will be broadcasted if: Dropped by monster -> player pick it up. Added items with this flag:
  * Gold_Key77 (7782)
  * Silver_Key77 (7783)
* Be used also to broadcast item in package/group with flag 'isAnnounced', replaced intif_broadcast().
* The message is using msgstringtable.txt on client side, make sure your translation is not messy.
* Credits:
  * fcba8a2161
  * 2761bb0af9

* Misc updates: Fixed job and class for items:
  * Sealed_Gloom_Under_Night_Gachapon (14696)
  * Sealed_General_Egnigem_Cenia_Scroll (14739)
  * Sealed_Vesper_Scroll (14740)
  * Midgard_Celebration_Lucky_Egg (14741)
  * Hero_Midgard_Egg (14753)
  * Safe_To_Smelting_Scroll (14758)
  * Limited_Edition_JOB_Battle_Manual (14765)
  * Rise_Midgard_Lucky_Egg (17494)
  * Lucky_Silvervine_Fruit_Box_III10 (17495)
  * Lucky_Silvervine_Fruit_Box_III110 (17496)
  * Epic_Heroes_Scroll (17519)
  * Majestic_Lucky_Egg (17526)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-12 00:43:04 +07:00
Cydh Ramdh
e1b658e462 * Item GUID Updates:
* Removed `ENABLE_ITEM_GUID` from src/config/core.h, after long time introduction it's worth to be enabled by default. Just remove all items with GUID flag if want to remove it generates GUID .
  * Implemented client interface to merge the items. Packet struct credits: 856b6f1feb
  * Edited `mergeitem` script command to use the interface, moved the 'old' `mergeitem` to `mergeitem2`.
  * Fixed the behavior to add GUID'd item to inventory in Cash Shop.
  * Updated item_flag.txt for listing `IT_CASH` items (item type 18).
  * NOTE: `IT_CASH` items which defined in item_flag.txt with flag `4`, cannot be merged.
  * NOTE: Please check the packets for older clients. Tested work on 2012-04-10, 2013-08-07 and 2014-10-22.
  * NOTE: Please import 'upgrade_20150804.sql' for MySQL Log Database.
* Removed duplicate clif functions:
  * `clif_msgtable()` -> `clif_msg()`
  * `clif_msgtable_num()` -> `clif_msg_value()`
* Item DB Updates:
  * Indonesia_Box2 (17079) should gives 5x Wing_Of_Butterfly (602).
  * Changed some item types to 18.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-04 20:57:49 +07:00
Cydh Ramdh
eb3d9587be Fixed #557 compile's error, follow up 64cb02e5f1. Thank @anacondaqq
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-04 19:36:39 +07:00
Cydh Ramdh
64cb02e5f1 * Introducing Item Reuse Limit Group
* By expanding current item_delay.txt's function to implement official item reuse limit.
  * There's the 3rd optional column, put SC ID value to add reuse limit. The reuse delay will be acknowledged as status change. Ignoring this column will use 'normal' item delay.
  * Added some items to their reuse limit group.
* Item DB Updates
  * Added effect for ASPD_Potion (12684).
  * Added effect and delay for Para_Team_Mark_ (22508).

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-03 20:48:35 +07:00
aleos89
51f6465709 Bug Fixes
* Fixes #479 - Fixed the unique item ID system not giving new items their unique ID. Blame 7295bdc.
* Fixes #488 - Fixed Water Barrier, Zephyr, and Power of Gaia not being applied to targets walking into the area of effect.
* Fixes #500 - Cursed Circle will now properly release targets if the caster moves out of AREA_SIZE.
* Fixes #501 - Reverberation can be placed an unlimited amount of times. The magic part now only deals neutral damage.
* Fixes #506 - Magnetic Field will now affect others in PvP maps, except for the caster. Thanks to @exneval.
* Fixes #527 - The Roulette item database will not be loaded at all if the feature is disabled.
* Fixed a small typo for 'unitwalk' and 'unitwalkto' script commands.
2015-07-22 17:46:38 -04:00
aleos89
35cd68873b Merged with master 2015-06-26 10:36:40 -04:00