151 Commits

Author SHA1 Message Date
Sapito Sucio
8be1f819d9
General typos (#8000)
* Fixes typos in several NPC.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2023-11-10 12:51:01 -05:00
Atemo
69802a23fb
Suggestion: NPC name as parameter in enablenpc (#6233)
* The required NPC name parameter is now optional for the following script commands:
    enablenpc
    disablenpc
    hideonnpc
    hideoffnpc
    cloakonnpc
    cloakoffnpc
    isnpccloaked
* Updated docs

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2021-09-09 14:50:24 +02:00
Atemo
b454237d95
Small correction for checkre script command (#5550)
Removed RENEWAL constant since it doesn't exist
2020-11-16 17:51:30 +01:00
Aleos
fd148a6783
Adjusts disabled NPC with waiting rooms (#5289)
* Fixes #5288.
* Follow up to 1c6270f.
* Changes NPC that have waiting rooms to not be disabled, but be hidden.
Thanks to @Forte22!
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2020-08-07 20:35:36 -04:00
Daegaladh
7adcfe1392 Fixed change quest error on Priest job change quest 2020-07-08 14:56:32 +02:00
Daegaladh
979e13dd66
Fixed a couple of bugs in Assassin job quest (#4723)
* Fixed a bug where the player can't finish the quest if the NPC times out after obtaining the weapon.
*Fixed savepoints for pre-renewal.
*Thanks to @Tydus1
2020-03-27 15:32:56 +01:00
Daegaladh
34cb15ec04
Fixed a couple of answers on Knight job quest test (#4724) 2020-03-27 15:31:24 +01:00
Daegaladh
354c632732
Fixed place names and other typos (#4475)
* Fixed common misspelled names from iRO and other typos.
2019-12-15 20:55:19 +01:00
zackdreaver
91667a9a11 Update Renewal and Pre-renewal Morocc NPCs (#2977)
Fixes #3392 

Thanks to @zackdreaver, @AzarthMZintos and @Lemongrass3110
2018-08-17 10:27:26 +02:00
Atemo
df9bac9b78
Clean-up and fixed quest issue of hunter.txt (#3059)
Thanks to @AzarthMZintos !
2018-05-11 15:59:35 +02:00
Atemo
ea88ea5054
Emoticons constant name (#2527)
This PR change the emoticons constant name to match emoticonlist from client side.
Note: the previous emoticons names are now deprecated.

Additionnally emotion and unitemote scripts commands are being merged together to the new format
-> emotion <emotion number>{,<target>};
Where target use the target Game ID (GID) of the unit (npc, pet, character etc..).

* unitemote is now deprecated.
* Additionnally fixed incorrect variable in quests_brasilis.txt

Thanks to @aleos89 and @Lemongrass3110 !
2017-11-10 18:35:21 +01:00
aleos
470364cbe1 Corrected a second changequest attempt
* Related to #2070.
Thanks to @LiamKarlMitchell!
2017-08-31 20:24:04 -04:00
Cydh Ramdh
2896d894d1 Official Random Coordinates for Savepoint (#1756)
* Added parameters for `savepoint are range for `x` and `y` for random savepoint coordinates.
* Added documentation for new savepoint params. Credits to @aleos89
* Updated savepoint on script to follow official behaviour (random save in 3x3). All credits to @Atemo
2016-12-20 17:16:42 +07:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00
Atemo
d62f422e3d Corrected OnTouch/OnTouch_ in NPC script (#1548)
Some leftover from aegis convertion..

Skipped pre-re folder, I don't have old data.
2016-09-07 21:35:14 +02:00
Atemo
f927d636b6 Fixed issue #1409 (NPC shouldn't be clickable) 2016-07-05 16:16:35 +02:00
Atemo
3261532403 Follow up 97426ecce0beec1426e374da4b8b82dc7e9e97c6 "Another 'unofficial fix' in assassin.txt" 2016-05-29 01:44:26 +02:00
Atemo
97426ecce0 Another 'unofficial fix' in assassin.txt follow up 33184fe3d558217f8ebb8399400352223c57197e 2016-05-28 20:47:56 +02:00
Jittapan Pluemsumran
631187b3ec
Follow up to 33184fe
add comment/explaination on the fix
[ci skip]
2016-05-23 00:51:46 +07:00
Jittapan Pluemsumran
33184fe3d5
Assassin job quest shouldn't set variable before the dialog is actually finished.
Fixes #1228. Thanks to @MrAntares and @spinzaku.
2016-05-23 00:43:48 +07:00
Euphy
17bace0ae6 Script bug fixes.
- Added Renewal location for "Knight De Thomas" NPC (previously inaccessible), and upgraded the script to the latest version.
- Fixed Pre-Renewal Merchant Quest questlog commands. (bugreport:9218)
http://rathena.org/board/tracker/issue-9218-merchant-quest-add-error-quest-add-1010/
- Corrected a handful of 'rand(1)' statements.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-16 19:10:19 -04:00
Cydh Ramdh
3441d4a30b * Updated/added item_db, thank https://github.com/ROClientSide/Translation for some item view ids
* Follow up 0724d1e
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 19:07:05 +07:00
Euphy
0724d1ebab Minor updates.
* Added Cryptura Academy monster spawns, commented until the scripts are implemented. Does not include monsters from job quests.
* Fixed two label errors in Wizard job quest. (bugreport:8590)
http://rathena.org/board/tracker/issue-8590-wizard-job-quest-label-error/
* Updated AUTHORS file. (credits to AnnieRuru and Keyworld for providing some missing names)
* Uncommented a mapflag in custom 'mvp_ladder' script. (credits: AnnieRuru)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-04 21:35:36 -05:00
Euphy
90b187ff3e Changed all "Compatible With" fields to "rAthena Project".
Edited a handful separately, as appropriate.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-12 16:24:38 -05:00
Euphy
1d64b8f9e1 Script/database bug fixes.
* Fixed an issue in "Message Delivery" quest blocking level 100+ characters. (bugreport:8373)
http://rathena.org/board/tracker/issue-8373-message-delivery/
* Added Renewal quest items to Ayothaya Dungeon Entrance quest. (bugreport:8375)
http://rathena.org/board/tracker/issue-8375-ayothaya-dungeon-entrance-quest/
* Temporarily moved the Renewal location of "Strange Machine" in the "Muff's Loan" quest; confirmation needed. (bugreport:8370)
http://rathena.org/board/tracker/issue-8370-muffs-loan/
* Updated Blacksmith job quest with some extra conditions. (fixes bugreport:8347)
http://rathena.org/board/tracker/issue-8347-about-blacksmith-job-quest/
* Changed all 'bAtk' bonuses to 'bBaseAtk', a continuation of r17149. (fixes bugreport:8372)
http://rathena.org/board/tracker/issue-8372-daehyon-card-is-not-working/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2013-12-28 22:47:32 -05:00
Euphy
bf68ccefa3 * Script style standardization.
- Standardized cases on constants (Zeny, Sex, BaseLevel, etc.).
- Replaced numerics with constants.
- Standardized parts of script headers.
- Changed some script styles to K&R.
- Added some official script file names as comments.
- Replaced most 'misceffect' commands with 'specialeffect'.

Signed-off-by: Euphy <euphy@rathena.org>
2013-08-27 03:28:41 -04:00
Euphy
be2428b832 * In Pre-Renewal, players can use items and self-targetting skills while talking to NPCs. (continuation of bugreport:6527)
* Fixed an issue in Malangdo quests. (bugreport:7863)
* Fixed two incorrect event calls in Assassin job change quest.

Signed-off-by: Euphy <euphy@rathena.org>
2013-07-18 23:32:25 -04:00
euphyy
fdd0fd1d72 * Standardized label names and converted all labels to Pascal case. (temp. fix for bugreport:6988)
* Many fixes to Izlude Arena scripts.
* Other misc. standardization.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17410 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-07-10 07:25:44 +00:00
lemongrass3110
6e9ce692b3 Fixed not working cutins. bugreport:6466
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17265 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-04-16 21:33:06 +00:00
euphyy
6aa1beed27 * Changed remaining bEquipmentMatk bonuses to bMatk in item_combo_db (follow-up r16981).
* Reverted r17116.
* Merged eAthena ea:15231, ea:15232 by ai4rei.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17117 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-02-02 05:45:09 +00:00
flaid
8b409e29b0 Splited hunter quest into renewal and pre-renewal.
Hunter quest in renewal doesn't require Claw of Desert Wolf anymore, it requires the normal Wolf Claw.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17116 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-02-02 00:20:10 +00:00
euphyy
f1577d8183 * Added a missing checkre() in Hunter job quest (bugreport:7230).
* Fixed item 18103 job and script (bugreport:7137).
* Added a note for where party_share_level is located in conf/battle/party.conf (tid:75137).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17115 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-01-31 22:34:30 +00:00
euphyy
5b456c67a1 * Documented @set command from r16123.
* Fixed a waitingroom bug in Wizard job quest (bugreport:7189).
* Fixed getequipname() returning -1 instead of an empty string (bugreport:7186).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17100 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-01-16 01:09:24 +00:00
euphyy
62dee5b8c7 * Updated Geneticist, Warlock, and Sura job quests to their latest versions.
* Added a clearer example for party_even_share_bonus (tid:58005).
* Standardized job headers.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17010 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-12-08 18:18:36 +00:00
brianluau
ec75513871 - Fixed missing 'close' in priest.txt (bugreport:6921)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16943 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-11-22 16:45:51 +00:00
j-tkay
de9950737d - Fixed bugreport:6785, missing changequest in Knight Job Quest. (npc/jobs/2-1/knight.txt)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16819 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-10-15 15:06:41 +00:00
euphyy
0448652500 * Fixed a misplaced quest log entry in Priest job quest, bugreport:6702 (jobs\2-1\priest.txt)
* Fixed an incorrect check in Taekwon job quest, bugreport:6711 (jobs\1-1e\taekwon.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16786 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-09-18 19:37:42 +00:00
euphyy
9800b743e6 * Raw revert of all job files back to r16578, prior to the rewrite in r16579. The updates will be re-applied after more testing is done.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16621 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-10 18:45:05 +00:00
masao87
44327805ca - This should fix all job quests which didn't work after the update.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16584 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-05 15:26:07 +00:00
masao87
93d361847e - Some little adjustments to the job change quests, also reverted some variables to the old job change files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-05 11:19:56 +00:00
masao87
9a71512a79 - Follow up r16579 .
* Added some missing Baby checks... This Update really started great didn't it ;)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-04 22:15:29 +00:00
masao87
b2dd8c722e - Here comes the big Job folder Update.
* Updated all 1-1, 2-1, 2-2 and the expanded files to the latest available official files and also added support for baby job change.
* There might be some optimizations still needed at some places and there maybe occur some errors as well or the job change isn't fully working anymore since I didn't test all the jobs through the end (Me = Lazy), if so then please fill out a bug report in our bug tracker: http://rathena.org/board/tracker/project-4-scripts/
* Ninja, Gunslinger and the other files will follow within the next days.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16579 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-04 21:45:50 +00:00
daegaladh
52a4de498e Fixed some bugs on jobs and merchants scripts.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16559 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-02 12:17:06 +00:00
daegaladh
f49b3d6f55 Full npc folder reorganization. (I hope I didn't break anything D:)
-Now common scripts goes to the main npc folder, and pre-re-only/re-only ones goes to their respective folders.
-NPCs with practically the same script but little differences have been left in the main folder and uses the command checkre() for the differences.
-For those NPCs with different coordinates but same script, the script has been left in the main folder but the NPCs splitted as duplicates.
-All pre-renewal files has been reverted back to their pre-renewal behavior.

TODO:
-Correct pre-re quest rewards.
-Check for pre-re/re differences in mapflags.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-01 04:29:56 +00:00
shennetsind
086af74531 Okie ladies and gentleman if this commit breaks anything it's jman's and maki's fault, yes, blame them.
Fixing pre-re / re npc support, moving /config/ folder to src root so other servers may also make use of the #define renewal dir and other stuff.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16382 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-08 19:30:07 +00:00
euphyy
36c9f0887b * Optimization of Knight job change quest, and fixed bugreport:6163 (jobs\2-1\knight.txt)
* Follow-up r16373: added another missing entry (bugreport:6162)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16374 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-04 03:31:55 +00:00
masao87
a1c12384fa - Fixed a bug in Eden Group Quests where a variable was set which was supposed to be converted and give the player certain gears. bugreport:6143
- Fixed an Priest Quest cutin which would result in getting an missing file error of the MvP Mistress Card illustration. bugreport:6144
- Fixed EXP Values in Eden Group Quest Boards 86 - 90 and 91 - 99. Source: http://irowiki.org/wiki/Eden_Group_Leveling_Quests
* 3 Hours cooldown isn't added yet since some testing is needed. bugreport:6110
- Some minor paranthesis fix in Knight Jobchange Quest.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16362 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-01 14:13:56 +00:00
masao87
f8b0c2426d - Updated Monster spawns in Job change Quests to renewal. bugreport:5574
- Some minor changes to the Arch Bishop Job change Quest.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16124 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-05-17 12:53:16 +00:00
mandark022
ea4361bb17 Fixed the (bugreport:4096) where player can enter the Test Area without passing the written exam. Now player will not be warp inside the Test Area when did not passed the written exam instead the player will be warp back to the written exam entrance.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15795 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-03-26 13:07:28 +00:00
brianluau
00367cd7b7 - Removed more trailing tabs.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15527 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-01-30 20:17:55 +00:00