14340 Commits

Author SHA1 Message Date
Lemongrass3110
7d0931a45d Follow up 3108bb1
Fixed a typo with configure call
2016-10-20 00:14:02 +02:00
Lemongrass3110
ed53167bc8 Follow up abd9809
appveyor lost the quotes
2016-10-20 00:11:52 +02:00
Lemongrass3110
abd98090d1 Follow up to dd55592 2016-10-20 00:01:03 +02:00
Lemongrass3110
dd555926a0 Reenabled buildbot defines
Now builds will fail if any warnings or errors occur.

Removed duplicated "matrix" keyword I added accidentally in 3108bb1.
Removed a default warning in run once mode in the character server. Follow up to a0b3e51
2016-10-19 23:58:29 +02:00
Lemongrass3110
3108bb1265 Added a configure option for vip features
Added the new option to the CI matrix
2016-10-19 23:15:13 +02:00
Lemongrass3110
15b40509d6 Added a -D equivalent for msbuild
Fixes appveyor not building in pre-renewal mode
2016-10-19 23:14:44 +02:00
Lemongrass3110
4db687c7a4 Fixed unknown state handling in mob skills 2016-10-19 14:46:11 +02:00
Lemongrass3110
b2f0ffb947 Fixed a potential server crash in mob_chat_db
Fixes #1635
Thanks to @Temtaime
2016-10-19 12:24:46 +02:00
Lemongrass3110
3ad16f04fb Merge pull request #1634 from Temtaime/patch-1
Fix type in warning message

Thanks to @Temtaime
2016-10-19 12:18:32 +02:00
Temtaime
655d6f56e7 Fix type in warning message 2016-10-19 12:35:12 +03:00
Aleos
e93c8880b3 Updated Manhole skill behavior (#1617)
* Updated Manhole skill behavior
* Fixes #1601
* GvG and Battleground monster objects are not able to be targeted by Manhole.
* Removed the usage of Strip Accessory on targets who are affected by Manhole.
Thanks to @ignizh!
2016-10-18 17:59:32 -04:00
Lemongrass3110
73eb96f358 Introducing charpointer macros for fifo/buffers (#1624)
* Introducing charpointer macros for fifo/buffers
2016-10-18 23:35:21 +02:00
Lemongrass3110
56c9765fe0 Fixed a wrong close in the eye of hellion quest
Merges HerculesWS/Hercules@d8441a3
Thanks to @Ridley8819
2016-10-18 22:49:18 +02:00
aleos89
031adff925 Updated Ranger Traps behavior
* Fixes #1611.
* Magenta, Cobalt, Maize, and Verdure Traps should permanently change the element of the target.
2016-10-18 21:54:46 +02:00
Lemongrass3110
55c5627eef Fixed compilation warning in pre-re
Fixes #1627
Thanks to @keitenai
2016-10-17 13:53:04 +02:00
rAthenaAPI
a0c7d6e2fe SQL synchronization 2016-10-16 23:07:52 +02:00
Lemongrass3110
568262faf4 Added latest npc constants
Also added some mob placeholders
2016-10-16 23:07:28 +02:00
Lemongrass3110
57131f286c Fixed some compile warnings
Fixes #1623
Thanks to @lelouch22
2016-10-16 14:20:17 +02:00
Lemongrass3110
48c43cf92f Refactored clif_charnameack
Added support for ZC_ACK_REQNAMEALL2 which is used from 2015-05-13 and higher
Added packet documentation for ZC_ACCEPT_ENTER3
Fixed some visual effects not being resent when using `@refresh`. Thanks to @Grantea
2016-10-16 12:58:03 +02:00
aleos89
7e2efec61b Moved some inventory checks
* Resolved item bonuses not properly being given that get applied before the player's inventory is received.
* Resolved rental items that have Status Changes attached to them not getting removed if the timer expired when the player logs in.
* Removed an extra call for player's with item sets.
Thanks to @Tokeiburu!
2016-10-14 12:50:06 -04:00
Jittapan Pluemsumran
09cb81d98e
Added a sample for utilizing the random option system. 2016-10-14 19:38:15 +07:00
Lemongrass3110
2bde36fb9d Merge pull request #1563 from rathena/cleanup/npc_name_length
Expand NPC Name Length to 50

Thanks to @cydh!
2016-10-14 09:37:36 +02:00
Lemongrass3110
6a8985531b Fixed NPC markets
Fixed signedness warnings for the sanity zero-terminations
2016-10-14 09:14:22 +02:00
Lemongrass3110
e443f846c6 Increased EVENT_NAME_LENGTH and some more cleanups
Fixed an invalid reference in clif.c(follow up to 008be23)
Moved the OnWhisperGlobal name definition to the other special event name declarations
Increased EVENT_NAME_LENGTH from 51 to 77 characters because it uses NPCs exname which can be up to 50 characters now
Added a warning when an NPCs exname is too long for an OnWhisperEvent
2016-10-14 09:13:53 +02:00
Lemongrass3110
b60f74c3df Sanity zero-termination for NAME_LENGTH usages 2016-10-14 09:13:21 +02:00
Lemongrass3110
4d71a12d00 Fixed a few EVENT_NAME_LENGTH usages 2016-10-14 09:11:28 +02:00
Cydh Ramdh
d3077435e8 Expand NPC Name Length to 50
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-14 09:11:28 +02:00
Cydh Ramdh
748035141b Merge branch 'master' into cleanup/storages_optimization 2016-10-14 06:12:52 +07:00
Cydh Ramdh
b2c4178209 Corrected 'VIP' personal info notification (#1613)
* Only displayed when map-server is changed or when changing map that has different base rate with previous map's rate, should not when map changed/warped.
* Updated some packet that related with VIP and its doc.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-14 06:04:09 +07:00
Lemongrass3110
768d801f3d Merged storage loading into a single function
Follow up to 800714a forgot to eliminate TABLE_CART_ completely.
2016-10-14 00:41:15 +02:00
aleos89
a8c8cbd498 Small cleanups
* Corrected the spacing to tabs in a few locations.
* Corrected a variable typo.
2016-10-13 18:06:58 -04:00
Lemongrass3110
800714abfe Reverted a lot of e8f4500
Wasted 11 bytes of network traffic to keep the code clean.

Process:
1) A player tries to open a vending store and is now in the pre-vend state.
2) If all items in the cart are saved then he can proceed to opening the store.
3) If not a request to save the cart data is sent to the inter server.
4) If the acknowledgment packet from the inter server is received then check if the player is still online and in pre-vend state and open the vending dialog
2016-10-13 23:53:34 +02:00
Cydh Ramdh
8f3599b0e3 Fixed VIP char selection window (#1598)
* Char selection window went crazy when `VIP_ENABLE` is defined
* Fixed #628

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-12 06:26:30 +07:00
aleos89
6663df344b Corrected script command statusup2 documentation (fixes #1612)
* Corrected the documentation referencing the wrong script command.
* Removed some trailing white spaces.
* Prettified some text.
Thanks to @lucasoli!
2016-10-11 14:23:15 -04:00
Jittapan Pluemsumran
f51a1c74ba Removed additional clif_maptypeproperty2 calls 2016-10-11 08:45:03 +02:00
Lemongrass3110
940c473c88 Cleaned up map property sending functions
Implemented ZC_MAPPROPERTY_R2 properly
2016-10-11 08:45:03 +02:00
Lemongrass3110
ce9e623e47 Added a configuration for deletion restriction
Additionally added the checks to char_delete_char_sql so it is triggered on deletion itself and from older packets(chclif_parse_delchar) too.
2016-10-11 08:41:06 +02:00
Cem YILMAZ
5ea873b8b2 Added guild/party checks for character deletion process #1480 2016-10-11 08:41:06 +02:00
Cydh Ramdh
3e4d2b86c2 Merge pull request #1089 from Baalberith6/autotrade
Fixing @at venders being stuck when map->char connection gets reset.
2016-10-11 12:38:14 +07:00
Lemongrass3110
103ee947ff Follow up to f0dd764
Fixed compile/merge errors from 5a56210
2016-10-10 13:13:23 +02:00
Lemongrass3110
f0dd764095 Merge branch 'master' into cleanup/storages_optimization
# Conflicts:
#	src/map/script.c
2016-10-10 13:06:52 +02:00
Jittapan Pluemsumran
10946dd891 Removed README.txt
README.md in its text form is already human-readable.
2016-10-09 09:12:34 +07:00
Cydh Ramdh
19d620575a Fixed #1575, cart cannot be changed.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-09 08:29:16 +07:00
Cydh Ramdh
cd0b2b2974 Follow up 9a52768f6fb35637edac233f85d7a857f852376e (#1595)
* Fixed #1594, compile warning

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-08 06:01:00 +07:00
Cydh Ramdh
9a52768f6f Cleanup party withdraw (#1585)
* Added enum for withdraw result in mmo.h.
* Added name of kicked player and changed `sd` init from `account_id` to `char_id`.
* Fixed party list window isn't updated when member kicked.
* Updated packet documentation.
* Thanks to @aleos89 @Lemongrass3110

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-06 10:58:05 +07:00
Jittapan Pluemsumran
01b1052570 Merge pull request #1589 from rathena/hotfix/issue1587
Fixed random options being removed on card removal
2016-10-03 21:50:08 +07:00
Lemongrass3110
5a5621073f Fixed random options being removed on cardremoval
Fixes #1587
2016-10-03 13:31:20 +02:00
Jittapan Pluemsumran
6510d414fa Merged warp and warpchar into a single function (#1584)
* the warp command now allows you to warp other players
* the warpchar script command is still usable but not recommended
* removed warpchar documentation from script_commands.txt to let it fade from people's memory
2016-10-02 23:25:03 +02:00
Atemo
6216bfbbfd Fixed Kafra length name follow up 7a011ecd3491adcd8ff82305d8e6fa9915c2a0d9 2016-10-01 22:14:14 +02:00
rAthenaAPI
963cfa5771 SQL synchronization 2016-10-01 16:54:54 +02:00