548 Commits

Author SHA1 Message Date
ai4rei
44294eb3b1 * Fixed a typo in npc_touchnext_areanpc (NPC's map being used as it's x-coordinate), which caused ::OnTouch_ invokation to affect different area than intended (bugreport:4814, since r14097).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14743 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-03-14 15:08:54 +00:00
ai4rei
1bb6a3d506 * Fixed NPCs with closing parenthesis in their name could not be duplicated (bugreport:3235).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:45:10 +00:00
ai4rei
ad4e9bbee1 * Replaced remaining occurences of '-1' with 'INVALID_TIMER', where appropriate (follow up to r12998).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 21:00:38 +00:00
ai4rei
75ca2f146a * Fixed improper use of itemdb_search. It does not return NULL but a dummy item, if the item id is invalid.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14642 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-30 17:23:54 +00:00
ai4rei
226fa32b4c * Fixed items, that get dropped at 100% chance, being reported in @iteminfo as 'available in the shops only' (since/replaces r3482).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14627 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-26 13:32:07 +00:00
ai4rei
a45a6400e3 * Fixed server processing the sell list (deleting items and giving zeny) for script-controlled shops (OnSellItem), causing the controller script to fail (bugreport:4656, since r6557).
- This also makes the server first check the sell list and only continue, if all items can be processed, thus no longer causing incomplete deals and the need for client disconnection in such case (since r6557).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14617 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-23 16:05:49 +00:00
ai4rei
d23eafd077 * NPC shop buy list received from the client is now validated for scripted shops (OnBuyItem), before the control is transfered to the script, as well (bugreport:3680, since r5841, related r8525).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14616 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22 23:05:50 +00:00
ai4rei
1e81541e66 * Resolved random compiler warnings.
- Silenced pointer size mismatch gcc warning for variables passed to script_setarray_pc (bugreport:4661, since r14613).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14615 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22 14:06:37 +00:00
ai4rei
b86d48e71a * Added script_setarray_pc for setting temporary character array variables outside of script.c without requiring them to use script-interal code (add_str and reference_uid).
- Applied script_setarray_pc to assignment of dynamic shop arrays (related r5841).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14613 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21 23:23:06 +00:00
ai4rei
7c90fd1bf1 * Fixed dynamic shop arrays @bought_nameid, @bought_quantity, @sold_nameid and @sold_quantity not getting reset to zero before use, thus providing attached script with wrong/old data, if it did not clear them by itself in previous call (bugreport:1574, since r5841).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14611 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21 21:30:46 +00:00
ai4rei
e26ea94a2f * Reverted r14563, due to multiple issues which render the source malfunctioning or uncompilable. To be redone later (bugreport:4627).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14567 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:45:24 +00:00
Paradox924X
ca53ef6f4a Changed almost all instances of sprintf() to snprintf().
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14563 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 18:38:03 +00:00
ai4rei
5cfc017080 * Removed leftovers of the item_value_db.txt feature (bugreport:2031, since athena-dev-2.1.1-mod377, followup to pre-svn 2004/05/29).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14553 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:15:29 +00:00
ai4rei
4ac5525eb8 * Fixed mapflags not getting initialized upon @reloadscript (bugreport:2247, since r1275).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14548 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 18:50:34 +00:00
ai4rei
5d1bbf6c2a * Added clr_type enumeration for vanish effect constants.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14517 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-28 21:41:38 +00:00
ai4rei
3541b61e5e * Fixed a crash when an unknown map is encountered during parsing a 'script' npc and the script has mismatched curly braces (bugreport:4423, since r11502).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14502 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-25 20:59:50 +00:00
ai4rei
338b3ad2d4 * Labels longer than 23 characters will no longer cause the server to exit immediately (bugreport:4563, since r1213).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14494 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-23 11:56:44 +00:00
Paradox924X
53e81e1369 Applied patch by xazax to clean up various bits of code across mapserver code. (bugreport:4512)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14438 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-11-02 04:24:46 +00:00
Gepard
123a803ccb * Removed unused 'indoors' mapflag (follow-up to r3729).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14434 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-21 00:38:57 +00:00
Paradox924X
2f9e3dbf81 Replaced all nullpo_retr() calls which returned 0 with nullpo_ret() calls.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14414 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-10-09 01:57:04 +00:00
L0ne_W0lf
0b1cd84732 * Commented out code from r14388, as this breaks NPCs that rely on running global events in duplicates. (IE: WoE scripts)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14390 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-20 20:54:10 +00:00
Paradox924X
e93febd7f3 Removed processing for undocumented and unused event 'OnCharIfInit' which is essentially an alias for event 'OnInterIfInit'.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14389 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-20 18:56:23 +00:00
Paradox924X
c076c81731 Made it so global events don't get executed in duplicates to prevent unnecessary reprocessing of events that only need to be run once. This potentially reduces the total number of global events by hundreds, even thousands.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14388 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-20 18:52:41 +00:00
Skotlex
e19451d423 - Implemented usage of packets 0x7fa and 0x7f7, 0x7f8, 0x7f9. These are used for proper deletion of items as well as movement/spawn packets for Renewal clients.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14383 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-08-19 15:46:55 +00:00
L0ne_W0lf
d5dbf77b28 * Implemented three new mercenary skills.
* Added two new monster mercenaries.
- Added information for the three new mercenary skills.
- Added mercenary skills with cast times to castnodex.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14367 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-07-31 01:50:57 +00:00
Inkfish
a07d7e43f9 Fixed OnTouch doesn't trigger on hiding characters. (bugreport:4208)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14291 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-04-28 09:10:04 +00:00
ultramage
fba253dc73 Added missing checks to stop an infinite free cash point exploit. (bugreport:4139)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14266 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-03-21 10:08:40 +00:00
Inkfish
27801bb67f 2010/02/06
* Added official packet to display received expirience. (info provided by papkil)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14240 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-02-06 05:08:37 +00:00
ultramage
e441bae997 Corrected a variable defined in a header file.
Cleaned up a bad case of variable recycling.
Separated the ALL_WEWISH case from the unrelated sage skill cases (undo of r14183).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14190 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-12-08 00:41:29 +00:00
Inkfish
5485daa6df * NPC event code cleanups.
- removed the 'OnMyMobDead' dead code. It's never supported though documented.
- removed the 'feature' that events only trigger when the player is in the OnTouch area IF it's specified. 
  It's never documented and breaks official scripts.
- some cleanups and bug fixes to OnTouch_.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14173 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-11-26 12:01:19 +00:00
ultramage
ada5a13abe Fixed instances not initializing after reloadscript (bugreport:3522).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14167 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-11-24 17:15:23 +00:00
skotlex
c92ff591f1 - Applied the renewal client support patch from Diablo (eA forum topic 222623)
- Added support for strcharinfo(3) to retrieve the player's map
- Added script command "searchitem" for name item searches.
- Moved PACKETVER to src/common/mmo.h as it's needed by the char-server now
- Changed the status valX from int to long so that it won't break for pointer-storage in other architectures.
- Moved the change party leader code to party.c
- A few bugfixes or packet field completions based on my past experience messing around with my server.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14155 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-11-19 18:19:09 +00:00
Inkfish
da07c3b06e Reverted renaming foreach functions and create a new one for OnTouch so that last commit will hopefully break NOTHING in use.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14098 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-25 11:20:47 +00:00
Inkfish
42987f61ad * Implemented the official version of 'OnTouch' named as 'OnTouch_'.(it can be defined in script_athena.conf)
* Adapted 'map_foreachinarea' to 'map_forsomeinarea' so that it allows you to specify the number of bl you wanna operate on.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14097 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-25 09:38:33 +00:00
ultramage
fa2f34ed86 Reverted the previous change to OnTouch not triggering for invisible chars.
While this is the official behavior for OnTouch (as opposed to OnTouch2 which we don't have), this change would break npcs that assume you can't just walk past them cloaked.
If there is a real need for implementing this behavior in the future, it should be done in a backwards-compatible way if possible (although, inverting the meaning of OnTouch/OnTouch2 would cause a lot of confusion).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14096 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-24 10:45:36 +00:00
Inkfish
7b46d2c473 * 'OnTouch' script shouldn't trigger when you are invisible.(same as warps)
* Fixed character doesn't stop walking when walking into OnTouch area of an NPC who doesn't have an OnTouch label. (bugreport:2700)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14095 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-24 03:03:30 +00:00
zephyrus
515cd8685c - Fixes and optimization to instancing. Thanks to Saithis
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14006 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-08-14 14:03:53 +00:00
zephyrus
6b710571ad - Optimization to instance system.
* Removed the crc feature to generate instance npc names. The instance npc name will be "dup_" + instanceid + "_" + srcnpcid.
* Removed the big array under map structure and coded in a different way. It was only used to generate map names, but i just used the instance_id + "origin map name".
* Moved all instance features to separated files.
* Moved the npc duplication for instances into npc.c as Ultramage says (removed npcname_db from npc.h).
* Added recomendations for scripts commands by Saithis.
- Testing required, i will prepare Endless Tower script soon. I hope this do almost anything in bugreport 3276.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14003 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-08-12 21:44:02 +00:00
Inkfish
f9b0729dfa Fixed when dynamic_mobs is active, reloading script right after the last player having left a map leads to permanet mobs not spawning on that map.(bugreport:2736)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13921 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-30 14:27:02 +00:00
zephyrus
33e1fbbd66 - Instancing System (Thanks to Sirius White who did most of the code, with some of my work to implement client side information, some optimizations and bugfixes). Also thanks to contributions from UEAUP team and Orcao.
- Fixed a bug on areamobuseskill and changed it to make it as Aegis.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13901 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-20 17:56:01 +00:00
Inkfish
d7d626e578 Now we can use 'boss_monster' to summon whatever monsters that need to be radared by Convex Mirror. (bugreport:2653)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13813 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-25 13:05:59 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
ultramage
4acc0932f2 Removed the undocumented custom level feature from monster spawn lines (bugreport:3076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13772 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:33:39 +00:00
Inkfish
c36c82150a * A typo on my last commit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13748 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 03:13:47 +00:00
Inkfish
b6f136a75d * Now if an NPC is unloaded, only the timer of the player attached to this npc will be deleted.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13747 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 02:44:02 +00:00
Inkfish
bb1c9d92de * Fixed NPC timer errors
- ted->rid is not initialized for global timer
- timer_id is not set to INVALID_TIMER when timer is deleted
- run script after next event is arranged

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13746 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-09 16:12:28 +00:00
Inkfish
a366ac53ce * Fixed some known and unknown player attached NPC timer problems
- Attached timer now can be stopped properly.
- Attached timer will now stop if the NPC is unloaded. (bugreport:2510)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13744 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-09 01:45:11 +00:00
Inkfish
0aa94a295f * Clean up for npc timer code
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13738 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 14:52:22 +00:00
Inkfish
8704a43725 * Players now cannot be revived during pvp respawn delay
* Fix a logical problem on my last commit

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13720 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:41:04 +00:00
Inkfish
a43c9e581b * Fix several npctimer issues (bugreport:1619, bugreport:1730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13718 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:06:53 +00:00