757 Commits

Author SHA1 Message Date
zephyrus
115d6a3fd0 - Implemented new packets for rental items (from Jobbie and Natz and fixed by me).
- Rental items now can be moved to storage and cart.
- Autotrade cannot be used when user is dead, and it's not dispelled if user dies to prevent abuse.
- Fixed pc_checkitem to do a proper item check and remove.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14082 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-04 21:42:15 +00:00
Inkfish
f1bcfea0b4 Marionette Control now has an infinite duration.(bugreport:2542)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14078 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-10-02 02:06:03 +00:00
Inkfish
d5c7d9e747 Added supports for Soul Bound.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14073 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-09-23 12:06:25 +00:00
Inkfish
ec8b12948e * Duration of SC_STONE is not reduced by MDEF.
* LexAeterna is allowed to be used on petrifying targets.
* Mobs won't attack back if StoneCurse fails.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14064 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-09-17 10:35:40 +00:00
Inkfish
b0d8294419 Added bMagicHPGainValue and bMagicSPGainValue.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14018 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-08-21 06:21:44 +00:00
Paradox924X
fda1387f60 Added proper bounds of INT_MIN to INT_MAX for hp/sp when being sent to/from status_damage/status_heal for negative values because of INT_MAX being (-INT_MIN - 1).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13955 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-07-22 18:46:44 +00:00
Inkfish
50961ceec3 fixed some typos on autobonus
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13916 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-28 10:28:48 +00:00
Inkfish
5516002a5c * Implemented script command "autobonus". [Inkfish]
- "autobonus" is similar to "bonusautoscript", however it has a timer of its own.
- Updated itemdb changing items bonus using "bonusautoscript + sc_start" mode to "autobonus + bonus" mode.
- Remove bonusautoscript and status changes that was needed by bonusautoscript and is no longer in use.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13915 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-28 08:23:53 +00:00
Inkfish
e447a8a92a * Changed Asura Strike/Jump Kick to target skill to get rid of the "target delay". (bugreport:2174)
- skill tree will be re-sent on status change to handle using these two skills during combo.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13900 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-20 08:22:52 +00:00
Inkfish
1d90917604 * Implemented script command "areamobuseskill" and skill NPC_INVINCIBLE and NPC_INVINCIBLEOFF. (topic:217330)
* Using items no longer cancels invincibility(but using target and ground skills through items does). (bugreport:3259)
* Fixed Butterfly Wings not working during GVG. (bugreport:3264)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13897 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-19 13:26:50 +00:00
Inkfish
6ee6b810e0 Fixed wings not working when used on top of Magnetic Earth.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13896 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-17 09:06:29 +00:00
ultramage
1035d7490f Removed the 'src' parameter from skill_delunitgroup() (see r5911) (bugreport:3253).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13893 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-15 16:33:01 +00:00
ultramage
7063f7330d Improving the r13888 crashfix to cover similar crash scenarios discovered:
Reordered code in status_change_end(SC_DANCING) so that an ensemble's skill unit group is deleted only after removing both performers' status changes.
Modified the call to skill_delunitgroup() IN status_change_end(SC_DANCING) so that it always processes the group's true owner and not others (bugreport:3253).
Replaced calls to skill_stop_dancing() with status_change_end(SC_DANCING), since it now provides identical functionality.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13891 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-15 14:00:27 +00:00
Inkfish
c15ff51a7b Fixed a crash due to group being redeleted when players are performing an ensemble and one of the partner's sp run out.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13888 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-14 15:29:04 +00:00
Inkfish
14cf988591 * Fixed itemskill not bypassing Silence, SteelBody, Berserk and the like. (bugreport:3232)
* Fury and Asura no longer disable SP regen on any other classes than Monk/Champion.(bugreport:3200)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13883 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-12 07:45:50 +00:00
ultramage
5435e5056a Added a check to prevent resetting a mob's hp to full when it levels up using the custom mobs_level_up feature (accidentally deleted in r13789) (bugreport:3216).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13871 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-09 13:07:56 +00:00
Inkfish
dc7f470790 * Fixed turning off a skill needed to meet the requirements. (bugreport:3175)
* Skills used through items not having aftercast delay or cast time now don't overwrite the former canact_tick. (topic:220921)
* Multiple autoscripts now can trigger at once.
* Applied a temp fix for autoscripts crashing server.(bugreport:3154)
* Implemented SC_JEXPBOOST (thanks to GMJobbie for the diff). (bugreport:3177)
* Implemented SC_IGNOREDEF. (topic:217330)
* SC_DEFRATIOATK won't affect boss monsters. (topic:217330)
* Fixed skip_teleport_lv1_menu made lv2 skip menu as well. (bugreport:3183)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13844 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-05 00:22:12 +00:00
L0ne_W0lf
7807036efd * Updates to ST_PRESERVE and a few other minor details!
- Recasting Preserve no longer toggles the skill off while active.
- Preserve is no longer saved on log-out or mapserver changes.
* Added SC_CRITICALWOUND and SC_SLOWCAST to negative statuses not saved with battle_config.debuff_on_logout&1
* Implemented the skills NPC_HELLPOWER and NPC_WIDEHELLDIGNITY, as per my personal experiences with the skill on iRO.
* Increased MAX_MOBSKILLS to 50, as Satan Morroc has over 40 active skills now.
* Added skill information for NPC_HELLPOWER and NPC_WIDEHELLDIGNITY, and enabled skills in mob_skill_db.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13843 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-04 22:46:14 +00:00
Inkfish
e7faa7e498 * Some clean ups on autocast and itemskill code. (see topic:220921 for some info)
- Autocasted Teleport now skips the menu.
- Fixed nullpo info when defensive autocasts are triggered. (follow up to r13815)
- Fixed Warp portal used in item script never worked.
- Item skills now bypass skill delay check.
- Implemented SM_SELFPROVOKE. 
- Updated item db using 'itemskill' for some items.
* Basic skills will never be reset. 

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13841 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 15:30:11 +00:00
L0ne_W0lf
c778107ca8 * Implemented the Party Buff cash skills.
* Misc updates, and updates for party buff items.
- Added CASH_BLESSING, CASH_INCAGI and CASH_ASSUMPTIO skills.
- Added itemskill commands for the party buff scrolls.
- Corrected Equipment repair book's itemtype to 11.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13840 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 03:28:20 +00:00
Playtester
cd381ab1a3 * Fixed Mystical Amplification having unlimited duration
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13838 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-02 19:35:32 +00:00
Inkfish
ac5aa55ae7 * Added new bonuses bHealPower and bHealPower2.
* Heal skills code clean up. 
- bSkillHeal can affect offensive heal now. 
- bSkillHeal2 can affect AppleIdun and SlimPitcher now.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13820 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 12:21:59 +00:00
Inkfish
c61942c8cd Fixed losing skill list after base change. (bugreport:3106)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13812 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-25 10:32:06 +00:00
Inkfish
45addf32f8 NPC_STOP now stops both sides and will be canceled if either side teleports or dies.(bugreport:3099)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13803 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 15:36:41 +00:00
Inkfish
5815851acf * The delay icon doesn't appear during casting now. (bugreport:3101)
* Status icon of ASPD potions doesn't overriding each other now.(bugreport:3095)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13802 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 13:24:16 +00:00
Inkfish
f3572b9e6d * Now fiberlocking a fiberlocked target doesn't renew the timer but instead increases its fireweakness [Inkfish]
- This makes doublecasting firebolts on a double fiberlocked target having double damage from both 2 bolts possible = =(bugreport:3061)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13799 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-20 12:42:06 +00:00
Playtester
0affe1454c * Item-bonuses and NPC skills now use the official default durations for status changes
- you gain Curse immunity if you have 0 Luk (seems buggy but is official)
- our status defense stats are already fully correct :-)
- thanks to ultramage for testing this

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13790 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 20:45:44 +00:00
ultramage
7f18f11403 status calc code cleanup
* Inverted the status calc code order, so that status_calc_bl optionally invokes status_calc_pc/mob/whatever instead of every status_calc_* calling status_calc_bl.
 * Inlined functions status_calc_bl_sub_pc, status_calc_bl_sub_hom and status_calc_bl_sub_mer into status_calc_bl.
 * Restructured status_calc_bl to require as little bl type-specific branching as possible.
 * Split status_calc_bl into two layers - the inner does the battle status calculations, while the outer deals with running appropriate base status calculations, remembering old values and handling client updates.
 * The status_calc_bl function is now the single entry-point for all status calculations.
 * status_calc_bl will now trigger a client update only on attributes that actually changed.
 * If hp or sp changes during status_calc_bl, it will now properly refresh on the client.
 * Removed SCB_PC, now SCB_ALL should be used instead.
 * Revived the unused status calc flag SCB_BASE to indicate that a base status recalculation should be done first (that's what the status_calc_* functions are for).
 * Defined a new symbolic bitmask SCB_BATTLE (SCB_ALL - SCB_BASE) in case someone needs to only calculate the battle status (currently unused).
Please report any issues with this update.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13789 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 07:24:58 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
ultramage
3e1d1414ae Changed the type of the 'first' parameter of status_calc_pc/mob/pet/homunculus/mercenary functions' from integer flag to a simple boolean.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13773 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:49:54 +00:00
ultramage
4acc0932f2 Removed the undocumented custom level feature from monster spawn lines (bugreport:3076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13772 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:33:39 +00:00
Inkfish
acdd90f4aa * Removed DEF reduction display when casting GrandCross.
- This might not be official and led to repeated calculation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13758 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 11:30:48 +00:00
ultramage
161d254bb3 Fixed Slow Grace decreasing aspd 10x less than it should (bugreport:2480).
It was a mistake in r12923 where I didn't realize aspd_rate uses a scale of 1000, not 100.
This also fixes Slow Grace not factoring in the Dance Lessons bonus (also 10x less than it should be).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13755 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-11 17:46:02 +00:00
Inkfish
bba5e225cc * Fixed the incorrect DEF reduction of Joint Beat (bugreport:3051)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13751 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 11:13:59 +00:00
Inkfish
96635c8c81 * Update Waterball code due to info updated
* A piece of GX casttime def reduction code I forgot to merge

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:43:37 +00:00
Inkfish
0595535167 * Fixed splash damage from Baphomet Card might miss. [Inkfish]
* Check if group unit is expired before processing it. (bugreport:3054) [Inkfish]
* Fixed Grand Corss outdated behavior (bugreport:1590) [Inkfish]
- use new damage formula
- DEF is reduced to 2/3 during cast time
- block shields switching within attack duration
- monsters don't damage themselves any more
- intervals between hits are 300ms

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13736 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:15:14 +00:00
ultramage
23bd309798 Added missing case SC_ONEHAND (from r5227) and case SC_MERC_QUICKEN (from r13203) to function status_change_start.
Added missing case SC_AURABLADE (from r13693) to function status_change_end.
Added symbolic names for all OPT3 values and replaced the OPT1/OPT2/OPT3/OPTION defines with corresponding enums.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-30 02:26:04 +00:00
Playtester
7a215a7119 * First attempt to fix up the strip skills, please make sure these fixes work (bugreport:3011)
- the minimum rate of strip skills is now 5% for all levels
- duration of strip skills depends on the dex difference between target and caster and can be reduced to 0
- strip skills can now affect bosses (if duration doesn't get reduced to 0 due to their high dex)
- strip skills do a fixed -25% ATK, -15% DEF, -40% VIT or -40% INT independant of skill level
- autocasting Full Strip has a duration now (if dex is high enough)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 10:40:40 +00:00
ultramage
ff21daafa2 Correction to some status icons based on official information
- Added SI_S_LIFEPOTION and SI_L_LIFEPOTION and their corresponding new status changes to deal with the fact that Small_Life_Potion and Med_Life_Potion each use a different status icon.
- Left the duplicate SC_HPREGEN status in fof backwards compatibility, but removed its icon.
- Corrected the status icon id for SC_INCCRI from 292 to 295.
- Corrected the status icon id for SC_INCHEALRATE from 293 to 292.
- Added status icons for SC_INCFLEE2, SC_SPCOST_RATE and SC_COMMONSC_RESIST.
- Removed icon from SC_ARMOR_RESIST since officially it is a bonus, not a status, and thus doesn't (and can't) have an icon.
- Renamed the status icon name of SC_ELEMENTALCHANGE from SI_ARMOR_RESIST to SI_ARMOR_PROPERTY.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13698 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 07:25:50 +00:00
ultramage
c17d002e07 Renamed Happy Break's status name from SC_TKREST to SC_EARTHSCROLL, since that's its official purpose and it doesn't do anything else.
Also removed the associated SI_TKREST since this status doesn't actually have an icon.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 09:37:08 +00:00
ultramage
26736bf2a8 Filled in missing OPT3 change for LK's Aura Blade.
Added comments for OPT3 values 0x100 and 0x20000, which are currently unused.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13693 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 05:52:34 +00:00
FlavioJS
768ceda5e9 * Took care of some warnings. (marionette formulas and *INTPTR_* macros)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-12 13:39:15 +00:00
akrus
f0c9188fce Yet another fix...
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13615 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 08:29:24 +00:00
Sara
b3860fdc01 * Added support for new status change packet, uses new setting display_status_timers in client.conf.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13613 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-24 01:56:16 +00:00
zephyrus
ed5eee1dcb - Implemented new item and bonuses for Kreiger Von Midgard rewards.
* Execute script on skill (bonusautoscript3)
* Add effect on skill (bAddEffOnSkill)
* Execute skill on skill (bAutoSpellOnSkill)
- Fixed some boxes Rental time according to item descriptions.
- Implemented SC_ITEMSCRIPT, a status that gives you temporally the effect of an item. Check items 14597 to 14605 if you want to get the idea.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13596 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-18 02:50:39 +00:00
ultramage
4d5e91c6f6 * Fixed a couple bugs with marionette control
- Reduces caster max hp by 1000.
- Job and Equipment bonuses counts toward the 99 limit.
- Fixed stat overflow on baby targets with stats over 80 (bugreport:2232).
- Fixed clowns being able to cast it on another bard/clown (same for gypsy/dancer) (bugreport:166).
- Caster is no longer blocked from using items.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13572 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-03-08 12:32:45 +00:00
zephyrus
e9153a3c17 - Fixed item Nemesis.
- Fixed Tarot Card being used on Emperium.
- First Part of BattleGround Implementation (please wait).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13550 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-02-26 21:27:12 +00:00
zephyrus
d4c7aad803 - Implemented new Pet Bonus System. Enjoy!! :D
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13491 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-25 20:06:13 +00:00
zephyrus
ede9af3b29 - Implemented new item bonus scripts required for battlegrounds.
- Battlegrounds items rewards for Tierra Valley and Flavius done (but autoscript rate is suggested - 5%).
- Restricted trade/storage/drop for those items.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13490 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-25 19:50:02 +00:00
FlavioJS
58e4991d42 * Changed all uses of struct skill_unit_group* to group_id in status_change_entry's. (last known 64bit portability issue)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13482 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-01-24 17:38:17 +00:00